[dovecot/core] 4f7951: dsync: When logging "Mailbox changed caused a desy...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 4f7951e71128c120d8a502d6406cc603fcc8eb0b
      https://github.com/dovecot/core/commit/4f7951e71128c120d8a502d6406cc603fcc8eb0b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-01 (Thu, 01 Dec 2016)

  Changed paths:
    M src/doveadm/doveadm-dsync.c
    M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c
    M src/doveadm/dsync/dsync-brain-mailbox.c
    M src/doveadm/dsync/dsync-brain-mails.c
    M src/doveadm/dsync/dsync-brain-private.h
    M src/doveadm/dsync/dsync-brain.c
    M src/doveadm/dsync/dsync-brain.h
    M src/doveadm/dsync/dsync-mailbox-import.c
    M src/doveadm/dsync/dsync-mailbox-import.h

  Log Message:
  -----------
  dsync: When logging "Mailbox changed caused a desync", log also the reason.

The reason is usually somewhere in the debug logs, but it's difficult to
find from there.


  Commit: cabf98de0145c8e233e41073fe3f8c1cc85ed1eb
      https://github.com/dovecot/core/commit/cabf98de0145c8e233e41073fe3f8c1cc85ed1eb
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-02 (Fri, 02 Dec 2016)

  Changed paths:
    M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c

  Log Message:
  -----------
  dsync: Add mailbox names as well as GUIDs to log messages.


  Commit: d640b628f27c9bbcbf6fe902b257002a3f0da57b
      https://github.com/dovecot/core/commit/d640b628f27c9bbcbf6fe902b257002a3f0da57b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-02 (Fri, 02 Dec 2016)

  Changed paths:
    M src/lib-dict/dict-client.c

  Log Message:
  -----------
  dict-client: Don't timeout lookups without waiting 1sec in dict ioloop.

What could have happened was:

 - dict-client sends a request to dict-server
 - dict-client process starts doing something else
 - dict-server answers
 - dict-client process continues doing something else for over 30 seconds,
   not reading the dict-server answer
 - dict-client process gets back to dict ioloop, which runs the timeout
   before checking if there is anything available for reading.

Now we'll wait for 1 second in the last dict ioloop before assuming that
there's a timeout.


  Commit: 44e07ea4de493626c862e98516decb8dfa22ab1d
      https://github.com/dovecot/core/commit/44e07ea4de493626c862e98516decb8dfa22ab1d
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-02 (Fri, 02 Dec 2016)

  Changed paths:
    M src/lib-storage/list/mailbox-list-index-status.c

  Log Message:
  -----------
  lib-storage: Return vsize=0 from mailbox list index for empty mailboxes.

If it's known that the mailbox has no mails, there's no reason to open the
mailbox to see that its size is 0.


  Commit: c8bac7666cdc780a3390110e420350fffb62b909
      https://github.com/dovecot/core/commit/c8bac7666cdc780a3390110e420350fffb62b909
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-02 (Fri, 02 Dec 2016)

  Changed paths:
    M src/lib/seq-range-array.c
    M src/lib/test-seq-range-array.c

  Log Message:
  -----------
  lib: seq_range_array_*(): Fix seq2=2^32-1 handling

Adding/merging it when it already existed added duplicated seq_range.


  Commit: df8046c9a4f6bc2a478ad1e74504d50f3110c906
      https://github.com/dovecot/core/commit/df8046c9a4f6bc2a478ad1e74504d50f3110c906
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-02 (Fri, 02 Dec 2016)

  Changed paths:
    M src/lib-storage/mail-search-args-simplify.c
    M src/lib-storage/test-mail-search-args-simplify.c

  Log Message:
  -----------
  lib-storage: Fix simplifying sequence sets and UID sets.

They were being handled completely wrong. The unit tests testing them
were also completely wrong.


  Commit: b1533bd0dd0787b9c0d879c2d7398b1ff7964570
      https://github.com/dovecot/core/commit/b1533bd0dd0787b9c0d879c2d7398b1ff7964570
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-12-02 (Fri, 02 Dec 2016)

  Changed paths:
    M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c

  Log Message:
  -----------
  dsync: Fix log format string broken by earlier change


Compare: https://github.com/dovecot/core/compare/fb13dfaa903c...b1533bd0dd07