[dovecot/core] 9e9711: lib: Fixed bits_required64() with 32bit systems.

Thu Apr 21 18:48:29 UTC 2016

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 9e9711ebed27c8efeece02d57cf91bb00f10015c
      https://github.com/dovecot/core/commit/9e9711ebed27c8efeece02d57cf91bb00f10015c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-19 (Tue, 19 Apr 2016)

  Changed paths:
    M src/lib/bits.h

  Log Message:
  -----------
  lib: Fixed bits_required64() with 32bit systems.

Broken by 84f697c5e30565823619abaaeb57164c789d4b66.

  Commit: 7a13cd2268a5a99d2975a1648d6d14ffe1b6ccb0
      https://github.com/dovecot/core/commit/7a13cd2268a5a99d2975a1648d6d14ffe1b6ccb0
  Author: Stephan Bosch <stephan at dovecot.fi>
  Date:   2016-04-20 (Wed, 20 Apr 2016)

  Changed paths:
    M src/lib-http/http-client-request.c
    M src/lib-http/http-client.h

  Log Message:
  -----------
  lib-http: client: Implemented means to set request payload buffer rather than an input stream.

This is not purely a convenience function: there have been bugs caused by allocating a data input stream from a datastack buffer.
With this function, the buffer is copied to the request pool, so that it is durably allocated while the request exists.
This prevents futher mishaps. The server already has an equivalent function for its response object.

  Commit: 5a37824675033747fcae3fe3fc3c0dd7ef0ca1cd
      https://github.com/dovecot/core/commit/5a37824675033747fcae3fe3fc3c0dd7ef0ca1cd
  Author: Stephan Bosch <stephan at dovecot.fi>
  Date:   2016-04-20 (Wed, 20 Apr 2016)

  Changed paths:
    M src/lib-http/http-client-private.h
    M src/lib-http/http-client.h

  Log Message:
  -----------
  lib-http: client: Cleaned up headers and added some more documentation there.

  Commit: 2a9cadfccc8fb2c609eedbb929952b49181b6d25
      https://github.com/dovecot/core/commit/2a9cadfccc8fb2c609eedbb929952b49181b6d25
  Author: Stephan Bosch <stephan at dovecot.fi>
  Date:   2016-04-20 (Wed, 20 Apr 2016)

  Changed paths:
    M src/lib-http/http-client-request.c
    M src/lib-http/http-client.h

  Log Message:
  -----------
  lib-http: client: Added pure attribute to some of the request property functions.

  Commit: d34a07d36865fa4438d6c6af8408376188343eb9
      https://github.com/dovecot/core/commit/d34a07d36865fa4438d6c6af8408376188343eb9
  Author: Baofeng <baofeng.wang at dovecot.com>
  Date:   2016-04-20 (Wed, 20 Apr 2016)

  Changed paths:
    M src/plugins/expire/expire-plugin.c

  Log Message:
  -----------
  expire-plugin: code cleanup

expire_mail_namespaces_created() will check dict_uri after namespace
validation check.

  Commit: a1630a3b3fa995fd68370de4054e5c04024b1c91
      https://github.com/dovecot/core/commit/a1630a3b3fa995fd68370de4054e5c04024b1c91
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-20 (Wed, 20 Apr 2016)

  Changed paths:
    M src/plugins/zlib/zlib-plugin.c

  Log Message:
  -----------
  zlib plugin: Make sure we don't keep mail istream referenced after mail is closed.

  Commit: 46d91e9ea8bf41e56c5436c064372171c5876d81
      https://github.com/dovecot/core/commit/46d91e9ea8bf41e56c5436c064372171c5876d81
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-20 (Wed, 20 Apr 2016)

  Changed paths:
    M src/lib-index/mail-cache.c

  Log Message:
  -----------
  lib-index: Fixed calling mail_cache_open_and_verify() on an already open cache.

This was done at least by index_index_rebuild_init().

Either the currently open cache->fd was leaked, or if the cache file open()
failed we left the cache in an inconsistent state where cache->fd == -1, but
cache->hdr != NULL, so it caused MAIL_CACHE_IS_UNUSABLE() to also be TRUE. This
could have ended up in an assert:

Panic: file mail-index-lock.c: line 31 (mail_index_lock_fd): assertion failed: (MAIL_INDEX_IS_IN_MEMORY(index))

  Commit: f330b7d9e14255fc06bc82908d9bc5a12cccb424
      https://github.com/dovecot/core/commit/f330b7d9e14255fc06bc82908d9bc5a12cccb424
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-20 (Wed, 20 Apr 2016)

  Changed paths:
    M src/lib-index/mail-cache-compress.c
    M src/lib-index/mail-cache.c

  Log Message:
  -----------
  lib-index: If opening a cache file fails, try again later.

The previous code would never retry opening the cache file within the same
session.

  Commit: f5a105b5e19f866d432f271cfef83fc42e38d908
      https://github.com/dovecot/core/commit/f5a105b5e19f866d432f271cfef83fc42e38d908
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-20 (Wed, 20 Apr 2016)

  Changed paths:
    M src/plugins/lazy-expunge/lazy-expunge-plugin.c

  Log Message:
  -----------
  lazy-expunge: Fixed using a mailbox (instead of namespace) as lazy_expunge destination.

The initial implementation in f2d7ae020bda762f78e8e639a69fb129230cbb7d was
completely broken.

  Commit: d5cfdf518b03c92ac96871b029be2a45be68b007
      https://github.com/dovecot/core/commit/d5cfdf518b03c92ac96871b029be2a45be68b007
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-20 (Wed, 20 Apr 2016)

  Changed paths:
    M src/plugins/zlib/zlib-plugin.c

  Log Message:
  -----------
  zlib: Compiling fix to a1630a3b3 - don't return a void function

  Commit: 373b27178af59c8579967c126e7c2c002974d095
      https://github.com/dovecot/core/commit/373b27178af59c8579967c126e7c2c002974d095
  Author: Baofeng Wang <baofeng.wang at dovecot.fi>
  Date:   2016-04-21 (Thu, 21 Apr 2016)

  Changed paths:
    M src/dict/dict-commands.c
    M src/lib-dict/dict-client.c
    M src/lib-dict/dict-file.c
    M src/lib-dict/dict-ldap.c
    M src/lib-dict/dict-memcached-ascii.c
    M src/lib-dict/dict-private.h
    M src/lib-dict/dict-redis.c
    M src/lib-dict/dict-sql.c
    M src/lib-dict/dict.c
    M src/lib-dict/dict.h

  Log Message:
  -----------
  lib-dict: remove dict_append()

Remove all *_dict_append and redis_append functions and corresponding
command from lib-dict.

  Commit: ac9600ec580ca6897d263b2f207f1571a09031fa
      https://github.com/dovecot/core/commit/ac9600ec580ca6897d263b2f207f1571a09031fa
  Author: Baofeng Wang <baofeng.wang at dovecot.fi>
  Date:   2016-04-21 (Thu, 21 Apr 2016)

  Changed paths:
    M src/lib-dict/dict-db.c
    M src/lib-dict/dict-fs.c
    M src/lib-dict/dict-memcached.c

  Log Message:
  -----------
  fixup: fix task for `lib-dict: remove dict_append()'

  Commit: 2982cfa232c4b320bc8df4d2e3c5f62e5b18c418
      https://github.com/dovecot/core/commit/2982cfa232c4b320bc8df4d2e3c5f62e5b18c418
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2016-04-21 (Thu, 21 Apr 2016)

  Changed paths:
    M src/doveadm/doveadm-print-pager.c

  Log Message:
  -----------
  doveadm: \f\n only between pages in pager

No more \f\n in the end.

  Commit: 5a1b498b646b5c5dbd1b3f3861df766f560578c5
      https://github.com/dovecot/core/commit/5a1b498b646b5c5dbd1b3f3861df766f560578c5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-21 (Thu, 21 Apr 2016)

  Changed paths:
    M src/lib/iostream-private.h
    M src/lib/iostream.c
    M src/lib/istream-tee.c
    M src/lib/istream.c
    M src/lib/ostream.c

  Log Message:
  -----------
  lib: When istream is destroyed, it now always unrefs the parent istream if it exists.

This way the implementations don't have to do it themselves in their
destroy() function. This change doesn't necessarily require changing the
existing code, because if the istream implementation already unrefs the
parent it gets set to NULL so the auto-unref won't be done.

  Commit: 899653bd8261ee9fe989aec0b1221a47e0de23cd
      https://github.com/dovecot/core/commit/899653bd8261ee9fe989aec0b1221a47e0de23cd
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2016-04-21 (Thu, 21 Apr 2016)

  Changed paths:
    M src/lib/istream-failure-at.c
    M src/lib/istream-limit.c
    M src/lib/istream-rawlog.c
    M src/lib/istream-sized.c

  Log Message:
  -----------
  lib: remove unneccesary i_stream_unrefs of parent

  Commit: c1f5ec50aa2d9f1efe2d75eac04e75aa6c7049c7
      https://github.com/dovecot/core/commit/c1f5ec50aa2d9f1efe2d75eac04e75aa6c7049c7
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2016-04-21 (Thu, 21 Apr 2016)

  Changed paths:
    M src/lib-http/http-server-request.c
    M src/lib-http/http-transfer-chunked.c
    M src/lib-mail/istream-header-filter.c
    M src/lib-storage/index/mbox/istream-raw-mbox.c

  Log Message:
  -----------
  lib-http, lib-mail, lib-storage: parent unrefs

Remove some unneccesary parent unrefs from i_stream_*_destroys. Don't
know too many or too few were removed.

  Commit: 556d69b89bf0afd1ba53acce4775097e494b6b8b
      https://github.com/dovecot/core/commit/556d69b89bf0afd1ba53acce4775097e494b6b8b
  Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
  Date:   2016-04-21 (Thu, 21 Apr 2016)

  Changed paths:
    M doc/example-config/conf.d/20-imap.conf
    M src/imap/imap-settings.c

  Log Message:
  -----------
  imap: add variables to default imap_logout_format

  Commit: e69026539591542dcdca3f27dd1652b80b2ef87a
      https://github.com/dovecot/core/commit/e69026539591542dcdca3f27dd1652b80b2ef87a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-21 (Thu, 21 Apr 2016)

  Changed paths:
    M src/lib-ssl-iostream/iostream-openssl-common.c

  Log Message:
  -----------
  lib-ssl-iostream: Fixed reporting errors returned by OpenSSL.

We were always logging all errors as "Stacked error" and then returning
"Unknown error".

Compare: https://github.com/dovecot/core/compare/f2d7ae020bda...e69026539591