[dovecot/core] 6cb874: lib-storage: Changed separator between session_id_...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 6cb874b7e9239922e509fc91c0567cd266904a4c
      https://github.com/dovecot/core/commit/6cb874b7e9239922e509fc91c0567cd266904a4c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-07 (Thu, 07 Apr 2016)

  Changed paths:
    M src/lib-storage/mail-storage-service.c

  Log Message:
  -----------
  lib-storage: Changed separator between session_id_prefix and unique part to be ':'

Although '-' wasn't used by default either, it's much more likely that
custom session IDs might contain it. ':' is hopefully less likely to be used.
This allows log parsers that actually want to find out the original session's
all log lines to cut out everything after the initial ':'.


  Commit: aeea3dbd1f4031634f7b318614adf51dcfc79f42
      https://github.com/dovecot/core/commit/aeea3dbd1f4031634f7b318614adf51dcfc79f42
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-07 (Thu, 07 Apr 2016)

  Changed paths:
    M src/lmtp/client.h
    M src/lmtp/commands.c

  Log Message:
  -----------
  lmtp: Use separate session ID suffixes for each RCPT TO delivery.

Otherwise each delivery will use the same session ID when talking to stats
process, which results in errors like:

Error: stats: FIFO input error: CONNECT: Duplicate session ID ME3ZHCi+A1dUDQAAvAUe3g for user foobar service lmtp
Warning: stats: Couldn't find session ID: ME3ZHCi+A1dUDQAAvAUe3g

(There was a DISCONNECT for the session ID between these two log lines.)


Compare: https://github.com/dovecot/core/compare/a50f8b9c6196...aeea3dbd1f40