dovecot-2.2: lib: Recent module_dir_load() changes broke error l...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.2/rev/8cb9f50f5b40
changeset: 18313:8cb9f50f5b40
user:      Timo Sirainen <tss at iki.fi>
date:      Mon Mar 09 17:14:35 2015 +0200
description:
lib: Recent module_dir_load() changes broke error logging.
If there was a required list of modules, the error was properly returned.
But when loading all plugins, the errors weren't logged.

diffstat:

 src/lib/module-dir.c |  9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diffs (20 lines):

diff -r 00d40bf9c289 -r 8cb9f50f5b40 src/lib/module-dir.c
--- a/src/lib/module-dir.c	Mon Mar 09 16:17:08 2015 +0200
+++ b/src/lib/module-dir.c	Mon Mar 09 17:14:35 2015 +0200
@@ -461,9 +461,14 @@
 		else {
 			path = t_strconcat(dir, "/", name, NULL);
 			ret = module_load(path, stripped_name, set, modules, &module, &error);
-			if (ret < 0 && module_names != NULL) {
-				*error_r = i_strdup_printf("Couldn't load required plugins: %s", error);
+			if (ret == 0)
+				;
+			else if (module_names != NULL) {
+				*error_r = i_strdup_printf("Couldn't load required plugin %s: %s",
+							   path, error);
 				i = count;
+			} else {
+				i_error("Couldn't load plugin %s: %s", path, error);
 			}
 		}