dovecot-2.2: lib-http: client: Removed asssert in http_client_co...

dovecot at dovecot.org dovecot at dovecot.org
Sun Oct 26 16:44:58 UTC 2014


details:   http://hg.dovecot.org/dovecot-2.2/rev/69af57dcd274
changeset: 18026:69af57dcd274
user:      Stephan Bosch <stephan at rename-it.nl>
date:      Sun Oct 26 18:43:57 2014 +0200
description:
lib-http: client: Removed asssert in http_client_connection_is_ready().
There is no reason why the input stream couldn't be full.

diffstat:

 src/lib-http/http-client-connection.c |  3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diffs (15 lines):

diff -r 583215301ba7 -r 69af57dcd274 src/lib-http/http-client-connection.c
--- a/src/lib-http/http-client-connection.c	Sun Oct 26 18:43:57 2014 +0200
+++ b/src/lib-http/http-client-connection.c	Sun Oct 26 18:43:57 2014 +0200
@@ -176,10 +176,9 @@
 		/* Active ioloop is different from what we saw earlier;
 		   we may have missed a disconnection event on this connection.
 		   Verify status by reading from connection. */
-		if ((ret=i_stream_read(conn->conn.input)) < 0) {
+		if ((ret=i_stream_read(conn->conn.input)) == -1) {
 			int stream_errno = conn->conn.input->stream_errno;
 
-			i_assert(ret != -2);
 			i_assert(conn->conn.input->stream_errno != 0 || conn->conn.input->eof);
 			http_client_connection_abort_temp_error(&conn,
 				HTTP_CLIENT_REQUEST_ERROR_CONNECTION_LOST,


More information about the dovecot-cvs mailing list