dovecot-2.2: auth: Some unsuccessful passdb lookups weren't retu...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.2/rev/3a8b417b0b80
changeset: 18005:3a8b417b0b80
user:      Timo Sirainen <tss at iki.fi>
date:      Sat Oct 25 02:42:47 2014 +0300
description:
auth: Some unsuccessful passdb lookups weren't returned as failures to passdb lookups.
These lookups were only being done internally, so it usually didn't matter.
Also this only affected things like allow_nets checking and some non-common
passdb { result_* } settings.

diffstat:

 src/auth/auth-master-connection.c |  4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diffs (14 lines):

diff -r d1aefed4589b -r 3a8b417b0b80 src/auth/auth-master-connection.c
--- a/src/auth/auth-master-connection.c	Sat Oct 25 02:39:00 2014 +0300
+++ b/src/auth/auth-master-connection.c	Sat Oct 25 02:42:47 2014 +0300
@@ -326,6 +326,10 @@
 	str = t_str_new(128);
 	switch (result) {
 	case PASSDB_RESULT_OK:
+		if (auth_request->failed || !auth_request->passdb_success) {
+			str_printfa(str, "FAIL\t%u", auth_request->id);
+			break;
+		}
 		str_printfa(str, "PASS\t%u\tuser=", auth_request->id);
 		str_append_tabescaped(str, auth_request->user);
 		if (!auth_fields_is_empty(auth_request->extra_fields)) {