dovecot-2.2: auth: userdb passwd iteration no longer skips shells.

dovecot at dovecot.org dovecot at dovecot.org
Fri Feb 22 15:14:28 EET 2013


details:   http://hg.dovecot.org/dovecot-2.2/rev/4eea2224e16b
changeset: 15891:4eea2224e16b
user:      Timo Sirainen <tss at iki.fi>
date:      Fri Feb 22 15:14:19 2013 +0200
description:
auth: userdb passwd iteration no longer skips shells.
Some systems are using passwd for mail users with shell set to nologin.
Maybe first_valid_uid check is good enough alone?

diffstat:

 src/auth/userdb-passwd.c |  7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diffs (17 lines):

diff -r c3d3d3360425 -r 4eea2224e16b src/auth/userdb-passwd.c
--- a/src/auth/userdb-passwd.c	Fri Feb 22 13:21:09 2013 +0200
+++ b/src/auth/userdb-passwd.c	Fri Feb 22 15:14:19 2013 +0200
@@ -146,13 +146,6 @@
 		return FALSE;
 	if (pw->pw_uid > (uid_t)set->last_valid_uid && set->last_valid_uid != 0)
 		return FALSE;
-
-	/* skip entries that don't have a valid shell.
-	   they're again probably not real users. */
-	if (strcmp(pw->pw_shell, "/bin/false") == 0 ||
-	    strcmp(pw->pw_shell, "/sbin/nologin") == 0 ||
-	    strcmp(pw->pw_shell, "/usr/sbin/nologin") == 0)
-		return FALSE;
 	return TRUE;
 }
 


More information about the dovecot-cvs mailing list