dovecot-2.2-pigeonhole: Fixed several Clang compile warnings and...
pigeonhole at rename-it.nl
pigeonhole at rename-it.nl
Tue Jul 31 02:24:36 EEST 2012
details: http://hg.rename-it.nl/dovecot-2.2-pigeonhole/rev/e3ea0270985a
changeset: 1640:e3ea0270985a
user: Stephan Bosch <stephan at rename-it.nl>
date: Mon Jul 30 10:14:42 2012 +0200
description:
Fixed several Clang compile warnings and a few potential bugs.
Patch by Timo Sirainen.
diffstat:
src/lib-sieve/rfc2822.h | 2 +-
src/lib-sieve/sieve-binary-dumper.c | 7 ++-
src/lib-sieve/sieve-binary-dumper.h | 6 ++-
src/lib-sieve/sieve-error.c | 64 ++++++++++++++++++------------------
src/lib-sieve/sieve-result.h | 3 +-
src/lib-sieve/sieve-runtime-trace.c | 6 +-
src/lib-sieve/sieve-runtime-trace.h | 20 ++++++-----
src/lib-sievestorage/sieve-storage.c | 2 +-
src/testsuite/testsuite-log.c | 8 ++--
9 files changed, 62 insertions(+), 56 deletions(-)
diffs (truncated from 498 to 300 lines):
diff -r b614a99f40f1 -r e3ea0270985a src/lib-sieve/rfc2822.h
--- a/src/lib-sieve/rfc2822.h Wed Jul 25 09:08:11 2012 +0200
+++ b/src/lib-sieve/rfc2822.h Mon Jul 30 10:14:42 2012 +0200
@@ -33,7 +33,7 @@
int rfc2822_header_field_write
(FILE *f, const char *name, const char *body);
-
+
int rfc2822_header_field_printf
(FILE *f, const char *name, const char *body_fmt, ...) ATTR_FORMAT(3, 4);
diff -r b614a99f40f1 -r e3ea0270985a src/lib-sieve/sieve-binary-dumper.c
--- a/src/lib-sieve/sieve-binary-dumper.c Wed Jul 25 09:08:11 2012 +0200
+++ b/src/lib-sieve/sieve-binary-dumper.c Mon Jul 30 10:14:42 2012 +0200
@@ -222,10 +222,11 @@
size_t offset;
data = (const char *) buffer_get_data(blockbuf, &data_size);
-
+
+ // FIXME: calculate offset more nicely.
sieve_binary_dump_sectionf
- (denv, "Block %d (%"PRIuSIZE_T" bytes, file offset %08llx)", i,
- data_size, sblock->offset + 8 /* header size (yuck) */);
+ (denv, "Block %d (%"PRIuSIZE_T" bytes, file offset %08llx)", i,
+ data_size, (unsigned long long int) sblock->offset + 8);
line = t_str_new(128);
offset = 0;
diff -r b614a99f40f1 -r e3ea0270985a src/lib-sieve/sieve-binary-dumper.h
--- a/src/lib-sieve/sieve-binary-dumper.h Wed Jul 25 09:08:11 2012 +0200
+++ b/src/lib-sieve/sieve-binary-dumper.h Mon Jul 30 10:14:42 2012 +0200
@@ -25,9 +25,11 @@
*/
void sieve_binary_dumpf
- (const struct sieve_dumptime_env *denv, const char *fmt, ...);
+ (const struct sieve_dumptime_env *denv, const char *fmt, ...)
+ ATTR_FORMAT(2, 3);
void sieve_binary_dump_sectionf
- (const struct sieve_dumptime_env *denv, const char *fmt, ...);
+ (const struct sieve_dumptime_env *denv, const char *fmt, ...)
+ ATTR_FORMAT(2, 3);
/*
* Dumping the binary
diff -r b614a99f40f1 -r e3ea0270985a src/lib-sieve/sieve-error.c
--- a/src/lib-sieve/sieve-error.c Wed Jul 25 09:08:11 2012 +0200
+++ b/src/lib-sieve/sieve-error.c Mon Jul 30 10:14:42 2012 +0200
@@ -602,7 +602,7 @@
typedef void (*master_log_func_t)(const char *fmt, ...) ATTR_FORMAT(1, 2);
-static void sieve_master_vlog
+static void ATTR_FORMAT(4, 0) sieve_master_vlog
(struct sieve_error_handler *_ehandler, master_log_func_t log_func,
const char *location, const char *fmt, va_list args)
{
@@ -624,7 +624,7 @@
log_func("%s", str_c(str));
}
-static void sieve_master_verror
+static void ATTR_FORMAT(4, 0) sieve_master_verror
(struct sieve_error_handler *ehandler,
unsigned int flags ATTR_UNUSED, const char *location, const char *fmt,
va_list args)
@@ -632,7 +632,7 @@
sieve_master_vlog(ehandler, i_error, location, fmt, args);
}
-static void sieve_master_vwarning
+static void ATTR_FORMAT(4, 0) sieve_master_vwarning
(struct sieve_error_handler *ehandler ATTR_UNUSED,
unsigned int flags ATTR_UNUSED, const char *location, const char *fmt,
va_list args)
@@ -640,7 +640,7 @@
sieve_master_vlog(ehandler, i_warning, location, fmt, args);
}
-static void sieve_master_vinfo
+static void ATTR_FORMAT(4, 0) sieve_master_vinfo
(struct sieve_error_handler *ehandler ATTR_UNUSED,
unsigned int flags ATTR_UNUSED, const char *location, const char *fmt,
va_list args)
@@ -648,7 +648,7 @@
sieve_master_vlog(ehandler, i_info, location, fmt, args);
}
-static void sieve_master_vdebug
+static void ATTR_FORMAT(4, 0) sieve_master_vdebug
(struct sieve_error_handler *ehandler ATTR_UNUSED,
unsigned int flags ATTR_UNUSED, const char *location, const char *fmt,
va_list args)
@@ -685,7 +685,7 @@
* - Output errors directly to stderror
*/
-static void sieve_stderr_vmessage
+static void ATTR_FORMAT(4, 0) sieve_stderr_vmessage
(struct sieve_error_handler *ehandler ATTR_UNUSED, const char *prefix,
const char *location, const char *fmt, va_list args)
{
@@ -695,28 +695,28 @@
fprintf(stderr, "%s: %s: %s.\n", location, prefix, t_strdup_vprintf(fmt, args));
}
-static void sieve_stderr_verror
+static void ATTR_FORMAT(4, 0) sieve_stderr_verror
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
sieve_stderr_vmessage(ehandler, "error", location, fmt, args);
}
-static void sieve_stderr_vwarning
+static void ATTR_FORMAT(4, 0) sieve_stderr_vwarning
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
sieve_stderr_vmessage(ehandler, "warning", location, fmt, args);
}
-static void sieve_stderr_vinfo
+static void ATTR_FORMAT(4, 0) sieve_stderr_vinfo
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
sieve_stderr_vmessage(ehandler, "info", location, fmt, args);
}
-static void sieve_stderr_vdebug
+static void ATTR_FORMAT(4, 0) sieve_stderr_vdebug
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
@@ -757,7 +757,7 @@
bool crlf;
};
-static void sieve_strbuf_vmessage
+static void ATTR_FORMAT(4, 0) sieve_strbuf_vmessage
(struct sieve_error_handler *ehandler, const char *prefix,
const char *location, const char *fmt, va_list args)
{
@@ -775,28 +775,28 @@
str_append(handler->errors, ".\r\n");
}
-static void sieve_strbuf_verror
+static void ATTR_FORMAT(4, 0) sieve_strbuf_verror
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
sieve_strbuf_vmessage(ehandler, "error", location, fmt, args);
}
-static void sieve_strbuf_vwarning
+static void ATTR_FORMAT(4, 0) sieve_strbuf_vwarning
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
sieve_strbuf_vmessage(ehandler, "warning", location, fmt, args);
}
-static void sieve_strbuf_vinfo
+static void ATTR_FORMAT(4, 0) sieve_strbuf_vinfo
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
sieve_strbuf_vmessage(ehandler, "info", location, fmt, args);
}
-static void sieve_strbuf_vdebug
+static void ATTR_FORMAT(4, 0) sieve_strbuf_vdebug
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
@@ -841,7 +841,7 @@
struct ostream *stream;
};
-static void sieve_logfile_vprintf
+static void ATTR_FORMAT(4, 0) sieve_logfile_vprintf
(struct sieve_logfile_ehandler *ehandler, const char *location,
const char *prefix, const char *fmt, va_list args)
{
@@ -877,7 +877,7 @@
}
}
-inline static void sieve_logfile_printf
+inline static void ATTR_FORMAT(4, 5) sieve_logfile_printf
(struct sieve_logfile_ehandler *ehandler, const char *location,
const char *prefix, const char *fmt, ...)
{
@@ -985,7 +985,7 @@
}
}
-static void sieve_logfile_verror
+static void ATTR_FORMAT(4, 0) sieve_logfile_verror
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
@@ -997,7 +997,7 @@
sieve_logfile_vprintf(handler, location, "error", fmt, args);
}
-static void sieve_logfile_vwarning
+static void ATTR_FORMAT(4, 0) sieve_logfile_vwarning
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
@@ -1009,7 +1009,7 @@
sieve_logfile_vprintf(handler, location, "warning", fmt, args);
}
-static void sieve_logfile_vinfo
+static void ATTR_FORMAT(4, 0) sieve_logfile_vinfo
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
@@ -1021,7 +1021,7 @@
sieve_logfile_vprintf(handler, location, "info", fmt, args);
}
-static void sieve_logfile_vdebug
+static void ATTR_FORMAT(4, 0) sieve_logfile_vdebug
(struct sieve_error_handler *ehandler, unsigned int flags ATTR_UNUSED,
const char *location, const char *fmt, va_list args)
{
@@ -1093,9 +1093,9 @@
const char *prefix;
};
-static const char *_prefix_message
+static const char *ATTR_FORMAT(3, 0) _prefix_message
(struct sieve_prefix_ehandler *ehandler,
- const char *location, const char *fmt, va_list args)
+ const char *location, const char *fmt, va_list args)
{
string_t *str = t_str_new(256);
@@ -1108,7 +1108,7 @@
return str_c(str);
}
-static void sieve_prefix_verror
+static void ATTR_FORMAT(4, 0) sieve_prefix_verror
(struct sieve_error_handler *_ehandler, unsigned int flags,
const char *location, const char *fmt, va_list args)
{
@@ -1119,7 +1119,7 @@
ehandler->location, "%s", _prefix_message(ehandler, location, fmt, args));
}
-static void sieve_prefix_vwarning
+static void ATTR_FORMAT(4, 0) sieve_prefix_vwarning
(struct sieve_error_handler *_ehandler, unsigned int flags,
const char *location, const char *fmt, va_list args)
{
@@ -1130,7 +1130,7 @@
ehandler->location, "%s", _prefix_message(ehandler, location, fmt, args));
}
-static void sieve_prefix_vinfo
+static void ATTR_FORMAT(4, 0) sieve_prefix_vinfo
(struct sieve_error_handler *_ehandler, unsigned int flags,
const char *location, const char *fmt, va_list args)
{
@@ -1141,7 +1141,7 @@
ehandler->location, "%s", _prefix_message(ehandler, location, fmt, args));
}
-static void sieve_prefix_vdebug
+static void ATTR_FORMAT(4, 0) sieve_prefix_vdebug
(struct sieve_error_handler *_ehandler, unsigned int flags,
const char *location, const char *fmt, va_list args)
{
@@ -1190,7 +1190,7 @@
ARRAY_DEFINE(table, struct var_expand_table);
};
-static const char *_expand_message
+static const char *ATTR_FORMAT(3, 0) _expand_message
(struct sieve_error_handler *_ehandler,
const char *location, const char *fmt, va_list args)
{
@@ -1211,7 +1211,7 @@
return str_c(str);
}
-static void sieve_varexpand_verror
+static void ATTR_FORMAT(4, 0) sieve_varexpand_verror
(struct sieve_error_handler *ehandler, unsigned int flags,
const char *location, const char *fmt, va_list args)
{
@@ -1219,7 +1219,7 @@
More information about the dovecot-cvs
mailing list