dovecot-2.1: login process wasn't logging all intended messages ...
dovecot at dovecot.org
dovecot at dovecot.org
Fri Jan 27 14:16:21 EET 2012
details: http://hg.dovecot.org/dovecot-2.1/rev/581aaea8569c
changeset: 14004:581aaea8569c
user: Timo Sirainen <tss at iki.fi>
date: Fri Jan 27 14:15:06 2012 +0200
description:
login process wasn't logging all intended messages with auth_verbose=yes
It was named verbose_auth setting accidentally.
diffstat:
src/login-common/client-common-auth.c | 4 ++--
src/login-common/login-settings.c | 7 +++++--
src/login-common/login-settings.h | 2 +-
src/login-common/sasl-server.c | 2 +-
src/login-common/ssl-proxy-openssl.c | 2 +-
5 files changed, 10 insertions(+), 7 deletions(-)
diffs (88 lines):
diff -r f3e000992f61 -r 581aaea8569c src/login-common/client-common-auth.c
--- a/src/login-common/client-common-auth.c Fri Jan 27 02:42:50 2012 +0200
+++ b/src/login-common/client-common-auth.c Fri Jan 27 14:15:06 2012 +0200
@@ -500,7 +500,7 @@
const char *init_resp)
{
if (!client->secured && strcmp(client->set->ssl, "required") == 0) {
- if (client->set->verbose_auth) {
+ if (client->set->auth_verbose) {
client_log(client, "Login failed: "
"SSL required for authentication");
}
@@ -531,7 +531,7 @@
if (client->secured || !client->set->disable_plaintext_auth)
return TRUE;
- if (client->set->verbose_auth) {
+ if (client->set->auth_verbose) {
client_log(client, "Login failed: "
"Plaintext authentication disabled");
}
diff -r f3e000992f61 -r 581aaea8569c src/login-common/login-settings.c
--- a/src/login-common/login-settings.c Fri Jan 27 02:42:50 2012 +0200
+++ b/src/login-common/login-settings.c Fri Jan 27 14:15:06 2012 +0200
@@ -42,7 +42,7 @@
DEF(SET_BOOL, verbose_ssl),
DEF(SET_BOOL, disable_plaintext_auth),
- DEF(SET_BOOL, verbose_auth),
+ DEF(SET_BOOL, auth_verbose),
DEF(SET_BOOL, auth_debug),
DEF(SET_BOOL, verbose_proctitle),
@@ -75,7 +75,7 @@
.verbose_ssl = FALSE,
.disable_plaintext_auth = TRUE,
- .verbose_auth = FALSE,
+ .auth_verbose = FALSE,
.auth_debug = FALSE,
.verbose_proctitle = FALSE,
@@ -143,6 +143,9 @@
set->ssl_verify_client_cert = TRUE;
}
+ if (set->auth_debug)
+ set->auth_verbose = TRUE;
+
if (strcmp(set->ssl, "no") == 0) {
/* disabled */
} else if (strcmp(set->ssl, "yes") == 0) {
diff -r f3e000992f61 -r 581aaea8569c src/login-common/login-settings.h
--- a/src/login-common/login-settings.h Fri Jan 27 02:42:50 2012 +0200
+++ b/src/login-common/login-settings.h Fri Jan 27 14:15:06 2012 +0200
@@ -24,7 +24,7 @@
bool verbose_ssl;
bool disable_plaintext_auth;
- bool verbose_auth;
+ bool auth_verbose;
bool auth_debug;
bool verbose_proctitle;
diff -r f3e000992f61 -r 581aaea8569c src/login-common/sasl-server.c
--- a/src/login-common/sasl-server.c Fri Jan 27 02:42:50 2012 +0200
+++ b/src/login-common/sasl-server.c Fri Jan 27 14:15:06 2012 +0200
@@ -332,7 +332,7 @@
{
i_assert(client->authenticating);
- if (client->set->verbose_auth && reason != NULL) {
+ if (client->set->auth_verbose && reason != NULL) {
const char *auth_name =
str_sanitize(client->auth_mech_name, MAX_MECH_NAME);
client_log(client, t_strdup_printf(
diff -r f3e000992f61 -r 581aaea8569c src/login-common/ssl-proxy-openssl.c
--- a/src/login-common/ssl-proxy-openssl.c Fri Jan 27 02:42:50 2012 +0200
+++ b/src/login-common/ssl-proxy-openssl.c Fri Jan 27 14:15:06 2012 +0200
@@ -848,7 +848,7 @@
proxy->cert_received = TRUE;
if (proxy->set->verbose_ssl ||
- (proxy->set->verbose_auth && !preverify_ok)) {
+ (proxy->set->auth_verbose && !preverify_ok)) {
char buf[1024];
X509_NAME *subject;
More information about the dovecot-cvs
mailing list