dovecot-2.1: Make static analyzer happier.

dovecot at dovecot.org dovecot at dovecot.org
Fri Jan 6 21:42:37 EET 2012


details:   http://hg.dovecot.org/dovecot-2.1/rev/3dc9c253880d
changeset: 13905:3dc9c253880d
user:      Timo Sirainen <tss at iki.fi>
date:      Fri Jan 06 19:54:03 2012 +0200
description:
Make static analyzer happier.

diffstat:

 src/doveadm/dsync/doveadm-dsync.c |  2 ++
 src/doveadm/dsync/dsync-proxy.c   |  6 ++----
 2 files changed, 4 insertions(+), 4 deletions(-)

diffs (28 lines):

diff -r 326b05f0246b -r 3dc9c253880d src/doveadm/dsync/doveadm-dsync.c
--- a/src/doveadm/dsync/doveadm-dsync.c	Fri Jan 06 19:29:23 2012 +0200
+++ b/src/doveadm/dsync/doveadm-dsync.c	Fri Jan 06 19:54:03 2012 +0200
@@ -79,6 +79,8 @@
 	unsigned int i;
 	const char *p;
 
+	i_assert(argv[0] != NULL);
+
 	t_array_init(&cmd_args, 16);
 	for (i = 0; argv[i] != NULL; i++) {
 		p = argv[i];
diff -r 326b05f0246b -r 3dc9c253880d src/doveadm/dsync/dsync-proxy.c
--- a/src/doveadm/dsync/dsync-proxy.c	Fri Jan 06 19:29:23 2012 +0200
+++ b/src/doveadm/dsync/dsync-proxy.c	Fri Jan 06 19:54:03 2012 +0200
@@ -345,10 +345,8 @@
 		return -1;
 	}
 
-	args += i;
-	count -= i;
-	if (dsync_proxy_cache_fields_import(args, pool, &box_r->cache_fields,
-					    error_r) < 0)
+	if (dsync_proxy_cache_fields_import(args + i, pool,
+					    &box_r->cache_fields, error_r) < 0)
 		return -1;
 	return 0;
 }


More information about the dovecot-cvs mailing list