dovecot-2.2: mbox: Removed assert that caused dsync to crash.

dovecot at dovecot.org dovecot at dovecot.org
Sat Dec 15 13:30:09 EET 2012


details:   http://hg.dovecot.org/dovecot-2.2/rev/fdf755b505c3
changeset: 15476:fdf755b505c3
user:      Timo Sirainen <tss at iki.fi>
date:      Sat Dec 15 13:30:02 2012 +0200
description:
mbox: Removed assert that caused dsync to crash.
This is valid:

1. dsync opened an internal transaction and locked mbox
2. dsync opened an external transaction, which didn't lock mbox
3. dsync committed internal transaction
<assert crash fixed>
4. dsync locks mbox with external transaction

diffstat:

 src/lib-storage/index/mbox/mbox-storage.c |  2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diffs (12 lines):

diff -r 507a4a57d7cd -r fdf755b505c3 src/lib-storage/index/mbox/mbox-storage.c
--- a/src/lib-storage/index/mbox/mbox-storage.c	Sat Dec 15 13:28:04 2012 +0200
+++ b/src/lib-storage/index/mbox/mbox-storage.c	Sat Dec 15 13:30:02 2012 +0200
@@ -730,8 +730,6 @@
 		i_assert(mbox->box.transaction_count > 0 ||
 			 mbox->external_transactions > 0 ||
 			 mbox->mbox_lock_type == F_UNLCK);
-		i_assert(mbox->external_transactions == 0 ||
-			 mbox->mbox_lock_type == F_WRLCK);
 	} else {
 		/* mailbox opened with MAILBOX_FLAG_KEEP_LOCKED */
 		i_assert(mbox->mbox_lock_type == F_WRLCK);


More information about the dovecot-cvs mailing list