dovecot-1.2: login client idle timeout should be larger than aut...

dovecot at dovecot.org dovecot at dovecot.org
Mon Jun 22 08:44:19 EEST 2009


details:   http://hg.dovecot.org/dovecot-1.2/rev/1c91fa0d804b
changeset: 9155:1c91fa0d804b
user:      Timo Sirainen <tss at iki.fi>
date:      Mon Jun 22 01:43:31 2009 -0400
description:
login client idle timeout should be larger than auth request timeout, not vice versa.

diffstat:

3 files changed, 6 insertions(+), 6 deletions(-)
src/auth/auth-client-interface.h |    4 ++--
src/imap-login/client.c          |    4 ++--
src/pop3-login/client.c          |    4 ++--

diffs (42 lines):

diff -r 8206c38856ff -r 1c91fa0d804b src/auth/auth-client-interface.h
--- a/src/auth/auth-client-interface.h	Mon Jun 22 00:42:56 2009 -0400
+++ b/src/auth/auth-client-interface.h	Mon Jun 22 01:43:31 2009 -0400
@@ -7,8 +7,8 @@
 #define AUTH_CLIENT_PROTOCOL_MINOR_VERSION 0
 
 #define AUTH_CLIENT_MAX_LINE_LENGTH 8192
-/* Use a bit larger than login process timeout */
-#define AUTH_REQUEST_TIMEOUT (3*60 + 30)
+/* Use a bit smaller than login process timeout */
+#define AUTH_REQUEST_TIMEOUT (3*60 - 30)
 
 enum mech_security_flags {
 	/* Don't advertise this as available SASL mechanism (eg. APOP) */
diff -r 8206c38856ff -r 1c91fa0d804b src/imap-login/client.c
--- a/src/imap-login/client.c	Mon Jun 22 00:42:56 2009 -0400
+++ b/src/imap-login/client.c	Mon Jun 22 01:43:31 2009 -0400
@@ -38,8 +38,8 @@
    send a "waiting" message. */
 #define AUTH_WAITING_TIMEOUT_MSECS (30*1000)
 
-#if CLIENT_LOGIN_IDLE_TIMEOUT_MSECS >= AUTH_REQUEST_TIMEOUT*1000
-#  error client idle timeout must be smaller than authentication timeout
+#if CLIENT_LOGIN_IDLE_TIMEOUT_MSECS < AUTH_REQUEST_TIMEOUT*1000
+#  error client idle timeout must be larger than authentication timeout
 #endif
 
 #define AUTH_WAITING_MSG \
diff -r 8206c38856ff -r 1c91fa0d804b src/pop3-login/client.c
--- a/src/pop3-login/client.c	Mon Jun 22 00:42:56 2009 -0400
+++ b/src/pop3-login/client.c	Mon Jun 22 01:43:31 2009 -0400
@@ -29,8 +29,8 @@
    clients, it's faster if we disconnect multiple clients. */
 #define CLIENT_DESTROY_OLDEST_COUNT 16
 
-#if CLIENT_LOGIN_IDLE_TIMEOUT_MSECS >= AUTH_REQUEST_TIMEOUT*1000
-#  error client idle timeout must be smaller than authentication timeout
+#if CLIENT_LOGIN_IDLE_TIMEOUT_MSECS < AUTH_REQUEST_TIMEOUT*1000
+#  error client idle timeout must be larger than authentication timeout
 #endif
 
 const char *login_protocol = "POP3";


More information about the dovecot-cvs mailing list