dovecot-1.1: Earlier changes broke login process, because it was...

dovecot at dovecot.org dovecot at dovecot.org
Fri Jan 16 00:21:04 EET 2009


details:   http://hg.dovecot.org/dovecot-1.1/rev/8b49675e1641
changeset: 8102:8b49675e1641
user:      Timo Sirainen <tss at iki.fi>
date:      Thu Jan 15 17:21:01 2009 -0500
description:
Earlier changes broke login process, because it wasn't chdir()ing to login directory.

diffstat:

1 file changed, 7 insertions(+), 8 deletions(-)
src/login-common/main.c |   15 +++++++--------

diffs (25 lines):

diff -r 60b4e34791c4 -r 8b49675e1641 src/login-common/main.c
--- a/src/login-common/main.c	Thu Jan 15 16:22:04 2009 -0500
+++ b/src/login-common/main.c	Thu Jan 15 17:21:01 2009 -0500
@@ -262,14 +262,13 @@ static void drop_privileges(unsigned int
 		value = getenv("SYSLOG_FACILITY");
 		i_set_failure_syslog(process_name, LOG_NDELAY,
 				     value == NULL ? LOG_MAIL : atoi(value));
-
-		/* if we don't chroot, we must chdir */
-		value = getenv("LOGIN_DIR");
-		if (value == NULL)
-			i_fatal("LOGIN_DIR environment missing");
-		if (chdir(value) < 0)
-			i_error("chdir(%s) failed: %m", value);
-	}
+	}
+
+	value = getenv("LOGIN_DIR");
+	if (value == NULL)
+		i_fatal("LOGIN_DIR environment missing");
+	if (chdir(value) < 0)
+		i_error("chdir(%s) failed: %m", value);
 
 	/* Initialize SSL proxy so it can read certificate and private
 	   key file. */


More information about the dovecot-cvs mailing list