dovecot-1.2: Removed umask setting. We're nowadays creating prac...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-1.2/rev/87c23fa4278e
changeset: 8900:87c23fa4278e
user:      Timo Sirainen <tss at iki.fi>
date:      Thu Apr 02 19:08:50 2009 -0400
description:
Removed umask setting. We're nowadays creating practically all files with proper umasks.

diffstat:

4 files changed, 1 insertion(+), 4 deletions(-)
src/master/mail-process.c         |    2 +-
src/master/master-settings-defs.c |    1 -
src/master/master-settings.c      |    1 -
src/master/master-settings.h      |    1 -

diffs (45 lines):

diff -r 0e0ce37ef99d -r 87c23fa4278e src/master/mail-process.c
--- a/src/master/mail-process.c	Thu Apr 02 18:25:58 2009 -0400
+++ b/src/master/mail-process.c	Thu Apr 02 19:08:50 2009 -0400
@@ -384,7 +384,7 @@ mail_process_set_environment(struct sett
 	   (e.g. epoll_ctl() gives EPERM). */
 	if (set->shutdown_clients && !exec_mail)
 		env_put("STDERR_CLOSE_SHUTDOWN=1");
-	(void)umask(set->umask);
+	(void)umask(0077);
 
 	env_put(t_strconcat("LOCK_METHOD=", set->lock_method, NULL));
 	env_put(t_strconcat("MBOX_READ_LOCKS=", set->mbox_read_locks, NULL));
diff -r 0e0ce37ef99d -r 87c23fa4278e src/master/master-settings-defs.c
--- a/src/master/master-settings-defs.c	Thu Apr 02 18:25:58 2009 -0400
+++ b/src/master/master-settings-defs.c	Thu Apr 02 19:08:50 2009 -0400
@@ -99,7 +99,6 @@ static struct setting_def setting_defs[]
 	DEF_INT(dbox_rotate_size),
 	DEF_INT(dbox_rotate_min_size),
 	DEF_INT(dbox_rotate_days),
-	DEF_INT(umask),
 	DEF_BOOL(mail_drop_priv_before_exec),
 
 	DEF_STR(mail_executable),
diff -r 0e0ce37ef99d -r 87c23fa4278e src/master/master-settings.c
--- a/src/master/master-settings.c	Thu Apr 02 18:25:58 2009 -0400
+++ b/src/master/master-settings.c	Thu Apr 02 19:08:50 2009 -0400
@@ -265,7 +265,6 @@ struct settings default_settings = {
 	MEMBER(dbox_rotate_size) 2048,
 	MEMBER(dbox_rotate_min_size) 16,
 	MEMBER(dbox_rotate_days) 1,
-	MEMBER(umask) 0077,
 	MEMBER(mail_drop_priv_before_exec) FALSE,
 
 	MEMBER(mail_executable) PKG_LIBEXECDIR"/imap",
diff -r 0e0ce37ef99d -r 87c23fa4278e src/master/master-settings.h
--- a/src/master/master-settings.h	Thu Apr 02 18:25:58 2009 -0400
+++ b/src/master/master-settings.h	Thu Apr 02 19:08:50 2009 -0400
@@ -111,7 +111,6 @@ struct settings {
 	unsigned int dbox_rotate_size;
 	unsigned int dbox_rotate_min_size;
 	unsigned int dbox_rotate_days;
-	unsigned int umask;
 	bool mail_drop_priv_before_exec;
 
 	const char *mail_executable;