dovecot: Don't sync mailbox when committing transaction. It's no...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot/rev/d98617723bc2
changeset: 6453:d98617723bc2
user:      Timo Sirainen <tss at iki.fi>
date:      Sat Sep 22 13:45:14 2007 +0300
description:
Don't sync mailbox when committing transaction. It's not needed.

diffstat:

4 files changed, 1 insertion(+), 18 deletions(-)
src/lib-storage/index/cydir/cydir-sync.c        |    2 +-
src/lib-storage/index/cydir/cydir-sync.h        |    1 -
src/lib-storage/index/cydir/cydir-transaction.c |    8 --------
src/lib-storage/index/dbox/dbox-transaction.c   |    8 --------

diffs (75 lines):

diff -r a62923d3c969 -r d98617723bc2 src/lib-storage/index/cydir/cydir-sync.c
--- a/src/lib-storage/index/cydir/cydir-sync.c	Sat Sep 22 13:44:37 2007 +0300
+++ b/src/lib-storage/index/cydir/cydir-sync.c	Sat Sep 22 13:45:14 2007 +0300
@@ -155,7 +155,7 @@ int cydir_sync_finish(struct cydir_sync_
 	return 0;
 }
 
-int cydir_sync(struct cydir_mailbox *mbox)
+static int cydir_sync(struct cydir_mailbox *mbox)
 {
 	struct cydir_sync_context *sync_ctx;
 
diff -r a62923d3c969 -r d98617723bc2 src/lib-storage/index/cydir/cydir-sync.h
--- a/src/lib-storage/index/cydir/cydir-sync.h	Sat Sep 22 13:44:37 2007 +0300
+++ b/src/lib-storage/index/cydir/cydir-sync.h	Sat Sep 22 13:45:14 2007 +0300
@@ -18,7 +18,6 @@ int cydir_sync_begin(struct cydir_mailbo
 int cydir_sync_begin(struct cydir_mailbox *mbox,
 		     struct cydir_sync_context **ctx_r);
 int cydir_sync_finish(struct cydir_sync_context **ctx, bool success);
-int cydir_sync(struct cydir_mailbox *mbox);
 
 struct mailbox_sync_context *
 cydir_storage_sync_init(struct mailbox *box, enum mailbox_sync_flags flags);
diff -r a62923d3c969 -r d98617723bc2 src/lib-storage/index/cydir/cydir-transaction.c
--- a/src/lib-storage/index/cydir/cydir-transaction.c	Sat Sep 22 13:44:37 2007 +0300
+++ b/src/lib-storage/index/cydir/cydir-transaction.c	Sat Sep 22 13:45:14 2007 +0300
@@ -13,9 +13,7 @@ static int cydir_transaction_commit(stru
 				    uoff_t *log_file_offset_r)
 {
 	struct cydir_transaction_context *dt = MAIL_STORAGE_CONTEXT(t);
-	struct cydir_mailbox *mbox = (struct cydir_mailbox *)dt->ictx.ibox;
 	struct cydir_save_context *save_ctx;
-	bool syncing = t->sync_transaction;
 	int ret = 0;
 
 	if (dt->save_ctx != NULL) {
@@ -43,12 +41,6 @@ static int cydir_transaction_commit(stru
 		   to make sure we don't write uids in wrong order. */
 		cydir_transaction_save_commit_post(save_ctx);
 	}
-
-	if (ret == 0 && !syncing) {
-		if (cydir_sync(mbox) < 0)
-			ret = -1;
-	}
-
 	return ret;
 }
 
diff -r a62923d3c969 -r d98617723bc2 src/lib-storage/index/dbox/dbox-transaction.c
--- a/src/lib-storage/index/dbox/dbox-transaction.c	Sat Sep 22 13:44:37 2007 +0300
+++ b/src/lib-storage/index/dbox/dbox-transaction.c	Sat Sep 22 13:45:14 2007 +0300
@@ -13,9 +13,7 @@ static int dbox_transaction_commit(struc
 				   uoff_t *log_file_offset_r)
 {
 	struct dbox_transaction_context *dt = MAIL_STORAGE_CONTEXT(t);
-	struct dbox_mailbox *mbox = (struct dbox_mailbox *)dt->ictx.ibox;
 	struct dbox_save_context *save_ctx;
-	bool syncing = t->sync_transaction;
 	int ret = 0;
 
 	if (dt->save_ctx != NULL) {
@@ -43,12 +41,6 @@ static int dbox_transaction_commit(struc
 		   to make sure we don't write uids in wrong order. */
 		dbox_transaction_save_commit_post(save_ctx);
 	}
-
-	if (ret == 0 && !syncing) {
-		if (dbox_sync(mbox, FALSE) < 0)
-			ret = -1;
-	}
-
 	return ret;
 }