dovecot-1.0: Don't try to preserve requests across reconnections...

dovecot at dovecot.org dovecot at dovecot.org
Sat Dec 29 04:20:17 EET 2007


details:   http://hg.dovecot.org/dovecot-1.0/rev/1a87f8495e07
changeset: 5501:1a87f8495e07
user:      Timo Sirainen <tss at iki.fi>
date:      Sat Dec 29 04:20:13 2007 +0200
description:
Don't try to preserve requests across reconnections. The retrying code is
somewhat broken, at least with auth binds.

diffstat:

1 file changed, 3 insertions(+), 1 deletion(-)
src/auth/db-ldap.c |    4 +++-

diffs (14 lines):

diff -r 500a21b449e9 -r 1a87f8495e07 src/auth/db-ldap.c
--- a/src/auth/db-ldap.c	Fri Dec 28 20:04:44 2007 +0200
+++ b/src/auth/db-ldap.c	Sat Dec 29 04:20:13 2007 +0200
@@ -180,7 +180,9 @@ static void db_ldap_handle_next_delayed_
 
 static void ldap_conn_reconnect(struct ldap_connection *conn)
 {
-	ldap_conn_close(conn, FALSE);
+	/* FIXME: we don't really want to flush requests here, but the queue
+	   code is buggy. v1.1 tree fixed this by rewriting the queue code. */
+	ldap_conn_close(conn, TRUE);
 
 	if (db_ldap_connect(conn) < 0) {
 		/* failed to reconnect. fail all requests. */


More information about the dovecot-cvs mailing list