dovecot: Use dotlock_use_excl=yes by default.

dovecot at dovecot.org dovecot at dovecot.org
Sun Dec 2 16:22:47 EET 2007


details:   http://hg.dovecot.org/dovecot/rev/139bd6094de6
changeset: 6896:139bd6094de6
user:      Timo Sirainen <tss at iki.fi>
date:      Sun Dec 02 16:22:44 2007 +0200
description:
Use dotlock_use_excl=yes by default.

diffstat:

2 files changed, 4 insertions(+), 5 deletions(-)
dovecot-example.conf         |    7 +++----
src/master/master-settings.c |    2 +-

diffs (29 lines):

diff -r bfdbc073598e -r 139bd6094de6 dovecot-example.conf
--- a/dovecot-example.conf	Sun Dec 02 15:49:05 2007 +0200
+++ b/dovecot-example.conf	Sun Dec 02 16:22:44 2007 +0200
@@ -300,10 +300,9 @@
 # filesystems (NFS or clustered filesystem).
 #mmap_disable = no
 
-# Rely on O_EXCL to work when creating dotlock files. The default is to use
-# hard linking. O_EXCL makes the dotlocking faster, but it doesn't always
-# work with NFS.
-#dotlock_use_excl = no
+# Rely on O_EXCL to work when creating dotlock files. NFS supports O_EXCL
+# since version 3, so this should be safe to use nowadays by default.
+#dotlock_use_excl = yes
 
 # Don't use fsync() or fdatasync() calls. This makes the performance better
 # at the cost of potential data loss if the server (or the file server)
diff -r bfdbc073598e -r 139bd6094de6 src/master/master-settings.c
--- a/src/master/master-settings.c	Sun Dec 02 15:49:05 2007 +0200
+++ b/src/master/master-settings.c	Sun Dec 02 16:22:44 2007 +0200
@@ -242,7 +242,7 @@ struct settings default_settings = {
 #else
 	MEMBER(mmap_disable) FALSE,
 #endif
-	MEMBER(dotlock_use_excl) FALSE,
+	MEMBER(dotlock_use_excl) TRUE,
 	MEMBER(fsync_disable) FALSE,
 	MEMBER(mail_nfs_storage) FALSE,
 	MEMBER(mail_nfs_index) FALSE,


More information about the dovecot-cvs mailing list