[dovecot-cvs] dovecot/src/lib-storage/index/maildir maildir-save.c, 1.73, 1.74

[cras at dovecot.org]

Update of /var/lib/cvs/dovecot/src/lib-storage/index/maildir
In directory talvi:/tmp/cvs-serv253

Modified Files:
	maildir-save.c 
Log Message:
Messages' received time wasn't saved properly when saving/copying multiple  
messages at a time. Also if using quota plugin the S= size was only set for 
the first saved file, and even that was wrong.



Index: maildir-save.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/lib-storage/index/maildir/maildir-save.c,v
retrieving revision 1.73
retrieving revision 1.74
diff -u -d -r1.73 -r1.74
--- maildir-save.c	28 Jun 2006 13:10:51 -0000	1.73
+++ maildir-save.c	1 Jul 2006 18:33:04 -0000	1.74
@@ -41,7 +41,7 @@
 	struct mail *mail, *cur_dest_mail;
 
 	const char *tmpdir, *newdir, *curdir;
-	struct maildir_filename *files, **files_tail;
+	struct maildir_filename *files, **files_tail, *file_last;
 
 	buffer_t *keywords_buffer;
 	ARRAY_TYPE(keyword_indexes) keywords_array;
@@ -152,8 +152,8 @@
 	mf->flags = flags;
 	mf->size = (uoff_t)-1;
 
-	if (*ctx->files_tail != NULL)
-		(*ctx->files_tail)->next = mf;
+	ctx->file_last = mf;
+	i_assert(*ctx->files_tail == NULL);
 	*ctx->files_tail = mf;
 	ctx->files_tail = &mf->next;
 
@@ -348,7 +348,7 @@
 		mail_storage_set_critical(STORAGE(ctx->mbox->storage),
 			"o_stream_send_istream(%s) failed: %m",
 			t_strconcat(ctx->tmpdir, "/",
-				    ctx->files->basename, NULL));
+				    ctx->file_last->basename, NULL));
 		ctx->failed = TRUE;
 		return -1;
 	}
@@ -375,10 +375,10 @@
 	}
 
 	/* remember the size in case we want to add it to filename */
-	ctx->files->size = ctx->output->offset;
+	ctx->file_last->size = ctx->output->offset;
 
 	t_push();
-	path = t_strconcat(ctx->tmpdir, "/", ctx->files->basename, NULL);
+	path = t_strconcat(ctx->tmpdir, "/", ctx->file_last->basename, NULL);
 
 	if (ctx->received_date != (time_t)-1) {
 		/* set the received_date by modifying mtime */
@@ -410,6 +410,8 @@
 	ctx->fd = -1;
 
 	if (ctx->failed) {
+		struct maildir_filename **fm;
+
 		/* delete the tmp file */
 		if (unlink(path) < 0 && errno != ENOENT) {
 			mail_storage_set_critical(STORAGE(ctx->mbox->storage),
@@ -425,12 +427,19 @@
 				"write(%s) failed: %m", ctx->mbox->path);
 		}
 
-		ctx->files = ctx->files->next;
+		/* remove from the linked list */
+		for (fm = &ctx->files; (*fm)->next != NULL; fm = &(*fm)->next) ;
+		i_assert(*fm == ctx->file_last);
+		*fm = NULL;
+		ctx->files_tail = fm;
+		ctx->file_last = NULL;
+
 		t_pop();
 		return -1;
 	}
 	t_pop();
 
+	ctx->file_last = NULL;
 	return 0;
 }