[dovecot-cvs] dovecot/src/lib-charset charset-iconv.c,1.14,1.15 charset-utf8.c,1.9,1.10

cras at procontrol.fi cras at procontrol.fi
Thu May 15 23:22:24 EEST 2003


Update of /home/cvs/dovecot/src/lib-charset
In directory danu:/tmp/cvs-serv28191/lib-charset

Modified Files:
	charset-iconv.c charset-utf8.c 
Log Message:
Renamed buffer_*_space() to buffer_*_space_unsafe() and added several
warnings about using them. Fixed their usage in a few places in sources
where they could have produced invalid results (no buffer overflows,
luckily).



Index: charset-iconv.c
===================================================================
RCS file: /home/cvs/dovecot/src/lib-charset/charset-iconv.c,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -d -r1.14 -r1.15
--- charset-iconv.c	17 Mar 2003 04:36:47 -0000	1.14
+++ charset-iconv.c	15 May 2003 19:22:22 -0000	1.15
@@ -85,7 +85,7 @@
 	size = destleft;
 	srcleft = *src_size;
 	ic_srcbuf = (ICONV_CONST char *) src;
-	ic_destbuf = buffer_append_space(dest, destleft);
+	ic_destbuf = buffer_append_space_unsafe(dest, destleft);
 
 	if (iconv(t->cd, &ic_srcbuf, &srcleft,
 		  &ic_destbuf, &destleft) != (size_t)-1)

Index: charset-utf8.c
===================================================================
RCS file: /home/cvs/dovecot/src/lib-charset/charset-utf8.c,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -d -r1.9 -r1.10
--- charset-utf8.c	17 Mar 2003 04:36:47 -0000	1.9
+++ charset-utf8.c	15 May 2003 19:22:22 -0000	1.10
@@ -12,7 +12,7 @@
 	char *destbuf;
 	size_t i;
 
-	destbuf = buffer_get_space(dest, destpos, src_size);
+	destbuf = buffer_get_space_unsafe(dest, destpos, src_size);
 	for (i = 0; i < src_size; i++)
 		destbuf[i] = i_toupper(src[i]); /* FIXME: utf8 */
 }



More information about the dovecot-cvs mailing list