[Dovecot] v. minor bug alpha4pre

[Andrew Hutchings]

On Mon, 2005-10-17 at 22:02 +0300, Tomi Hakala wrote:
> Andrew Hutchings wrote:
> > When upgrading to Alpha4pre I also changed UIDL format from %08Xv%08Xu
> > to %08Xu%08Xv to be in line with future dovecot default.  This caused
> > the following error to happen on about 1% of mailboxes:
> > 
> > file ostream-file.c: line 370 (stream_send_io): assertion failed:
> > (fstream->io != NULL)
> 
> I'm seeing this also, but with "pop3_uidl_format = %v.%u" so this
> is not UIDL format dependent. Just sent a backtrace from this to
> Timo.

You are right.  Undoing the following patch will probably temporary fix:

Update of /var/lib/cvs/dovecot/src/lib
In directory talvi:/tmp/cvs-serv12604

Modified Files:
	ostream-file.c 
Log Message:
Cleanup



Index: ostream-file.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/lib/ostream-file.c,v
retrieving revision 1.55
retrieving revision 1.56
diff -u -d -r1.55 -r1.56
--- ostream-file.c	15 Oct 2005 20:11:27 -0000	1.55
+++ ostream-file.c	15 Oct 2005 22:21:31 -0000	1.56
@@ -367,10 +367,7 @@
 			fstream->io = NULL;
 		}
 	} else {
-		if (fstream->io == NULL) {
-			fstream->io = io_add(fstream->fd, IO_WRITE,
-					     stream_send_io, fstream);
-		}
+		i_assert(fstream->io != NULL);
 	}
 
 	o_stream_unref(&fstream->ostream.ostream);

Regards
Andrew
--
Andrew Hutchings (A-Wing) - Linux Guru
Netserve Consultants - http://www.domaincity.co.uk/
Linux CDs and DVDs - http://www.linuxiso.co.uk/
Random quote 215: Windows isn't a virus, viruses do something" - Nowhere
Man