From noreply at github.com Wed Mar 1 08:00:11 2017 From: noreply at github.com (GitHub) Date: Wed, 01 Mar 2017 00:00:11 -0800 Subject: [dovecot/core] 7369ea: master: Don't crash if master socket couldn't be r... Message-ID: <58b67f8b75c54_302e3fe2d366bc3c1699f@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7369eabcd8d67bef57c2b5d72d37b7181a3ff4d7 https://github.com/dovecot/core/commit/7369eabcd8d67bef57c2b5d72d37b7181a3ff4d7 Author: Timo Sirainen Date: 2017-03-01 (Wed, 01 Mar 2017) Changed paths: M src/master/service-monitor.c Log Message: ----------- master: Don't crash if master socket couldn't be re-opened after settings reload. Commit: 9b7a4aa38539a9723586e150b13b14722f965f5e https://github.com/dovecot/core/commit/9b7a4aa38539a9723586e150b13b14722f965f5e Author: Timo Sirainen Date: 2017-03-01 (Wed, 01 Mar 2017) Changed paths: M src/master/service-listen.c Log Message: ----------- master: Add missing error logging for master socket listening failure. Commit: b39dd48436b5894d15ec0c632c8a65f936c2c487 https://github.com/dovecot/core/commit/b39dd48436b5894d15ec0c632c8a65f936c2c487 Author: Timo Sirainen Date: 2017-03-01 (Wed, 01 Mar 2017) Changed paths: M src/master/service-listen.c Log Message: ----------- master: Try to listen on master socket even if all services couldn't be listened to. This could happen during a settings reload. Compare: https://github.com/dovecot/core/compare/71cb0c74694b...b39dd48436b5 From noreply at github.com Wed Mar 1 10:30:10 2017 From: noreply at github.com (GitHub) Date: Wed, 01 Mar 2017 02:30:10 -0800 Subject: [dovecot/core] 326fb0: trash: Read settings after namespaces are loaded Message-ID: <58b6a2b2af52f_d7d93fb65cfddc3c347fc@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 326fb016a23480e4ff8dcc03dc80e76812859bd6 https://github.com/dovecot/core/commit/326fb016a23480e4ff8dcc03dc80e76812859bd6 Author: Aki Tuomi Date: 2017-03-01 (Wed, 01 Mar 2017) Changed paths: M src/plugins/trash/trash-plugin.c Log Message: ----------- trash: Read settings after namespaces are loaded Fixes Panic: file mail-namespace.c: line 709 (mail_namespace_find): assertion failed: (ns != NULL) From noreply at github.com Wed Mar 1 11:30:11 2017 From: noreply at github.com (GitHub) Date: Wed, 01 Mar 2017 03:30:11 -0800 Subject: [dovecot/core] 3751b6: fts: Don't add NULL content disposition or type to... Message-ID: <58b6b0c324d5a_50593fe4a75dfc341066f7@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 3751b61dfbc6c141731a740d982fc59918db2482 https://github.com/dovecot/core/commit/3751b61dfbc6c141731a740d982fc59918db2482 Author: Martti Rannanj?rvi Date: 2017-03-01 (Wed, 01 Mar 2017) Changed paths: M src/plugins/fts/fts-parser-tika.c Log Message: ----------- fts: Don't add NULL content disposition or type to HTTP header From noreply at github.com Wed Mar 1 11:30:15 2017 From: noreply at github.com (GitHub) Date: Wed, 01 Mar 2017 03:30:15 -0800 Subject: [dovecot/core] 081097: fts: Don't add NULL content disposition or type to... Message-ID: <58b6b0c7a5032_e1423fd095cf9c34185f@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 081097d8949b1b8bb9e8a065a127f82a7cdd36ea https://github.com/dovecot/core/commit/081097d8949b1b8bb9e8a065a127f82a7cdd36ea Author: Martti Rannanj?rvi Date: 2017-03-01 (Wed, 01 Mar 2017) Changed paths: M src/plugins/fts/fts-parser-tika.c Log Message: ----------- fts: Don't add NULL content disposition or type to HTTP header Commit: 0217804ec8d3962845ea4dc4c0cf36d3947a37d6 https://github.com/dovecot/core/commit/0217804ec8d3962845ea4dc4c0cf36d3947a37d6 Author: Timo Sirainen Date: 2017-03-01 (Wed, 01 Mar 2017) Changed paths: M src/lib/strfuncs.h Log Message: ----------- lib: Added i_strchr_to_next() Compare: https://github.com/dovecot/core/compare/de93e9557850...0217804ec8d3 From noreply at github.com Wed Mar 1 12:00:12 2017 From: noreply at github.com (GitHub) Date: Wed, 01 Mar 2017 04:00:12 -0800 Subject: [dovecot/core] e0f82a: imap-hibernate: Avoid using casts Message-ID: <58b6b7cc42399_308f3fa9ce59fc38716e0@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e0f82a1aa965de22af825ea68548a5a5f48fa3f9 https://github.com/dovecot/core/commit/e0f82a1aa965de22af825ea68548a5a5f48fa3f9 Author: Timo Sirainen Date: 2017-03-01 (Wed, 01 Mar 2017) Changed paths: M src/imap-hibernate/imap-client.c Log Message: ----------- imap-hibernate: Avoid using casts From noreply at github.com Thu Mar 2 08:30:11 2017 From: noreply at github.com (GitHub) Date: Thu, 02 Mar 2017 00:30:11 -0800 Subject: [dovecot/core] 8f251d: lib-ssl-iostream: Ensure verify_remote_cert is tru... Message-ID: <58b7d8132338c_28a23f96e7335c30102532@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8f251da1b6dfe6dc3d86ae71b377d99afe2d4bd2 https://github.com/dovecot/core/commit/8f251da1b6dfe6dc3d86ae71b377d99afe2d4bd2 Author: Aki Tuomi Date: 2017-03-02 (Thu, 02 Mar 2017) Changed paths: M src/lib-ssl-iostream/iostream-ssl.c Log Message: ----------- lib-ssl-iostream: Ensure verify_remote_cert is true Forgotten in 38424b8081a75be3ef93729fed4d30dbafca5885 From noreply at github.com Fri Mar 3 07:00:12 2017 From: noreply at github.com (GitHub) Date: Thu, 02 Mar 2017 23:00:12 -0800 Subject: [dovecot/core] 2dc6c0: example-config: Update deliver_log_format comment Message-ID: <58b9147c4727d_12413fd3c54a1c3420198@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2dc6c073d4f0f4012b7a5a6cf800a07caaa2e9dd https://github.com/dovecot/core/commit/2dc6c073d4f0f4012b7a5a6cf800a07caaa2e9dd Author: Timo Sirainen Date: 2017-03-02 (Thu, 02 Mar 2017) Changed paths: M doc/example-config/conf.d/10-logging.conf Log Message: ----------- example-config: Update deliver_log_format comment From noreply at github.com Fri Mar 3 07:30:10 2017 From: noreply at github.com (GitHub) Date: Thu, 02 Mar 2017 23:30:10 -0800 Subject: [dovecot/core] 2461ec: lib-oauth2: Add missing content-type header Message-ID: <58b91b82bd626_18933fbcbed89c34430b6@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2461ec3b9c9784099376b53ae064abcbcda6410a https://github.com/dovecot/core/commit/2461ec3b9c9784099376b53ae064abcbcda6410a Author: Aki Tuomi Date: 2017-03-03 (Fri, 03 Mar 2017) Changed paths: M src/lib-oauth2/oauth2-introspect.c Log Message: ----------- lib-oauth2: Add missing content-type header From noreply at github.com Fri Mar 3 09:30:13 2017 From: noreply at github.com (GitHub) Date: Fri, 03 Mar 2017 01:30:13 -0800 Subject: [dovecot/core] 665a20: lib-oauth2: Add missing content-type header Message-ID: <58b937a5376c_3cf93fe559dbbc342744e@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 665a2083e3b53f38398cccf173d197e22a405d99 https://github.com/dovecot/core/commit/665a2083e3b53f38398cccf173d197e22a405d99 Author: Aki Tuomi Date: 2017-03-03 (Fri, 03 Mar 2017) Changed paths: M src/lib-oauth2/oauth2-introspect.c Log Message: ----------- lib-oauth2: Add missing content-type header From noreply at github.com Sat Mar 4 09:00:09 2017 From: noreply at github.com (GitHub) Date: Sat, 04 Mar 2017 01:00:09 -0800 Subject: [dovecot/core] 8ac67b: lib-lda: smtp-client: Make sure only the first err... Message-ID: <58ba8219e395e_f0be3fa402479c2c12459a@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8ac67bc3b77575484aa7c9f4eebcb5ee06589382 https://github.com/dovecot/core/commit/8ac67bc3b77575484aa7c9f4eebcb5ee06589382 Author: Stephan Bosch Date: 2017-03-04 (Sat, 04 Mar 2017) Changed paths: M src/lib-lda/smtp-client.c Log Message: ----------- lib-lda: smtp-client: Make sure only the first error determines the tempfail status. The client is supposed to stop running the moment the first error occurs. However, there is a (very unlikely) possiblity that the encapsulated LMTP client issues both an RCPT and DATA error callback in sequence. In that case, the second callback should not override the tempfail status of the first (the second likely is a tempfail). If the server disconnects right after failing the last of at least two recipients, the lmtp-client would issue a DATA callback with a disconnection error. The disconnect error would set the client->tempfail flag, which caused smtp_client_deinit*() to always return -1 in this scenario. Commit: e422d45a7853cb4ae08020df1526b00ba8e6119c https://github.com/dovecot/core/commit/e422d45a7853cb4ae08020df1526b00ba8e6119c Author: Stephan Bosch Date: 2017-03-04 (Sat, 04 Mar 2017) Changed paths: M src/lib-smtp/lmtp-client.c Log Message: ----------- lib-smtp: lmtp-client: Fixed bug in timeout handling. The timeout was erroneously stopped when lmtp_client_send() was invoked before a connection was established. Once the connection finally got established, the timeout was removed. This would cause the client to wait indefinitely. Commit: 17e89642b6815b5a3e3256d21dff9b9825ec58a6 https://github.com/dovecot/core/commit/17e89642b6815b5a3e3256d21dff9b9825ec58a6 Author: Stephan Bosch Date: 2017-03-04 (Sat, 04 Mar 2017) Changed paths: M src/lib-lda/smtp-client.c Log Message: ----------- lib-lda: smtp-client: Fixed cleanup of LMTP client at end of transaction. It was not deinitialized, causing a memory leak. Commit: cb12dd3a1da1fac17484e36963554f538bcd3683 https://github.com/dovecot/core/commit/cb12dd3a1da1fac17484e36963554f538bcd3683 Author: Stephan Bosch Date: 2017-03-04 (Sat, 04 Mar 2017) Changed paths: M src/lib-lda/smtp-client.c Log Message: ----------- lib-lda: smtp-client: Fixed memory leak of the error message string. Compare: https://github.com/dovecot/core/compare/2461ec3b9c97...cb12dd3a1da1 From noreply at github.com Sun Mar 5 21:30:09 2017 From: noreply at github.com (GitHub) Date: Sun, 05 Mar 2017 13:30:09 -0800 Subject: [dovecot/core] 29e074: lib-http: test-http-server-errors: Fixed logically... Message-ID: <58bc83614f7c4_40b53fac0db07c34991f8@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 29e074eeea9975be7cca658651ea5184de184fcc https://github.com/dovecot/core/commit/29e074eeea9975be7cca658651ea5184de184fcc Author: Stephan Bosch Date: 2017-03-05 (Sun, 05 Mar 2017) Changed paths: M src/lib-http/test-http-server-errors.c Log Message: ----------- lib-http: test-http-server-errors: Fixed logically dead code. Problem reported by Coverity. From noreply at github.com Mon Mar 6 12:00:10 2017 From: noreply at github.com (GitHub) Date: Mon, 06 Mar 2017 04:00:10 -0800 Subject: [dovecot/core] 9fedd3: auth: Apply skips to first passdb Message-ID: <58bd4f4a94656_e8b83f9ba5ecbc30733f8@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9fedd371d33808d0b62c8f3c6dae007046b66b67 https://github.com/dovecot/core/commit/9fedd371d33808d0b62c8f3c6dae007046b66b67 Author: Aki Tuomi Date: 2017-03-06 (Mon, 06 Mar 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Apply skips to first passdb This is required to apply filters to first passdb, so that mechanism filters can be applied. From noreply at github.com Mon Mar 6 12:00:15 2017 From: noreply at github.com (GitHub) Date: Mon, 06 Mar 2017 04:00:15 -0800 Subject: [dovecot/core] 3f9770: auth: Apply skips to first passdb Message-ID: <58bd4f4f3ff03_430d3ff67e299c30136436@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 3f97702b106bd11a885e7a42507d0ce4fd47c6af https://github.com/dovecot/core/commit/3f97702b106bd11a885e7a42507d0ce4fd47c6af Author: Aki Tuomi Date: 2017-03-06 (Mon, 06 Mar 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Apply skips to first passdb This is required to apply filters to first passdb, so that mechanism filters can be applied. From noreply at github.com Tue Mar 7 10:30:10 2017 From: noreply at github.com (GitHub) Date: Tue, 07 Mar 2017 02:30:10 -0800 Subject: [dovecot/core] 477629: lib-oauth2: Use http client destroy callback Message-ID: <58be8bb2c6e46_e2b43fba2fdcfc348813@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 477629dd338056c9f8bfe088e2da3e65d9a8d319 https://github.com/dovecot/core/commit/477629dd338056c9f8bfe088e2da3e65d9a8d319 Author: Aki Tuomi Date: 2017-03-07 (Tue, 07 Mar 2017) Changed paths: M src/lib-oauth2/oauth2-introspect.c M src/lib-oauth2/oauth2-refresh.c M src/lib-oauth2/oauth2-token-validate.c Log Message: ----------- lib-oauth2: Use http client destroy callback Avoids freeing memory early. Fixes signal 11 crash in auth Commit: 3871fbbab95e41424a29d6f1cbfedc198b00079d https://github.com/dovecot/core/commit/3871fbbab95e41424a29d6f1cbfedc198b00079d Author: Aki Tuomi Date: 2017-03-07 (Tue, 07 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- db-oauth2: Make sure request is removed only once Callback might be called twice. Compare: https://github.com/dovecot/core/compare/9fedd371d338...3871fbbab95e From noreply at github.com Tue Mar 7 17:00:10 2017 From: noreply at github.com (GitHub) Date: Tue, 07 Mar 2017 09:00:10 -0800 Subject: [dovecot/core] b1808d: lib-sasl: Fix xoauth2 data format Message-ID: <58bee71a856cf_726b3fb26c5e3c348578a@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b1808dcac22fa2c75d5666cc98c9ab59f030a798 https://github.com/dovecot/core/commit/b1808dcac22fa2c75d5666cc98c9ab59f030a798 Author: Aki Tuomi Date: 2017-03-07 (Tue, 07 Mar 2017) Changed paths: M src/lib-sasl/mech-oauthbearer.c Log Message: ----------- lib-sasl: Fix xoauth2 data format Authentication data was missing user= From noreply at github.com Wed Mar 8 17:30:10 2017 From: noreply at github.com (GitHub) Date: Wed, 08 Mar 2017 09:30:10 -0800 Subject: [dovecot/core] 42886b: imap: When disconnecting due to FETCH failure, inc... Message-ID: <58c03fa2c1e6b_f01e3f9f0e279c40144286@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 42886bc89208a0a61f20ee5d0b42fe6358122130 https://github.com/dovecot/core/commit/42886bc89208a0a61f20ee5d0b42fe6358122130 Author: Timo Sirainen Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/imap/cmd-fetch.c Log Message: ----------- imap: When disconnecting due to FETCH failure, include "FETCH" in the log message. Commit: 7f2cb2e5b258280af90ae99b6d07dfa44109e5be https://github.com/dovecot/core/commit/7f2cb2e5b258280af90ae99b6d07dfa44109e5be Author: Timo Sirainen Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/imap/imap-state.c Log Message: ----------- imap: If unhibernation fails due to a mailbox error, log the mailbox name. Commit: 3e961b1decd1089d0ae0de8e0dd8d93eb2d909ab https://github.com/dovecot/core/commit/3e961b1decd1089d0ae0de8e0dd8d93eb2d909ab Author: Timo Sirainen Date: 2017-03-08 (Wed, 08 Mar 2017) Changed paths: M src/pop3/pop3-client.c Log Message: ----------- pop3: Set process title before syncing mailbox. The syncing could be taking a long time, so it's useful to have the username in the process title during that. Compare: https://github.com/dovecot/core/compare/b1808dcac22f...3e961b1decd1 From noreply at github.com Sat Mar 11 17:30:10 2017 From: noreply at github.com (GitHub) Date: Sat, 11 Mar 2017 09:30:10 -0800 Subject: [dovecot/core] 2b9688: *-login: Add client.proxy_get_state() for providin... Message-ID: <58c43422a0f54_e3e93f9bd879dc3c204245@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2b96880f2d789d125aff6a95eaa7b51f558a6a1c https://github.com/dovecot/core/commit/2b96880f2d789d125aff6a95eaa7b51f558a6a1c Author: Timo Sirainen Date: 2017-03-09 (Thu, 09 Mar 2017) Changed paths: M src/imap-urlauth/imap-urlauth-login.c M src/login-common/client-common-auth.c M src/login-common/client-common.c M src/login-common/client-common.h M src/login-common/login-proxy.c M src/pop3-login/client.c Log Message: ----------- *-login: Add client.proxy_get_state() for providing human-readable proxy state If not implemented, it defaults to the old method of returning proxy_state number. Commit: b4bf60434dcfc23433fc09e1899bba4a8b20022e https://github.com/dovecot/core/commit/b4bf60434dcfc23433fc09e1899bba4a8b20022e Author: Timo Sirainen Date: 2017-03-09 (Thu, 09 Mar 2017) Changed paths: M src/imap-login/imap-login-client.c M src/imap-login/imap-login-client.h M src/imap-login/imap-proxy.c M src/imap-login/imap-proxy.h Log Message: ----------- imap-login: Log proxy state as human-readable string. Separate sent/received state and log them as strings. Commit: d77f679dac93f2416d6b04299b1a8154941036dd https://github.com/dovecot/core/commit/d77f679dac93f2416d6b04299b1a8154941036dd Author: Timo Sirainen Date: 2017-03-09 (Thu, 09 Mar 2017) Changed paths: M src/pop3-login/client.c M src/pop3-login/client.h M src/pop3-login/pop3-proxy.c M src/pop3-login/pop3-proxy.h Log Message: ----------- pop3-login: Log proxy state as human-readable string. Commit: 339726ad7f9f8b787ced3cd12042d0c29938de3d https://github.com/dovecot/core/commit/339726ad7f9f8b787ced3cd12042d0c29938de3d Author: Timo Sirainen Date: 2017-03-09 (Thu, 09 Mar 2017) Changed paths: M src/pop3-login/client.h M src/pop3-login/pop3-proxy.c Log Message: ----------- pop3-login: Remove usage of client.common.proxy_state Commit: a8d3f2d03d260b55064d3be868bc06b025d6c9d3 https://github.com/dovecot/core/commit/a8d3f2d03d260b55064d3be868bc06b025d6c9d3 Author: Timo Sirainen Date: 2017-03-09 (Thu, 09 Mar 2017) Changed paths: M src/login-common/client-common-auth.c M src/login-common/client-common.h Log Message: ----------- *-login: Remove unused client.proxy_state Compare: https://github.com/dovecot/core/compare/3e961b1decd1...a8d3f2d03d26 From noreply at github.com Sun Mar 12 18:30:10 2017 From: noreply at github.com (GitHub) Date: Sun, 12 Mar 2017 11:30:10 -0700 Subject: [dovecot/core] 000030: auth: Do not double-expand key in passdb dict when... Message-ID: <58c593b2e2955_3bdf3fcf0a6fdc4013953b@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 000030feb7a30f193197f1aab8a7b04a26b42735 https://github.com/dovecot/core/commit/000030feb7a30f193197f1aab8a7b04a26b42735 Author: Aki Tuomi Date: 2017-03-12 (Sun, 12 Mar 2017) Changed paths: M src/auth/db-dict.c Log Message: ----------- auth: Do not double-expand key in passdb dict when authenticating Broken by 79042f8c From noreply at github.com Wed Mar 15 13:21:31 2017 From: noreply at github.com (GitHub) Date: Wed, 15 Mar 2017 06:21:31 -0700 Subject: [dovecot/pigeonhole] 362f0a: doveadm-sieve: Fix crash when setting Sieve script... Message-ID: <58c93fdb4a954_8683fb4b4d6fc382826c8@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: 362f0a45e9b30bad4b601fd0ecbd3a141888719d https://github.com/dovecot/pigeonhole/commit/362f0a45e9b30bad4b601fd0ecbd3a141888719d Author: Timo Sirainen Date: 2017-02-19 (Sun, 19 Feb 2017) Changed paths: M src/plugins/doveadm-sieve/doveadm-sieve-sync.c Log Message: ----------- doveadm-sieve: Fix crash when setting Sieve script via attribute's string value. Commit: 91ab251fd5563d8d87cb6435d71e9568232f933a https://github.com/dovecot/pigeonhole/commit/91ab251fd5563d8d87cb6435d71e9568232f933a Author: Stephan Bosch Date: 2017-02-20 (Mon, 20 Feb 2017) Changed paths: M NEWS Log Message: ----------- Added v0.4.16 to NEWS. Commit: e64d3e2465dccbc114122e6f1f2496982d9fdc09 https://github.com/dovecot/pigeonhole/commit/e64d3e2465dccbc114122e6f1f2496982d9fdc09 Author: Stephan Bosch Date: 2017-02-28 (Tue, 28 Feb 2017) Changed paths: M src/lib-sieve/sieve-smtp.c M src/lib-sieve/sieve-smtp.h M src/lib-sieve/sieve-types.h M src/plugins/imapsieve/imap-sieve.c M src/plugins/lda-sieve/lda-sieve-plugin.c M src/sieve-tools/sieve-test.c M src/testsuite/testsuite-smtp.c M src/testsuite/testsuite-smtp.h M src/testsuite/testsuite.c Log Message: ----------- lib-sieve: Implemented means to abort SMTP message submission after it is started. This adds a new callback to the Sieve script execution environment. Commit: fe4cc662a80ed447ca25106dc04e6b63eb0686ae https://github.com/dovecot/pigeonhole/commit/fe4cc662a80ed447ca25106dc04e6b63eb0686ae Author: Stephan Bosch Date: 2017-02-28 (Tue, 28 Feb 2017) Changed paths: M src/lib-sieve/cmd-redirect.c M src/lib-sieve/sieve-actions.c M src/lib-sieve/sieve-actions.h Log Message: ----------- lib-sieve: Made public function for adding a redirect action to the result. Commit: 2888ba02085e72e348c62d08ca52fab692fff38f https://github.com/dovecot/pigeonhole/commit/2888ba02085e72e348c62d08ca52fab692fff38f Author: Stephan Bosch Date: 2017-02-28 (Tue, 28 Feb 2017) Changed paths: M src/managesieve/managesieve-client.c Log Message: ----------- managesieve: Fix creation of critical error message timestamp. This used strftime() directly and allocated memory from the heap before i_fatal(). It also used printf() to send the BYE message, which will only work right when the service is running stand-alone. Commit: 023f391ee66595e74481fdfc4fbb24a1479b4898 https://github.com/dovecot/pigeonhole/commit/023f391ee66595e74481fdfc4fbb24a1479b4898 Author: Stephan Bosch Date: 2017-02-28 (Tue, 28 Feb 2017) Changed paths: M src/lib-sieve/sieve-actions.c Log Message: ----------- lib-sieve: store action: Made static analyzer happier about tr_context argument for sieve_act_store_add_flags(). Added an assert ensuring it is not NULL. Compare: https://github.com/dovecot/pigeonhole/compare/0d78a3001773...023f391ee665 From noreply at github.com Thu Mar 16 07:00:11 2017 From: noreply at github.com (GitHub) Date: Thu, 16 Mar 2017 00:00:11 -0700 Subject: [dovecot/core] cbf6b2: auth: oauth2 - Fix aborting auth requests on deini... Message-ID: <58ca37fbd04bb_7c443fb990ad7c383824bb@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: cbf6b2a59538d86e0acc1b63c5923ab1be2d2100 https://github.com/dovecot/core/commit/cbf6b2a59538d86e0acc1b63c5923ab1be2d2100 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - Fix aborting auth requests on deinit. The auth_request needs to be finished by calling the callback. Commit: 8fd1d49dca142533bc3e30e443d857602081aa14 https://github.com/dovecot/core/commit/8fd1d49dca142533bc3e30e443d857602081aa14 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - Make sure db_oauth2_request.req is set to NULL when it gets freed. Doesn't fix anything, but makes it clearer that req->req must not be aborted anymore after this stage, because it gets freed anyway. Commit: 6bcf2e4195f000194f11a37433caa7890663bd22 https://github.com/dovecot/core/commit/6bcf2e4195f000194f11a37433caa7890663bd22 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - introspection lookup error should be internal failure Not the default, which is "password mismatch". Commit: 3d365d35f808bfe6096738d56d75cdb23bddd585 https://github.com/dovecot/core/commit/3d365d35f808bfe6096738d56d75cdb23bddd585 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c M src/auth/db-oauth2.h Log Message: ----------- auth: oauth2 - make db_oauth2_template_export() static It's not used outside db-oauth2.c Commit: 01484d200b661650021338c7516cef5449623db9 https://github.com/dovecot/core/commit/01484d200b661650021338c7516cef5449623db9 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - Template expand failure should be an internal error Not the default "password mismatch". Also changed the API to be closer to the other nearby functions. Commit: 5e48e30039369053adfc16b93bca0cc9a7ec9f1d https://github.com/dovecot/core/commit/5e48e30039369053adfc16b93bca0cc9a7ec9f1d Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c M src/auth/db-oauth2.h M src/auth/passdb-oauth2.c Log Message: ----------- auth: oauth2 - remove db_oauth2_request.result It's not a persistent state. When it's set, the callback needs to be called. This way it's more difficult to forget to set it. Commit: b928b757e77cf5d791fdf54b87e308b39e87071c https://github.com/dovecot/core/commit/b928b757e77cf5d791fdf54b87e308b39e87071c Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c M src/auth/db-oauth2.h M src/auth/passdb-oauth2.c Log Message: ----------- auth: oauth2 - remove db_oauth2_request.failed It is an unnecessary duplication of passdb_result. Commit: e252a81ca2dc3eb8d2af986229a3a40ff26c5ce8 https://github.com/dovecot/core/commit/e252a81ca2dc3eb8d2af986229a3a40ff26c5ce8 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - Clarify token validation success/valid error handling result->error is NULL only if result->success && !result->valid. Also !result->success is the more important error handling case. Write out these cases explicitly so it's easier to understand. Commit: 34cb91abb3ba217aa1220b967b61aabc00f7251c https://github.com/dovecot/core/commit/34cb91abb3ba217aa1220b967b61aabc00f7251c Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - make it easier to see where db_oauth2_callback() is called Doesn't fix anything, but places the db_oauth2_callback() calls into the end of _continue() calls so it's clearer that they're always being called exactly once. Commit: d88304d95978c1f92477f5c35f1821510ca607e6 https://github.com/dovecot/core/commit/d88304d95978c1f92477f5c35f1821510ca607e6 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c M src/auth/db-oauth2.h M src/auth/passdb-oauth2.c Log Message: ----------- auth: oauth2 - cleanup db_oauth2_lookup_callback_t db parameter isn't needed, because request->db already contains it. Also moved request parameter to be the first. Commit: 070caf28f190230fc211f22ba8fbd8e26aec06fd https://github.com/dovecot/core/commit/070caf28f190230fc211f22ba8fbd8e26aec06fd Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-oauth2/oauth2-introspect.c M src/lib-oauth2/oauth2-private.h M src/lib-oauth2/oauth2-refresh.c M src/lib-oauth2/oauth2-token-validate.c M src/lib-oauth2/oauth2.c Log Message: ----------- lib-oauth2: Fix memory leak if HTTP URL parsing fails. Also delay calling the callback. The callers don't necessarily expect an immediate callback (auth/db-oauth2.c doesn't). Commit: 878915649726a252d6e1679b28db8c3dd807af26 https://github.com/dovecot/core/commit/878915649726a252d6e1679b28db8c3dd807af26 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-oauth2/oauth2-introspect.c M src/lib-oauth2/oauth2-refresh.c M src/lib-oauth2/oauth2-token-validate.c Log Message: ----------- lib-oauth2: Don't free oauth2_request too early. Move the freeing explicitly to only after calling the callback. The previous method of freeing it on when http_request was destroyed could have happened too early when oauth2_parse_json() called i_stream_unref(), which released the last reference to the http_request. Commit: 0098ac3b6dcd8ef6ac20f87a8285da201db75a01 https://github.com/dovecot/core/commit/0098ac3b6dcd8ef6ac20f87a8285da201db75a01 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Treat CASS_ERROR_SERVER_UNAVAILABLE as "write success is uncertain" Looks like the write could still have actually gone through. Commit: c5e62353a11087958ea4e619660e084a613e1a37 https://github.com/dovecot/core/commit/c5e62353a11087958ea4e619660e084a613e1a37 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/login-common/client-common.c M src/login-common/client-common.h M src/login-common/main.c Log Message: ----------- *-login: Change API for how login_plugins hook into client allocation. The previous API worked badly when there were more than one plugin. The current behavior works similarly to how mail_plugins work. Commit: c12aed4d817acd9b72d12830e1fbf6df76062e7b https://github.com/dovecot/core/commit/c12aed4d817acd9b72d12830e1fbf6df76062e7b Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/auth-client-connection.c Log Message: ----------- auth: Properly hide all fields with passwords client reply line wasn't hiding all items which contain 'pass' substring. This was inconsistent behaviour since elsewhere this was done. Commit: e0a84bcd487b05872da59781452168609b5c1f2c https://github.com/dovecot/core/commit/e0a84bcd487b05872da59781452168609b5c1f2c Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/auth-worker-client.c Log Message: ----------- auth: passdb/userdb lookups via auth-worker cached too much of the replies Only the fields returned by the lookup itself were supposed to be cached. This was especially problematic if the lookup via auth-worker didn't uniquely identify the user. For example doing a passdb lookup for an attribute shared by multiple users could have caused the reply to contain the previous cached user's all extra fields. Commit: 865a82c1e9bba11609835a36674964649025bf77 https://github.com/dovecot/core/commit/865a82c1e9bba11609835a36674964649025bf77 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/auth-request.c M src/auth/auth-request.h M src/auth/auth-worker-client.c M src/auth/passdb-blocking.c M src/auth/userdb-blocking.c Log Message: ----------- auth: Auth workers shouldn't return username if it wasn't changed This continues the previous fix where username was always added to passdb/userdb cache, even if the username wasn't changed. That could have resulted in wrongly changing usernames if the cache key didn't uniquely identify the user. Compare: https://github.com/dovecot/core/compare/000030feb7a3...865a82c1e9bb From noreply at github.com Thu Mar 16 07:30:11 2017 From: noreply at github.com (GitHub) Date: Thu, 16 Mar 2017 00:30:11 -0700 Subject: [dovecot/core] 7c6347: pop3: Add client.destroyed boolean Message-ID: <58ca3f031b690_73fa3fee603ffc302337fa@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7c6347e851175dd64ec490999b8a1fa020927ed1 https://github.com/dovecot/core/commit/7c6347e851175dd64ec490999b8a1fa020927ed1 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/pop3/pop3-client.c M src/pop3/pop3-client.h Log Message: ----------- pop3: Add client.destroyed boolean Commit: 3c6a7ca2d3ed89dd999cc6885220097777090791 https://github.com/dovecot/core/commit/3c6a7ca2d3ed89dd999cc6885220097777090791 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/imap/imap-client.c M src/imap/main.c M src/indexer/master-connection.c M src/pop3/main.c M src/pop3/pop3-client.c Log Message: ----------- imap, pop3, indexer-worker: Add (deinit) to process title before autoexpunging runs. lmtp should also do this, but it needs a bit larger changes. Compare: https://github.com/dovecot/core/compare/865a82c1e9bb...3c6a7ca2d3ed From noreply at github.com Thu Mar 16 10:30:11 2017 From: noreply at github.com (GitHub) Date: Thu, 16 Mar 2017 03:30:11 -0700 Subject: [dovecot/core] 10ac33: lib-storage & imap: add MAIL_ERROR_UNAVAILABLE as ... Message-ID: <58ca69333c1b7_e4973fa11e945c242499bc@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 10ac3345fef3976ef573122de2a58a50c2fa63ce https://github.com/dovecot/core/commit/10ac3345fef3976ef573122de2a58a50c2fa63ce Author: Josef 'Jeff' Sipek Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/doveadm/doveadm-mail.c M src/imap/imap-commands-util.c M src/lib-storage/mail-error.h Log Message: ----------- lib-storage & imap: add MAIL_ERROR_UNAVAILABLE as [UNAVAILABLE] [UNAVAILABLE] is defined in RFC 5530 and we were just missing a MAIL_ERROR_* constant to make use of it. Commit: 3dffcebc7d1758a2d3db0ae1a8563b7e84c6e5bc https://github.com/dovecot/core/commit/3dffcebc7d1758a2d3db0ae1a8563b7e84c6e5bc Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-dcrypt/dcrypt-openssl.c Log Message: ----------- lib-dcrypt: Add asserts Fixes several static analysis reports Commit: bb0484f2d26a985e42688597e455cf49578ab2a1 https://github.com/dovecot/core/commit/bb0484f2d26a985e42688597e455cf49578ab2a1 Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/doveadm/doveadm-mail.c Log Message: ----------- doveadm: Do not crash doveadm-server if input file missing save commands expects valid input file for it to work, if we are not running for cli, and input file is not provided, provide EINVAL error to caller via i_stream_error. Compare: https://github.com/dovecot/core/compare/3c6a7ca2d3ed...bb0484f2d26a From noreply at github.com Thu Mar 16 13:30:10 2017 From: noreply at github.com (GitHub) Date: Thu, 16 Mar 2017 06:30:10 -0700 Subject: [dovecot/core] b0831e: lib-index: Minor fix to day_first_uid updating Message-ID: <58ca936278a77_24a13fc254eedc38215887@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b0831ed2daa5724a883926534825337903cf97dc https://github.com/dovecot/core/commit/b0831ed2daa5724a883926534825337903cf97dc Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-index/mail-index-transaction-update.c Log Message: ----------- lib-index: Minor fix to day_first_uid updating mktime() was getting a bit confused around day changes. Giving it only year/month/day makes it less confused. Commit: 95fe5a25ac87f2a56933117a80373cf38379c456 https://github.com/dovecot/core/commit/95fe5a25ac87f2a56933117a80373cf38379c456 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-index/test-mail-index-transaction-update.c Log Message: ----------- lib-index: Fix test-mail-index-transaction-update It was broken with TZ=Australia/ACT. Fixing it seems too troublesome, so just use TZ=UTC during the test. Compare: https://github.com/dovecot/core/compare/bb0484f2d26a...95fe5a25ac87 From noreply at github.com Thu Mar 16 17:55:49 2017 From: noreply at github.com (GitHub) Date: Thu, 16 Mar 2017 10:55:49 -0700 Subject: [dovecot/core] 1ad320: lib-oauth2: Use http client destroy callback Message-ID: <58cad1a511d4c_2e4e3ff31c42fc3073328@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 1ad3209862c49d0f2d95a67753a6757799c89397 https://github.com/dovecot/core/commit/1ad3209862c49d0f2d95a67753a6757799c89397 Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-oauth2/oauth2-introspect.c M src/lib-oauth2/oauth2-refresh.c M src/lib-oauth2/oauth2-token-validate.c Log Message: ----------- lib-oauth2: Use http client destroy callback Avoids freeing memory early. Fixes signal 11 crash in auth Commit: c9e9cfac848db4b67fdb711e61f4cfb4d1dfd266 https://github.com/dovecot/core/commit/c9e9cfac848db4b67fdb711e61f4cfb4d1dfd266 Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- db-oauth2: Make sure request is removed only once Callback might be called twice. Commit: 7979af45b5e4461f649232cdab6032069ea1bbb7 https://github.com/dovecot/core/commit/7979af45b5e4461f649232cdab6032069ea1bbb7 Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-sasl/mech-oauthbearer.c Log Message: ----------- lib-sasl: Fix xoauth2 data format Authentication data was missing user= Commit: 1a7641cce2ba2b601ede1e1eb46a82f46c5f1ab3 https://github.com/dovecot/core/commit/1a7641cce2ba2b601ede1e1eb46a82f46c5f1ab3 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/imap/cmd-fetch.c Log Message: ----------- imap: When disconnecting due to FETCH failure, include "FETCH" in the log message. Commit: 7d4b3c6acb10cbf0969f538c5c2a2d50dfdfb84a https://github.com/dovecot/core/commit/7d4b3c6acb10cbf0969f538c5c2a2d50dfdfb84a Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/imap/imap-state.c Log Message: ----------- imap: If unhibernation fails due to a mailbox error, log the mailbox name. Commit: be66ad91ed2cc14906e40400bdd912f93403ff57 https://github.com/dovecot/core/commit/be66ad91ed2cc14906e40400bdd912f93403ff57 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/pop3/pop3-client.c Log Message: ----------- pop3: Set process title before syncing mailbox. The syncing could be taking a long time, so it's useful to have the username in the process title during that. Commit: 043aa65325dd28931258a9c8b6ed4bffaba60ef0 https://github.com/dovecot/core/commit/043aa65325dd28931258a9c8b6ed4bffaba60ef0 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/imap-urlauth/imap-urlauth-login.c M src/login-common/client-common-auth.c M src/login-common/client-common.c M src/login-common/client-common.h M src/login-common/login-proxy.c M src/pop3-login/client.c Log Message: ----------- *-login: Add client.proxy_get_state() for providing human-readable proxy state If not implemented, it defaults to the old method of returning proxy_state number. Commit: e7d9dd003e6192b294507b9fbe9917a514e441f6 https://github.com/dovecot/core/commit/e7d9dd003e6192b294507b9fbe9917a514e441f6 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/imap-login/imap-login-client.c M src/imap-login/imap-login-client.h M src/imap-login/imap-proxy.c M src/imap-login/imap-proxy.h Log Message: ----------- imap-login: Log proxy state as human-readable string. Separate sent/received state and log them as strings. Commit: 7a690778e2d288338c66a2a7f70efa9a85578312 https://github.com/dovecot/core/commit/7a690778e2d288338c66a2a7f70efa9a85578312 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/pop3-login/client.c M src/pop3-login/client.h M src/pop3-login/pop3-proxy.c M src/pop3-login/pop3-proxy.h Log Message: ----------- pop3-login: Log proxy state as human-readable string. Commit: c386ebe04c47d60feab83a4b7bc17dfc984c0080 https://github.com/dovecot/core/commit/c386ebe04c47d60feab83a4b7bc17dfc984c0080 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/pop3-login/client.h M src/pop3-login/pop3-proxy.c Log Message: ----------- pop3-login: Remove usage of client.common.proxy_state Commit: 319959b042e6818be0410994a04851bb0d1c0b71 https://github.com/dovecot/core/commit/319959b042e6818be0410994a04851bb0d1c0b71 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/login-common/client-common-auth.c M src/login-common/client-common.h Log Message: ----------- *-login: Remove unused client.proxy_state Commit: 21d083ffb353b33f902a78f3f2781868fc457557 https://github.com/dovecot/core/commit/21d083ffb353b33f902a78f3f2781868fc457557 Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-dict.c Log Message: ----------- auth: Do not double-expand key in passdb dict when authenticating Broken by 79042f8c Commit: 68df507e448fe7d2c2bb885161a148b7caaf3e58 https://github.com/dovecot/core/commit/68df507e448fe7d2c2bb885161a148b7caaf3e58 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - Fix aborting auth requests on deinit. The auth_request needs to be finished by calling the callback. Commit: e2065b361594e72dd30e4f660bfcb077416f1927 https://github.com/dovecot/core/commit/e2065b361594e72dd30e4f660bfcb077416f1927 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - Make sure db_oauth2_request.req is set to NULL when it gets freed. Doesn't fix anything, but makes it clearer that req->req must not be aborted anymore after this stage, because it gets freed anyway. Commit: 98fce39003a460d332c106d7c50a6908f54a4593 https://github.com/dovecot/core/commit/98fce39003a460d332c106d7c50a6908f54a4593 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - introspection lookup error should be internal failure Not the default, which is "password mismatch". Commit: 3f1dde2d6dd324df0bbbcd3552a0d1d74b751523 https://github.com/dovecot/core/commit/3f1dde2d6dd324df0bbbcd3552a0d1d74b751523 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c M src/auth/db-oauth2.h Log Message: ----------- auth: oauth2 - make db_oauth2_template_export() static It's not used outside db-oauth2.c Commit: 693b6f93dbe4cf6d5daabe72f63e2fca4f1d4ec0 https://github.com/dovecot/core/commit/693b6f93dbe4cf6d5daabe72f63e2fca4f1d4ec0 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - Template expand failure should be an internal error Not the default "password mismatch". Also changed the API to be closer to the other nearby functions. Commit: 0aa06a246b503c25f12b729d8c01b564445616c6 https://github.com/dovecot/core/commit/0aa06a246b503c25f12b729d8c01b564445616c6 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c M src/auth/db-oauth2.h M src/auth/passdb-oauth2.c Log Message: ----------- auth: oauth2 - remove db_oauth2_request.result It's not a persistent state. When it's set, the callback needs to be called. This way it's more difficult to forget to set it. Commit: 91ae7a2a4060e70e285f1e6408efdd31edeb2e75 https://github.com/dovecot/core/commit/91ae7a2a4060e70e285f1e6408efdd31edeb2e75 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c M src/auth/db-oauth2.h M src/auth/passdb-oauth2.c Log Message: ----------- auth: oauth2 - remove db_oauth2_request.failed It is an unnecessary duplication of passdb_result. Commit: 92709fcc5f68084e7d7b3d12a86afc4e639c0885 https://github.com/dovecot/core/commit/92709fcc5f68084e7d7b3d12a86afc4e639c0885 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - Clarify token validation success/valid error handling result->error is NULL only if result->success && !result->valid. Also !result->success is the more important error handling case. Write out these cases explicitly so it's easier to understand. Commit: 2eea5e3f5bb6592d1a5007a476134b0869c0f764 https://github.com/dovecot/core/commit/2eea5e3f5bb6592d1a5007a476134b0869c0f764 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c Log Message: ----------- auth: oauth2 - make it easier to see where db_oauth2_callback() is called Doesn't fix anything, but places the db_oauth2_callback() calls into the end of _continue() calls so it's clearer that they're always being called exactly once. Commit: f72a75a57d11f9f691588e94bdaa84a2ef69fa13 https://github.com/dovecot/core/commit/f72a75a57d11f9f691588e94bdaa84a2ef69fa13 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/db-oauth2.c M src/auth/db-oauth2.h M src/auth/passdb-oauth2.c Log Message: ----------- auth: oauth2 - cleanup db_oauth2_lookup_callback_t db parameter isn't needed, because request->db already contains it. Also moved request parameter to be the first. Commit: 466217193ffb52300713b50ecca1fb345075b3f7 https://github.com/dovecot/core/commit/466217193ffb52300713b50ecca1fb345075b3f7 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-oauth2/oauth2-introspect.c M src/lib-oauth2/oauth2-private.h M src/lib-oauth2/oauth2-refresh.c M src/lib-oauth2/oauth2-token-validate.c M src/lib-oauth2/oauth2.c Log Message: ----------- lib-oauth2: Fix memory leak if HTTP URL parsing fails. Also delay calling the callback. The callers don't necessarily expect an immediate callback (auth/db-oauth2.c doesn't). Commit: 45598d313a58eeefe1079cc8317899257fd581f5 https://github.com/dovecot/core/commit/45598d313a58eeefe1079cc8317899257fd581f5 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-oauth2/oauth2-introspect.c M src/lib-oauth2/oauth2-refresh.c M src/lib-oauth2/oauth2-token-validate.c Log Message: ----------- lib-oauth2: Don't free oauth2_request too early. Move the freeing explicitly to only after calling the callback. The previous method of freeing it on when http_request was destroyed could have happened too early when oauth2_parse_json() called i_stream_unref(), which released the last reference to the http_request. Commit: 170f62e6e89c30f0d1b68465e7b23814e4d5bdf9 https://github.com/dovecot/core/commit/170f62e6e89c30f0d1b68465e7b23814e4d5bdf9 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Treat CASS_ERROR_SERVER_UNAVAILABLE as "write success is uncertain" Looks like the write could still have actually gone through. Commit: 4325f1b85329ec7d7164b643e2ed24a32b762e1f https://github.com/dovecot/core/commit/4325f1b85329ec7d7164b643e2ed24a32b762e1f Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/login-common/client-common.c M src/login-common/client-common.h M src/login-common/main.c Log Message: ----------- *-login: Change API for how login_plugins hook into client allocation. The previous API worked badly when there were more than one plugin. The current behavior works similarly to how mail_plugins work. Commit: 3c87f3ede6c8503b46e525d507d20c16edbcf1cb https://github.com/dovecot/core/commit/3c87f3ede6c8503b46e525d507d20c16edbcf1cb Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/auth-client-connection.c Log Message: ----------- auth: Properly hide all fields with passwords client reply line wasn't hiding all items which contain 'pass' substring. This was inconsistent behaviour since elsewhere this was done. Commit: 3b9d623c0b6fd967991fb7887fa8c4c196e6b078 https://github.com/dovecot/core/commit/3b9d623c0b6fd967991fb7887fa8c4c196e6b078 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/auth-worker-client.c Log Message: ----------- auth: passdb/userdb lookups via auth-worker cached too much of the replies Only the fields returned by the lookup itself were supposed to be cached. This was especially problematic if the lookup via auth-worker didn't uniquely identify the user. For example doing a passdb lookup for an attribute shared by multiple users could have caused the reply to contain the previous cached user's all extra fields. Commit: ad504875883fdc78c7567d72bddbb2810139b594 https://github.com/dovecot/core/commit/ad504875883fdc78c7567d72bddbb2810139b594 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/auth/auth-request.c M src/auth/auth-request.h M src/auth/auth-worker-client.c M src/auth/passdb-blocking.c M src/auth/userdb-blocking.c Log Message: ----------- auth: Auth workers shouldn't return username if it wasn't changed This continues the previous fix where username was always added to passdb/userdb cache, even if the username wasn't changed. That could have resulted in wrongly changing usernames if the cache key didn't uniquely identify the user. Commit: cc6a567ca5c8e1a57aa78d053b36cbdda6ee3fb8 https://github.com/dovecot/core/commit/cc6a567ca5c8e1a57aa78d053b36cbdda6ee3fb8 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/pop3/pop3-client.c M src/pop3/pop3-client.h Log Message: ----------- pop3: Add client.destroyed boolean Commit: 8590275ece826d76c38dccf84215ec86b205e1b5 https://github.com/dovecot/core/commit/8590275ece826d76c38dccf84215ec86b205e1b5 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/imap/imap-client.c M src/imap/main.c M src/indexer/master-connection.c M src/pop3/main.c M src/pop3/pop3-client.c Log Message: ----------- imap, pop3, indexer-worker: Add (deinit) to process title before autoexpunging runs. lmtp should also do this, but it needs a bit larger changes. Commit: edab7ec20988aab18334a8ea684556a778b339c6 https://github.com/dovecot/core/commit/edab7ec20988aab18334a8ea684556a778b339c6 Author: Josef 'Jeff' Sipek Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/doveadm/doveadm-mail.c M src/imap/imap-commands-util.c M src/lib-storage/mail-error.h Log Message: ----------- lib-storage & imap: add MAIL_ERROR_UNAVAILABLE as [UNAVAILABLE] [UNAVAILABLE] is defined in RFC 5530 and we were just missing a MAIL_ERROR_* constant to make use of it. Commit: 07b27806c9574acc4b999e6591f97ddc9f8a7a6d https://github.com/dovecot/core/commit/07b27806c9574acc4b999e6591f97ddc9f8a7a6d Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-dcrypt/dcrypt-openssl.c Log Message: ----------- lib-dcrypt: Add asserts Fixes several static analysis reports Commit: 2f7bf1862d6228a04277497ba7a46d7c5072b682 https://github.com/dovecot/core/commit/2f7bf1862d6228a04277497ba7a46d7c5072b682 Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/doveadm/doveadm-mail.c Log Message: ----------- doveadm: Do not crash doveadm-server if input file missing save commands expects valid input file for it to work, if we are not running for cli, and input file is not provided, provide EINVAL error to caller via i_stream_error. Commit: 9e3c2654f5de70c0a55d2879a86caa83df47c86f https://github.com/dovecot/core/commit/9e3c2654f5de70c0a55d2879a86caa83df47c86f Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-index/mail-index-transaction-update.c Log Message: ----------- lib-index: Minor fix to day_first_uid updating mktime() was getting a bit confused around day changes. Giving it only year/month/day makes it less confused. Commit: 35b34705199ce22c6f2f3e3b9dc1d95b05aa088e https://github.com/dovecot/core/commit/35b34705199ce22c6f2f3e3b9dc1d95b05aa088e Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-index/test-mail-index-transaction-update.c Log Message: ----------- lib-index: Fix test-mail-index-transaction-update It was broken with TZ=Australia/ACT. Fixing it seems too troublesome, so just use TZ=UTC during the test. Commit: 8f02dfd839231ba5661092f4b75a743c3a937fae https://github.com/dovecot/core/commit/8f02dfd839231ba5661092f4b75a743c3a937fae Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/imap-hibernate/imap-client.c Log Message: ----------- imap-hibernate: Support userdb in var_expand Commit: 3b5d60f0cf9b6f10a09061fb90afc93b4afd1041 https://github.com/dovecot/core/commit/3b5d60f0cf9b6f10a09061fb90afc93b4afd1041 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/master/service-monitor.c Log Message: ----------- master: Don't crash if master socket couldn't be re-opened after settings reload. Commit: 64c85d1687566eccf06595ed7275733d04820f90 https://github.com/dovecot/core/commit/64c85d1687566eccf06595ed7275733d04820f90 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/master/service-listen.c Log Message: ----------- master: Add missing error logging for master socket listening failure. Commit: d82bad3787af38001dc0d2673e0c67877065b4e3 https://github.com/dovecot/core/commit/d82bad3787af38001dc0d2673e0c67877065b4e3 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/master/service-listen.c Log Message: ----------- master: Try to listen on master socket even if all services couldn't be listened to. This could happen during a settings reload. Commit: 012969729f15b56177976e71ec57662a428beed5 https://github.com/dovecot/core/commit/012969729f15b56177976e71ec57662a428beed5 Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/plugins/trash/trash-plugin.c Log Message: ----------- trash: Read settings after namespaces are loaded Fixes Panic: file mail-namespace.c: line 709 (mail_namespace_find): assertion failed: (ns != NULL) Commit: 895a31a20313f1b1e2162524c039f4d4e291e619 https://github.com/dovecot/core/commit/895a31a20313f1b1e2162524c039f4d4e291e619 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/imap-hibernate/imap-client.c Log Message: ----------- imap-hibernate: Avoid using casts Commit: d7f6e4ab4352a04f7e64041dd9ca5ba42d2e0873 https://github.com/dovecot/core/commit/d7f6e4ab4352a04f7e64041dd9ca5ba42d2e0873 Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-ssl-iostream/iostream-openssl-context.c Log Message: ----------- lib-ssl-iostream: Fix ambiguity with SSL settings - lib-ssl-iostream as client: Use only allow_invalid_cert. If it's not set, verify the server cert. - lib-ssl-iostream as server: If verify_client_cert=FALSE, don't ask for the client cert. Otherwise, ask for client cert but still allow it if allow_invalid_cert=TRUE. Commit: 3ad044975d9b9f3ec4f2cbf7ba8275f6633169e0 https://github.com/dovecot/core/commit/3ad044975d9b9f3ec4f2cbf7ba8275f6633169e0 Author: Aki Tuomi Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-ssl-iostream/iostream-ssl.c Log Message: ----------- lib-ssl-iostream: Ensure verify_remote_cert is true Forgotten in 38424b8081a75be3ef93729fed4d30dbafca5885 Commit: 058ae8da2cf431a833a1253f11c81a2aece2fcb7 https://github.com/dovecot/core/commit/058ae8da2cf431a833a1253f11c81a2aece2fcb7 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M doc/example-config/conf.d/10-logging.conf Log Message: ----------- example-config: Update deliver_log_format comment Commit: a39b5b2852f27efcf584619112dee3189ed2fd81 https://github.com/dovecot/core/commit/a39b5b2852f27efcf584619112dee3189ed2fd81 Author: Stephan Bosch Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-http/test-http-server-errors.c Log Message: ----------- lib-http: test-http-server-errors: Fixed logically dead code. Problem reported by Coverity. Compare: https://github.com/dovecot/core/compare/3f97702b106b...a39b5b2852f2 From noreply at github.com Thu Mar 16 22:49:39 2017 From: noreply at github.com (GitHub) Date: Thu, 16 Mar 2017 15:49:39 -0700 Subject: [dovecot/pigeonhole] 5144d5: managesieve-login: Use enum managesieve_proxy_stat... Message-ID: <58cb1683321ac_34b23ffbd17cfc3810939a@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: 5144d5b0a7748adf727e0e0bd2fa9e140f7990d0 https://github.com/dovecot/pigeonhole/commit/5144d5b0a7748adf727e0e0bd2fa9e140f7990d0 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/managesieve-login/client.h M src/managesieve-login/managesieve-proxy.c Log Message: ----------- managesieve-login: Use enum managesieve_proxy_state for proxy_state Commit: 4952602925438e61f2baafc7783126e7c3c0af77 https://github.com/dovecot/pigeonhole/commit/4952602925438e61f2baafc7783126e7c3c0af77 Author: Timo Sirainen Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/managesieve-login/client.c M src/managesieve-login/client.h M src/managesieve-login/managesieve-proxy.c M src/managesieve-login/managesieve-proxy.h Log Message: ----------- managesieve-login: Log proxy state as human-readable string Commit: 8d5bc6c6d3d2cd8d14a2186fa6fd762e99b1634b https://github.com/dovecot/pigeonhole/commit/8d5bc6c6d3d2cd8d14a2186fa6fd762e99b1634b Author: Stephan Bosch Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-sieve/sieve.c Log Message: ----------- lib-sieve: multiscript: The execution of the discard script had an implicit "keep", rather than an implicit "discard". Compare: https://github.com/dovecot/pigeonhole/compare/023f391ee665...8d5bc6c6d3d2 From noreply at github.com Thu Mar 16 22:51:00 2017 From: noreply at github.com (GitHub) Date: Thu, 16 Mar 2017 15:51:00 -0700 Subject: [dovecot/pigeonhole] 7d06cd: managesieve: Fix creation of critical error messag... Message-ID: <58cb16d446b0c_5f573ffb2914dc3c459c5@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 7d06cde9e02c0d397e31f1cf6c45af8796c725e3 https://github.com/dovecot/pigeonhole/commit/7d06cde9e02c0d397e31f1cf6c45af8796c725e3 Author: Stephan Bosch Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M src/managesieve/managesieve-client.c Log Message: ----------- managesieve: Fix creation of critical error message timestamp. This used strftime() directly and allocated memory from the heap before i_fatal(). It also used printf() to send the BYE message, which will only work right when the service is running stand-alone. Commit: bf2bd0ff180c791d3c69f775a9e796853d6bd527 https://github.com/dovecot/pigeonhole/commit/bf2bd0ff180c791d3c69f775a9e796853d6bd527 Author: Stephan Bosch Date: 2017-02-26 (Sun, 26 Feb 2017) Changed paths: M src/lib-sieve/sieve-actions.c Log Message: ----------- lib-sieve: store action: Made static analyzer happier about tr_context argument for sieve_act_store_add_flags(). Added an assert ensuring it is not NULL. Commit: 9f9bc901b00927482e5b8c6f3c744261e8cf87fd https://github.com/dovecot/pigeonhole/commit/9f9bc901b00927482e5b8c6f3c744261e8cf87fd Author: Timo Sirainen Date: 2017-03-09 (Thu, 09 Mar 2017) Changed paths: M src/managesieve-login/client.h M src/managesieve-login/managesieve-proxy.c Log Message: ----------- managesieve-login: Use enum managesieve_proxy_state for proxy_state Commit: 8053c068a8da678eeeeeb7ec7a1a619bbcef0246 https://github.com/dovecot/pigeonhole/commit/8053c068a8da678eeeeeb7ec7a1a619bbcef0246 Author: Timo Sirainen Date: 2017-03-09 (Thu, 09 Mar 2017) Changed paths: M src/managesieve-login/client.c M src/managesieve-login/client.h M src/managesieve-login/managesieve-proxy.c M src/managesieve-login/managesieve-proxy.h Log Message: ----------- managesieve-login: Log proxy state as human-readable string Commit: e028318918be8322c2205481b44f88a89cc579b2 https://github.com/dovecot/pigeonhole/commit/e028318918be8322c2205481b44f88a89cc579b2 Author: Stephan Bosch Date: 2017-03-16 (Thu, 16 Mar 2017) Changed paths: M src/lib-sieve/sieve.c Log Message: ----------- lib-sieve: multiscript: The execution of the discard script had an implicit "keep", rather than an implicit "discard". Compare: https://github.com/dovecot/pigeonhole/compare/92f3d3238a6d...e028318918be From noreply at github.com Fri Mar 17 08:30:11 2017 From: noreply at github.com (GitHub) Date: Fri, 17 Mar 2017 01:30:11 -0700 Subject: [dovecot/core] 97f774: trash: Move config file to trash user Message-ID: <58cb9e931e2ad_354e3fee02f4fc24344aa@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 97f774ab04af1c5cb4b8b4f8437df3a2faeb8bef https://github.com/dovecot/core/commit/97f774ab04af1c5cb4b8b4f8437df3a2faeb8bef Author: Aki Tuomi Date: 2017-03-17 (Fri, 17 Mar 2017) Changed paths: M src/plugins/trash/trash-plugin.c Log Message: ----------- trash: Move config file to trash user Makes static analyser happy From noreply at github.com Fri Mar 17 09:30:11 2017 From: noreply at github.com (GitHub) Date: Fri, 17 Mar 2017 02:30:11 -0700 Subject: [dovecot/core] 5eb43c: lib-storage: Don't reset \Recent flags when rebuil... Message-ID: <58cbaca31ce8d_72e23fac15a37c34572e@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 5eb43c3bb43c559cc54d66504c7b79183d45e803 https://github.com/dovecot/core/commit/5eb43c3bb43c559cc54d66504c7b79183d45e803 Author: Timo Sirainen Date: 2017-03-17 (Fri, 17 Mar 2017) Changed paths: M src/lib-storage/index/index-rebuild.c Log Message: ----------- lib-storage: Don't reset \Recent flags when rebuilding index The recent flags are tracked with first_recent_uid in the header. If the first_recent_uid is valid in the old index, preserve it. This way all mails don't show as having \Recent flag. This was used by sdbox and mdbox code. From noreply at github.com Sun Mar 19 16:30:10 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Mar 2017 09:30:10 -0700 Subject: [dovecot/core] d35da3: imapc: Use LOGOUT to cleanly disconnect from serve... Message-ID: <58ceb212e2e95_60bf3f97f8035c3076378@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d35da39e688b94bb7e9adc6c865a45004c64a506 https://github.com/dovecot/core/commit/d35da39e688b94bb7e9adc6c865a45004c64a506 Author: Timo Sirainen Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/lib-imap-client/imapc-client-private.h M src/lib-imap-client/imapc-client.c M src/lib-imap-client/imapc-client.h M src/lib-imap-client/imapc-connection.c M src/lib-imap-client/imapc-connection.h M src/lib-storage/index/imapc/imapc-list.c M src/lib-storage/index/imapc/imapc-storage.c Log Message: ----------- imapc: Use LOGOUT to cleanly disconnect from server. This makes it clearer in the remote server's logs whether the disconnection was intentional or not. Use a hardcoded 5 second timeout for LOGOUT. It should be enough time for the server to finish sending the tagged reply. From noreply at github.com Sun Mar 19 22:30:10 2017 From: noreply at github.com (GitHub) Date: Sun, 19 Mar 2017 15:30:10 -0700 Subject: [dovecot/core] b045b6: login-common: Add preproxy pool Message-ID: <58cf067294d99_235583f9aec89bc344221b@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b045b66988bfbaa2795791e42ee724fae6f0db1c https://github.com/dovecot/core/commit/b045b66988bfbaa2795791e42ee724fae6f0db1c Author: Aki Tuomi Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/login-common/client-common.c M src/login-common/client-common.h M src/login-common/login-proxy.c Log Message: ----------- login-common: Add preproxy pool preproxy pool can be used to do allocations that are released once proxying starts. Commit: a8dac1be6a0c3adbbce5887ca395f418194c6c06 https://github.com/dovecot/core/commit/a8dac1be6a0c3adbbce5887ca395f418194c6c06 Author: Aki Tuomi Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/auth/auth-request.c M src/auth/auth-request.h M src/lib-auth/auth-client-request.c M src/lib-auth/auth-client.h M src/login-common/client-common.h M src/login-common/sasl-server.c Log Message: ----------- auth: Accept client_id from auth client Client ID contains the ID client request string for IMAP. Commit: 07142eb1dc6453bfc6206c14af7b6d3c3ec05eeb https://github.com/dovecot/core/commit/07142eb1dc6453bfc6206c14af7b6d3c3ec05eeb Author: Aki Tuomi Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/imap-login/imap-login-settings.c M src/imap-login/imap-login-settings.h Log Message: ----------- imap-login: Add option to retain client id This should be enabled if client_id is wanted for auth policy Commit: 2f7c73483ff5474a74a83a646f82e1b60f687680 https://github.com/dovecot/core/commit/2f7c73483ff5474a74a83a646f82e1b60f687680 Author: Aki Tuomi Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/imap-login/imap-login-client.c M src/login-common/client-common.h Log Message: ----------- imap-login: Retain ID request without dovecot specials Commit: a9523ec8f6c32ccdfe3a78d743a9cd749c3eb3aa https://github.com/dovecot/core/commit/a9523ec8f6c32ccdfe3a78d743a9cd749c3eb3aa Author: Aki Tuomi Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/imap-login/imap-proxy.c Log Message: ----------- imap-login: Forward original client ID to next hop This will be done if ID is present. Commit: e88c6613d3bc78fa928b0e74f8e4ebd91151206e https://github.com/dovecot/core/commit/e88c6613d3bc78fa928b0e74f8e4ebd91151206e Author: Aki Tuomi Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/auth/auth-request-var-expand.c M src/auth/auth-request-var-expand.h Log Message: ----------- auth: Support client_id variable When imap_id_retain is turned on, contains the client ID request content with dovecot special vars removed. Commit: 6e76be05e480dc717f4d48483029ac1cbd8d237b https://github.com/dovecot/core/commit/6e76be05e480dc717f4d48483029ac1cbd8d237b Author: Aki Tuomi Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/auth/auth-fields.c M src/auth/auth-fields.h Log Message: ----------- auth: Add auth_fields_import_prefixed Commit: 53f97800b16ab3a8d263c5331132dec1e8fea9a0 https://github.com/dovecot/core/commit/53f97800b16ab3a8d263c5331132dec1e8fea9a0 Author: Aki Tuomi Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/auth/auth-request.c M src/lib-auth/auth-client-request.c M src/lib-auth/auth-client.h M src/login-common/client-common.h M src/login-common/sasl-server.c Log Message: ----------- auth: Accept forward_fields from auth client Commit: 998eadc15aabe598cc9301fdb28c0fef5225b3f7 https://github.com/dovecot/core/commit/998eadc15aabe598cc9301fdb28c0fef5225b3f7 Author: Aki Tuomi Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/imap-login/imap-login-client.c M src/imap-login/imap-proxy.c M src/login-common/client-common-auth.c Log Message: ----------- imap-login: Allow x-forward- to specify forward fields from trusted networks Commit: 67ac9e1493601933d3d4eb2d30893e0d84d2a5b5 https://github.com/dovecot/core/commit/67ac9e1493601933d3d4eb2d30893e0d84d2a5b5 Author: Aki Tuomi Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/pop3-login/pop3-proxy.c Log Message: ----------- pop3-login: Pass forward_ passdb args using XCLIENT command Commit: 017d99aa1c9decec9e79d6183f61df97f35f5df2 https://github.com/dovecot/core/commit/017d99aa1c9decec9e79d6183f61df97f35f5df2 Author: Aki Tuomi Date: 2017-03-19 (Sun, 19 Mar 2017) Changed paths: M src/pop3-login/client.c Log Message: ----------- pop3-login: Add FORWARD for XCLIENT This allows passing passdb variables. They are prefixed with forward_ when imported to extra fields. Compare: https://github.com/dovecot/core/compare/d35da39e688b...017d99aa1c9d From noreply at github.com Tue Mar 21 07:30:11 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Mar 2017 00:30:11 -0700 Subject: [dovecot/core] 8e066c: lib-dict: Ensure init returns dict Message-ID: <58d0d68373ba9_236693f9c1eb51c34459b6@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8e066cce954f6d23acec4b669b09b358401bd386 https://github.com/dovecot/core/commit/8e066cce954f6d23acec4b669b09b358401bd386 Author: Aki Tuomi Date: 2017-03-20 (Mon, 20 Mar 2017) Changed paths: M src/lib-dict/dict.c Log Message: ----------- lib-dict: Ensure init returns dict Commit: 5b29a2a2ebca13ad2385d807cb231bf8defb72a6 https://github.com/dovecot/core/commit/5b29a2a2ebca13ad2385d807cb231bf8defb72a6 Author: Aki Tuomi Date: 2017-03-20 (Mon, 20 Mar 2017) Changed paths: M src/lib-dict/dict-cdb.c Log Message: ----------- dict-cdb: Fix API for v2.3 Broken by 39ea5717264668e2c7f9f7986eb821d21785f47f Compare: https://github.com/dovecot/core/compare/017d99aa1c9d...5b29a2a2ebca From noreply at github.com Tue Mar 21 10:00:15 2017 From: noreply at github.com (GitHub) Date: Tue, 21 Mar 2017 03:00:15 -0700 Subject: [dovecot/core] 265b99: trash: Move config file to trash user Message-ID: <58d0f9afa9e23_7adc3fdbe1f6fc3c61976@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 265b99eaaedbbafe679cbbe350d10668f8c99a4b https://github.com/dovecot/core/commit/265b99eaaedbbafe679cbbe350d10668f8c99a4b Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/plugins/trash/trash-plugin.c Log Message: ----------- trash: Move config file to trash user Makes static analyser happy Commit: 7c5caf33b05c0426290f870f52b4bcf852a6aeb2 https://github.com/dovecot/core/commit/7c5caf33b05c0426290f870f52b4bcf852a6aeb2 Author: Timo Sirainen Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/lib-storage/index/index-rebuild.c Log Message: ----------- lib-storage: Don't reset \Recent flags when rebuilding index The recent flags are tracked with first_recent_uid in the header. If the first_recent_uid is valid in the old index, preserve it. This way all mails don't show as having \Recent flag. This was used by sdbox and mdbox code. Commit: 9fe890fdbf8e64b0fac30787ca1f370f8913e6ba https://github.com/dovecot/core/commit/9fe890fdbf8e64b0fac30787ca1f370f8913e6ba Author: Timo Sirainen Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/lib-imap-client/imapc-client-private.h M src/lib-imap-client/imapc-client.c M src/lib-imap-client/imapc-client.h M src/lib-imap-client/imapc-connection.c M src/lib-imap-client/imapc-connection.h M src/lib-storage/index/imapc/imapc-list.c M src/lib-storage/index/imapc/imapc-storage.c Log Message: ----------- imapc: Use LOGOUT to cleanly disconnect from server. This makes it clearer in the remote server's logs whether the disconnection was intentional or not. Use a hardcoded 5 second timeout for LOGOUT. It should be enough time for the server to finish sending the tagged reply. Commit: f61eac37a6905fb43ae2cbaf669ee1cf963505c4 https://github.com/dovecot/core/commit/f61eac37a6905fb43ae2cbaf669ee1cf963505c4 Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/login-common/client-common.c M src/login-common/client-common.h M src/login-common/login-proxy.c Log Message: ----------- login-common: Add preproxy pool preproxy pool can be used to do allocations that are released once proxying starts. Commit: 3b3dc40b22c8e7dcca74891073d9a8e89fbe0419 https://github.com/dovecot/core/commit/3b3dc40b22c8e7dcca74891073d9a8e89fbe0419 Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/auth/auth-request.c M src/auth/auth-request.h M src/lib-auth/auth-client-request.c M src/lib-auth/auth-client.h M src/login-common/client-common.h M src/login-common/sasl-server.c Log Message: ----------- auth: Accept client_id from auth client Client ID contains the ID client request string for IMAP. Commit: 5658aec7c154c5bbdf0f2ffa09dab694bfccf3ac https://github.com/dovecot/core/commit/5658aec7c154c5bbdf0f2ffa09dab694bfccf3ac Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/imap-login/imap-login-settings.c M src/imap-login/imap-login-settings.h Log Message: ----------- imap-login: Add option to retain client id This should be enabled if client_id is wanted for auth policy Commit: f1d4d448c87a017edafd116af19121e2a4fde6ec https://github.com/dovecot/core/commit/f1d4d448c87a017edafd116af19121e2a4fde6ec Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/imap-login/imap-login-client.c M src/login-common/client-common.h Log Message: ----------- imap-login: Retain ID request without dovecot specials Commit: 7ee65ad6c0b7adfbc9ba9c100cc369bade68a60b https://github.com/dovecot/core/commit/7ee65ad6c0b7adfbc9ba9c100cc369bade68a60b Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/imap-login/imap-proxy.c Log Message: ----------- imap-login: Forward original client ID to next hop This will be done if ID is present. Commit: ccb936a8dde1179994ad859fd4f6951ec139fd89 https://github.com/dovecot/core/commit/ccb936a8dde1179994ad859fd4f6951ec139fd89 Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/auth/auth-request-var-expand.c M src/auth/auth-request-var-expand.h Log Message: ----------- auth: Support client_id variable When imap_id_retain is turned on, contains the client ID request content with dovecot special vars removed. Commit: d9ab90950838b034ab456b83856c96e961ebba5c https://github.com/dovecot/core/commit/d9ab90950838b034ab456b83856c96e961ebba5c Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/auth/auth-fields.c M src/auth/auth-fields.h Log Message: ----------- auth: Add auth_fields_import_prefixed Commit: dcdece5d5ade183bd5a7384010d9c6166fb6e6e7 https://github.com/dovecot/core/commit/dcdece5d5ade183bd5a7384010d9c6166fb6e6e7 Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/auth/auth-request.c M src/lib-auth/auth-client-request.c M src/lib-auth/auth-client.h M src/login-common/client-common.h M src/login-common/sasl-server.c Log Message: ----------- auth: Accept forward_fields from auth client Commit: 6ca2c6216499671873204082249e0b8b6364f34f https://github.com/dovecot/core/commit/6ca2c6216499671873204082249e0b8b6364f34f Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/imap-login/imap-login-client.c M src/imap-login/imap-proxy.c M src/login-common/client-common-auth.c Log Message: ----------- imap-login: Allow x-forward- to specify forward fields from trusted networks Commit: 870ed05d307da67f556551d7449686cbf0d7daf0 https://github.com/dovecot/core/commit/870ed05d307da67f556551d7449686cbf0d7daf0 Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/pop3-login/pop3-proxy.c Log Message: ----------- pop3-login: Pass forward_ passdb args using XCLIENT command Commit: 2c182e046b5972197c62fe6c03e333b4758d310b https://github.com/dovecot/core/commit/2c182e046b5972197c62fe6c03e333b4758d310b Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/pop3-login/client.c Log Message: ----------- pop3-login: Add FORWARD for XCLIENT This allows passing passdb variables. They are prefixed with forward_ when imported to extra fields. Commit: 9945103c54a084bfeb27e6b40445221aeec95a3f https://github.com/dovecot/core/commit/9945103c54a084bfeb27e6b40445221aeec95a3f Author: Aki Tuomi Date: 2017-03-21 (Tue, 21 Mar 2017) Changed paths: M src/lib-dict/dict.c Log Message: ----------- lib-dict: Ensure init returns dict Compare: https://github.com/dovecot/core/compare/a39b5b2852f2...9945103c54a0 From noreply at github.com Wed Mar 22 07:00:14 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Mar 2017 00:00:14 -0700 Subject: [dovecot/core] fcb3cc: lib: Add missing error handling to o_stream_cork() Message-ID: <58d220fe5c513_32083fb259561c382240bf@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: fcb3ccff65b4511cb348cf07046c4b37dd0c56f8 https://github.com/dovecot/core/commit/fcb3ccff65b4511cb348cf07046c4b37dd0c56f8 Author: Timo Sirainen Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/lib/ostream.c Log Message: ----------- lib: Add missing error handling to o_stream_cork() With ostream-file the corking could have called buffer_flush(), which could have failed and set stream_errno, but nothing would set last_failed_errno. Fixes: Panic: file ostream.c: line 59 (o_stream_close_full): assertion failed: (stream->last_failed_errno != 0) From noreply at github.com Wed Mar 22 18:30:11 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Mar 2017 11:30:11 -0700 Subject: [dovecot/core] c466bb: doveadm: Add exit code/string conversion functions Message-ID: <58d2c2b3e6000_244a03fc583af3c2c1852f9@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c466bbccb4b8b0026aea13540ebdef3bddbd67dd https://github.com/dovecot/core/commit/c466bbccb4b8b0026aea13540ebdef3bddbd67dd Author: Aki Tuomi Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm.h Log Message: ----------- doveadm: Add exit code/string conversion functions Commit: 89387c6f098be5a8589c30109d9744ef7c5c336c https://github.com/dovecot/core/commit/89387c6f098be5a8589c30109d9744ef7c5c336c Author: Aki Tuomi Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/doveadm/client-connection.c M src/doveadm/server-connection.c Log Message: ----------- doveadm: Send and receive exit codes correctly The old code would assume TEMPFAIL for almost everything. Compare: https://github.com/dovecot/core/compare/5b29a2a2ebca...89387c6f098b From noreply at github.com Wed Mar 22 19:00:10 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Mar 2017 12:00:10 -0700 Subject: [dovecot/core] 4102d9: lib-http: test-http-client-errors: Always use the ... Message-ID: <58d2c9baef207_6ddc3fafe42c9c2c13392c@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 4102d9f269837affa671a46fe047290366768ad1 https://github.com/dovecot/core/commit/4102d9f269837affa671a46fe047290366768ad1 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: test-http-client-errors: Always use the proper error status code definitions rather than an integer literal. Commit: a8741f46cb3cf40e58e3d47b263f238918243380 https://github.com/dovecot/core/commit/a8741f46cb3cf40e58e3d47b263f238918243380 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/lib-http/http-client.h M src/lib-http/http-response.h Log Message: ----------- lib-http: Explicitly define the start of the range of internal response status codes. Commit: 17908b11e2e0cece58f0b653876385da5d62f3c0 https://github.com/dovecot/core/commit/17908b11e2e0cece58f0b653876385da5d62f3c0 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/lib-http/http-response.h Log Message: ----------- lib-http: Added a function to obtain a message suitable for logging from a response object. This prevents logging internal error codes (>= 9000). Commit: ce3fc9190e82d8d9e9604afd4ebbee1d61957764 https://github.com/dovecot/core/commit/ce3fc9190e82d8d9e9604afd4ebbee1d61957764 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/auth/auth-policy.c M src/lib-http/http-client-connection.c M src/plugins/fts-solr/solr-connection.c M src/plugins/fts/fts-parser-tika.c M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- global: Use http_response_get_message() to log HTTP responses. Commit: 905ada5e56cbad1a3ccf827332dabd4898ea8fc5 https://github.com/dovecot/core/commit/905ada5e56cbad1a3ccf827332dabd4898ea8fc5 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: test-http-client-errors: Added test for using https:// while SSL is not configured. Commit: 15fe3500f08cfb1d4bde1f97afd7d287486dbd21 https://github.com/dovecot/core/commit/15fe3500f08cfb1d4bde1f97afd7d287486dbd21 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/lib-http/http-client-request.c Log Message: ----------- lib-http: client: Clear request pointer immediately in http_client_request_error(). Commit: 8d845733408c0cb06a8884d12101beb0d40e6869 https://github.com/dovecot/core/commit/8d845733408c0cb06a8884d12101beb0d40e6869 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/lib-http/http-client-request.c M src/lib-http/http-client.c Log Message: ----------- lib-http: client: Restructured the handling of delayed errors. The req->delayed_error* fields are cleared before the callback is called and before the request is dereferenced. This way, freeing the request never removes it from the delayed request list when the list is being processed. It also makes it possible to resubmit the request from the callback (mainly for future use). Commit: 7a358ecd8918d1280a0b68cdf348c23f6721c799 https://github.com/dovecot/core/commit/7a358ecd8918d1280a0b68cdf348c23f6721c799 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/lib-http/http-client-request.c Log Message: ----------- lib-http: client: Make sure a request's log label never gets a duplicate request target part. Make sure the URL part of the label always only consists of a http://host:port part and nothing more. Commit: e46130f48a6962734bfde7e71906d3894bedf45b https://github.com/dovecot/core/commit/e46130f48a6962734bfde7e71906d3894bedf45b Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/lib-http/http-client-request.c M src/lib-http/http-client.h M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Implemented http_client_request_url_str() function that accepts an URL string rather than a pre-parsed URL object. If the provided HTTP URL is invalid, the callback with the error is called some time later from the ioloop. This change also amends the test-http-client-errors test suite with a new test for this new feature. Compare: https://github.com/dovecot/core/compare/89387c6f098b...e46130f48a69 From noreply at github.com Wed Mar 22 23:02:09 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Mar 2017 16:02:09 -0700 Subject: [dovecot/pigeonhole] 148ba0: imapsieve plugin: Forgot to cleanup imap_sieve_run... Message-ID: <58d30271ab746_73883fe4cdab7c401524fd@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 148ba04067fb18e086ffe266dc208a5a4b607bee https://github.com/dovecot/pigeonhole/commit/148ba04067fb18e086ffe266dc208a5a4b607bee Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Forgot to cleanup imap_sieve_run object when mailbox_sync() fails. Commit: 1748e01b8883c871b907df0db1064ffae71ea8bc https://github.com/dovecot/pigeonhole/commit/1748e01b8883c871b907df0db1064ffae71ea8bc Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/plugins/imapsieve/imap-sieve.c Log Message: ----------- imapsieve plugin: Don't open the user's personal script storage if no personal script is configured. Commit: b7ade8c3b9669ea9d17a0e1a191ed6e14adf9c19 https://github.com/dovecot/pigeonhole/commit/b7ade8c3b9669ea9d17a0e1a191ed6e14adf9c19 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M doc/plugins/imapsieve.txt M src/plugins/imapsieve/ext-imapsieve-common.h M src/plugins/imapsieve/ext-imapsieve-environment.c M src/plugins/imapsieve/ext-imapsieve.c M src/plugins/imapsieve/imap-sieve-storage.c M src/plugins/imapsieve/imap-sieve.c M src/plugins/imapsieve/imap-sieve.h M src/plugins/imapsieve/sieve-imapsieve-plugin.c Log Message: ----------- imapsieve plugin: Added non-standard Sieve environment items for source and destination mailbox. Commit: 71e773ca8f39b06aea05a4af4a0e78f54857fb36 https://github.com/dovecot/pigeonhole/commit/71e773ca8f39b06aea05a4af4a0e78f54857fb36 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Prevent recording events for the COPY/MOVE source mailbox transaction. This already has the imapsieve transaction context associated with it before the sieve scripts are executed. This currently cannot occur, but it will become relevant in subsequent commits. Commit: e69a6dec745aba9accf01f3c83bbb03a0789255d https://github.com/dovecot/pigeonhole/commit/e69a6dec745aba9accf01f3c83bbb03a0789255d Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M doc/plugins/imapsieve.txt M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Implemented the copy_source_after rule action. When this is enabled for a mailbox rule, the specified Sieve script is executed for the message in the source mailbox during a "COPY" event. This happens only after the Sieve script that is executed for the corresponding message in the destination mailbox finishes running successfully. Compare: https://github.com/dovecot/pigeonhole/compare/e028318918be...e69a6dec745a From noreply at github.com Wed Mar 22 23:04:50 2017 From: noreply at github.com (GitHub) Date: Wed, 22 Mar 2017 16:04:50 -0700 Subject: [dovecot/pigeonhole] c2e9ef: imapsieve plugin: Forgot to cleanup imap_sieve_run... Message-ID: <58d30312c8f6e_5f5d3fd0ddda1c34130590@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: c2e9ef09fd62fd5208719383ff7ac135a15b8e02 https://github.com/dovecot/pigeonhole/commit/c2e9ef09fd62fd5208719383ff7ac135a15b8e02 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Forgot to cleanup imap_sieve_run object when mailbox_sync() fails. Commit: 47e54e4db8aed76e84d052ae9f5f2459693c8e73 https://github.com/dovecot/pigeonhole/commit/47e54e4db8aed76e84d052ae9f5f2459693c8e73 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/plugins/imapsieve/imap-sieve.c Log Message: ----------- imapsieve plugin: Don't open the user's personal script storage if no personal script is configured. Commit: e9eece0d2052a40fc2ec41ced2f713f3d89a945a https://github.com/dovecot/pigeonhole/commit/e9eece0d2052a40fc2ec41ced2f713f3d89a945a Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M doc/plugins/imapsieve.txt M src/plugins/imapsieve/ext-imapsieve-common.h M src/plugins/imapsieve/ext-imapsieve-environment.c M src/plugins/imapsieve/ext-imapsieve.c M src/plugins/imapsieve/imap-sieve-storage.c M src/plugins/imapsieve/imap-sieve.c M src/plugins/imapsieve/imap-sieve.h M src/plugins/imapsieve/sieve-imapsieve-plugin.c Log Message: ----------- imapsieve plugin: Added non-standard Sieve environment items for source and destination mailbox. Commit: 951ee5bdcb14a44e19035477ff5b91188b019609 https://github.com/dovecot/pigeonhole/commit/951ee5bdcb14a44e19035477ff5b91188b019609 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Prevent recording events for the COPY/MOVE source mailbox transaction. This already has the imapsieve transaction context associated with it before the sieve scripts are executed. This currently cannot occur, but it will become relevant in subsequent commits. Commit: 256ff65c5c23786566b064891c3edf658256a896 https://github.com/dovecot/pigeonhole/commit/256ff65c5c23786566b064891c3edf658256a896 Author: Stephan Bosch Date: 2017-03-22 (Wed, 22 Mar 2017) Changed paths: M doc/plugins/imapsieve.txt M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Implemented the copy_source_after rule action. When this is enabled for a mailbox rule, the specified Sieve script is executed for the message in the source mailbox during a "COPY" event. This happens only after the Sieve script that is executed for the corresponding message in the destination mailbox finishes running successfully. Compare: https://github.com/dovecot/pigeonhole/compare/8d5bc6c6d3d2...256ff65c5c23 From noreply at github.com Thu Mar 23 08:00:11 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Mar 2017 01:00:11 -0700 Subject: [dovecot/core] 4e64ac: lib: Download unicode.org files from dovecot.org Message-ID: <58d3808b6e990_343e3fcf42007c3c172181@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 4e64ac91c5a3eb2a55e0b18d8da832b29ec08289 https://github.com/dovecot/core/commit/4e64ac91c5a3eb2a55e0b18d8da832b29ec08289 Author: Martti Rannanj?rvi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-fts/Makefile.am M src/lib/Makefile.am Log Message: ----------- lib: Download unicode.org files from dovecot.org From noreply at github.com Thu Mar 23 10:30:11 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Mar 2017 03:30:11 -0700 Subject: [dovecot/core] 8ca217: lib-storage: Add mailbox_list_get_last_internal_er... Message-ID: <58d3a3b31cdbb_6db23f937d911c341378de@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8ca217bf3aa23c7922d0d4aa44fcd2320416d61c https://github.com/dovecot/core/commit/8ca217bf3aa23c7922d0d4aa44fcd2320416d61c Author: Martti Rannanj?rvi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-storage/mailbox-list-private.h M src/lib-storage/mailbox-list.c M src/lib-storage/mailbox-list.h Log Message: ----------- lib-storage: Add mailbox_list_get_last_internal_error() This returns the error given to mailbox_list_set_critical(). Commit: d4847b921058734e0668bc7690465c91523d9ec0 https://github.com/dovecot/core/commit/d4847b921058734e0668bc7690465c91523d9ec0 Author: Martti Rannanj?rvi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/doveadm/doveadm-mail-index.c M src/doveadm/doveadm-mail-mailbox.c M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-mailbox-list-iter.c M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c M src/doveadm/dsync/dsync-mailbox-tree-fill.c M src/imap/main.c M src/lib-imap-urlauth/imap-urlauth-backend.c M src/lib-storage/list/mailbox-list-index-backend.c M src/lib-storage/mail-autoexpunge.c M src/plugins/quota/quota-count.c M src/plugins/virtual/virtual-config.c M src/pop3/pop3-client.c Log Message: ----------- global: Log mailbox_list internal errors Compare: https://github.com/dovecot/core/compare/4e64ac91c5a3...d4847b921058 From noreply at github.com Thu Mar 23 11:30:10 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Mar 2017 04:30:10 -0700 Subject: [dovecot/core] d70bf1: lib-dict: Add dict-fail driver Message-ID: <58d3b1c2a8b66_2dee3f7e7191dc3017488d@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d70bf110f2f37ab5315a250c2367f164069755ad https://github.com/dovecot/core/commit/d70bf110f2f37ab5315a250c2367f164069755ad Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-dict/Makefile.am A src/lib-dict/dict-fail.c M src/lib-dict/dict-private.h Log Message: ----------- lib-dict: Add dict-fail driver It can be used for providing various failures Commit: 10f126b558e39b0f69fe2baecc9e74d2bfad8c7d https://github.com/dovecot/core/commit/10f126b558e39b0f69fe2baecc9e74d2bfad8c7d Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-dict/dict.c Log Message: ----------- dict: Update correct counter in dict_iterate_init Commit: 7932885c8a996991f46f877cca0043d2cd2cc9da https://github.com/dovecot/core/commit/7932885c8a996991f46f877cca0043d2cd2cc9da Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-dict/dict.c Log Message: ----------- lib-dict: Use dict-fail iterator and transaction when missing from dict driver Commit: d42321abd735a9c9bb1bb3d5b9a89799153cad06 https://github.com/dovecot/core/commit/d42321abd735a9c9bb1bb3d5b9a89799153cad06 Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-dict/Makefile.am Log Message: ----------- lib-dict: Fix test-dict linkage Commit: f32da6b73c1edb6963eae0d4a5c1f995ad23151a https://github.com/dovecot/core/commit/f32da6b73c1edb6963eae0d4a5c1f995ad23151a Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-dict/dict-private.h M src/lib-dict/dict.c Log Message: ----------- lib-dict: Track transaction counts Commit: be64b3bbf9e1664071516f2a4a68a0916da7abac https://github.com/dovecot/core/commit/be64b3bbf9e1664071516f2a4a68a0916da7abac Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-dict/dict.c Log Message: ----------- lib-dict: Ensure all iterations and transactions are done in deinit Commit: 2e295aaaf04febd3bb7be66cddd4d8ffa96fa5dc https://github.com/dovecot/core/commit/2e295aaaf04febd3bb7be66cddd4d8ffa96fa5dc Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/plugins/acl/acl-mailbox-list.c Log Message: ----------- acl: Use mailbox_list_context instead of ctx->ctx This prepares for the next commit Commit: 7e1600ded6fe7e056cea3771bb28fc11d571f039 https://github.com/dovecot/core/commit/7e1600ded6fe7e056cea3771bb28fc11d571f039 Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/plugins/acl/acl-mailbox-list.c Log Message: ----------- acl: Use MODULE_CONTEXT for mailbox list iterator Commit: fbcc3e140de579779d67b6cb9a0220eb2a13ad8a https://github.com/dovecot/core/commit/fbcc3e140de579779d67b6cb9a0220eb2a13ad8a Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-storage/list/mailbox-list-iter.c M src/lib-storage/mailbox-list-private.h Log Message: ----------- lib-storage: Expose mailbox_list_init_autocreate It is needed when backend_ctx is created on the fly Commit: 34b724d1d7e50b1ab24267a3b6fc089b1147c1ab https://github.com/dovecot/core/commit/34b724d1d7e50b1ab24267a3b6fc089b1147c1ab Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-storage/index/imapc/imapc-list.c M src/lib-storage/list/mailbox-list-fs-iter.c M src/lib-storage/list/mailbox-list-index-iter.c M src/lib-storage/list/mailbox-list-iter.c M src/lib-storage/list/mailbox-list-maildir-iter.c M src/lib-storage/list/mailbox-list-subscriptions.c M src/lib-storage/mailbox-list-private.h Log Message: ----------- lib-storage: Add and use default mailbox iterator The idea is to allow mail plugins to see also the non-existent autoboxes by feeding them thru the iterator. Fixes problem where autocreated boxes are not seen by ACL plugin. Compare: https://github.com/dovecot/core/compare/d4847b921058...34b724d1d7e5 From noreply at github.com Thu Mar 23 12:00:13 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Mar 2017 05:00:13 -0700 Subject: [dovecot/core] 2c2bcf: lib: Fix whitespace in var-expand.c Message-ID: <58d3b8cd45aa9_28773ff8d2a85c2c1823ce@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2c2bcffb5d26ebf0c7cc0c6586feda4ce7967e98 https://github.com/dovecot/core/commit/2c2bcffb5d26ebf0c7cc0c6586feda4ce7967e98 Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib/var-expand.c Log Message: ----------- lib: Fix whitespace in var-expand.c Commit: 0306a3100b0fd42f00004bb728e2a9039e0a4846 https://github.com/dovecot/core/commit/0306a3100b0fd42f00004bb728e2a9039e0a4846 Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib/var-expand.c Log Message: ----------- lib: Check var_expand_long return value correctly Commit: 5c00a22fcca7f68479a8768fec7ace7f679b344d https://github.com/dovecot/core/commit/5c00a22fcca7f68479a8768fec7ace7f679b344d Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib/Makefile.am M src/lib/lib.c A src/lib/var-expand-private.h M src/lib/var-expand.c Log Message: ----------- lib: Add extension support for var-expand This enables loading new var-expand features using plugins. Commit: dbc351d8a8dad8cfbc0c1f5d957d23873ab5e26c https://github.com/dovecot/core/commit/dbc351d8a8dad8cfbc0c1f5d957d23873ab5e26c Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M configure.ac M src/plugins/Makefile.am A src/plugins/var-expand-crypt/Makefile.am A src/plugins/var-expand-crypt/var-expand-crypt-plugin.c Log Message: ----------- var-expand-crypt: Encryption/decryption support for var-expand Registers new encrypt and decrypt processors for var-expand. Commit: b8596c89dd8b6628e0fa52e52f2a95e869968706 https://github.com/dovecot/core/commit/b8596c89dd8b6628e0fa52e52f2a95e869968706 Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib/test-var-expand.c Log Message: ----------- lib: Add tests for extensions Compare: https://github.com/dovecot/core/compare/34b724d1d7e5...b8596c89dd8b From noreply at github.com Thu Mar 23 13:30:12 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Mar 2017 06:30:12 -0700 Subject: [dovecot/core] f504be: dbox: Allow ":" separator between mail_attachment_... Message-ID: <58d3cde4d2a83_23a533fc033c5bc2c1486a5@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f504be57bf0a77b1ad055322c4aa936606fc6e4d https://github.com/dovecot/core/commit/f504be57bf0a77b1ad055322c4aa936606fc6e4d Author: Timo Sirainen Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-storage/index/dbox-common/dbox-storage.c Log Message: ----------- dbox: Allow ":" separator between mail_attachment_fs driver and args. The ":" separator is nowadays commonly used elsewhere for the separator, so it should work here as well. Commit: 38ce5769db11e7f52562610ee6e6fc4f0ea7888f https://github.com/dovecot/core/commit/38ce5769db11e7f52562610ee6e6fc4f0ea7888f Author: Martti Rannanj?rvi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/plugins/quota/quota-status.c M src/plugins/quota/quota-storage.c M src/plugins/quota/quota.c M src/plugins/quota/quota.h Log Message: ----------- quota: Introduce quota_alloc_result return type Commit: 64f889c7c1707f9951755c997d750639be5dd41c https://github.com/dovecot/core/commit/64f889c7c1707f9951755c997d750639be5dd41c Author: Martti Rannanj?rvi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/plugins/quota/quota-private.h M src/plugins/quota/quota.c M src/plugins/trash/trash-plugin.c Log Message: ----------- quota: Use quota_alloc_result in quota_settings.test_alloc Commit: 7f4fa37676bac8efcf4e2ac706172b1bad779a8a https://github.com/dovecot/core/commit/7f4fa37676bac8efcf4e2ac706172b1bad779a8a Author: Martti Rannanj?rvi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M doc/example-config/conf.d/90-quota.conf M src/plugins/quota/Makefile.am M src/plugins/quota/quota-private.h M src/plugins/quota/quota-status.c M src/plugins/quota/quota-storage.c M src/plugins/quota/quota.c M src/plugins/quota/quota.h Log Message: ----------- quota: Add quota_max_mail_size setting Commit: 8fc6dd0572450cc2896f8089d23319a64a50267a https://github.com/dovecot/core/commit/8fc6dd0572450cc2896f8089d23319a64a50267a Author: Martti Rannanj?rvi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/plugins/quota/quota.c Log Message: ----------- quota: Use mail_user_plugin_getenv_bool to get quota_vsizes Commit: 98c217499d578495e982ea6010ebff831e9669ae https://github.com/dovecot/core/commit/98c217499d578495e982ea6010ebff831e9669ae Author: Martti Rannanj?rvi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.c M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Add mail_storage_get_last_internal_error() This returns the error given to mail_storage_set_critical(). Commit: 8d2e45a300932ae6c49d2c9bf4b6fe7820cc25a8 https://github.com/dovecot/core/commit/8d2e45a300932ae6c49d2c9bf4b6fe7820cc25a8 Author: Martti Rannanj?rvi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lmtp/commands.c Log Message: ----------- lmtp: Log internal error on STATUS_CHECK_OVER_QUOTA failure Commit: bf7dc750b95039981c0e9d728f313d50cf38a156 https://github.com/dovecot/core/commit/bf7dc750b95039981c0e9d728f313d50cf38a156 Author: Martti Rannanj?rvi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/doveadm/doveadm-mail-altmove.c M src/doveadm/doveadm-mail-copymove.c M src/doveadm/doveadm-mail-deduplicate.c M src/doveadm/doveadm-mail-expunge.c M src/doveadm/doveadm-mail-fetch.c M src/doveadm/doveadm-mail-flags.c M src/doveadm/doveadm-mail-import.c M src/doveadm/doveadm-mail-index.c M src/doveadm/doveadm-mail-iter.c M src/doveadm/doveadm-mail-mailbox-metadata.c M src/doveadm/doveadm-mail-mailbox-status.c M src/doveadm/doveadm-mail-mailbox.c M src/doveadm/doveadm-mail-save.c M src/doveadm/doveadm-mail-search.c M src/doveadm/doveadm-mail.c M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c M src/doveadm/dsync/dsync-brain-mailbox.c M src/doveadm/dsync/dsync-brain.c M src/doveadm/dsync/dsync-mailbox-export.c M src/doveadm/dsync/dsync-mailbox-import.c M src/doveadm/dsync/dsync-mailbox-tree-fill.c M src/imap/imap-state.c M src/indexer/master-connection.c M src/lda/main.c M src/lib-imap-urlauth/imap-urlauth-backend.c M src/lib-lda/mail-deliver.c M src/lib-storage/index/dbox-multi/mdbox-storage-rebuild.c M src/lib-storage/index/index-mailbox-size.c M src/lib-storage/mail-autoexpunge.c M src/lib-storage/mail-storage.c M src/lib-storage/mailbox-guid-cache.c M src/lmtp/commands.c M src/plugins/acl/doveadm-acl.c M src/plugins/fts-lucene/fts-backend-lucene.c M src/plugins/fts-lucene/lucene-wrapper.cc M src/plugins/fts/fts-api.c M src/plugins/fts/fts-build-mail.c M src/plugins/lazy-expunge/lazy-expunge-plugin.c M src/plugins/mail-crypt/doveadm-mail-crypt.c M src/plugins/mail-crypt/mail-crypt-acl-plugin.c M src/plugins/mail-crypt/mail-crypt-key.c M src/plugins/mail-crypt/test-mail-key.c M src/plugins/pop3-migration/pop3-migration-plugin.c M src/plugins/push-notification/push-notification-driver-ox.c M src/plugins/push-notification/push-notification-event-mailboxcreate.c M src/plugins/quota/quota-count.c M src/plugins/quota/quota.c M src/pop3/pop3-client.c M src/pop3/pop3-commands.c Log Message: ----------- global: Log internal storage error on failure Compare: https://github.com/dovecot/core/compare/b8596c89dd8b...bf7dc750b950 From noreply at github.com Thu Mar 23 14:30:10 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Mar 2017 07:30:10 -0700 Subject: [dovecot/core] 9e3841: var-expand-crypt: Fix base64 encoding Message-ID: <58d3dbf28d1c9_74b23fd5e836bc3c22593a@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9e38412ec12ae8dc4f67ade5b18c8b976de59bcb https://github.com/dovecot/core/commit/9e38412ec12ae8dc4f67ade5b18c8b976de59bcb Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/plugins/var-expand-crypt/var-expand-crypt-plugin.c Log Message: ----------- var-expand-crypt: Fix base64 encoding the break was missing, also removed confusing block. Commit: 439dab8f70cbf52cd5d82e5c3803d79e181b75f7 https://github.com/dovecot/core/commit/439dab8f70cbf52cd5d82e5c3803d79e181b75f7 Author: Aki Tuomi Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/plugins/var-expand-crypt/var-expand-crypt-plugin.c Log Message: ----------- var-expand-crypt: Remove pointless assigment It's never used Compare: https://github.com/dovecot/core/compare/bf7dc750b950...439dab8f70cb From noreply at github.com Fri Mar 24 01:30:10 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Mar 2017 18:30:10 -0700 Subject: [dovecot/core] f9dad5: pop3: Start autoexpunging only after client is dis... Message-ID: <58d476a25f779_64783ff1acd27c3c4608c@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f9dad58173067427f68fd67c3cdc7412c3efedba https://github.com/dovecot/core/commit/f9dad58173067427f68fd67c3cdc7412c3efedba Author: Timo Sirainen Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/pop3/pop3-client.c Log Message: ----------- pop3: Start autoexpunging only after client is disconnected Commit: 646817f0cfb39b0e0eb545900f1566b76a851b20 https://github.com/dovecot/core/commit/646817f0cfb39b0e0eb545900f1566b76a851b20 Author: Timo Sirainen Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/imap/imap-client.c M src/imap/main.c M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage-service.h M src/lib-storage/mail-user.c M src/lib-storage/mail-user.h M src/lmtp/commands.c M src/lmtp/main.c M src/pop3/main.c M src/pop3/pop3-client.c Log Message: ----------- lib-storage: Replace MAIL_STORAGE_SERVICE_FLAG_AUTOEXPUNGE with explicit mail_user_autoexpunge() This allows better control of which users are being autoexpunged. This patch changes behavior at least in two ways now: 1) After shared folder access, the owner user isn't autoexpunged at deinit. Although this is a bit questionable of whether it should be or not. 2) LMTP's quota check at RCPT TO stage doesn't trigger autoexpunging. Commit: 0c9dda2bad67db38d67d92d64839a14214f7d293 https://github.com/dovecot/core/commit/0c9dda2bad67db38d67d92d64839a14214f7d293 Author: Timo Sirainen Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lmtp/commands.c Log Message: ----------- lmtp: Trigger autoexpunging only for the last RCPT TO. Otherwise if the autoexpunging takes a long time, the LMTP client could disconnect due to a timeout. The mails would still eventually get delivered though, so it would result in duplicate mails being delivered. An alternative to this would be to keep all the mail_users referenced until the delivery is finished and then autoexpunge all of them at the end. It increases memory usage though and complicates the code, so at least for now it's not implemented. Commit: 8c0afac054fc783b1510c7839324302e8dc23643 https://github.com/dovecot/core/commit/8c0afac054fc783b1510c7839324302e8dc23643 Author: Timo Sirainen Date: 2017-03-23 (Thu, 23 Mar 2017) Changed paths: M src/lib-storage/mail-autoexpunge.c M src/lib-storage/mail-autoexpunge.h Log Message: ----------- lib-storage: Change mail_user_autoexpunge() to return number of autoexpunged mails Compare: https://github.com/dovecot/core/compare/439dab8f70cb...8c0afac054fc From noreply at github.com Fri Mar 24 02:30:09 2017 From: noreply at github.com (GitHub) Date: Thu, 23 Mar 2017 19:30:09 -0700 Subject: [dovecot/core] 7c3717: lib-storage: Fix mail_user_autoexpunge() return va... Message-ID: <58d484b1afc00_b3163f91870e7c2c6925d@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7c3717a05b919f4a50a9b39b6c1e8d383860a182 https://github.com/dovecot/core/commit/7c3717a05b919f4a50a9b39b6c1e8d383860a182 Author: Timo Sirainen Date: 2017-03-24 (Fri, 24 Mar 2017) Changed paths: M src/lib-storage/mail-autoexpunge.c Log Message: ----------- lib-storage: Fix mail_user_autoexpunge() return value to be initialized properly From noreply at github.com Fri Mar 24 12:04:44 2017 From: noreply at github.com (GitHub) Date: Fri, 24 Mar 2017 05:04:44 -0700 Subject: [dovecot/core] c4ec7c: imap-login: Move forward_fields updating code to l... Message-ID: <58d50b5c59a64_e783fcf85ab9c28115fb@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c4ec7cb598805b1387dc3aab59ec8f32d8cc24e1 https://github.com/dovecot/core/commit/c4ec7cb598805b1387dc3aab59ec8f32d8cc24e1 Author: Timo Sirainen Date: 2017-03-24 (Fri, 24 Mar 2017) Changed paths: M src/imap-login/imap-login-client.c M src/login-common/client-common.c M src/login-common/client-common.h Log Message: ----------- imap-login: Move forward_fields updating code to login-common This allows using the new client_add_forward_field() in e.g. plugins. From noreply at github.com Fri Mar 24 14:00:10 2017 From: noreply at github.com (GitHub) Date: Fri, 24 Mar 2017 07:00:10 -0700 Subject: [dovecot/core] 0c83df: ssl: change to more secure default ssl_cipher_list Message-ID: <58d5266ac3782_63073f900bb29c30724c9@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 0c83dfe6a877d636b1562da6be54674e3238dee3 https://github.com/dovecot/core/commit/0c83dfe6a877d636b1562da6be54674e3238dee3 Author: Martti Rannanj?rvi Date: 2017-03-24 (Fri, 24 Mar 2017) Changed paths: M doc/example-config/conf.d/10-ssl.conf M src/lib-master/master-service-ssl-settings.c Log Message: ----------- ssl: change to more secure default ssl_cipher_list Commit: d25aba3ff9ae3f4229586115b38f5524b04a3d4f https://github.com/dovecot/core/commit/d25aba3ff9ae3f4229586115b38f5524b04a3d4f Author: Martti Rannanj?rvi Date: 2017-03-24 (Fri, 24 Mar 2017) Changed paths: M doc/example-config/conf.d/10-ssl.conf Log Message: ----------- doc: remove obsolete ssl_dh_parameters_length from example config Commit: 519675ef367190665da4ddc02067f6178da283da https://github.com/dovecot/core/commit/519675ef367190665da4ddc02067f6178da283da Author: Martti Rannanj?rvi Date: 2017-03-24 (Fri, 24 Mar 2017) Changed paths: M doc/example-config/conf.d/10-ssl.conf Log Message: ----------- doc: mention no_ticket in ssl config example Commit: 7dd7e8ed41c2da4d76cc80597c253b9f0e75603b https://github.com/dovecot/core/commit/7dd7e8ed41c2da4d76cc80597c253b9f0e75603b Author: Martti Rannanj?rvi Date: 2017-03-24 (Fri, 24 Mar 2017) Changed paths: M doc/example-config/conf.d/10-ssl.conf M src/lib-master/master-service-ssl-settings.c Log Message: ----------- ssl: deprecate no_compression in ssl_options Compression is now disabled by default. Compare: https://github.com/dovecot/core/compare/c4ec7cb59880...7dd7e8ed41c2 From noreply at github.com Sat Mar 25 18:30:10 2017 From: noreply at github.com (GitHub) Date: Sat, 25 Mar 2017 11:30:10 -0700 Subject: [dovecot/core] 79454b: lib-mail: Fix read overflow / crash in message_hea... Message-ID: <58d6b732c66dc_6b923fbafc0b5c3850514@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 79454ba23ef6baf56997cd3cc23123eb69ae4f4c https://github.com/dovecot/core/commit/79454ba23ef6baf56997cd3cc23123eb69ae4f4c Author: Timo Sirainen Date: 2017-03-24 (Fri, 24 Mar 2017) Changed paths: M src/lib-mail/message-header-decode.c M src/lib-mail/test-message-header-decode.c Log Message: ----------- lib-mail: Fix read overflow / crash in message_header_decode() If the input string was "=?charset?Q|B?text?", the code attempted to look up the character after it. And if it was "=", the callback was called with size=-1, which ends up in a crash. From noreply at github.com Sun Mar 26 09:00:11 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Mar 2017 02:00:11 -0700 Subject: [dovecot/core] bd2a17: quota: Add backend register/unregister Message-ID: <58d7831bcabda_15e93fb323571c3091084@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: bd2a176b573f9679e7e45339c20ef71704f071c0 https://github.com/dovecot/core/commit/bd2a176b573f9679e7e45339c20ef71704f071c0 Author: Aki Tuomi Date: 2017-03-26 (Sun, 26 Mar 2017) Changed paths: M src/plugins/quota/quota-plugin.c M src/plugins/quota/quota-private.h M src/plugins/quota/quota.c Log Message: ----------- quota: Add backend register/unregister This way, other mail plugins can register their own quota backends. From noreply at github.com Sun Mar 26 16:30:11 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Mar 2017 09:30:11 -0700 Subject: [dovecot/core] 92cd92: imapc: Fail user creation if login to imapc_host f... Message-ID: <58d7ec93a8ebf_172f3fba6fcd1c34594f6@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 92cd929df2ebf3291886a11542b2815a426e906d https://github.com/dovecot/core/commit/92cd929df2ebf3291886a11542b2815a426e906d Author: Timo Sirainen Date: 2017-03-26 (Sun, 26 Mar 2017) Changed paths: M src/lib-storage/index/imapc/imapc-storage.c M src/lib-storage/index/imapc/imapc-storage.h Log Message: ----------- imapc: Fail user creation if login to imapc_host fails. This causes imapc to actually wait for the login to succeed or fail. Such a wait was already done by the imap code, which will be removed by the next patch. Commit: 3c902023723d178357b83d21cd03d418bc88482c https://github.com/dovecot/core/commit/3c902023723d178357b83d21cd03d418bc88482c Author: Timo Sirainen Date: 2017-03-26 (Sun, 26 Mar 2017) Changed paths: M src/imap/main.c Log Message: ----------- imap: Remove imapc-specific "is connection valid?" code This is now done by imapc itself in the previous patch Commit: 30871b77e627d3d6b244305fbea7aeee578f2927 https://github.com/dovecot/core/commit/30871b77e627d3d6b244305fbea7aeee578f2927 Author: Timo Sirainen Date: 2017-03-26 (Sun, 26 Mar 2017) Changed paths: M src/lib-storage/index/imapc/imapc-settings.c M src/lib-storage/index/imapc/imapc-settings.h M src/lib-storage/index/imapc/imapc-storage.c Log Message: ----------- imapc: Add imapc_features=delay-login The connection to imapc_host is delayed until it's actually needed to be performed. Compare: https://github.com/dovecot/core/compare/bd2a176b573f...30871b77e627 From noreply at github.com Sun Mar 26 18:30:09 2017 From: noreply at github.com (GitHub) Date: Sun, 26 Mar 2017 11:30:09 -0700 Subject: [dovecot/core] 561a21: lib-http: client: Fix aborting a request that has ... Message-ID: <58d808b1d0ee9_6be43f9b9a6a5c3c125330@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 561a21c8ecefaade916d686c763f2123e1f9a151 https://github.com/dovecot/core/commit/561a21c8ecefaade916d686c763f2123e1f9a151 Author: Stephan Bosch Date: 2017-03-26 (Sun, 26 Mar 2017) Changed paths: M src/lib-http/http-client-request.c M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Fix aborting a request that has a delayed error. Caused by recent changes in delayed error handling. From noreply at github.com Mon Mar 27 10:00:15 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Mar 2017 03:00:15 -0700 Subject: [dovecot/core] 077b35: lib-lda: smtp-client: Renamed "smtp_client" parame... Message-ID: <58d8e2af6697d_b5553fe238607c3c85487@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 077b350ebf3542424b31693ccc6f2fc7d4524f98 https://github.com/dovecot/core/commit/077b350ebf3542424b31693ccc6f2fc7d4524f98 Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-lda/smtp-client.c Log Message: ----------- lib-lda: smtp-client: Renamed "smtp_client" parameters to "client" for consistency. Commit: 14a37c403acfe3e7f040f1aab37f70a2b3cc1379 https://github.com/dovecot/core/commit/14a37c403acfe3e7f040f1aab37f70a2b3cc1379 Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-lda/smtp-client.c Log Message: ----------- lib-lda: smtp-client: Make sure only the first error determines the tempfail status. The client is supposed to stop running the moment the first error occurs. However, there is a (very unlikely) possiblity that the encapsulated LMTP client issues both an RCPT and DATA error callback in sequence. In that case, the second callback should not override the tempfail status of the first (the second likely is a tempfail). If the server disconnects right after failing the last of at least two recipients, the lmtp-client would issue a DATA callback with a disconnection error. The disconnect error would set the client->tempfail flag, which caused smtp_client_deinit*() to always return -1 in this scenario. Commit: a3a4c12c35a38fe5008fe2001fa73b5bb82e7371 https://github.com/dovecot/core/commit/a3a4c12c35a38fe5008fe2001fa73b5bb82e7371 Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-smtp/lmtp-client.c Log Message: ----------- lib-smtp: lmtp-client: Fixed bug in timeout handling. The timeout was erroneously stopped when lmtp_client_send() was invoked before a connection was established. Once the connection finally got established, the timeout was removed. This would cause the client to wait indefinitely. Commit: 17084e30a4a316ec2f3a765f5bb4936d65367493 https://github.com/dovecot/core/commit/17084e30a4a316ec2f3a765f5bb4936d65367493 Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-lda/smtp-client.c Log Message: ----------- lib-lda: smtp-client: Fixed cleanup of LMTP client at end of transaction. It was not deinitialized, causing a memory leak. Commit: e8a8ae03e6c87211d32eec10778a055119174b5b https://github.com/dovecot/core/commit/e8a8ae03e6c87211d32eec10778a055119174b5b Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-lda/smtp-client.c Log Message: ----------- lib-lda: smtp-client: Fixed memory leak of the error message string. Commit: 37f0284ba928733361c4ba77570e03883ea2dce1 https://github.com/dovecot/core/commit/37f0284ba928733361c4ba77570e03883ea2dce1 Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm.h Log Message: ----------- doveadm: Add exit code/string conversion functions Commit: 0a812a18bab1acfc42e84cb45b2cd99846a10332 https://github.com/dovecot/core/commit/0a812a18bab1acfc42e84cb45b2cd99846a10332 Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/doveadm/client-connection.c M src/doveadm/server-connection.c Log Message: ----------- doveadm: Send and receive exit codes correctly The old code would assume TEMPFAIL for almost everything. Commit: 07b307039b497a8acea6082a577544176b02b86e https://github.com/dovecot/core/commit/07b307039b497a8acea6082a577544176b02b86e Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: test-http-client-errors: Always use the proper error status code definitions rather than an integer literal. Commit: f6d2025b8039a12c09cdc3fd517e84b9cb54d3b9 https://github.com/dovecot/core/commit/f6d2025b8039a12c09cdc3fd517e84b9cb54d3b9 Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-http/http-client.h M src/lib-http/http-response.h Log Message: ----------- lib-http: Explicitly define the start of the range of internal response status codes. Commit: a474158382b6f33757116e0a349236b2617655db https://github.com/dovecot/core/commit/a474158382b6f33757116e0a349236b2617655db Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-http/http-response.h Log Message: ----------- lib-http: Added a function to obtain a message suitable for logging from a response object. This prevents logging internal error codes (>= 9000). Commit: 6da637fe37eb76ae2ace3a42bc0df45498ec8dce https://github.com/dovecot/core/commit/6da637fe37eb76ae2ace3a42bc0df45498ec8dce Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/auth/auth-policy.c M src/lib-http/http-client-connection.c M src/plugins/fts-solr/solr-connection.c M src/plugins/fts/fts-parser-tika.c M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- global: Use http_response_get_message() to log HTTP responses. Commit: 62852b807f32600d71425aedbf10eb84be8ce9fc https://github.com/dovecot/core/commit/62852b807f32600d71425aedbf10eb84be8ce9fc Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: test-http-client-errors: Added test for using https:// while SSL is not configured. Commit: 4d57187d09661340e1a01ea90a075c1346cdaff6 https://github.com/dovecot/core/commit/4d57187d09661340e1a01ea90a075c1346cdaff6 Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-http/http-client-request.c Log Message: ----------- lib-http: client: Clear request pointer immediately in http_client_request_error(). Commit: 7b846290fb429af258c0082384f30b1eb70a4828 https://github.com/dovecot/core/commit/7b846290fb429af258c0082384f30b1eb70a4828 Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-http/http-client-request.c M src/lib-http/http-client.c Log Message: ----------- lib-http: client: Restructured the handling of delayed errors. The req->delayed_error* fields are cleared before the callback is called and before the request is dereferenced. This way, freeing the request never removes it from the delayed request list when the list is being processed. It also makes it possible to resubmit the request from the callback (mainly for future use). Commit: 452cc7b2087431d505dad50ad1e0e5bc0faaac1a https://github.com/dovecot/core/commit/452cc7b2087431d505dad50ad1e0e5bc0faaac1a Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-http/http-client-request.c Log Message: ----------- lib-http: client: Make sure a request's log label never gets a duplicate request target part. Make sure the URL part of the label always only consists of a http://host:port part and nothing more. Commit: 06a7484862f3f911bd36911e4e533ca193699046 https://github.com/dovecot/core/commit/06a7484862f3f911bd36911e4e533ca193699046 Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-http/http-client-request.c M src/lib-http/http-client.h M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Implemented http_client_request_url_str() function that accepts an URL string rather than a pre-parsed URL object. If the provided HTTP URL is invalid, the callback with the error is called some time later from the ioloop. This change also amends the test-http-client-errors test suite with a new test for this new feature. Commit: 7c75172b93b1adb0a9e113dae92741325e8bf41f https://github.com/dovecot/core/commit/7c75172b93b1adb0a9e113dae92741325e8bf41f Author: Martti Rannanj?rvi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-fts/Makefile.am M src/lib/Makefile.am Log Message: ----------- lib: Download unicode.org files from dovecot.org Commit: 99b77f8e57396a1fcb45ba6163b48ab57d646d4e https://github.com/dovecot/core/commit/99b77f8e57396a1fcb45ba6163b48ab57d646d4e Author: Martti Rannanj?rvi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-storage/mailbox-list-private.h M src/lib-storage/mailbox-list.c M src/lib-storage/mailbox-list.h Log Message: ----------- lib-storage: Add mailbox_list_get_last_internal_error() This returns the error given to mailbox_list_set_critical(). Commit: 0e7af5e64e1c3ff9e8ed6940687d2fecb9a02e41 https://github.com/dovecot/core/commit/0e7af5e64e1c3ff9e8ed6940687d2fecb9a02e41 Author: Martti Rannanj?rvi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/doveadm/doveadm-mail-index.c M src/doveadm/doveadm-mail-mailbox.c M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-mailbox-list-iter.c M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c M src/doveadm/dsync/dsync-mailbox-tree-fill.c M src/imap/main.c M src/lib-imap-urlauth/imap-urlauth-backend.c M src/lib-storage/list/mailbox-list-index-backend.c M src/lib-storage/mail-autoexpunge.c M src/plugins/quota/quota-count.c M src/plugins/virtual/virtual-config.c M src/pop3/pop3-client.c Log Message: ----------- global: Log mailbox_list internal errors Commit: 08e468540bff9d538f7cbe1b8be6aa5f7d53bd7b https://github.com/dovecot/core/commit/08e468540bff9d538f7cbe1b8be6aa5f7d53bd7b Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-dict/Makefile.am A src/lib-dict/dict-fail.c M src/lib-dict/dict-private.h Log Message: ----------- lib-dict: Add dict-fail driver It can be used for providing various failures Commit: 9cce4519d6d71c5c0ac1814eb1c0ba75ef19133d https://github.com/dovecot/core/commit/9cce4519d6d71c5c0ac1814eb1c0ba75ef19133d Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-dict/dict.c Log Message: ----------- dict: Update correct counter in dict_iterate_init Commit: a0053e52a3d62322f8b630258f4ec7179c1e4e7e https://github.com/dovecot/core/commit/a0053e52a3d62322f8b630258f4ec7179c1e4e7e Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-dict/dict.c Log Message: ----------- lib-dict: Use dict-fail iterator and transaction when missing from dict driver Commit: 6440a342205737dbc3a9d5c88b32a500c7f54902 https://github.com/dovecot/core/commit/6440a342205737dbc3a9d5c88b32a500c7f54902 Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-dict/Makefile.am Log Message: ----------- lib-dict: Fix test-dict linkage Commit: 57906900c186c27941771874536c388019b69d33 https://github.com/dovecot/core/commit/57906900c186c27941771874536c388019b69d33 Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-dict/dict-private.h M src/lib-dict/dict.c Log Message: ----------- lib-dict: Track transaction counts Commit: 884394237744c0ab2da558e471a67dbe270f86ca https://github.com/dovecot/core/commit/884394237744c0ab2da558e471a67dbe270f86ca Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-dict/dict.c Log Message: ----------- lib-dict: Ensure all iterations and transactions are done in deinit Commit: 09b0bde688a00eaebb76f998b0f59d18296b0238 https://github.com/dovecot/core/commit/09b0bde688a00eaebb76f998b0f59d18296b0238 Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/plugins/acl/acl-mailbox-list.c Log Message: ----------- acl: Use mailbox_list_context instead of ctx->ctx This prepares for the next commit Commit: f9586610b32f9fa488f987cfe2c1c1208cb189b5 https://github.com/dovecot/core/commit/f9586610b32f9fa488f987cfe2c1c1208cb189b5 Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/plugins/acl/acl-mailbox-list.c Log Message: ----------- acl: Use MODULE_CONTEXT for mailbox list iterator Commit: e8878afb91d5247de037afffcdb3505ae1a81bfd https://github.com/dovecot/core/commit/e8878afb91d5247de037afffcdb3505ae1a81bfd Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-storage/list/mailbox-list-iter.c M src/lib-storage/mailbox-list-private.h Log Message: ----------- lib-storage: Expose mailbox_list_init_autocreate It is needed when backend_ctx is created on the fly Commit: 6f1f9bac6c909efda241ea929af5bd52e756abeb https://github.com/dovecot/core/commit/6f1f9bac6c909efda241ea929af5bd52e756abeb Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-storage/index/imapc/imapc-list.c M src/lib-storage/list/mailbox-list-fs-iter.c M src/lib-storage/list/mailbox-list-index-iter.c M src/lib-storage/list/mailbox-list-iter.c M src/lib-storage/list/mailbox-list-maildir-iter.c M src/lib-storage/list/mailbox-list-subscriptions.c M src/lib-storage/mailbox-list-private.h Log Message: ----------- lib-storage: Add and use default mailbox iterator The idea is to allow mail plugins to see also the non-existent autoboxes by feeding them thru the iterator. Fixes problem where autocreated boxes are not seen by ACL plugin. Commit: ff271fae9e12a424a3bce19cf0b23f64a434e383 https://github.com/dovecot/core/commit/ff271fae9e12a424a3bce19cf0b23f64a434e383 Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib/var-expand.c Log Message: ----------- lib: Fix whitespace in var-expand.c Compare: https://github.com/dovecot/core/compare/fcb3ccff65b4...ff271fae9e12 From noreply at github.com Mon Mar 27 10:30:14 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Mar 2017 03:30:14 -0700 Subject: [dovecot/core] 2dec37: dbox: Allow ":" separator between mail_attachment_... Message-ID: <58d8e9b6ad48c_6be43f9b9a6a5c3c1335b@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 2dec3731d6837dc40366643e3d3a6eb896b5ea44 https://github.com/dovecot/core/commit/2dec3731d6837dc40366643e3d3a6eb896b5ea44 Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-storage/index/dbox-common/dbox-storage.c Log Message: ----------- dbox: Allow ":" separator between mail_attachment_fs driver and args. The ":" separator is nowadays commonly used elsewhere for the separator, so it should work here as well. Commit: 42edee2d75292e639bfd5ef852203fa75fac9bbc https://github.com/dovecot/core/commit/42edee2d75292e639bfd5ef852203fa75fac9bbc Author: Martti Rannanj?rvi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/plugins/quota/quota-status.c M src/plugins/quota/quota-storage.c M src/plugins/quota/quota.c M src/plugins/quota/quota.h Log Message: ----------- quota: Introduce quota_alloc_result return type Commit: 9edefd429576dc07298d525f7d01feaa755642cd https://github.com/dovecot/core/commit/9edefd429576dc07298d525f7d01feaa755642cd Author: Martti Rannanj?rvi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/plugins/quota/quota-private.h M src/plugins/quota/quota.c M src/plugins/trash/trash-plugin.c Log Message: ----------- quota: Use quota_alloc_result in quota_settings.test_alloc Commit: 690f935be61409138e9cd700aff4b2fea9429c08 https://github.com/dovecot/core/commit/690f935be61409138e9cd700aff4b2fea9429c08 Author: Martti Rannanj?rvi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M doc/example-config/conf.d/90-quota.conf M src/plugins/quota/Makefile.am M src/plugins/quota/quota-private.h M src/plugins/quota/quota-status.c M src/plugins/quota/quota-storage.c M src/plugins/quota/quota.c M src/plugins/quota/quota.h Log Message: ----------- quota: Add quota_max_mail_size setting Commit: dcf7e4f93a2fbd31d17b4ac71bf8c611fc5d22ae https://github.com/dovecot/core/commit/dcf7e4f93a2fbd31d17b4ac71bf8c611fc5d22ae Author: Martti Rannanj?rvi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.c M src/lib-storage/mail-storage.h Log Message: ----------- lib-storage: Add mail_storage_get_last_internal_error() This returns the error given to mail_storage_set_critical(). Commit: 6732ce37da006744404e79c9fde312c10f7ac4cf https://github.com/dovecot/core/commit/6732ce37da006744404e79c9fde312c10f7ac4cf Author: Martti Rannanj?rvi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lmtp/commands.c Log Message: ----------- lmtp: Log internal error on STATUS_CHECK_OVER_QUOTA failure Commit: 5c556ef3aabed152516b23de04031e78f74f893b https://github.com/dovecot/core/commit/5c556ef3aabed152516b23de04031e78f74f893b Author: Martti Rannanj?rvi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/doveadm/doveadm-mail-altmove.c M src/doveadm/doveadm-mail-copymove.c M src/doveadm/doveadm-mail-deduplicate.c M src/doveadm/doveadm-mail-expunge.c M src/doveadm/doveadm-mail-fetch.c M src/doveadm/doveadm-mail-flags.c M src/doveadm/doveadm-mail-import.c M src/doveadm/doveadm-mail-index.c M src/doveadm/doveadm-mail-iter.c M src/doveadm/doveadm-mail-mailbox-metadata.c M src/doveadm/doveadm-mail-mailbox-status.c M src/doveadm/doveadm-mail-mailbox.c M src/doveadm/doveadm-mail-save.c M src/doveadm/doveadm-mail-search.c M src/doveadm/doveadm-mail.c M src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c M src/doveadm/dsync/dsync-brain-mailbox.c M src/doveadm/dsync/dsync-brain.c M src/doveadm/dsync/dsync-mailbox-export.c M src/doveadm/dsync/dsync-mailbox-import.c M src/doveadm/dsync/dsync-mailbox-tree-fill.c M src/imap/imap-state.c M src/indexer/master-connection.c M src/lda/main.c M src/lib-imap-urlauth/imap-urlauth-backend.c M src/lib-lda/mail-deliver.c M src/lib-storage/index/dbox-multi/mdbox-storage-rebuild.c M src/lib-storage/index/index-mailbox-size.c M src/lib-storage/mail-autoexpunge.c M src/lib-storage/mail-storage.c M src/lib-storage/mailbox-guid-cache.c M src/lmtp/commands.c M src/plugins/acl/doveadm-acl.c M src/plugins/fts-lucene/fts-backend-lucene.c M src/plugins/fts-lucene/lucene-wrapper.cc M src/plugins/fts/fts-api.c M src/plugins/fts/fts-build-mail.c M src/plugins/lazy-expunge/lazy-expunge-plugin.c M src/plugins/mail-crypt/doveadm-mail-crypt.c M src/plugins/mail-crypt/mail-crypt-acl-plugin.c M src/plugins/mail-crypt/mail-crypt-key.c M src/plugins/mail-crypt/test-mail-key.c M src/plugins/pop3-migration/pop3-migration-plugin.c M src/plugins/push-notification/push-notification-driver-ox.c M src/plugins/push-notification/push-notification-event-mailboxcreate.c M src/plugins/quota/quota-count.c M src/plugins/quota/quota.c M src/pop3/pop3-client.c M src/pop3/pop3-commands.c Log Message: ----------- global: Log internal storage error on failure Commit: b551e46cacdc52de740c532a257e86ba85060b41 https://github.com/dovecot/core/commit/b551e46cacdc52de740c532a257e86ba85060b41 Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/pop3/pop3-client.c Log Message: ----------- pop3: Start autoexpunging only after client is disconnected Commit: 70d00769d337bd4703b9e40bba7e75652892634b https://github.com/dovecot/core/commit/70d00769d337bd4703b9e40bba7e75652892634b Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/imap/imap-client.c M src/imap/main.c M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage-service.h M src/lib-storage/mail-user.c M src/lib-storage/mail-user.h M src/lmtp/commands.c M src/lmtp/main.c M src/pop3/main.c M src/pop3/pop3-client.c Log Message: ----------- lib-storage: Replace MAIL_STORAGE_SERVICE_FLAG_AUTOEXPUNGE with explicit mail_user_autoexpunge() This allows better control of which users are being autoexpunged. This patch changes behavior at least in two ways now: 1) After shared folder access, the owner user isn't autoexpunged at deinit. Although this is a bit questionable of whether it should be or not. 2) LMTP's quota check at RCPT TO stage doesn't trigger autoexpunging. Commit: bc72ba681ebc14b5e8384676dc6b74a0abd7840b https://github.com/dovecot/core/commit/bc72ba681ebc14b5e8384676dc6b74a0abd7840b Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lmtp/commands.c Log Message: ----------- lmtp: Trigger autoexpunging only for the last RCPT TO. Otherwise if the autoexpunging takes a long time, the LMTP client could disconnect due to a timeout. The mails would still eventually get delivered though, so it would result in duplicate mails being delivered. An alternative to this would be to keep all the mail_users referenced until the delivery is finished and then autoexpunge all of them at the end. It increases memory usage though and complicates the code, so at least for now it's not implemented. Commit: 35b5cca7a320676f82a8f5a185e4ea890740d44e https://github.com/dovecot/core/commit/35b5cca7a320676f82a8f5a185e4ea890740d44e Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-storage/mail-autoexpunge.c M src/lib-storage/mail-autoexpunge.h Log Message: ----------- lib-storage: Change mail_user_autoexpunge() to return number of autoexpunged mails Commit: a440c98a2e21f9571c54b6b11314315a562964d9 https://github.com/dovecot/core/commit/a440c98a2e21f9571c54b6b11314315a562964d9 Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-storage/mail-autoexpunge.c Log Message: ----------- lib-storage: Fix mail_user_autoexpunge() return value to be initialized properly Commit: 5f7ffdbe9f6bf4acea8558f88c06879fad1df1a5 https://github.com/dovecot/core/commit/5f7ffdbe9f6bf4acea8558f88c06879fad1df1a5 Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/imap-login/imap-login-client.c M src/login-common/client-common.c M src/login-common/client-common.h Log Message: ----------- imap-login: Move forward_fields updating code to login-common This allows using the new client_add_forward_field() in e.g. plugins. Commit: 26fde3e2171e414581ac2e8c6b40cdc06e56f615 https://github.com/dovecot/core/commit/26fde3e2171e414581ac2e8c6b40cdc06e56f615 Author: Martti Rannanj?rvi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M doc/example-config/conf.d/10-ssl.conf Log Message: ----------- doc: mention no_ticket in ssl config example Commit: dfabd74c045675a1bfc583f7fe0fab7868c789f9 https://github.com/dovecot/core/commit/dfabd74c045675a1bfc583f7fe0fab7868c789f9 Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-mail/message-header-decode.c M src/lib-mail/test-message-header-decode.c Log Message: ----------- lib-mail: Fix read overflow / crash in message_header_decode() If the input string was "=?charset?Q|B?text?", the code attempted to look up the character after it. And if it was "=", the callback was called with size=-1, which ends up in a crash. Commit: e1275ba7add8a8c849551fcba2e6f7511875d34a https://github.com/dovecot/core/commit/e1275ba7add8a8c849551fcba2e6f7511875d34a Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/plugins/quota/quota-plugin.c M src/plugins/quota/quota-private.h M src/plugins/quota/quota.c Log Message: ----------- quota: Add backend register/unregister This way, other mail plugins can register their own quota backends. Commit: a7b684786e67a00a44cf3e4950a437ae4c374de2 https://github.com/dovecot/core/commit/a7b684786e67a00a44cf3e4950a437ae4c374de2 Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-storage/index/imapc/imapc-storage.c M src/lib-storage/index/imapc/imapc-storage.h Log Message: ----------- imapc: Fail user creation if login to imapc_host fails. This causes imapc to actually wait for the login to succeed or fail. Such a wait was already done by the imap code, which will be removed by the next patch. Commit: c8e6aa69b7802fbd8f10475e7e359168c045374d https://github.com/dovecot/core/commit/c8e6aa69b7802fbd8f10475e7e359168c045374d Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/imap/main.c Log Message: ----------- imap: Remove imapc-specific "is connection valid?" code This is now done by imapc itself in the previous patch Commit: 772535ebc559b331101b436113899b407858290d https://github.com/dovecot/core/commit/772535ebc559b331101b436113899b407858290d Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-storage/index/imapc/imapc-settings.c M src/lib-storage/index/imapc/imapc-settings.h M src/lib-storage/index/imapc/imapc-storage.c Log Message: ----------- imapc: Add imapc_features=delay-login The connection to imapc_host is delayed until it's actually needed to be performed. Commit: c1b218cd6da5f6efcaedfad14e62c5710d254313 https://github.com/dovecot/core/commit/c1b218cd6da5f6efcaedfad14e62c5710d254313 Author: Stephan Bosch Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-http/http-client-request.c M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Fix aborting a request that has a delayed error. Caused by recent changes in delayed error handling. Compare: https://github.com/dovecot/core/compare/ff271fae9e12...c1b218cd6da5 From noreply at github.com Mon Mar 27 11:30:12 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Mar 2017 04:30:12 -0700 Subject: [dovecot/core] a8a5f2: cassandra: Fallback consistency fix - max retry in... Message-ID: <58d8f7c422273_7f6a3ffcff1e3c3c8550@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: a8a5f2f8ccc134dcc7b61ea48664c3381db4a1aa https://github.com/dovecot/core/commit/a8a5f2f8ccc134dcc7b61ea48664c3381db4a1aa Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Fallback consistency fix - max retry interval was set wrong The maximum msecs is _MAX_RETRY_MSECS, not _FIRST_RETRY_MSECS Commit: 2a24f3565c61cb429d1e428601f153ce53b8bae3 https://github.com/dovecot/core/commit/2a24f3565c61cb429d1e428601f153ce53b8bae3 Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Fallback consistency fix - it wasn't used permanently Because the "do I want to retry using primary consistency?" check was done using the first failure timestamp, after 60 seconds that check always returned TRUE. We should instead be checking the last timestamp for a query that was sent with the primary consistency. Compare: https://github.com/dovecot/core/compare/561a21c8ecef...2a24f3565c61 From noreply at github.com Mon Mar 27 12:30:09 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Mar 2017 05:30:09 -0700 Subject: [dovecot/core] c9712c: config: Don't stop the process due to idling. Message-ID: <58d905d1ab728_dc43f9441e07c24898d9@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c9712cd137b6d62e39513f74811d5b0197e25f17 https://github.com/dovecot/core/commit/c9712cd137b6d62e39513f74811d5b0197e25f17 Author: Timo Sirainen Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/config/config-settings.c Log Message: ----------- config: Don't stop the process due to idling. If the config process restarts, it also reloads configuration. We'd rather want the configuration reloads to always be explicit. From noreply at github.com Mon Mar 27 15:30:12 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Mar 2017 08:30:12 -0700 Subject: [dovecot/core] 6c51e3: lib-storage: Indicate mail is being autoexpunged Message-ID: <58d9300461075_bf93f9905163c341165a@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 6c51e3c3dc8dc5dc6fef2280b7c2c9ebef3de8f0 https://github.com/dovecot/core/commit/6c51e3c3dc8dc5dc6fef2280b7c2c9ebef3de8f0 Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib-storage/mail-autoexpunge.c M src/lib-storage/mail-storage-private.h M src/lib-storage/mail.c Log Message: ----------- lib-storage: Indicate mail is being autoexpunged This way plugins, such as mail_log, can detect this. Commit: 7f3fe26555d38209e4072eaee4ac56e912733c25 https://github.com/dovecot/core/commit/7f3fe26555d38209e4072eaee4ac56e912733c25 Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/plugins/mail-log/mail-log-plugin.c Log Message: ----------- mail-log: Differentiate autoexpunges from expunges Compare: https://github.com/dovecot/core/compare/c9712cd137b6...7f3fe26555d3 From noreply at github.com Mon Mar 27 16:00:11 2017 From: noreply at github.com (GitHub) Date: Mon, 27 Mar 2017 09:00:11 -0700 Subject: [dovecot/core] 7c6818: lib: Add uuid support to guid Message-ID: <58d9370b3e88_61543f9e54dbbc301159da@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7c681809344b880aae61e99b6ab74ae19945ff9e https://github.com/dovecot/core/commit/7c681809344b880aae61e99b6ab74ae19945ff9e Author: Aki Tuomi Date: 2017-03-27 (Mon, 27 Mar 2017) Changed paths: M src/lib/guid.c M src/lib/guid.h M src/lib/test-guid.c Log Message: ----------- lib: Add uuid support to guid From noreply at github.com Wed Mar 29 17:00:11 2017 From: noreply at github.com (GitHub) Date: Wed, 29 Mar 2017 07:00:11 -0700 Subject: [dovecot/core] 257111: auth: Mark username changed if it's changes in aut... Message-ID: <58dbbdebad0cc_23e53fe7204e7c34656e5@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 257111a99add076b74612b5f0b4158efa0d84450 https://github.com/dovecot/core/commit/257111a99add076b74612b5f0b4158efa0d84450 Author: Aki Tuomi Date: 2017-03-29 (Wed, 29 Mar 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Mark username changed if it's changes in auth_request_try_update_username It was forgotten in by 865a82c1 Commit: d56b6dfe677ce154f94034ced1220d23e30bef2e https://github.com/dovecot/core/commit/d56b6dfe677ce154f94034ced1220d23e30bef2e Author: Aki Tuomi Date: 2017-03-29 (Wed, 29 Mar 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Do not cache username unless it was changed by lookup This could've caused usernames to be unexpectedly changed because they were cached by a lookup that did not include username in the cache key. Compare: https://github.com/dovecot/core/compare/7c681809344b...d56b6dfe677c From noreply at github.com Wed Mar 29 21:00:11 2017 From: noreply at github.com (GitHub) Date: Wed, 29 Mar 2017 11:00:11 -0700 Subject: [dovecot/core] 501258: lib-dict: Keep a linked list of all transactions i... Message-ID: <58dbf62b357b7_56ef3f9fd764bc3c83081@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 5012586ed3a75857ced48302bf0b8a8dc049796a https://github.com/dovecot/core/commit/5012586ed3a75857ced48302bf0b8a8dc049796a Author: Timo Sirainen Date: 2017-03-29 (Wed, 29 Mar 2017) Changed paths: M src/lib-dict/dict-private.h M src/lib-dict/dict.c Log Message: ----------- lib-dict: Keep a linked list of all transactions in dict. This helps debugging if a transaction is leaked. Commit: acfeae4e2b5c2acdab88a1377ff6cd4a9b5f0a3a https://github.com/dovecot/core/commit/acfeae4e2b5c2acdab88a1377ff6cd4a9b5f0a3a Author: Timo Sirainen Date: 2017-03-29 (Wed, 29 Mar 2017) Changed paths: M src/lib-storage/index/index-transaction.c Log Message: ----------- lib-storage: Fix potential dict transaction leak on transaction rollback. Commit: f6aa54d259b34ab746363334fb31d32fb499e76c https://github.com/dovecot/core/commit/f6aa54d259b34ab746363334fb31d32fb499e76c Author: Timo Sirainen Date: 2017-03-29 (Wed, 29 Mar 2017) Changed paths: M src/doveadm/doveadm-dump-log.c Log Message: ----------- doveadm dump log: Use istream for reading the file. Cleans up the code a bit and removes the 1MB record limit. Commit: fb83662d364aaee5b2f7c2fcc4d33d531f81f1a2 https://github.com/dovecot/core/commit/fb83662d364aaee5b2f7c2fcc4d33d531f81f1a2 Author: Timo Sirainen Date: 2017-03-29 (Wed, 29 Mar 2017) Changed paths: M src/doveadm/doveadm-dump-log.c Log Message: ----------- doveadm dump log: Cleanup - don't change hdr.size Needed by the next commit. Commit: 5bbc21995d38b67cf4223814910e5224170230fa https://github.com/dovecot/core/commit/5bbc21995d38b67cf4223814910e5224170230fa Author: Timo Sirainen Date: 2017-03-29 (Wed, 29 Mar 2017) Changed paths: M src/doveadm/doveadm-dump-log.c Log Message: ----------- doveadm dump log: Use shared lib-index code for updating modseq When MAIL_TRANSACTION_MODSEQ_UPDATE records were seen, the printed modseqs afterwards weren't correct. Now that mail_transaction_update_modseq() is used, we don't need to keep this code synchronized with it. Compare: https://github.com/dovecot/core/compare/d56b6dfe677c...5bbc21995d38 From noreply at github.com Thu Mar 30 09:30:09 2017 From: noreply at github.com (GitHub) Date: Wed, 29 Mar 2017 23:30:09 -0700 Subject: [dovecot/core] 939f75: master: When logging fork() EAGAIN failure, includ... Message-ID: <58dca5f111f0_2c57f3fcc5e631c3461730@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 939f758ca239c53a60dae89e70ccdecd92072c5b https://github.com/dovecot/core/commit/939f758ca239c53a60dae89e70ccdecd92072c5b Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/master/service-process.c Log Message: ----------- master: When logging fork() EAGAIN failure, include current ulimit -u value From noreply at github.com Thu Mar 30 20:00:10 2017 From: noreply at github.com (GitHub) Date: Thu, 30 Mar 2017 10:00:10 -0700 Subject: [dovecot/core] b3abfd: director: Log vhost count changes and HOST-UP/DOWN Message-ID: <58dd399a2cbe7_e173fafa7a2dc447372@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b3abfd0ac256ffa0cbfd74c3793eac4e83d41f78 https://github.com/dovecot/core/commit/b3abfd0ac256ffa0cbfd74c3793eac4e83d41f78 Author: Martti Rannanj?rvi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/director/director-connection.c M src/director/doveadm-connection.c M src/director/mail-host.c M src/director/mail-host.h Log Message: ----------- director: Log vhost count changes and HOST-UP/DOWN From noreply at github.com Thu Mar 30 20:30:10 2017 From: noreply at github.com (GitHub) Date: Thu, 30 Mar 2017 10:30:10 -0700 Subject: [dovecot/core] 620ddd: push-notification-driver-ox: Wait for http request... Message-ID: <58dd40a2a8bc_3a643fd7a2fc5c388337e@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 620ddd4ab772dad26afc439745cbcb2944139b9a https://github.com/dovecot/core/commit/620ddd4ab772dad26afc439745cbcb2944139b9a Author: Martti Rannanj?rvi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- push-notification-driver-ox: Wait for http requests to finish in deinit This is to make sure mail_user is still usable in http response callback. Commit: 01aca4a521410be85e1f39e37c662435d052f48a https://github.com/dovecot/core/commit/01aca4a521410be85e1f39e37c662435d052f48a Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- driver-cassandra: Add metric for slow queries Compare: https://github.com/dovecot/core/compare/b3abfd0ac256...01aca4a52141 From noreply at github.com Thu Mar 30 21:00:10 2017 From: noreply at github.com (GitHub) Date: Thu, 30 Mar 2017 11:00:10 -0700 Subject: [dovecot/core] 293586: test: lib: Check o_stream_send return value Message-ID: <58dd47aa3641e_2c8dd3fac51a87c3448963@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2935863763d8655c2c23e52591f2cbfff54811a6 https://github.com/dovecot/core/commit/2935863763d8655c2c23e52591f2cbfff54811a6 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib/test-ostream-escaped.c Log Message: ----------- test: lib: Check o_stream_send return value Make static analyzers happier Commit: b75580cbe5e17597beb2a02b4b9caf9fdf6fdfd8 https://github.com/dovecot/core/commit/b75580cbe5e17597beb2a02b4b9caf9fdf6fdfd8 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-http/test-http-server.c Log Message: ----------- test: lib-http: Check o_stream_send return value Makes static analyzers happier Commit: b261fc7c4fa222748c8c4e401d925d32e0d86041 https://github.com/dovecot/core/commit/b261fc7c4fa222748c8c4e401d925d32e0d86041 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/plugins/mail-crypt/test-mail-key.c Log Message: ----------- test: mail-crypt: Check dcrypt_id_key_private_old return value Makes static analyzers happier Commit: 5c97732871842800816aea0215c56bf701f623a6 https://github.com/dovecot/core/commit/5c97732871842800816aea0215c56bf701f623a6 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-fts/test-fts-tokenizer.c Log Message: ----------- test: lib-fts: Ignore uni_utf8_get_valid_data return value Makes static analyzers happier Commit: c34bdea0d736047ba7bbc835baf4126ea78d5da7 https://github.com/dovecot/core/commit/c34bdea0d736047ba7bbc835baf4126ea78d5da7 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib/test-iostream-proxy.c Log Message: ----------- test: lib: Check o_stream_flush return value in proxy test Makes static analyzers happier Commit: 24c5bcb933f82becfb24aa5bd76f040cca2eca3f https://github.com/dovecot/core/commit/24c5bcb933f82becfb24aa5bd76f040cca2eca3f Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-program-client/test-program-client-net.c Log Message: ----------- test: lib-program-client: Ignore some return values in test server Makes static analyzers happier Commit: 9f99d5a1b52247efcfd9688e830c861f92608cca https://github.com/dovecot/core/commit/9f99d5a1b52247efcfd9688e830c861f92608cca Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-program-client/test-program-client-unix.c Log Message: ----------- test: lib-program-client: Use i_close_fd instead of close Commit: 50e44da76293529a86fd61b40fa06d9dde98e4a8 https://github.com/dovecot/core/commit/50e44da76293529a86fd61b40fa06d9dde98e4a8 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib/test-priorityq.c Log Message: ----------- test: lib: Ensure item is not null Makes static analyzers happier Commit: 108bb19d23b091ce2a025660a1d2ffcdb90a2d19 https://github.com/dovecot/core/commit/108bb19d23b091ce2a025660a1d2ffcdb90a2d19 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-index/test-mail-index-transaction-finish.c Log Message: ----------- test: lib-index: Ensure conficts_seqs is created in test Makes static analyzers happier Commit: ab9be857a5ae00ac114ce00815509676ef972787 https://github.com/dovecot/core/commit/ab9be857a5ae00ac114ce00815509676ef972787 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/plugins/fts-squat/squat-test.c Log Message: ----------- test: fts-squat: Ignore gettimeofday return value in test Makes static analyzers happier Commit: ea0bf787109249074f9ceb0d68fb1bd3554e987f https://github.com/dovecot/core/commit/ea0bf787109249074f9ceb0d68fb1bd3554e987f Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-http/test-http-client.c Log Message: ----------- test: lib-http: Check write_full return value in test Makes static analyzers happier Commit: 820c323f80426fbd288358f885ac0cfe5a30db59 https://github.com/dovecot/core/commit/820c323f80426fbd288358f885ac0cfe5a30db59 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/plugins/var-expand-crypt/var-expand-crypt-plugin.c Log Message: ----------- var-expand-crypt: Do not free dcrypt context twice Found by coverity Commit: 5d2c15eaba4920cb6556be2c735fdb3f79655aba https://github.com/dovecot/core/commit/5d2c15eaba4920cb6556be2c735fdb3f79655aba Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/plugins/var-expand-crypt/var-expand-crypt-plugin.c Log Message: ----------- var-expand-crypt: Add error handling for initialization Commit: e8d8cff110f7a194c18abda75a07e9f15bc9fa44 https://github.com/dovecot/core/commit/e8d8cff110f7a194c18abda75a07e9f15bc9fa44 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/plugins/var-expand-crypt/var-expand-crypt-plugin.c Log Message: ----------- var-expand-crypt: Fix data decryption Commit: 205f29a013ee4aa95e9be993ebf261a9d9bc251b https://github.com/dovecot/core/commit/205f29a013ee4aa95e9be993ebf261a9d9bc251b Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/plugins/var-expand-crypt/Makefile.am A src/plugins/var-expand-crypt/test-var-expand-crypt.c Log Message: ----------- var-expand-crypt-plugin: Add test suite Compare: https://github.com/dovecot/core/compare/01aca4a52141...205f29a013ee From noreply at github.com Thu Mar 30 21:00:16 2017 From: noreply at github.com (GitHub) Date: Thu, 30 Mar 2017 11:00:16 -0700 Subject: [dovecot/core] 87c3d6: cassandra: Fallback consistency fix - max retry in... Message-ID: <58dd47b02e2ef_2ce473fd14201fc2c884ca@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 87c3d632c4050d28f6fb2707a73982cca235e62e https://github.com/dovecot/core/commit/87c3d632c4050d28f6fb2707a73982cca235e62e Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Fallback consistency fix - max retry interval was set wrong The maximum msecs is _MAX_RETRY_MSECS, not _FIRST_RETRY_MSECS Commit: 454f3876bff0c876b3992913b9c12149a625fb87 https://github.com/dovecot/core/commit/454f3876bff0c876b3992913b9c12149a625fb87 Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Fallback consistency fix - it wasn't used permanently Because the "do I want to retry using primary consistency?" check was done using the first failure timestamp, after 60 seconds that check always returned TRUE. We should instead be checking the last timestamp for a query that was sent with the primary consistency. Commit: 1fdc2de588c78e9e249eef04fb98c0172ae5d83d https://github.com/dovecot/core/commit/1fdc2de588c78e9e249eef04fb98c0172ae5d83d Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/config/config-settings.c Log Message: ----------- config: Don't stop the process due to idling. If the config process restarts, it also reloads configuration. We'd rather want the configuration reloads to always be explicit. Commit: ee4ce072d799cb9d3ef115875350dce4b5d9e8dc https://github.com/dovecot/core/commit/ee4ce072d799cb9d3ef115875350dce4b5d9e8dc Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-storage/mail-autoexpunge.c M src/lib-storage/mail-storage-private.h M src/lib-storage/mail.c Log Message: ----------- lib-storage: Indicate mail is being autoexpunged This way plugins, such as mail_log, can detect this. Commit: 28cdaf64379e761fa8a58e173e4f783da1b56f63 https://github.com/dovecot/core/commit/28cdaf64379e761fa8a58e173e4f783da1b56f63 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/plugins/mail-log/mail-log-plugin.c Log Message: ----------- mail-log: Differentiate autoexpunges from expunges Commit: 5f2a6395a50314aacf3f757fa3751e61568dd87c https://github.com/dovecot/core/commit/5f2a6395a50314aacf3f757fa3751e61568dd87c Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib/guid.c M src/lib/guid.h M src/lib/test-guid.c Log Message: ----------- lib: Add uuid support to guid Commit: b0fcc4f492c7b3151abb6c57b661b18009f889c0 https://github.com/dovecot/core/commit/b0fcc4f492c7b3151abb6c57b661b18009f889c0 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Mark username changed if it's changes in auth_request_try_update_username It was forgotten in by 865a82c1 Commit: c2bdba68268556cc7c3d0fdd05a0454ad6d4639d https://github.com/dovecot/core/commit/c2bdba68268556cc7c3d0fdd05a0454ad6d4639d Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Do not cache username unless it was changed by lookup This could've caused usernames to be unexpectedly changed because they were cached by a lookup that did not include username in the cache key. Commit: 90927c83cd54c682d887e22276c497d2faf1e49a https://github.com/dovecot/core/commit/90927c83cd54c682d887e22276c497d2faf1e49a Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-dict/dict-private.h M src/lib-dict/dict.c Log Message: ----------- lib-dict: Keep a linked list of all transactions in dict. This helps debugging if a transaction is leaked. Commit: d6baf552a85470661a1886fbdf2c82cbe27a06c5 https://github.com/dovecot/core/commit/d6baf552a85470661a1886fbdf2c82cbe27a06c5 Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-storage/index/index-transaction.c Log Message: ----------- lib-storage: Fix potential dict transaction leak on transaction rollback. Commit: 8dca8b41ce00eecc0204f709f0bb2836f8d7f6e6 https://github.com/dovecot/core/commit/8dca8b41ce00eecc0204f709f0bb2836f8d7f6e6 Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/doveadm/doveadm-dump-log.c Log Message: ----------- doveadm dump log: Use istream for reading the file. Cleans up the code a bit and removes the 1MB record limit. Commit: d49124818069c447d9a640774e0d558e0a2539ab https://github.com/dovecot/core/commit/d49124818069c447d9a640774e0d558e0a2539ab Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/doveadm/doveadm-dump-log.c Log Message: ----------- doveadm dump log: Cleanup - don't change hdr.size Needed by the next commit. Commit: 6c6fe8d884c8ba69af5abc28adacea81f0027af6 https://github.com/dovecot/core/commit/6c6fe8d884c8ba69af5abc28adacea81f0027af6 Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/doveadm/doveadm-dump-log.c Log Message: ----------- doveadm dump log: Use shared lib-index code for updating modseq When MAIL_TRANSACTION_MODSEQ_UPDATE records were seen, the printed modseqs afterwards weren't correct. Now that mail_transaction_update_modseq() is used, we don't need to keep this code synchronized with it. Commit: ac37a92a9314f80d96237122a2c6b404093909ee https://github.com/dovecot/core/commit/ac37a92a9314f80d96237122a2c6b404093909ee Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/master/service-process.c Log Message: ----------- master: When logging fork() EAGAIN failure, include current ulimit -u value Commit: 276dedbc72e9e8755d9b79b4d846be90ba0682b5 https://github.com/dovecot/core/commit/276dedbc72e9e8755d9b79b4d846be90ba0682b5 Author: Martti Rannanj?rvi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/director/director-connection.c M src/director/doveadm-connection.c M src/director/mail-host.c M src/director/mail-host.h Log Message: ----------- director: Log vhost count changes and HOST-UP/DOWN Commit: b4820284ae0d5f07c5a88ac256580f175ae3557e https://github.com/dovecot/core/commit/b4820284ae0d5f07c5a88ac256580f175ae3557e Author: Martti Rannanj?rvi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- push-notification-driver-ox: Wait for http requests to finish in deinit This is to make sure mail_user is still usable in http response callback. Commit: d2cda64e7ab14ba1eb216315b16557c6905927fd https://github.com/dovecot/core/commit/d2cda64e7ab14ba1eb216315b16557c6905927fd Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- driver-cassandra: Add metric for slow queries Commit: f76d3786a74496476c2db402f324e439abee99d3 https://github.com/dovecot/core/commit/f76d3786a74496476c2db402f324e439abee99d3 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib/test-ostream-escaped.c Log Message: ----------- test: lib: Check o_stream_send return value Make static analyzers happier Commit: 63bc80a8e50327329554eb17605882253f21680b https://github.com/dovecot/core/commit/63bc80a8e50327329554eb17605882253f21680b Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-http/test-http-server.c Log Message: ----------- test: lib-http: Check o_stream_send return value Makes static analyzers happier Commit: dc50da71ba181a5f524fd40cfdbdf857fc0837dc https://github.com/dovecot/core/commit/dc50da71ba181a5f524fd40cfdbdf857fc0837dc Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/plugins/mail-crypt/test-mail-key.c Log Message: ----------- test: mail-crypt: Check dcrypt_id_key_private_old return value Makes static analyzers happier Commit: 3c269a88e10869c8610dd29e8f9a8e37111d038b https://github.com/dovecot/core/commit/3c269a88e10869c8610dd29e8f9a8e37111d038b Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-fts/test-fts-tokenizer.c Log Message: ----------- test: lib-fts: Ignore uni_utf8_get_valid_data return value Makes static analyzers happier Commit: df6396438c58587ebb34e2100c2de041843e902b https://github.com/dovecot/core/commit/df6396438c58587ebb34e2100c2de041843e902b Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib/test-priorityq.c Log Message: ----------- test: lib: Ensure item is not null Makes static analyzers happier Commit: f5132aa882f0773d2227d75bd0cc3228b584602d https://github.com/dovecot/core/commit/f5132aa882f0773d2227d75bd0cc3228b584602d Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-index/test-mail-index-transaction-finish.c Log Message: ----------- test: lib-index: Ensure conficts_seqs is created in test Makes static analyzers happier Commit: b64df825306071ed0948e845a56d5d0f27281833 https://github.com/dovecot/core/commit/b64df825306071ed0948e845a56d5d0f27281833 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/plugins/fts-squat/squat-test.c Log Message: ----------- test: fts-squat: Ignore gettimeofday return value in test Makes static analyzers happier Commit: 1389da1b90ffce05497b10dbb9423e81c7a0dec7 https://github.com/dovecot/core/commit/1389da1b90ffce05497b10dbb9423e81c7a0dec7 Author: Aki Tuomi Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-http/test-http-client.c Log Message: ----------- test: lib-http: Check write_full return value in test Makes static analyzers happier Compare: https://github.com/dovecot/core/compare/c1b218cd6da5...1389da1b90ff From noreply at github.com Thu Mar 30 21:30:09 2017 From: noreply at github.com (GitHub) Date: Thu, 30 Mar 2017 11:30:09 -0700 Subject: [dovecot/core] c85dd5: lib-index: Code cleanup - expand LOG_WANT_ROTATE()... Message-ID: <58dd4eb1a15bc_61ab3fdfce989c2874323@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c85dd5fbf419770eb0728267df151edcaa3da4b9 https://github.com/dovecot/core/commit/c85dd5fbf419770eb0728267df151edcaa3da4b9 Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-index/mail-transaction-log.c Log Message: ----------- lib-index: Code cleanup - expand LOG_WANT_ROTATE() macro There was no reason it had to be a macro. Also this fixes off-by-one error when checking for log_rotate_min_size. Commit: 27a33f6aaa3d02d88c020315ae613e0c4910e950 https://github.com/dovecot/core/commit/27a33f6aaa3d02d88c020315ae613e0c4910e950 Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib/test-time-util.c M src/lib/time-util.c M src/lib/time-util.h Log Message: ----------- lib: Add time_to_local_day_start() Commit: 55ef2c46b1bc8273be59d8238c92c832d52e2134 https://github.com/dovecot/core/commit/55ef2c46b1bc8273be59d8238c92c832d52e2134 Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-index/mail-index-transaction-update.c Log Message: ----------- lib-index: Use time_to_local_day_start() instead of reimplementing Compare: https://github.com/dovecot/core/compare/205f29a013ee...55ef2c46b1bc From noreply at github.com Thu Mar 30 21:30:14 2017 From: noreply at github.com (GitHub) Date: Thu, 30 Mar 2017 11:30:14 -0700 Subject: [dovecot/core] 6129bb: lib-index: Code cleanup - expand LOG_WANT_ROTATE()... Message-ID: <58dd4eb6516d4_10153fd13ce01c381111c7@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 6129bb326dde9c0619f0a5f3b99f1484885831b6 https://github.com/dovecot/core/commit/6129bb326dde9c0619f0a5f3b99f1484885831b6 Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-index/mail-transaction-log.c Log Message: ----------- lib-index: Code cleanup - expand LOG_WANT_ROTATE() macro There was no reason it had to be a macro. Also this fixes off-by-one error when checking for log_rotate_min_size. Commit: 6d9227e1c69126e138add851b3d8545b1932e824 https://github.com/dovecot/core/commit/6d9227e1c69126e138add851b3d8545b1932e824 Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib/test-time-util.c M src/lib/time-util.c M src/lib/time-util.h Log Message: ----------- lib: Add time_to_local_day_start() Commit: 4f67426cdf80531e24353a0ac192310c873786f3 https://github.com/dovecot/core/commit/4f67426cdf80531e24353a0ac192310c873786f3 Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-index/mail-index-transaction-update.c Log Message: ----------- lib-index: Use time_to_local_day_start() instead of reimplementing Compare: https://github.com/dovecot/core/compare/1389da1b90ff...4f67426cdf80 From noreply at github.com Fri Mar 31 00:00:09 2017 From: noreply at github.com (GitHub) Date: Thu, 30 Mar 2017 14:00:09 -0700 Subject: [dovecot/core] 210256: lib-http: client: Fixed request-specific attempt t... Message-ID: <58dd71d9d1a4c_3dbd3fb446651c30423a2@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 210256b5d443a13a9ea662cd3a807b80bdeff331 https://github.com/dovecot/core/commit/210256b5d443a13a9ea662cd3a807b80bdeff331 Author: Stephan Bosch Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-http/http-client-connection.c M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Fixed request-specific attempt timeout. This is the timeout applied to a single request attempt. Using http_client_request_set_attempt_timeout_msecs() this can be set for a specific request. However, this was mostly ignored for requests that weren't in the process of handling response payload. Instead, the global request_timeout_msecs client setting was used. Also amended the (currently manual) test suite with tests that demonstated the problem and now verify the fix. From noreply at github.com Fri Mar 31 00:00:14 2017 From: noreply at github.com (GitHub) Date: Thu, 30 Mar 2017 14:00:14 -0700 Subject: [dovecot/core] 34c9ae: lib-http: client: Fixed request-specific attempt t... Message-ID: <58dd71de37047_37253fe276eadc2c1131c8@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 34c9aed77f78bc50a4eb609049578bd7e76fd4b6 https://github.com/dovecot/core/commit/34c9aed77f78bc50a4eb609049578bd7e76fd4b6 Author: Stephan Bosch Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-http/http-client-connection.c M src/lib-http/test-http-client-errors.c Log Message: ----------- lib-http: client: Fixed request-specific attempt timeout. This is the timeout applied to a single request attempt. Using http_client_request_set_attempt_timeout_msecs() this can be set for a specific request. However, this was mostly ignored for requests that weren't in the process of handling response payload. Instead, the global request_timeout_msecs client setting was used. Also amended the (currently manual) test suite with tests that demonstated the problem and now verify the fix. From noreply at github.com Fri Mar 31 01:00:10 2017 From: noreply at github.com (GitHub) Date: Thu, 30 Mar 2017 15:00:10 -0700 Subject: [dovecot/core] eed02e: lib-http: http_client_request_delay_from_response(... Message-ID: <58dd7feae9d63_2c57f3fcc5e631c3486513@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: eed02e3be957727e44afac3c20ab64ed80cc8644 https://github.com/dovecot/core/commit/eed02e3be957727e44afac3c20ab64ed80cc8644 Author: Timo Sirainen Date: 2017-03-30 (Thu, 30 Mar 2017) Changed paths: M src/lib-http/http-client-request.c Log Message: ----------- lib-http: http_client_request_delay_from_response() should use per-request timeout as max It was using the global request_timeout_msecs for the maximum timeout, which could be different from the per-request timeout set by http_client_request_set_attempt_timeout_msecs(). From noreply at github.com Fri Mar 31 01:00:15 2017 From: noreply at github.com (GitHub) Date: Thu, 30 Mar 2017 15:00:15 -0700 Subject: [dovecot/core] b74e23: lib-http: http_client_request_delay_from_response(... Message-ID: <58dd7fef3e8f7_2ed53fd0243c7c2c591186@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: b74e236675217f32b1d3980f00ccf3a5a8389219 https://github.com/dovecot/core/commit/b74e236675217f32b1d3980f00ccf3a5a8389219 Author: Timo Sirainen Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/lib-http/http-client-request.c Log Message: ----------- lib-http: http_client_request_delay_from_response() should use per-request timeout as max It was using the global request_timeout_msecs for the maximum timeout, which could be different from the per-request timeout set by http_client_request_set_attempt_timeout_msecs(). From noreply at github.com Fri Mar 31 10:00:10 2017 From: noreply at github.com (GitHub) Date: Fri, 31 Mar 2017 00:00:10 -0700 Subject: [dovecot/core] 01c791: imap: Fix assert-crash when hibernation triggers d... Message-ID: <58ddfe7a874ee_31823ff66053dc349306e@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 01c7913d4b30695b4a808e47d0402eacfd4873fc https://github.com/dovecot/core/commit/01c7913d4b30695b4a808e47d0402eacfd4873fc Author: Timo Sirainen Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/imap/cmd-idle.c Log Message: ----------- imap: Fix assert-crash when hibernation triggers during IDLE syncing Fixes: Panic: file cmd-idle.c: line 182 (idle_hibernate_timeout): assertion failed: (ctx->sync_ctx == NULL) Commit: b1e097e04ceff5800101ec3615f815f2d0f2fd12 https://github.com/dovecot/core/commit/b1e097e04ceff5800101ec3615f815f2d0f2fd12 Author: Timo Sirainen Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/plugins/acl/acl-backend.c M src/plugins/quota/quota.c Log Message: ----------- quota, acl: Use mail_user_plugin_getenv_bool() for boolean settings These were forgotten earlier. Compare: https://github.com/dovecot/core/compare/eed02e3be957...b1e097e04cef From noreply at github.com Fri Mar 31 14:30:13 2017 From: noreply at github.com (GitHub) Date: Fri, 31 Mar 2017 04:30:13 -0700 Subject: [dovecot/core] 031450: lib: Use error_r in var_expand_long and friends Message-ID: <58de3dc5840b4_28ed3f8a18e8fc2452169@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 0314505e538c0f287c82abdcd3e91e972ada0c6a https://github.com/dovecot/core/commit/0314505e538c0f287c82abdcd3e91e972ada0c6a Author: Aki Tuomi Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/lib/var-expand.c Log Message: ----------- lib: Use error_r in var_expand_long and friends This is aligment commit for extensions, and differs from v2.3 so that error is reported in var_expand_with_funcs since the public API is not changed. Commit: 122014ad84488d6309dc7d1572dfc988fedc18c4 https://github.com/dovecot/core/commit/122014ad84488d6309dc7d1572dfc988fedc18c4 Author: Aki Tuomi Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/lib/Makefile.am M src/lib/lib.c A src/lib/var-expand-private.h M src/lib/var-expand.c Log Message: ----------- lib: Add extension support for var-expand This enables loading new var-expand features using plugins. Commit: ec4485c4b04e470f75edf9eb86ac8693c0dbcc24 https://github.com/dovecot/core/commit/ec4485c4b04e470f75edf9eb86ac8693c0dbcc24 Author: Aki Tuomi Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/lib/test-var-expand.c Log Message: ----------- lib: Add tests for extensions Commit: 217905ea4d59acbb11d807fe5dc5a6410273c9bf https://github.com/dovecot/core/commit/217905ea4d59acbb11d807fe5dc5a6410273c9bf Author: Aki Tuomi Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M configure.ac M src/plugins/Makefile.am A src/plugins/var-expand-crypt/Makefile.am A src/plugins/var-expand-crypt/var-expand-crypt-plugin.c Log Message: ----------- var-expand-crypt: Encryption/decryption support for var-expand Registers new encrypt and decrypt processors for var-expand. Commit: ffd9c6241e946e80594701a544e79b8c3e950da6 https://github.com/dovecot/core/commit/ffd9c6241e946e80594701a544e79b8c3e950da6 Author: Aki Tuomi Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/plugins/var-expand-crypt/var-expand-crypt-plugin.c Log Message: ----------- var-expand-crypt: Fix base64 encoding the break was missing, also removed confusing block. Commit: b82a1a409c52686e4eae5aebb2fb7d8898a0e1eb https://github.com/dovecot/core/commit/b82a1a409c52686e4eae5aebb2fb7d8898a0e1eb Author: Aki Tuomi Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/plugins/var-expand-crypt/var-expand-crypt-plugin.c Log Message: ----------- var-expand-crypt: Remove pointless assigment It's never used Compare: https://github.com/dovecot/core/compare/b74e23667521...b82a1a409c52 From noreply at github.com Fri Mar 31 16:00:10 2017 From: noreply at github.com (GitHub) Date: Fri, 31 Mar 2017 06:00:10 -0700 Subject: [dovecot/core] 8f900b: lib-fs: Allow fs_set_metadata() to update already ... Message-ID: <58de52da4f262_78923fd9be563c2c104b5@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8f900bf5b01a78ac9be748e7502aad7cf3486420 https://github.com/dovecot/core/commit/8f900bf5b01a78ac9be748e7502aad7cf3486420 Author: Timo Sirainen Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/lib-fs/fs-api.c Log Message: ----------- lib-fs: Allow fs_set_metadata() to update already added metadata. Previously we were just appending the metadata multiple times with different values, which could have caused problems. Commit: 15fa038377f9e3da24d088aa8a908919581c60a6 https://github.com/dovecot/core/commit/15fa038377f9e3da24d088aa8a908919581c60a6 Author: Timo Sirainen Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/lib-fs/fs-api.c M src/lib-fs/fs-api.h Log Message: ----------- lib-fs: Add FS_METADATA_ORIG_PATH This allows fs backends to keep track of the original filename and use it for logging purposes and such. Commit: 5930d3ff79f8af73abce293a93e20f3723479631 https://github.com/dovecot/core/commit/5930d3ff79f8af73abce293a93e20f3723479631 Author: Timo Sirainen Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/lib-index/mail-index-transaction-update.c Log Message: ----------- lib-index: Assert in mail_index_append_finish_uids() to prevent UID wrapping This should be handled better eventually, but it's better to crash earlier now than later. This avoids a later assert: Panic: file mail-index-transaction-finish.c: line 187 (mail_index_transaction_get_uid): assertion failed: (rec->uid != 0) Compare: https://github.com/dovecot/core/compare/b1e097e04cef...5930d3ff79f8 From noreply at github.com Fri Mar 31 16:00:15 2017 From: noreply at github.com (GitHub) Date: Fri, 31 Mar 2017 06:00:15 -0700 Subject: [dovecot/core] c2f200: test-var-expand: Expect error Message-ID: <58de52dfb25c8_7c023fe5cb79bc386716f@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: c2f200c787200b54ff1278666669f8f33ae7953c https://github.com/dovecot/core/commit/c2f200c787200b54ff1278666669f8f33ae7953c Author: Aki Tuomi Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/lib/test-var-expand.c Log Message: ----------- test-var-expand: Expect error From noreply at github.com Fri Mar 31 21:30:09 2017 From: noreply at github.com (GitHub) Date: Fri, 31 Mar 2017 11:30:09 -0700 Subject: [dovecot/core] f33cd5: lmtp: Die at startup if config reading fails. Message-ID: <58dea031d78db_38863fce523a5c405596@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f33cd5b8b44175256eb92bec51a60ad8fb98bbe0 https://github.com/dovecot/core/commit/f33cd5b8b44175256eb92bec51a60ad8fb98bbe0 Author: Timo Sirainen Date: 2017-03-31 (Fri, 31 Mar 2017) Changed paths: M src/lmtp/main.c Log Message: ----------- lmtp: Die at startup if config reading fails. Although most of the time it's not strictly required for config to be read here, one exception is SSL server settings. If this config reading fails, the SSL initialization just crashes. So this gives a better error message than a crash. Also config reading really isn't supposed to fail anyway.