From noreply at github.com Thu Sep 1 10:30:15 2016 From: noreply at github.com (GitHub) Date: Thu, 01 Sep 2016 03:30:15 -0700 Subject: [dovecot/core] 14cac2: Fix control flow and T_BEGIN/T_END hygiene Message-ID: <57c80337726c1_36d03fe96c0b113073429@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 14cac26dcb71108abfdc95ea524e74be1f95774c https://github.com/dovecot/core/commit/14cac26dcb71108abfdc95ea524e74be1f95774c Author: Phil Carmody Date: 2016-08-31 (Wed, 31 Aug 2016) Changed paths: M src/director/login-connection.c M src/lib/file-lock.c Log Message: ----------- Fix control flow and T_BEGIN/T_END hygiene You mustn't goto, break, continue, or return from out of a T_BEGIN {...} T_END block, as that will lose a t_pop(). This has been seen in the wild: Panic: Leaked t_pop() call Signed-off-by: Phil Carmody From noreply at github.com Thu Sep 1 11:00:14 2016 From: noreply at github.com (GitHub) Date: Thu, 01 Sep 2016 04:00:14 -0700 Subject: [dovecot/core] 79fe1b: lib: var-expand: Removed var_expand_table_build(). Message-ID: <57c80a3ec7e3a_38ec3fe41f7a114013928a@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 79fe1b28df44ba22b230326bee895583c1df5a28 https://github.com/dovecot/core/commit/79fe1b28df44ba22b230326bee895583c1df5a28 Author: Stephan Bosch Date: 2016-09-01 (Thu, 01 Sep 2016) Changed paths: M src/auth/userdb-vpopmail.c M src/lib/var-expand.c M src/lib/var-expand.h Log Message: ----------- lib: var-expand: Removed var_expand_table_build(). Replaced it with explicit table construction at the one place it was used. Clang -Wvargargs complained about passing a char argument to va_start(). From noreply at github.com Fri Sep 2 09:00:12 2016 From: noreply at github.com (GitHub) Date: Fri, 02 Sep 2016 02:00:12 -0700 Subject: [dovecot/core] 8cf55b: lib: Minor t_push() optimization - use unlikely() Message-ID: <57c93f9c85837_64953fd5e589b1386022c@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8cf55b1c05d0d0a19c95ebbc8390ceb1d36da4a9 https://github.com/dovecot/core/commit/8cf55b1c05d0d0a19c95ebbc8390ceb1d36da4a9 Author: Timo Sirainen Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M src/lib/data-stack.c Log Message: ----------- lib: Minor t_push() optimization - use unlikely() Commit: 7bc9e4a3b0d68eefc9c14a58a8d9f946740f5be6 https://github.com/dovecot/core/commit/7bc9e4a3b0d68eefc9c14a58a8d9f946740f5be6 Author: Timo Sirainen Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M src/lib/data-stack.c Log Message: ----------- lib: Small code cleanup to data-stack - use explicit data_stack_initialized This will make it easier to change data_stack_frame's type. Commit: e2588872c1fe79642589b805aaab9fbb6750771b https://github.com/dovecot/core/commit/e2588872c1fe79642589b805aaab9fbb6750771b Author: Timo Sirainen Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M src/lib/data-stack.c M src/lib/data-stack.h M src/lib/ioloop.c M src/lib/mempool-datastack.c M src/lib/test-data-stack.c Log Message: ----------- lib: Created data_stack_frame_t type for data_stack_frame Commit: 28bf8f762fcd21c57bf71822cf818447babce9a0 https://github.com/dovecot/core/commit/28bf8f762fcd21c57bf71822cf818447babce9a0 Author: Timo Sirainen Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M src/lib-master/master-service-private.h M src/lib-master/master-service.c Log Message: ----------- lib-master: master_service_init_finish() now verifies that t_pop() wasn't leaked Commit: 3c5ee51327f075dc13cdacf46135f7f0abbdaafe https://github.com/dovecot/core/commit/3c5ee51327f075dc13cdacf46135f7f0abbdaafe Author: Timo Sirainen Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M src/lib-master/master-service.c M src/lib-test/test-common.c M src/lib/data-stack.c M src/lib/data-stack.h M src/lib/ioloop.c M src/lib/test-data-stack.c Log Message: ----------- lib: Changed t_pop() API to make it a bit more like free() Commit: 32c3ba3ba51c80d3fa2b4e17c34a621a8532cca0 https://github.com/dovecot/core/commit/32c3ba3ba51c80d3fa2b4e17c34a621a8532cca0 Author: Timo Sirainen Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M src/lib/data-stack.c M src/lib/data-stack.h Log Message: ----------- lib: If DEBUG is enabled, use a pointer type for data_stack_frame_t This allows telling static analyzers to treat t_push() and t_pop() similarly to malloc()/free() and check for leaks. Compare: https://github.com/dovecot/core/compare/79fe1b28df44...32c3ba3ba51c From noreply at github.com Fri Sep 2 16:30:12 2016 From: noreply at github.com (GitHub) Date: Fri, 02 Sep 2016 09:30:12 -0700 Subject: [dovecot/core] 4b4e8d: dcrypt: Allow stream prefetch Message-ID: <57c9a9145cbd7_75b13fb01f557134939f4@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 4b4e8dcad11120fa006e8edf1c659271ed5bd800 https://github.com/dovecot/core/commit/4b4e8dcad11120fa006e8edf1c659271ed5bd800 Author: Aki Tuomi Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M src/lib-dcrypt/istream-decrypt.c Log Message: ----------- dcrypt: Allow stream prefetch We might get stream that has already been buffered, so we must try read it in case buffer is full. Commit: 7d0d1c56133c82168a3cee2a7ef34dea44d0d462 https://github.com/dovecot/core/commit/7d0d1c56133c82168a3cee2a7ef34dea44d0d462 Author: Aki Tuomi Date: 2016-09-02 (Fri, 02 Sep 2016) Changed paths: M src/lib-dcrypt/test-stream.c Log Message: ----------- dcrypt: Test for stream prefetch Compare: https://github.com/dovecot/core/compare/32c3ba3ba51c...7d0d1c56133c From noreply at github.com Mon Sep 5 20:00:11 2016 From: noreply at github.com (GitHub) Date: Mon, 05 Sep 2016 13:00:11 -0700 Subject: [dovecot/core] 9913ea: dovecot.service.in: removed ExecStartPre and ExecS... Message-ID: <57cdcecbae139_64753f857e62913c1542b1@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9913ea5ea62749f43c9cf100d01a7c398b19b611 https://github.com/dovecot/core/commit/9913ea5ea62749f43c9cf100d01a7c398b19b611 Author: Ville Savolainen Date: 2016-09-05 (Mon, 05 Sep 2016) Changed paths: M dovecot.service.in Log Message: ----------- dovecot.service.in: removed ExecStartPre and ExecStopPost default definitions Additional definitions currently added to dovecot.service.d/ by packaging From noreply at github.com Tue Sep 6 00:00:12 2016 From: noreply at github.com (GitHub) Date: Mon, 05 Sep 2016 17:00:12 -0700 Subject: [dovecot/core] 8a2f21: lib-dcrypt: Avoid infinite loop if istream header ... Message-ID: <57ce070cf1f30_c683fc34bb47140622cf@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8a2f21f2b03878918333efac486f99e4fa0ecce2 https://github.com/dovecot/core/commit/8a2f21f2b03878918333efac486f99e4fa0ecce2 Author: Timo Sirainen Date: 2016-09-06 (Tue, 06 Sep 2016) Changed paths: M src/lib-dcrypt/istream-decrypt.c M src/lib-dcrypt/test-stream.c Log Message: ----------- lib-dcrypt: Avoid infinite loop if istream header is too large. We'll return an error now instead. We can't just return -2 here, because nothing was actually being returned to the caller. Attempting to do that would just trigger an assert: Panic: file istream.c: line 182 (i_stream_read): assertion failed: (_stream->skip != _stream->pos) From noreply at github.com Tue Sep 6 16:30:17 2016 From: noreply at github.com (GitHub) Date: Tue, 06 Sep 2016 09:30:17 -0700 Subject: [dovecot/core] 8dfdcd: doveadm-server: Reset error code between calls Message-ID: <57ceef19d4367_dd13fb1b650b14c17017c@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 8dfdcd15772931a6d768adb40ea4094b68eb218a https://github.com/dovecot/core/commit/8dfdcd15772931a6d768adb40ea4094b68eb218a Author: Aki Tuomi Date: 2016-09-06 (Tue, 06 Sep 2016) Changed paths: M src/doveadm/client-connection.c Log Message: ----------- doveadm-server: Reset error code between calls Commit: cfb4971cccca2ef18a45e7a5d3e5069c90df9422 https://github.com/dovecot/core/commit/cfb4971cccca2ef18a45e7a5d3e5069c90df9422 Author: Aki Tuomi Date: 2016-09-06 (Tue, 06 Sep 2016) Changed paths: M src/lib-fs/fs-metawrap.c M src/lib-fs/fs-randomfail.c M src/lib-fs/fs-sis-queue.c M src/lib-fs/fs-sis.c M src/lib-fs/fs-wrapper.c M src/plugins/fs-compress/fs-compress.c Log Message: ----------- lib-fs: Do not abort parent of parent Commit: 2e7a0190d94de727a012616c13566ba9e9973554 https://github.com/dovecot/core/commit/2e7a0190d94de727a012616c13566ba9e9973554 Author: Phil Carmody Date: 2016-09-06 (Tue, 06 Sep 2016) Changed paths: M src/director/login-connection.c M src/lib/file-lock.c Log Message: ----------- Fix control flow and T_BEGIN/T_END hygiene You mustn't goto, break, continue, or return from out of a T_BEGIN {...} T_END block, as that will lose a t_pop(). This has been seen in the wild: Panic: Leaked t_pop() call Signed-off-by: Phil Carmody Commit: 527d6c592aec1e3db5d6cd4205328b73f3047dd9 https://github.com/dovecot/core/commit/527d6c592aec1e3db5d6cd4205328b73f3047dd9 Author: Aki Tuomi Date: 2016-09-06 (Tue, 06 Sep 2016) Changed paths: M src/lib-dcrypt/istream-decrypt.c Log Message: ----------- dcrypt: Allow stream prefetch We might get stream that has already been buffered, so we must try read it in case buffer is full. Commit: b5d604ba1775dbb841ec367724eb61b19d14a3e3 https://github.com/dovecot/core/commit/b5d604ba1775dbb841ec367724eb61b19d14a3e3 Author: Aki Tuomi Date: 2016-09-06 (Tue, 06 Sep 2016) Changed paths: M src/lib-dcrypt/test-stream.c Log Message: ----------- dcrypt: Test for stream prefetch Commit: 6a008d83f39981731372fd24b6653af674a33448 https://github.com/dovecot/core/commit/6a008d83f39981731372fd24b6653af674a33448 Author: Timo Sirainen Date: 2016-09-06 (Tue, 06 Sep 2016) Changed paths: M src/lib-dcrypt/istream-decrypt.c M src/lib-dcrypt/test-stream.c Log Message: ----------- lib-dcrypt: Avoid infinite loop if istream header is too large. We'll return an error now instead. We can't just return -2 here, because nothing was actually being returned to the caller. Attempting to do that would just trigger an assert: Panic: file istream.c: line 182 (i_stream_read): assertion failed: (_stream->skip != _stream->pos) Compare: https://github.com/dovecot/core/compare/0204e1fcc053...6a008d83f399 From noreply at github.com Wed Sep 7 09:30:10 2016 From: noreply at github.com (GitHub) Date: Wed, 07 Sep 2016 02:30:10 -0700 Subject: [dovecot/core] 9d3f82: quota: Flush quota after recalc Message-ID: <57cfde22428_3ccf3fc90c4d3130183346@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9d3f82fe687d9ca62ed501fa741730c50c6714c4 https://github.com/dovecot/core/commit/9d3f82fe687d9ca62ed501fa741730c50c6714c4 Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/plugins/quota/doveadm-quota.c Log Message: ----------- quota: Flush quota after recalc Correctly fix issue where the dict commit is left unfinished. Commit: 741287129c22cadc14c05584704685b31169dbce https://github.com/dovecot/core/commit/741287129c22cadc14c05584704685b31169dbce Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/plugins/zlib/zlib-plugin.c Log Message: ----------- zlib-plugin: Check that UID is assigned When caching, code has to check whether UID is assigned to avoid reusing cache for different email since they all have UID = 0 before they are actually committed. Commit: 4269461e311f48f9182281860c726a0f2bff3bba https://github.com/dovecot/core/commit/4269461e311f48f9182281860c726a0f2bff3bba Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/lib-imap-storage/imap-msgpart.c Log Message: ----------- lib-imap-storage: Check that UID is assigned before caching Commit: ae5330824a7ca85edd005109a353c3ab6b23b6b8 https://github.com/dovecot/core/commit/ae5330824a7ca85edd005109a353c3ab6b23b6b8 Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/lib-storage/index/index-mail-binary.c Log Message: ----------- lib-storage: Check that UID is set before caching Commit: 37c72fa0cd3f1d74d79b64afb3fb6da5ffd4fe3a https://github.com/dovecot/core/commit/37c72fa0cd3f1d74d79b64afb3fb6da5ffd4fe3a Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/plugins/acl/acl-api-private.h M src/plugins/acl/acl-api.c M src/plugins/acl/acl-api.h M src/plugins/acl/acl-attributes.c M src/plugins/acl/acl-backend-vfile-acllist.c M src/plugins/acl/acl-backend-vfile.h M src/plugins/acl/doveadm-acl.c Log Message: ----------- acl-plugin: Make iterators more conforming The *_next functions return true/false, deinit will report errors and end result. Commit: 5f63ee5a915d1b6a89b36a68a00d82ff678fc450 https://github.com/dovecot/core/commit/5f63ee5a915d1b6a89b36a68a00d82ff678fc450 Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/plugins/acl/acl-attributes.c Log Message: ----------- acl-plugin: Deinit acl_iter on deinit too Commit: b607b432d14af662bbd20d3a894a8315d25a0fdd https://github.com/dovecot/core/commit/b607b432d14af662bbd20d3a894a8315d25a0fdd Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/plugins/acl/acl-api.c M src/plugins/acl/acl-api.h M src/plugins/acl/acl-attributes.c Log Message: ----------- acl-plugin: Whitespace fixes Commit: fdef08644ba66b9db8fe4fc041ecc31a1ec9524b https://github.com/dovecot/core/commit/fdef08644ba66b9db8fe4fc041ecc31a1ec9524b Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/lib-fs/fs-api.c Log Message: ----------- fs-api: Retrieve errno before dest->copy_output is NULL'ed CID 10144: When aborting output, errno retrieval is attempted after dest->copy_output has already been unreffed. Found by coverity. Compare: https://github.com/dovecot/core/compare/8a2f21f2b038...fdef08644ba6 From noreply at github.com Wed Sep 7 09:30:15 2016 From: noreply at github.com (GitHub) Date: Wed, 07 Sep 2016 02:30:15 -0700 Subject: [dovecot/core] e525e4: lib-dict: Discard result when callback is NULL on ... Message-ID: <57cfde274df17_26cc3f96a03b513469388@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: e525e4215127aeb76a3b5a31f1a0d24a68f37c68 https://github.com/dovecot/core/commit/e525e4215127aeb76a3b5a31f1a0d24a68f37c68 Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- lib-dict: Discard result when callback is NULL on async call Commit: 1bac2e496362f368bdb1a03643fbb2c5282ae8fe https://github.com/dovecot/core/commit/1bac2e496362f368bdb1a03643fbb2c5282ae8fe Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/plugins/quota/doveadm-quota.c Log Message: ----------- quota: Flush quota after recalc Correctly fix issue where the dict commit is left unfinished. Compare: https://github.com/dovecot/core/compare/6a008d83f399...1bac2e496362 From noreply at github.com Wed Sep 7 19:30:15 2016 From: noreply at github.com (GitHub) Date: Wed, 07 Sep 2016 12:30:15 -0700 Subject: [dovecot/core] ff405d: zlib-plugin: Check that UID is assigned Message-ID: <57d06ac7a28e1_7cc63fa55a10513c161898@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: ff405d544575ad23d30f8247310d459d4f10756b https://github.com/dovecot/core/commit/ff405d544575ad23d30f8247310d459d4f10756b Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/plugins/zlib/zlib-plugin.c Log Message: ----------- zlib-plugin: Check that UID is assigned When caching, code has to check whether UID is assigned to avoid reusing cache for different email since they all have UID = 0 before they are actually committed. Commit: 86fe00056ce504027dd05b09a3a5ab27b04e3928 https://github.com/dovecot/core/commit/86fe00056ce504027dd05b09a3a5ab27b04e3928 Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/lib-imap-storage/imap-msgpart.c Log Message: ----------- lib-imap-storage: Check that UID is assigned before caching Commit: 55992ff06a6fa05909643236cca6c1310905ff52 https://github.com/dovecot/core/commit/55992ff06a6fa05909643236cca6c1310905ff52 Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/lib-storage/index/index-mail-binary.c Log Message: ----------- lib-storage: Check that UID is set before caching Commit: b3a37312811259fe6d8da7189016a370759a3cdc https://github.com/dovecot/core/commit/b3a37312811259fe6d8da7189016a370759a3cdc Author: Aki Tuomi Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/lib-fs/fs-api.c Log Message: ----------- fs-api: Retrieve errno before dest->copy_output is NULL'ed CID 10144: When aborting output, errno retrieval is attempted after dest->copy_output has already been unreffed. Found by coverity. Commit: 51b18a2c6c14516313d610fbff64442fc5def8c5 https://github.com/dovecot/core/commit/51b18a2c6c14516313d610fbff64442fc5def8c5 Author: Timo Sirainen Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/imap/imap-master-client.c Log Message: ----------- imap: Fixed assert-crash if un-hibernation failed to initialize user. master_service_client_connection_destroyed() was also being called in imap_master_client_destroy() so it was done twice. Fixes: Panic: file master-service.c: line 775 (master_service_client_connection_destroyed): assertion failed: (service->total_available_count > 0) Compare: https://github.com/dovecot/core/compare/1bac2e496362...51b18a2c6c14 From noreply at github.com Wed Sep 7 19:30:11 2016 From: noreply at github.com (GitHub) Date: Wed, 07 Sep 2016 12:30:11 -0700 Subject: [dovecot/core] 82b3d0: imap: Fixed assert-crash if un-hibernation failed ... Message-ID: <57d06ac3babfa_43593fa293303138361e7@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 82b3d02b7384847d077b9121e08b9838903fd3d7 https://github.com/dovecot/core/commit/82b3d02b7384847d077b9121e08b9838903fd3d7 Author: Timo Sirainen Date: 2016-09-07 (Wed, 07 Sep 2016) Changed paths: M src/imap/imap-master-client.c Log Message: ----------- imap: Fixed assert-crash if un-hibernation failed to initialize user. master_service_client_connection_destroyed() was also being called in imap_master_client_destroy() so it was done twice. Fixes: Panic: file master-service.c: line 775 (master_service_client_connection_destroyed): assertion failed: (service->total_available_count > 0) From noreply at github.com Thu Sep 8 12:30:11 2016 From: noreply at github.com (GitHub) Date: Thu, 08 Sep 2016 05:30:11 -0700 Subject: [dovecot/core] a48046: lmtp: Always read settings before dropping privs Message-ID: <57d159d393853_27d13f92252251401062c5@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: a4804621ea31f573a68da297ee64bfe1f1d5d9b1 https://github.com/dovecot/core/commit/a4804621ea31f573a68da297ee64bfe1f1d5d9b1 Author: Aki Tuomi Date: 2016-09-08 (Thu, 08 Sep 2016) Changed paths: M src/lmtp/main.c Log Message: ----------- lmtp: Always read settings before dropping privs If lmtp is ran explicitly as root, settings were not read. From noreply at github.com Thu Sep 8 15:00:13 2016 From: noreply at github.com (GitHub) Date: Thu, 08 Sep 2016 08:00:13 -0700 Subject: [dovecot/core] c7f699: acl-plugin: Adjust to API changes Message-ID: <57d17cfd719fa_208b3f8dc2a8b1341369f@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c7f6992db44e9cd33b3b0d754833a1503ee9a53f https://github.com/dovecot/core/commit/c7f6992db44e9cd33b3b0d754833a1503ee9a53f Author: Aki Tuomi Date: 2016-09-08 (Thu, 08 Sep 2016) Changed paths: M src/plugins/acl/acl-backend-vfile-acllist.c M src/plugins/acl/acl-lookup-dict.c M src/plugins/acl/acl-mailbox-list.c M src/plugins/acl/acl-mailbox.c M src/plugins/imap-acl/imap-acl-plugin.c Log Message: ----------- acl-plugin: Adjust to API changes From noreply at github.com Thu Sep 8 17:30:13 2016 From: noreply at github.com (GitHub) Date: Thu, 08 Sep 2016 10:30:13 -0700 Subject: [dovecot/core] af2cc7: doveadm flags: Sync mailbox after committing trans... Message-ID: <57d1a025ac615_1a723f82e5bed12c968db@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: af2cc755b98e6e61e3167b0d5e69b7c88d8e6aa5 https://github.com/dovecot/core/commit/af2cc755b98e6e61e3167b0d5e69b7c88d8e6aa5 Author: Timo Sirainen Date: 2016-09-08 (Thu, 08 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-flags.c Log Message: ----------- doveadm flags: Sync mailbox after committing transaction. Commit: a94f1909a9a83f7c1cb3afa0adc7f1aabf72d293 https://github.com/dovecot/core/commit/a94f1909a9a83f7c1cb3afa0adc7f1aabf72d293 Author: Timo Sirainen Date: 2016-09-08 (Thu, 08 Sep 2016) Changed paths: M src/lib-stats/stats-connection.c M src/lib-stats/stats-connection.h Log Message: ----------- lib-stats: stats_connection_send() now returns whether it succeeded or not Commit: 80943492e5f4c2670267267cca73b8c78780538e https://github.com/dovecot/core/commit/80943492e5f4c2670267267cca73b8c78780538e Author: Timo Sirainen Date: 2016-09-08 (Thu, 08 Sep 2016) Changed paths: M src/plugins/stats/mail-stats-connection.c M src/plugins/stats/mail-stats-connection.h M src/plugins/stats/stats-plugin.c M src/plugins/stats/stats-plugin.h Log Message: ----------- stats plugin: Don't send any stats before CONNECT was successfully sent. After stats write failures this fixes warnings like: Warning: stats: Couldn't find session ID: smqAXQE8pIp/AAAB Commit: cd9cf45dcf9fcabc89e156117c4dcf464ec4eb85 https://github.com/dovecot/core/commit/cd9cf45dcf9fcabc89e156117c4dcf464ec4eb85 Author: Timo Sirainen Date: 2016-09-08 (Thu, 08 Sep 2016) Changed paths: M src/imap/imap-client.c Log Message: ----------- imap: Avoid wrongly assert-crashing in client_check_command_hangs() Fixes assert: Panic: file imap-client.c: line 837 (client_check_command_hangs): assertion failed: (client->io != NULL) Compare: https://github.com/dovecot/core/compare/c7f6992db44e...cd9cf45dcf9f From noreply at github.com Thu Sep 8 19:00:13 2016 From: noreply at github.com (GitHub) Date: Thu, 08 Sep 2016 12:00:13 -0700 Subject: [dovecot/core] f2ed47: configure: Added --enable-static-checker parameter Message-ID: <57d1b53d12d25_714a3fd551a8d1389512c@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f2ed47f80616d404113cbed57fd56b3ca13491cc https://github.com/dovecot/core/commit/f2ed47f80616d404113cbed57fd56b3ca13491cc Author: Timo Sirainen Date: 2016-09-08 (Thu, 08 Sep 2016) Changed paths: M configure.ac Log Message: ----------- configure: Added --enable-static-checker parameter Commit: e90d9eaa3ef3486c2da76b86ffd83b779f45d9cd https://github.com/dovecot/core/commit/e90d9eaa3ef3486c2da76b86ffd83b779f45d9cd Author: Timo Sirainen Date: 2016-09-08 (Thu, 08 Sep 2016) Changed paths: M src/lib/data-stack.c M src/lib/data-stack.h M src/lib/mempool-datastack.c Log Message: ----------- lib: Allow static analyzers to check for t_pop() leaks. They should be able to detect the missing free() call from code paths missing a t_pop(). Compare: https://github.com/dovecot/core/compare/cd9cf45dcf9f...e90d9eaa3ef3 From noreply at github.com Thu Sep 8 20:30:14 2016 From: noreply at github.com (GitHub) Date: Thu, 08 Sep 2016 13:30:14 -0700 Subject: [dovecot/core] bbc7e2: acl: Deinit will return 1 on non-empty Message-ID: <57d1ca565b4ad_143b3fa884651140101760@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: bbc7e2c2e726cf84da49f4062d05b0c35a9377bd https://github.com/dovecot/core/commit/bbc7e2c2e726cf84da49f4062d05b0c35a9377bd Author: Aki Tuomi Date: 2016-09-08 (Thu, 08 Sep 2016) Changed paths: M src/plugins/acl/acl-mailbox-list.c M src/plugins/acl/acl-mailbox.c Log Message: ----------- acl: Deinit will return 1 on non-empty Commit: 75771bd32a86b7360d28f1254ffba99f63d763d9 https://github.com/dovecot/core/commit/75771bd32a86b7360d28f1254ffba99f63d763d9 Author: Aki Tuomi Date: 2016-09-08 (Thu, 08 Sep 2016) Changed paths: M src/plugins/imap-acl/imap-acl-plugin.c Log Message: ----------- imap-acl: acl plugin deinit returns 1 on non-empty Compare: https://github.com/dovecot/core/compare/e90d9eaa3ef3...75771bd32a86 From noreply at github.com Thu Sep 8 22:30:11 2016 From: noreply at github.com (GitHub) Date: Thu, 08 Sep 2016 15:30:11 -0700 Subject: [dovecot/core] 85cce7: lib-index: mail_index_modseq_get_next_log_offset()... Message-ID: <57d1e673bc0da_67d13ff131c1d13c2212de@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 85cce7cabad6bfcb507f2c7c8841273b944ce100 https://github.com/dovecot/core/commit/85cce7cabad6bfcb507f2c7c8841273b944ce100 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/doveadm/dsync/dsync-transaction-log-scan.c M src/lib-index/mail-index-modseq.c Log Message: ----------- lib-index: mail_index_modseq_get_next_log_offset() shouldn't return offset beyond view's head This also allows removing the same workaround from dsync code. Commit: 4fca0e30565d7c46043719627e238b2e1a125310 https://github.com/dovecot/core/commit/4fca0e30565d7c46043719627e238b2e1a125310 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/stats/mail-session.c Log Message: ----------- stats: Include PIDs in "Duplicate session ID" errors. Compare: https://github.com/dovecot/core/compare/75771bd32a86...4fca0e30565d From noreply at github.com Thu Sep 8 23:00:12 2016 From: noreply at github.com (GitHub) Date: Thu, 08 Sep 2016 16:00:12 -0700 Subject: [dovecot/core] 4b9355: imap-hibernate: Increased imap-master communicatio... Message-ID: <57d1ed7c5aaf6_3ba83ff9ca82d1348069@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 4b9355028a364c6e901ce2d8a7d91180d3e55399 https://github.com/dovecot/core/commit/4b9355028a364c6e901ce2d8a7d91180d3e55399 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/imap-hibernate/imap-master-connection.c Log Message: ----------- imap-hibernate: Increased imap-master communication timeout from 5s to 30s Looks like 5s isn't enough in loaded environments. It's also not really a problem if the timeout is large, it's just going to take a while longer to restore the connection. When timeout is reached the client would just get disconnected anyway. From noreply at github.com Fri Sep 9 00:30:09 2016 From: noreply at github.com (GitHub) Date: Thu, 08 Sep 2016 17:30:09 -0700 Subject: [dovecot/core] a20a8a: lib-test: test_expect_errors() now works for the e... Message-ID: <57d20291b6cdb_7a883fcac036d13c522af@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: a20a8a9fcde3e7f4e01458542320c9a9b78c40da https://github.com/dovecot/core/commit/a20a8a9fcde3e7f4e01458542320c9a9b78c40da Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-test/test-common.c Log Message: ----------- lib-test: test_expect_errors() now works for the entire log string, not just format parameter From noreply at github.com Fri Sep 9 06:00:13 2016 From: noreply at github.com (GitHub) Date: Thu, 08 Sep 2016 23:00:13 -0700 Subject: [dovecot/core] 3c014d: lib-index: limit mail_index error prints to one pe... Message-ID: <57d24fed5d58d_4d113ff10df0713c205136@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 3c014db6f22aa3d18676f69f2881ab4336b6ecff https://github.com/dovecot/core/commit/3c014db6f22aa3d18676f69f2881ab4336b6ecff Author: Martti Rannanj?rvi Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-index/mail-index-private.h M src/lib-index/mail-index.c Log Message: ----------- lib-index: limit mail_index error prints to one per ioloop_time This is to prevent log flooding. From noreply at github.com Fri Sep 9 07:00:11 2016 From: noreply at github.com (GitHub) Date: Fri, 09 Sep 2016 00:00:11 -0700 Subject: [dovecot/core] 191265: fs-randomfail: Fixed assert-crash in fs_write_stre... Message-ID: <57d25dfb5d931_6d1e3fa019937134530ec@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 19126597f92e5cdde901ac472090aa423e0e5541 https://github.com/dovecot/core/commit/19126597f92e5cdde901ac472090aa423e0e5541 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-fs/fs-randomfail.c Log Message: ----------- fs-randomfail: Fixed assert-crash in fs_write_stream_abort_error() Commit: bd7ae8952d41fc1e847098439690355b09920618 https://github.com/dovecot/core/commit/bd7ae8952d41fc1e847098439690355b09920618 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-fs/fs-api-private.h M src/lib-fs/fs-api.h Log Message: ----------- lib-fs: Moved fs_write_stream_abort_parent() to fs-api-private.h Only fs wrapper drivers are supposed to call it. Commit: f818f91a2e6ee003aaa83323acd74008aa1276d9 https://github.com/dovecot/core/commit/f818f91a2e6ee003aaa83323acd74008aa1276d9 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/imap-hibernate/imap-hibernate-client.c M src/imap/imap-client-hibernate.c Log Message: ----------- imap: When hibernating, wait for old imap process to cleanup before creating new ones. This fixes stats errors: stats: Error: FIFO input error: CONNECT: Duplicate session ID Y7Q6E4U7xO1/AAAB for user testuser service imap stats: Warning: Couldn't find session ID: Y7Q6E4U7xO1/AAAB Commit: da8556f5919db300a9ffee5e75dbb6ef4b2d0cef https://github.com/dovecot/core/commit/da8556f5919db300a9ffee5e75dbb6ef4b2d0cef Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-storage/mailbox-get.c Log Message: ----------- lib-storage: Code cleanup for mailbox_get_expunge*() The previous code did actually work as well, but it wasn't very obvious that it did. Commit: 1ff03d2244dd08effadfecec365bec28793a1aa0 https://github.com/dovecot/core/commit/1ff03d2244dd08effadfecec365bec28793a1aa0 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: Make sure new dovecot.index.log files start tracking modseqs. This will make mail_index_modseq_get_next_log_offset() work correctly even if modseqs haven't been explicitly enabled. Commit: 2485e31c7ef8ac6656dd8b9def439fc6cf6f7598 https://github.com/dovecot/core/commit/2485e31c7ef8ac6656dd8b9def439fc6cf6f7598 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: Fixed mail_index_modseq_get_next_log_offset() when accessing .log.2 file->sync_offset was set only after header, so sync_highest_modseq was also same as initial_modseq. The previous code then just returned offset pointing to sync_offset, which was too early. Compare: https://github.com/dovecot/core/compare/3c014db6f22a...2485e31c7ef8 From noreply at github.com Fri Sep 9 08:00:14 2016 From: noreply at github.com (GitHub) Date: Fri, 09 Sep 2016 01:00:14 -0700 Subject: [dovecot/core] d3cc15: lib-test: Added missing va_end() call. Message-ID: <57d26c0e1054d_3fe73fbd64d0512c43670@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d3cc15f20e34ba52c851e7dd08c3bc61f5ca8659 https://github.com/dovecot/core/commit/d3cc15f20e34ba52c851e7dd08c3bc61f5ca8659 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-test/test-common.c Log Message: ----------- lib-test: Added missing va_end() call. From noreply at github.com Fri Sep 9 11:30:12 2016 From: noreply at github.com (GitHub) Date: Fri, 09 Sep 2016 04:30:12 -0700 Subject: [dovecot/core] 8c8110: lib-storage: Fixed accessing user as root when use... Message-ID: <57d29d4441f5b_6b2f3fa1249b913c1278ac@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8c81109dca287f1830aac57bae61e57260248941 https://github.com/dovecot/core/commit/8c81109dca287f1830aac57bae61e57260248941 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-storage/mail-storage-service.c Log Message: ----------- lib-storage: Fixed accessing user as root when user has no uid. This shouldn't normally be done, but might as well fix it. Fixes: Fatal: mail-storage-service: seteuid(4294967295) failed: Invalid argument From noreply at github.com Fri Sep 9 12:00:14 2016 From: noreply at github.com (GitHub) Date: Fri, 09 Sep 2016 05:00:14 -0700 Subject: [dovecot/core] 7b9e28: fs-metawrap: Fixed assert that checks we don't cre... Message-ID: <57d2a44e2988a_1b4b3fe8f9fdb13816112@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7b9e289e4f74f5c3fcd96448fad4955d5057ca7f https://github.com/dovecot/core/commit/7b9e289e4f74f5c3fcd96448fad4955d5057ca7f Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-fs/fs-metawrap.c Log Message: ----------- fs-metawrap: Fixed assert that checks we don't create empty files. If the entire write failed, offset could be 0. From noreply at github.com Fri Sep 9 12:00:17 2016 From: noreply at github.com (GitHub) Date: Fri, 09 Sep 2016 05:00:17 -0700 Subject: [dovecot/core] 91f029: lmtp: Always read settings before dropping privs Message-ID: <57d2a451d4932_784c3f85e56c313087587@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 91f029608947d4fa49b3c2c1a15a25eb75343147 https://github.com/dovecot/core/commit/91f029608947d4fa49b3c2c1a15a25eb75343147 Author: Aki Tuomi Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lmtp/main.c Log Message: ----------- lmtp: Always read settings before dropping privs If lmtp is ran explicitly as root, settings were not read. Commit: ceb5ed30950cd5df60d4b597a2be93dc58837041 https://github.com/dovecot/core/commit/ceb5ed30950cd5df60d4b597a2be93dc58837041 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-flags.c Log Message: ----------- doveadm flags: Sync mailbox after committing transaction. Commit: e19ba44ebff7bbdc0f4e2416d951334f349ae2d6 https://github.com/dovecot/core/commit/e19ba44ebff7bbdc0f4e2416d951334f349ae2d6 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-stats/stats-connection.c M src/lib-stats/stats-connection.h Log Message: ----------- lib-stats: stats_connection_send() now returns whether it succeeded or not Commit: 853992ac27d2a110abfd5b203997a20b7a306ea7 https://github.com/dovecot/core/commit/853992ac27d2a110abfd5b203997a20b7a306ea7 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/plugins/stats/mail-stats-connection.c M src/plugins/stats/mail-stats-connection.h M src/plugins/stats/stats-plugin.c M src/plugins/stats/stats-plugin.h Log Message: ----------- stats plugin: Don't send any stats before CONNECT was successfully sent. After stats write failures this fixes warnings like: Warning: stats: Couldn't find session ID: smqAXQE8pIp/AAAB Commit: 980f2d5f4f552499eae0ed744bd3c42481762fd6 https://github.com/dovecot/core/commit/980f2d5f4f552499eae0ed744bd3c42481762fd6 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/imap/imap-client.c Log Message: ----------- imap: Avoid wrongly assert-crashing in client_check_command_hangs() Fixes assert: Panic: file imap-client.c: line 837 (client_check_command_hangs): assertion failed: (client->io != NULL) Commit: 54ee447f75cd2cca9cd7507d81cad201606c5de0 https://github.com/dovecot/core/commit/54ee447f75cd2cca9cd7507d81cad201606c5de0 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/doveadm/dsync/dsync-transaction-log-scan.c M src/lib-index/mail-index-modseq.c Log Message: ----------- lib-index: mail_index_modseq_get_next_log_offset() shouldn't return offset beyond view's head This also allows removing the same workaround from dsync code. Commit: 3e2ec5a539218f69a2e5a3500cd58a830ca10464 https://github.com/dovecot/core/commit/3e2ec5a539218f69a2e5a3500cd58a830ca10464 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/stats/mail-session.c Log Message: ----------- stats: Include PIDs in "Duplicate session ID" errors. Commit: 8154226c0c2bdc5f95e78d3b26287a50eecbd48d https://github.com/dovecot/core/commit/8154226c0c2bdc5f95e78d3b26287a50eecbd48d Author: Phil Carmody Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-test/test-common.c M src/lib-test/test-common.h M src/lib/test-failures.c Log Message: ----------- lib-test: improve expected error handling If we expect a specific error string, then when we see it, suppress it. We do not suppress errors expected by count, because if we get unexpected errors, then we do not want them suppressed, and we have no way of distinguishing between the expected and unexpected errors. This of course favours the use of the expected string version of the helper, but alas that's not always usable, as you can only expect one at a time. Additionally, if we failed to see an expected message, then when we no longer expect to see it, reset the expected message state to not cascade further test assertion failures. Signed-off-by: Phil Carmody Conflicts: src/lib-test/test-common.c Commit: 7d436489b2f53af417b9ee40066cbe2914a800c4 https://github.com/dovecot/core/commit/7d436489b2f53af417b9ee40066cbe2914a800c4 Author: Phil Carmody Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-test/test-common.c M src/lib-test/test-common.h Log Message: ----------- lib-test: enable naming of tests, such that only a subset is run How to use these will become clear in a subsequent patch. Even if you don't want to name tests, the macros can reduce redundancy in the code, as the list of test function prototypes and the list of test functions to call become the same lists, expanded through 2 different macros. Signed-off-by: Phil Carmody Commit: f663500cb0daf7c1afa2c00a4a8ed62076cf91a2 https://github.com/dovecot/core/commit/f663500cb0daf7c1afa2c00a4a8ed62076cf91a2 Author: Phil Carmody Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-test/test-common.c M src/lib-test/test-common.h M src/lib/test-istream-unix.c Log Message: ----------- lib-test: test-exit helper to stop valgrind complaining about fork()s fork()s that want to _exit() will cause valgrind's full memory leak checker to complain a lot - this performs a quick cleanup first. Before: phil at phil:~/repos/dovecot-core$ valgrind --trace-children=yes --leak-check=full --show-leak-kinds=all src/lib/test-lib --match unix ==19576== total heap usage: 4 allocs, 0 frees, 17,858 bytes allocated istream unix ......................................................... : ok 0 / 1 tests failed ==19575== total heap usage: 7 allocs, 7 frees, 19,327 bytes allocated After: phil at phil:~/repos/dovecot-core$ valgrind --trace-children=yes --leak-check=full --show-leak-kinds=all src/lib/test-lib --match unix istream unix ......................................................... : ok ==4993== total heap usage: 4 allocs, 4 frees, 17,858 bytes allocated 0 / 1 tests failed ==4992== total heap usage: 7 allocs, 7 frees, 19,327 bytes allocated Signed-off-by: Phil Carmody Commit: bd30f04db41a2d610ff2a88945249a3c5c958a73 https://github.com/dovecot/core/commit/bd30f04db41a2d610ff2a88945249a3c5c958a73 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-test/test-common.c Log Message: ----------- lib-test: test_expect_errors() now works for the entire log string, not just format parameter Commit: 4148574050287a234907791e5128dbff4f03252e https://github.com/dovecot/core/commit/4148574050287a234907791e5128dbff4f03252e Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-test/test-common.c Log Message: ----------- lib-test: Added missing va_end() call. Commit: 796336749045577e47132b7b7f49a7bb697c4933 https://github.com/dovecot/core/commit/796336749045577e47132b7b7f49a7bb697c4933 Author: Martti Rannanj?rvi Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-index/mail-index-private.h M src/lib-index/mail-index.c Log Message: ----------- lib-index: limit mail_index error prints to one per ioloop_time This is to prevent log flooding. Commit: 67c972905e21ab84dbd732f30e69e8d3c105c85d https://github.com/dovecot/core/commit/67c972905e21ab84dbd732f30e69e8d3c105c85d Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-fs/fs-api-private.h M src/lib-fs/fs-api.h Log Message: ----------- lib-fs: Moved fs_write_stream_abort_parent() to fs-api-private.h Only fs wrapper drivers are supposed to call it. Commit: d0b5b7e1e110051b6eb667488bd85e61a35d2737 https://github.com/dovecot/core/commit/d0b5b7e1e110051b6eb667488bd85e61a35d2737 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/imap-hibernate/imap-hibernate-client.c M src/imap/imap-client-hibernate.c Log Message: ----------- imap: When hibernating, wait for old imap process to cleanup before creating new ones. This fixes stats errors: stats: Error: FIFO input error: CONNECT: Duplicate session ID Y7Q6E4U7xO1/AAAB for user testuser service imap stats: Warning: Couldn't find session ID: Y7Q6E4U7xO1/AAAB Commit: adf7780dd221833ed73602aa611c212b1beaba03 https://github.com/dovecot/core/commit/adf7780dd221833ed73602aa611c212b1beaba03 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-storage/mailbox-get.c Log Message: ----------- lib-storage: Code cleanup for mailbox_get_expunge*() The previous code did actually work as well, but it wasn't very obvious that it did. Commit: 32c8340302c9487e269c8efd8573489c75312386 https://github.com/dovecot/core/commit/32c8340302c9487e269c8efd8573489c75312386 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: Make sure new dovecot.index.log files start tracking modseqs. This will make mail_index_modseq_get_next_log_offset() work correctly even if modseqs haven't been explicitly enabled. Commit: 8e757fc1b0778ad3e16fab1d64505302660796e6 https://github.com/dovecot/core/commit/8e757fc1b0778ad3e16fab1d64505302660796e6 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-index/mail-transaction-log-file.c Log Message: ----------- lib-index: Fixed mail_index_modseq_get_next_log_offset() when accessing .log.2 file->sync_offset was set only after header, so sync_highest_modseq was also same as initial_modseq. The previous code then just returned offset pointing to sync_offset, which was too early. Commit: 5186e3510487efdd189ab88b26f245e56dc41adc https://github.com/dovecot/core/commit/5186e3510487efdd189ab88b26f245e56dc41adc Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-storage/mail-storage-service.c Log Message: ----------- lib-storage: Fixed accessing user as root when user has no uid. This shouldn't normally be done, but might as well fix it. Fixes: Fatal: mail-storage-service: seteuid(4294967295) failed: Invalid argument Commit: 063b8d80161aae0bc1357f79f484933725d950c2 https://github.com/dovecot/core/commit/063b8d80161aae0bc1357f79f484933725d950c2 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/imap-hibernate/imap-master-connection.c Log Message: ----------- imap-hibernate: Increased imap-master communication timeout from 5s to 30s Looks like 5s isn't enough in loaded environments. It's also not really a problem if the timeout is large, it's just going to take a while longer to restore the connection. When timeout is reached the client would just get disconnected anyway. Commit: bd64561d613e03747556162e3432cb615ad8026f https://github.com/dovecot/core/commit/bd64561d613e03747556162e3432cb615ad8026f Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-fs/fs-randomfail.c Log Message: ----------- fs-randomfail: Fixed assert-crash in fs_write_stream_abort_error() Commit: 38a254286953f5acdb13fdfcd50132aefafb1a75 https://github.com/dovecot/core/commit/38a254286953f5acdb13fdfcd50132aefafb1a75 Author: Timo Sirainen Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-fs/fs-metawrap.c Log Message: ----------- fs-metawrap: Added assert to make sure we don't create empty files. It seems like this could be happening in some situation. Compare: https://github.com/dovecot/core/compare/51b18a2c6c14...38a254286953 From noreply at github.com Fri Sep 9 20:00:12 2016 From: noreply at github.com (GitHub) Date: Fri, 09 Sep 2016 13:00:12 -0700 Subject: [dovecot/core] bedb7f: lib-storage: Limit folder full name only Message-ID: <57d314cc448ed_5daf3f9c0049713c874a@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: bedb7f369599d112e62eed14ab692351493bf623 https://github.com/dovecot/core/commit/bedb7f369599d112e62eed14ab692351493bf623 Author: Aki Tuomi Date: 2016-09-09 (Fri, 09 Sep 2016) Changed paths: M src/lib-storage/mail-storage.c M src/lib-storage/mailbox-list-private.h M src/lib-storage/mailbox-list.c Log Message: ----------- lib-storage: Limit folder full name only Before we had limit of 16 levels and 255 bytes per name which is same as 4096 bytes. Now we limit only the total length of the name to MAILBOX_LIST_NAME_MAX_LENGTH. For compability reasons, we are restricting individual component names to 255 characters. From noreply at github.com Mon Sep 12 08:00:12 2016 From: noreply at github.com (GitHub) Date: Mon, 12 Sep 2016 01:00:12 -0700 Subject: [dovecot/core] ea125b: plugins: fts - replace i_assert under _expunge_log... Message-ID: <57d6608c87a94_54153fe2ffe2512c886c5@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: ea125b1c394cb6a281c6120f5396faa11fcb268b https://github.com/dovecot/core/commit/ea125b1c394cb6a281c6120f5396faa11fcb268b Author: Phil Carmody Date: 2016-09-12 (Mon, 12 Sep 2016) Changed paths: M src/plugins/fts/fts-expunge-log.c M src/plugins/fts/fts-expunge-log.h Log Message: ----------- plugins: fts - replace i_assert under _expunge_log_subtract with warning (API change) The helper whose interface is changing currently has no other known clients (there's little need for it to be exposed at all). This should never happen, but if it does, just tally the number of times it happened, and squirt out a warning message after the whole subtract. If it happens at all, there's no reason not to expect a lot, so only warn once per file. In particular - do not assert crash when this is seen - it has been seen on live test systems where file corruption seems to have occured. As this can only be associated with corrupt fts indexes, seeing this error implies that the whole FTS index should be rebuilt for that user. Signed-off-by: Phil Carmody From noreply at github.com Mon Sep 12 09:00:14 2016 From: noreply at github.com (GitHub) Date: Mon, 12 Sep 2016 02:00:14 -0700 Subject: [dovecot/core] 12f86e: doveconf: Hide any _api_key Message-ID: <57d66e9e84e68_29e83fa779fb51348192f@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 12f86e86d952a56848d925e6445c36c39b37ba8e https://github.com/dovecot/core/commit/12f86e86d952a56848d925e6445c36c39b37ba8e Author: Aki Tuomi Date: 2016-09-12 (Mon, 12 Sep 2016) Changed paths: M src/config/doveconf.c Log Message: ----------- doveconf: Hide any _api_key From noreply at github.com Mon Sep 12 12:00:12 2016 From: noreply at github.com (GitHub) Date: Mon, 12 Sep 2016 05:00:12 -0700 Subject: [dovecot/core] 2bc671: pop3-migration-plugin: Add to index after successf... Message-ID: <57d698cc25bc0_545b3f859790b13452459@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2bc67190c90d08703ceb421fc8dcf16780020886 https://github.com/dovecot/core/commit/2bc67190c90d08703ceb421fc8dcf16780020886 Author: Aki Tuomi Date: 2016-09-12 (Mon, 12 Sep 2016) Changed paths: M src/plugins/pop3-migration/pop3-migration-plugin.c Log Message: ----------- pop3-migration-plugin: Add to index after successful retry Also change return value to indicate that the hash has been assigned to header. From noreply at github.com Mon Sep 12 12:30:15 2016 From: noreply at github.com (GitHub) Date: Mon, 12 Sep 2016 05:30:15 -0700 Subject: [dovecot/core] ad082a: lib-storage: Limit folder full name only Message-ID: <57d69fd788090_49ac3fee8af5713012031@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: ad082a8bfd74393367ee5968741340f686ae0a73 https://github.com/dovecot/core/commit/ad082a8bfd74393367ee5968741340f686ae0a73 Author: Aki Tuomi Date: 2016-09-12 (Mon, 12 Sep 2016) Changed paths: M src/lib-storage/mail-storage.c M src/lib-storage/mailbox-list-private.h M src/lib-storage/mailbox-list.c Log Message: ----------- lib-storage: Limit folder full name only Before we had limit of 16 levels and 255 bytes per name which is same as 4096 bytes. Now we limit only the total length of the name to MAILBOX_LIST_NAME_MAX_LENGTH. For compability reasons, we are restricting individual component names to 255 characters. Commit: 8d41c2d42f8884a2d0d38a42ffe33f1ec3bc0f85 https://github.com/dovecot/core/commit/8d41c2d42f8884a2d0d38a42ffe33f1ec3bc0f85 Author: Phil Carmody Date: 2016-09-12 (Mon, 12 Sep 2016) Changed paths: M src/plugins/fts/fts-expunge-log.c M src/plugins/fts/fts-expunge-log.h Log Message: ----------- plugins: fts - replace i_assert under _expunge_log_subtract with warning (API change) The helper whose interface is changing currently has no other known clients (there's little need for it to be exposed at all). This should never happen, but if it does, just tally the number of times it happened, and squirt out a warning message after the whole subtract. If it happens at all, there's no reason not to expect a lot, so only warn once per file. In particular - do not assert crash when this is seen - it has been seen on live test systems where file corruption seems to have occured. As this can only be associated with corrupt fts indexes, seeing this error implies that the whole FTS index should be rebuilt for that user. Signed-off-by: Phil Carmody Commit: 5affc316cebc5f8765a0e32bbccec64eac2656a1 https://github.com/dovecot/core/commit/5affc316cebc5f8765a0e32bbccec64eac2656a1 Author: Aki Tuomi Date: 2016-09-12 (Mon, 12 Sep 2016) Changed paths: M src/config/doveconf.c Log Message: ----------- doveconf: hide ssl_key without -P Commit: 63648d35ce915cc43adbb7a2f9c7f8882229b1a3 https://github.com/dovecot/core/commit/63648d35ce915cc43adbb7a2f9c7f8882229b1a3 Author: Aki Tuomi Date: 2016-09-12 (Mon, 12 Sep 2016) Changed paths: M src/config/doveconf.c Log Message: ----------- doveconf: Hide any _api_key Commit: 9c96b04f26fac44878c2b61b22a92060c1c8effa https://github.com/dovecot/core/commit/9c96b04f26fac44878c2b61b22a92060c1c8effa Author: Aki Tuomi Date: 2016-09-12 (Mon, 12 Sep 2016) Changed paths: M src/plugins/pop3-migration/pop3-migration-plugin.c Log Message: ----------- pop3-migration-plugin: Add to index after successful retry Also change return value to indicate that the hash has been assigned to header. Compare: https://github.com/dovecot/core/compare/38a254286953...9c96b04f26fa From noreply at github.com Tue Sep 13 04:30:10 2016 From: noreply at github.com (GitHub) Date: Mon, 12 Sep 2016 21:30:10 -0700 Subject: [dovecot/core] fdf3e1: configure: hardening logic is backwards Message-ID: <57d780d2cdfc7_65233f9715c291381103a4@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: fdf3e1e28e824a562b895c8c6b5d77d70146d357 https://github.com/dovecot/core/commit/fdf3e1e28e824a562b895c8c6b5d77d70146d357 Author: Josef 'Jeff' Sipek Date: 2016-09-12 (Mon, 12 Sep 2016) Changed paths: M configure.ac M m4/cc_fortify.m4 M m4/cc_pie.m4 M m4/cc_stack_protector.m4 M m4/ld_relro.m4 Log Message: ----------- configure: hardening logic is backwards Before this change, the argument parsing was busted. The --help string only compounded the incorrect behavior by suggesting that --disable-hardening could take a yes/no argument. | before | after ------------------------------+----------+-------- | enable | enable --enable-hardening | disable | enable --enable-hardening=yes | disable | enable --enable-hardening=no | enable | disable --disable-hardening | enable | disable --disable-hardening=yes | error | error --disable-hardening=no | error | error From noreply at github.com Tue Sep 13 08:00:12 2016 From: noreply at github.com (GitHub) Date: Tue, 13 Sep 2016 01:00:12 -0700 Subject: [dovecot/core] c46d97: imap, pop3: Added rawlog_dir setting to store IMAP... Message-ID: <57d7b20c966b2_1f8f3fe95a76513c732a@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c46d97e6a26a5bacb40a1d817407b94ae3860bdd https://github.com/dovecot/core/commit/c46d97e6a26a5bacb40a1d817407b94ae3860bdd Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/imap/imap-client.c M src/imap/imap-settings.c M src/imap/imap-settings.h M src/pop3/pop3-client.c M src/pop3/pop3-settings.c M src/pop3/pop3-settings.h Log Message: ----------- imap, pop3: Added rawlog_dir setting to store IMAP/POP3 traffic logs. This at least partially replaces the "rawlog" post-login binary. For now the "rawlog" binary supports some parameters, which aren't configurable for rawlog_dir. From noreply at github.com Tue Sep 13 15:00:15 2016 From: noreply at github.com (GitHub) Date: Tue, 13 Sep 2016 08:00:15 -0700 Subject: [dovecot/core] b804e2: lib-imap-urlauth: Don't access freed memory on err... Message-ID: <57d8147fb5b56_4a33fb546107134968b9@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b804e2b1744ef1616626dd7b8b8ff6cb83cfb2df https://github.com/dovecot/core/commit/b804e2b1744ef1616626dd7b8b8ff6cb83cfb2df Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-imap-urlauth/imap-urlauth-connection.c Log Message: ----------- lib-imap-urlauth: Don't access freed memory on errors. Commit: 262eeae35ee285981b37294628ec8d054daa1b23 https://github.com/dovecot/core/commit/262eeae35ee285981b37294628ec8d054daa1b23 Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-dict/dict-file.c Log Message: ----------- dict-file: Don't leak a lock on temp file creation failure. Commit: 67a0f9eecf3f0f351afaf2f675fded998312a6fc https://github.com/dovecot/core/commit/67a0f9eecf3f0f351afaf2f675fded998312a6fc Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/plugins/fts-squat/squat-uidlist.c Log Message: ----------- fts-squat: Fixed memory leak on corrupted uidlist handling Commit: e87393d3a562cdbc3fd0b346d57612808175f420 https://github.com/dovecot/core/commit/e87393d3a562cdbc3fd0b346d57612808175f420 Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-sql/driver-pgsql.c Log Message: ----------- pgsql: Fixed clearing sql_commit_result.error_type error was correctly set to NULL with the earlier memset(), but error_type may have been garbage. This shouldn't have caused any actual problems. Commit: 9474b66acc57ad89538328d6fbb89a81c3decd94 https://github.com/dovecot/core/commit/9474b66acc57ad89538328d6fbb89a81c3decd94 Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-test/test-common.c Log Message: ----------- lib-test: Fixed NULL pointer dereference when using --enable-static-checker Commit: 79fff45046397ba48c8693d5f37a1fd93096987f https://github.com/dovecot/core/commit/79fff45046397ba48c8693d5f37a1fd93096987f Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-storage/mail-storage-service.c Log Message: ----------- lib-storage: Fix potential crash when userdb-returns "key+=value" for a nonexistent setting. type would have also happened to be initialized to SET_STR for the crash to happen. Commit: 3177b410680f3915549719f84a4acbffd4f9c561 https://github.com/dovecot/core/commit/3177b410680f3915549719f84a4acbffd4f9c561 Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-dcrypt/dcrypt-openssl.c M src/lib-storage/index/dbox-common/dbox-save.c M src/lib-storage/list/mailbox-list-iter.c M src/lib-storage/mail-storage.c M src/plugins/fts-squat/squat-trie.c Log Message: ----------- Removed dead code to make static analyzer happier. Commit: abb404575a238f27ea03b6049880f30f1656ddc4 https://github.com/dovecot/core/commit/abb404575a238f27ea03b6049880f30f1656ddc4 Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-fs/fs-posix.c M src/lib-index/mailbox-log.c M src/lib-stats/stats-connection.c M src/lib-storage/index/imapc/imapc-mail.c M src/lib/istream-file.c M src/login-common/login-proxy-state.c M src/plugins/fts/fts-api.c M src/plugins/virtual/virtual-mail.c Log Message: ----------- Added asserts to make static analyzer happier. Commit: c8a54e1bb71d9f3cee6935f1ca5067b9fa8e1ee3 https://github.com/dovecot/core/commit/c8a54e1bb71d9f3cee6935f1ca5067b9fa8e1ee3 Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/auth/auth-policy.c Log Message: ----------- auth: Explicitly ignore return value to make static analyzer happier. Commit: 3c30113d275819d3ec946e327401241b8d2797db https://github.com/dovecot/core/commit/3c30113d275819d3ec946e327401241b8d2797db Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Make sure auth_request_log_info() doesn't crash when there are no passdbs auth_request_is_disabled_master_user() could have caused such crash. Commit: 4598234b354e4f43bdc5855d96be2854e6cdeb98 https://github.com/dovecot/core/commit/4598234b354e4f43bdc5855d96be2854e6cdeb98 Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Don't crash if dict-server returns broken reply. Just treat missing value as empty value. Commit: 5525765548dda226c3b4432228d2fb1a9c7549d9 https://github.com/dovecot/core/commit/5525765548dda226c3b4432228d2fb1a9c7549d9 Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/doveadm/doveadm-print.c Log Message: ----------- doveadm: Don't allow doveadm_print_header(title==NULL) anymore. It's not used anywhere, and if it was used it would have crashed with at least "tab" backend. Commit: d4361f37b24057f615db6fc55aca0dc2b5d7444e https://github.com/dovecot/core/commit/d4361f37b24057f615db6fc55aca0dc2b5d7444e Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-master/ipc-server.c Log Message: ----------- lib-master: Fixed memory leak when IPC server is handling commands. This mainly meant that when login processes responded to doveadm proxy list/kick commands memory was leaked. Commit: 6b32b849af6e0aeb7106103b758757ffa69b2b71 https://github.com/dovecot/core/commit/6b32b849af6e0aeb7106103b758757ffa69b2b71 Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-lda/lmtp-client.c Log Message: ----------- lib-lda: Cleanup error handling in LMTP client code. If there are no successful recipients, we'll need to deinit the client. But at that point we've already called all the callbacks, so the line parameter to lmtp_client_fail_full() isn't actually used anywhere. This was confusing static analyzer because global_fail_string was used as parameter, which could have been NULL and wouldn't have been valid for the callbacks. Commit: 5bfda550bd63d34365db650232e7a618f3cbeae7 https://github.com/dovecot/core/commit/5bfda550bd63d34365db650232e7a618f3cbeae7 Author: Timo Sirainen Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/doveadm/doveadm-auth.c Log Message: ----------- doveadm-auth: Handle unexpected auth "continue" request without crashing. Compare: https://github.com/dovecot/core/compare/c46d97e6a26a...5bfda550bd63 From noreply at github.com Wed Sep 14 08:30:11 2016 From: noreply at github.com (GitHub) Date: Wed, 14 Sep 2016 01:30:11 -0700 Subject: [dovecot/core] 19f862: lib-http: test-http-payload: Improved logging of n... Message-ID: <57d90a9356d92_60643faef1ead1407201c@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 19f8621e1473269d6820988d84f815774c2c1053 https://github.com/dovecot/core/commit/19f8621e1473269d6820988d84f815774c2c1053 Author: Stephan Bosch Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-http/test-http-payload.c Log Message: ----------- lib-http: test-http-payload: Improved logging of nested ioloop tests. Commit: 0873f750d44a45e027c5f770f1619977ad676f18 https://github.com/dovecot/core/commit/0873f750d44a45e027c5f770f1619977ad676f18 Author: Stephan Bosch Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-http/test-http-payload.c Log Message: ----------- lib-http: test-http-payload: Fixed problem in nested ioloop test. The running ioloop was not always stopped properly at the end of the test. This caused an assert failure in the running ioloop. Commit: 1c9f4c14e9c17abcc2813ae977274e40b6579973 https://github.com/dovecot/core/commit/1c9f4c14e9c17abcc2813ae977274e40b6579973 Author: Stephan Bosch Date: 2016-09-13 (Tue, 13 Sep 2016) Changed paths: M src/lib-http/http-client-connection.c Log Message: ----------- lib-http: client: Fixed hang occurring when nested ioloops are used in response callbacks. To prevent missing disconnect events, i_stream_read() is called once a change in ioloop is detected. However, if something was actually read into the stream, the input handler was never called. So, a response could linger in the stream buffer, without being handled, thereby causing the connection to hang indefinitely. An additional input event could end the hang, but sometimes this doesn't happen before the request times out. This problem was seen in test-http-payload once in about 10 invocations. Obox uses nested ioloops, to this applies there. Compare: https://github.com/dovecot/core/compare/5bfda550bd63...1c9f4c14e9c1 From noreply at github.com Wed Sep 14 12:00:13 2016 From: noreply at github.com (GitHub) Date: Wed, 14 Sep 2016 05:00:13 -0700 Subject: [dovecot/core] 6dd167: lib-storage: document mailbox and server attribute... Message-ID: <57d93bcd8ab21_3633fc929b1713c126722@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 6dd167432ab004909073d05a6e6cbdeb5ff28721 https://github.com/dovecot/core/commit/6dd167432ab004909073d05a6e6cbdeb5ff28721 Author: Josef 'Jeff' Sipek Date: 2016-09-14 (Wed, 14 Sep 2016) Changed paths: M src/lib-storage/mailbox-attribute.h Log Message: ----------- lib-storage: document mailbox and server attribute handling Commit: ee06e0aa58c00c9028d1bb5705996710b5c08de7 https://github.com/dovecot/core/commit/ee06e0aa58c00c9028d1bb5705996710b5c08de7 Author: Josef 'Jeff' Sipek Date: 2016-09-14 (Wed, 14 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-mailbox-metadata.c Log Message: ----------- doveadm: lowercase attribute names before trying to parse them This now matches what the imap server does. Commit: d1147c225f64596fc5eeb1cb2aab31b3c57d5215 https://github.com/dovecot/core/commit/d1147c225f64596fc5eeb1cb2aab31b3c57d5215 Author: Josef 'Jeff' Sipek Date: 2016-09-14 (Wed, 14 Sep 2016) Changed paths: M src/lib-storage/index/index-attribute.c M src/lib-storage/index/index-storage.h Log Message: ----------- lib-storage: remove attribute accessibility checks index_storage_attribute_{set,get} should assume that the caller performed due diligence and checked whether or not the user is allowed to store under the key. Commit: 26c41874cf6019c3e39f0ed630b2a07a92b2635f https://github.com/dovecot/core/commit/26c41874cf6019c3e39f0ed630b2a07a92b2635f Author: Josef 'Jeff' Sipek Date: 2016-09-14 (Wed, 14 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-mailbox-metadata.c M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-mail.h Log Message: ----------- doveadm: allow access to server attributes via empty mailbox name Commit: 70e0c96e14bb7cf6601645b3a858ee0261230031 https://github.com/dovecot/core/commit/70e0c96e14bb7cf6601645b3a858ee0261230031 Author: Josef 'Jeff' Sipek Date: 2016-09-14 (Wed, 14 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-mailbox-metadata.c Log Message: ----------- doveadm: refactor mailbox attribute get/set/unset/list to share more code Compare: https://github.com/dovecot/core/compare/1c9f4c14e9c1...70e0c96e14bb From noreply at github.com Thu Sep 15 04:00:13 2016 From: noreply at github.com (GitHub) Date: Wed, 14 Sep 2016 21:00:13 -0700 Subject: [dovecot/core] 9e904c: imapc: mail_get_stream() shouldn't return cached h... Message-ID: <57da1ccd6000b_12553f936294113410274b@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9e904c22e2124da78e05b818c5fae72309a34b85 https://github.com/dovecot/core/commit/9e904c22e2124da78e05b818c5fae72309a34b85 Author: Timo Sirainen Date: 2016-09-14 (Wed, 14 Sep 2016) Changed paths: M src/lib-storage/index/imapc/imapc-mail.c Log Message: ----------- imapc: mail_get_stream() shouldn't return cached hdr_size Commit: 061046c9aa2eec5c6c2f148ec95a4e51db3d8fd2 https://github.com/dovecot/core/commit/061046c9aa2eec5c6c2f148ec95a4e51db3d8fd2 Author: Timo Sirainen Date: 2016-09-14 (Wed, 14 Sep 2016) Changed paths: M src/plugins/pop3-migration/pop3-migration-plugin.c M src/plugins/pop3-migration/pop3-migration-plugin.h M src/plugins/pop3-migration/test-pop3-migration-plugin.c Log Message: ----------- pop3-migration: Avoid unnecessarily using stream's hdr_size. Shouldn't change any behavior, except reduce CPU usage a little bit. Compare: https://github.com/dovecot/core/compare/70e0c96e14bb...061046c9aa2e From noreply at github.com Thu Sep 15 06:30:11 2016 From: noreply at github.com (GitHub) Date: Wed, 14 Sep 2016 23:30:11 -0700 Subject: [dovecot/core] d97f08: iostream-temp: If write() to temp file fails at an... Message-ID: <57da3ff32cc90_9a73f91f4de11408674@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d97f081a3de44852197ced772e21560c108895a6 https://github.com/dovecot/core/commit/d97f081a3de44852197ced772e21560c108895a6 Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/lib/iostream-temp.c M src/lib/iostream-temp.h M src/lib/test-iostream-temp.c Log Message: ----------- iostream-temp: If write() to temp file fails at any time, move it back to memory. Similarly to if the write() to temp fails during the initial move attempt. This way even if write() fails due to out of disk space, it's not visible to caller. An error message is logged in any case. From noreply at github.com Thu Sep 15 06:30:16 2016 From: noreply at github.com (GitHub) Date: Wed, 14 Sep 2016 23:30:16 -0700 Subject: [dovecot/core] e90a0e: imap, pop3: Added rawlog_dir setting to store IMAP... Message-ID: <57da3ff8109f9_4a8b3ff6ec5011305358d@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: e90a0ed00032388ffe15b10c2ebf115355d553d5 https://github.com/dovecot/core/commit/e90a0ed00032388ffe15b10c2ebf115355d553d5 Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/imap/imap-client.c M src/imap/imap-settings.c M src/imap/imap-settings.h M src/pop3/pop3-client.c M src/pop3/pop3-settings.c M src/pop3/pop3-settings.h Log Message: ----------- imap, pop3: Added rawlog_dir setting to store IMAP/POP3 traffic logs. This at least partially replaces the "rawlog" post-login binary. For now the "rawlog" binary supports some parameters, which aren't configurable for rawlog_dir. Commit: 7ee368a94f5e2d56c07a35755bc4b16e4a56f5ee https://github.com/dovecot/core/commit/7ee368a94f5e2d56c07a35755bc4b16e4a56f5ee Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/lib-imap-urlauth/imap-urlauth-connection.c Log Message: ----------- lib-imap-urlauth: Don't access freed memory on errors. Commit: d464010001899d48b5e1848ffd9807681c5f9b1e https://github.com/dovecot/core/commit/d464010001899d48b5e1848ffd9807681c5f9b1e Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/lib-storage/mail-storage-service.c Log Message: ----------- lib-storage: Fix potential crash when userdb-returns "key+=value" for a nonexistent setting. type would have also happened to be initialized to SET_STR for the crash to happen. Commit: 0ee86a8ebf9b65aab40fcfe95382ef0108ae9df6 https://github.com/dovecot/core/commit/0ee86a8ebf9b65aab40fcfe95382ef0108ae9df6 Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/lib-dcrypt/dcrypt-openssl.c M src/lib-storage/index/dbox-common/dbox-save.c M src/lib-storage/list/mailbox-list-iter.c M src/lib-storage/mail-storage.c M src/plugins/fts-squat/squat-trie.c Log Message: ----------- Removed dead code to make static analyzer happier. Commit: 83ad90e5d8a37ba652e5b32557c989b725ffd9d4 https://github.com/dovecot/core/commit/83ad90e5d8a37ba652e5b32557c989b725ffd9d4 Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/lib-fs/fs-posix.c M src/lib-index/mailbox-log.c M src/lib-stats/stats-connection.c M src/lib-storage/index/imapc/imapc-mail.c M src/lib/istream-file.c M src/login-common/login-proxy-state.c M src/plugins/fts/fts-api.c M src/plugins/virtual/virtual-mail.c Log Message: ----------- Added asserts to make static analyzer happier. Commit: abea9d7b6be179628f4911e3314274e3950d09e6 https://github.com/dovecot/core/commit/abea9d7b6be179628f4911e3314274e3950d09e6 Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/auth/auth-policy.c Log Message: ----------- auth: Explicitly ignore return value to make static analyzer happier. Commit: 88eab5220d312cb3aea1e7edb9aa3758ed0cf336 https://github.com/dovecot/core/commit/88eab5220d312cb3aea1e7edb9aa3758ed0cf336 Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Make sure auth_request_log_info() doesn't crash when there are no passdbs auth_request_is_disabled_master_user() could have caused such crash. Commit: b49ca324eadb397bdfe08753e6d755f447259a6e https://github.com/dovecot/core/commit/b49ca324eadb397bdfe08753e6d755f447259a6e Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Don't crash if dict-server returns broken reply. Just treat missing value as empty value. Commit: 41d91454ba0338113ec6fef3ae96e94af0138b5e https://github.com/dovecot/core/commit/41d91454ba0338113ec6fef3ae96e94af0138b5e Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/lib-master/ipc-server.c Log Message: ----------- lib-master: Fixed memory leak when IPC server is handling commands. This mainly meant that when login processes responded to doveadm proxy list/kick commands memory was leaked. Commit: 6f94745813906563ffe2488e09cfcea63e3862b0 https://github.com/dovecot/core/commit/6f94745813906563ffe2488e09cfcea63e3862b0 Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/lib-lda/lmtp-client.c Log Message: ----------- lib-lda: Cleanup error handling in LMTP client code. If there are no successful recipients, we'll need to deinit the client. But at that point we've already called all the callbacks, so the line parameter to lmtp_client_fail_full() isn't actually used anywhere. This was confusing static analyzer because global_fail_string was used as parameter, which could have been NULL and wouldn't have been valid for the callbacks. Commit: ecdabaf86ff25b01b0b25df647334a12bcd6e642 https://github.com/dovecot/core/commit/ecdabaf86ff25b01b0b25df647334a12bcd6e642 Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/doveadm/doveadm-auth.c Log Message: ----------- doveadm-auth: Handle unexpected auth "continue" request without crashing. Commit: 9d0e2470e0b0fdd8bd71b90c89b77935306b2f56 https://github.com/dovecot/core/commit/9d0e2470e0b0fdd8bd71b90c89b77935306b2f56 Author: Stephan Bosch Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/lib-http/http-client-connection.c Log Message: ----------- lib-http: client: Fixed hang occurring when nested ioloops are used in response callbacks. To prevent missing disconnect events, i_stream_read() is called once a change in ioloop is detected. However, if something was actually read into the stream, the input handler was never called. So, a response could linger in the stream buffer, without being handled, thereby causing the connection to hang indefinitely. An additional input event could end the hang, but sometimes this doesn't happen before the request times out. This problem was seen in test-http-payload once in about 10 invocations. Obox uses nested ioloops, to this applies there. Commit: f75889f56c6c1d52c032f3f0beaa93f724d0908d https://github.com/dovecot/core/commit/f75889f56c6c1d52c032f3f0beaa93f724d0908d Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/lib-storage/index/imapc/imapc-mail.c Log Message: ----------- imapc: mail_get_stream() shouldn't return cached hdr_size Commit: c06590cb3d4d49747322da128f8153c847fd1c84 https://github.com/dovecot/core/commit/c06590cb3d4d49747322da128f8153c847fd1c84 Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/plugins/pop3-migration/pop3-migration-plugin.c M src/plugins/pop3-migration/pop3-migration-plugin.h M src/plugins/pop3-migration/test-pop3-migration-plugin.c Log Message: ----------- pop3-migration: Avoid unnecessarily using stream's hdr_size. Shouldn't change any behavior, except reduce CPU usage a little bit. Compare: https://github.com/dovecot/core/compare/9c96b04f26fa...c06590cb3d4d From noreply at github.com Thu Sep 15 07:30:11 2016 From: noreply at github.com (GitHub) Date: Thu, 15 Sep 2016 00:30:11 -0700 Subject: [dovecot/core] 6d2e2c: pop3-migration: Fixed crash when not specifying po... Message-ID: <57da4e036f94c_3a183f7f0c3c31404085a@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 6d2e2c79173f8af12b17c89ac5ec07b8be23971d https://github.com/dovecot/core/commit/6d2e2c79173f8af12b17c89ac5ec07b8be23971d Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/plugins/pop3-migration/pop3-migration-plugin.c Log Message: ----------- pop3-migration: Fixed crash when not specifying pop3_migration_mailbox setting. From noreply at github.com Thu Sep 15 09:00:14 2016 From: noreply at github.com (GitHub) Date: Thu, 15 Sep 2016 02:00:14 -0700 Subject: [dovecot/core] 033e31: lib: safe_mkstemp*() didn't always truncate prefix... Message-ID: <57da631ec8e_4c403fd1d6ae3138340e6@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 033e315cc9396332a09b98bee7824b8e6641c2fc https://github.com/dovecot/core/commit/033e315cc9396332a09b98bee7824b8e6641c2fc Author: Timo Sirainen Date: 2016-09-15 (Thu, 15 Sep 2016) Changed paths: M src/lib/safe-mkstemp.c Log Message: ----------- lib: safe_mkstemp*() didn't always truncate prefix back to original on failure. This caused repeated safe_mkstemp*() calls with the same prefix to keep increasing its size. It probably didn't really break anything (unless it was called enough many times to reach 255 filename length), but the filenames were still confusingly ugly. From noreply at github.com Fri Sep 16 06:30:12 2016 From: noreply at github.com (GitHub) Date: Thu, 15 Sep 2016 23:30:12 -0700 Subject: [dovecot/core] fe4058: lib-ssl-iostream: Use more standard _init() & _dei... Message-ID: <57db9174a5ca_77ba3f824b2d113c15678d@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: fe4058e6f01bf0e104c44815b6df7cfefb80634c https://github.com/dovecot/core/commit/fe4058e6f01bf0e104c44815b6df7cfefb80634c Author: Timo Sirainen Date: 2016-09-16 (Fri, 16 Sep 2016) Changed paths: M src/lib-ssl-iostream/iostream-openssl.c M src/lib-ssl-iostream/iostream-openssl.h M src/lib-ssl-iostream/iostream-ssl-private.h M src/lib-ssl-iostream/iostream-ssl.c Log Message: ----------- lib-ssl-iostream: Use more standard _init() & _deinit() to initialize SSL plugin This is mainly to make it easier for test programs to link to the plugin directly. Commit: c45da70c96800ce9d84a886b163ad913e3d8ddea https://github.com/dovecot/core/commit/c45da70c96800ce9d84a886b163ad913e3d8ddea Author: Timo Sirainen Date: 2016-09-16 (Fri, 16 Sep 2016) Changed paths: M src/lib-http/Makefile.am M src/lib-http/test-http-client.c Log Message: ----------- lib-http: Link test-http-client libssl_iostream_openssl.so directly. This way it can be run without having to do make install first. Compare: https://github.com/dovecot/core/compare/033e315cc939...c45da70c9680 From noreply at github.com Fri Sep 16 14:30:14 2016 From: noreply at github.com (GitHub) Date: Fri, 16 Sep 2016 07:30:14 -0700 Subject: [dovecot/core] 50072a: fs-randomfail: Operation is unfinished on EAGAIN, ... Message-ID: <57dc01f6e8078_35be3fd717dcb1341049f0@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 50072aa4241f048dbdf4800c554b2766615c31d9 https://github.com/dovecot/core/commit/50072aa4241f048dbdf4800c554b2766615c31d9 Author: Timo Sirainen Date: 2016-09-16 (Fri, 16 Sep 2016) Changed paths: M src/lib-fs/fs-randomfail.c Log Message: ----------- fs-randomfail: Operation is unfinished on EAGAIN, not ENOENT. This caused crashes and other problems when using randomfail with asynchronous fs drivers. From noreply at github.com Sat Sep 17 14:30:11 2016 From: noreply at github.com (GitHub) Date: Sat, 17 Sep 2016 07:30:11 -0700 Subject: [dovecot/core] 609bea: auth-policy: Ref/unref auth request Message-ID: <57dd5373ad60b_2f493fb32e8e514088335@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 609bea0534dffe2b8a34a93b0346b1f938903f16 https://github.com/dovecot/core/commit/609bea0534dffe2b8a34a93b0346b1f938903f16 Author: Aki Tuomi Date: 2016-09-17 (Sat, 17 Sep 2016) Changed paths: M src/auth/auth-policy.c Log Message: ----------- auth-policy: Ref/unref auth request If auth_request is not referenced it can go away before HTTP response is handled. From noreply at github.com Sun Sep 18 14:00:12 2016 From: noreply at github.com (GitHub) Date: Sun, 18 Sep 2016 07:00:12 -0700 Subject: [dovecot/core] ecc2fb: lib-ssl-iostream: Fixed OpenSSL module to be actua... Message-ID: <57de9dec2747f_4ab03fc4cc54513450323@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: ecc2fb34641f1bd39e10c774192ca18527ecb953 https://github.com/dovecot/core/commit/ecc2fb34641f1bd39e10c774192ca18527ecb953 Author: Timo Sirainen Date: 2016-09-18 (Sun, 18 Sep 2016) Changed paths: M src/lib-http/test-http-client.c M src/lib-ssl-iostream/iostream-openssl.c M src/lib-ssl-iostream/iostream-openssl.h M src/lib-ssl-iostream/iostream-ssl.c Log Message: ----------- lib-ssl-iostream: Fixed OpenSSL module to be actually initialized. From noreply at github.com Mon Sep 19 08:30:13 2016 From: noreply at github.com (GitHub) Date: Mon, 19 Sep 2016 01:30:13 -0700 Subject: [dovecot/core] db8a51: lib-ssl-iostream: The final fix to make the SSL pl... Message-ID: <57dfa215dd0f2_472d3fdc88da713c88814@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: db8a5116f65292d362c97cdc9725092233072537 https://github.com/dovecot/core/commit/db8a5116f65292d362c97cdc9725092233072537 Author: Timo Sirainen Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/lib-ssl-iostream/iostream-ssl.c Log Message: ----------- lib-ssl-iostream: The final fix to make the SSL plugin loading not fail.. From noreply at github.com Mon Sep 19 10:00:15 2016 From: noreply at github.com (GitHub) Date: Mon, 19 Sep 2016 03:00:15 -0700 Subject: [dovecot/core] f2496b: fts-backend-lucene: Check that box is not NULL Message-ID: <57dfb72fdf3c_733e3fdfbc56313812691a@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f2496be45dc16d1f93cb82a146b91d273b0621c0 https://github.com/dovecot/core/commit/f2496be45dc16d1f93cb82a146b91d273b0621c0 Author: Aki Tuomi Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/plugins/fts-lucene/fts-backend-lucene.c Log Message: ----------- fts-backend-lucene: Check that box is not NULL fts_backend_update_deinit will set box to NULL and call update_set_mailbox then. Commit: 768ac0aa3403eee7146ec01acff401c004fef7f7 https://github.com/dovecot/core/commit/768ac0aa3403eee7146ec01acff401c004fef7f7 Author: Aki Tuomi Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/plugins/fts-solr/fts-backend-solr.c Log Message: ----------- fts-backend-solr: Check that box is not NULL fts_backend_update_deinit will set box to NULL and call update_set_mailbox then. Commit: 2fcde0841df86e1260770a356ad74c5c128e8fc1 https://github.com/dovecot/core/commit/2fcde0841df86e1260770a356ad74c5c128e8fc1 Author: Aki Tuomi Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/plugins/fts/fts-api.c Log Message: ----------- fts-plugin: Remove NULL assert fts_backend_update_deinit will set box to NULL and call update_set_mailbox then. NULL check needs to be done in backends. Compare: https://github.com/dovecot/core/compare/db8a5116f652...2fcde0841df8 From noreply at github.com Mon Sep 19 13:00:28 2016 From: noreply at github.com (GitHub) Date: Mon, 19 Sep 2016 06:00:28 -0700 Subject: [dovecot/core] 7736f2: iostream-temp: If write() to temp file fails at an... Message-ID: <57dfe16cb7c9_444f3f9ed078f13c124460@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 7736f24e80078aea794c1c9341de82d4c6956107 https://github.com/dovecot/core/commit/7736f24e80078aea794c1c9341de82d4c6956107 Author: Timo Sirainen Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/lib/iostream-temp.c M src/lib/iostream-temp.h Log Message: ----------- iostream-temp: If write() to temp file fails at any time, move it back to memory. Similarly to if the write() to temp fails during the initial move attempt. This way even if write() fails due to out of disk space, it's not visible to caller. An error message is logged in any case. Commit: f2ade3006e45ccf21c820d71f9108f7aa2648fcf https://github.com/dovecot/core/commit/f2ade3006e45ccf21c820d71f9108f7aa2648fcf Author: Timo Sirainen Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/plugins/pop3-migration/pop3-migration-plugin.c Log Message: ----------- pop3-migration: Fixed crash when not specifying pop3_migration_mailbox setting. Commit: 68571169a44b0879d217f1b7bf2193f12862587d https://github.com/dovecot/core/commit/68571169a44b0879d217f1b7bf2193f12862587d Author: Timo Sirainen Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/lib/safe-mkstemp.c Log Message: ----------- lib: safe_mkstemp*() didn't always truncate prefix back to original on failure. This caused repeated safe_mkstemp*() calls with the same prefix to keep increasing its size. It probably didn't really break anything (unless it was called enough many times to reach 255 filename length), but the filenames were still confusingly ugly. Commit: 69de251551ebe6defc646f9228a733d5c6a3e4ff https://github.com/dovecot/core/commit/69de251551ebe6defc646f9228a733d5c6a3e4ff Author: Timo Sirainen Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/lib-fs/fs-randomfail.c Log Message: ----------- fs-randomfail: Operation is unfinished on EAGAIN, not ENOENT. This caused crashes and other problems when using randomfail with asynchronous fs drivers. Commit: 461e4c7e6ca31a47a0dcc020c74074e6d2c81f08 https://github.com/dovecot/core/commit/461e4c7e6ca31a47a0dcc020c74074e6d2c81f08 Author: Aki Tuomi Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/auth/auth-policy.c Log Message: ----------- auth-policy: Ref/unref auth request If auth_request is not referenced it can go away before HTTP response is handled. Commit: ff3bf633ae277fceeb7e3e9b12d0a1064995c31d https://github.com/dovecot/core/commit/ff3bf633ae277fceeb7e3e9b12d0a1064995c31d Author: Aki Tuomi Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/plugins/fts-lucene/fts-backend-lucene.c Log Message: ----------- fts-backend-lucene: Check that box is not NULL fts_backend_update_deinit will set box to NULL and call update_set_mailbox then. Commit: 04a1b385004803577f11f76781c35d043a1838f6 https://github.com/dovecot/core/commit/04a1b385004803577f11f76781c35d043a1838f6 Author: Aki Tuomi Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/plugins/fts-solr/fts-backend-solr.c Log Message: ----------- fts-backend-solr: Check that box is not NULL fts_backend_update_deinit will set box to NULL and call update_set_mailbox then. Commit: ea091ce92f74ebfc9a60477133fb811b325c2c14 https://github.com/dovecot/core/commit/ea091ce92f74ebfc9a60477133fb811b325c2c14 Author: Aki Tuomi Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/plugins/fts/fts-api.c Log Message: ----------- fts-plugin: Remove NULL assert fts_backend_update_deinit will set box to NULL and call update_set_mailbox then. NULL check needs to be done in backends. Compare: https://github.com/dovecot/core/compare/c06590cb3d4d...ea091ce92f74 From noreply at github.com Mon Sep 19 13:30:18 2016 From: noreply at github.com (GitHub) Date: Mon, 19 Sep 2016 06:30:18 -0700 Subject: [dovecot/core] 17466c: lib: Assert if i_stream_create_seekable_path(temp_... Message-ID: <57dfe86a30a43_7c0a3fd25e1cd138681e1@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 17466c748183b19f7775374ce6afbd7bf62d479d https://github.com/dovecot/core/commit/17466c748183b19f7775374ce6afbd7bf62d479d Author: Timo Sirainen Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/lib/istream-seekable.c Log Message: ----------- lib: Assert if i_stream_create_seekable_path(temp_path_prefix==NULL) If the stream becomes large enough it would crash then in a callback function, which makes debugging more difficult. From noreply at github.com Mon Sep 19 13:30:26 2016 From: noreply at github.com (GitHub) Date: Mon, 19 Sep 2016 06:30:26 -0700 Subject: [dovecot/core] ec50ef: lib: Assert if i_stream_create_seekable_path(temp_... Message-ID: <57dfe8725e24c_64e33ffc258a713481499@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: ec50efeec1c16fc3fcb64373caa3e69da2209d8a https://github.com/dovecot/core/commit/ec50efeec1c16fc3fcb64373caa3e69da2209d8a Author: Timo Sirainen Date: 2016-09-19 (Mon, 19 Sep 2016) Changed paths: M src/lib/istream-seekable.c Log Message: ----------- lib: Assert if i_stream_create_seekable_path(temp_path_prefix==NULL) If the stream becomes large enough it would crash then in a callback function, which makes debugging more difficult. From noreply at github.com Tue Sep 20 06:30:10 2016 From: noreply at github.com (GitHub) Date: Mon, 19 Sep 2016 23:30:10 -0700 Subject: [dovecot/core] 15cdc6: lib: Prevent crash in ioloop Message-ID: <57e0d7721719f_5e703ffd371c3134353cd@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 15cdc6b0ecd87f4cddc18e765601ad5c6b1b5ab1 https://github.com/dovecot/core/commit/15cdc6b0ecd87f4cddc18e765601ad5c6b1b5ab1 Author: Aki Tuomi Date: 2016-09-20 (Tue, 20 Sep 2016) Changed paths: M src/lib/ioloop.c Log Message: ----------- lib: Prevent crash in ioloop If only non-fd sources and no timeouts are in ioloop, prevent crash and unnecessary waiting when there are pending IOs. Commit: 80cfaba9e253545cbcd08f84939b27cdbb4a50d0 https://github.com/dovecot/core/commit/80cfaba9e253545cbcd08f84939b27cdbb4a50d0 Author: Aki Tuomi Date: 2016-09-20 (Tue, 20 Sep 2016) Changed paths: M src/lib/ioloop-epoll.c Log Message: ----------- lib: Ensure handler_context is not NULL handler context must not be NULL here. Compare: https://github.com/dovecot/core/compare/17466c748183...80cfaba9e253 From noreply at github.com Tue Sep 20 09:00:11 2016 From: noreply at github.com (GitHub) Date: Tue, 20 Sep 2016 02:00:11 -0700 Subject: [dovecot/core] 452d00: lib-dcrypt: Makefile.am fix Message-ID: <57e0fa9b96be9_72683fe3b53fd134122379@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 452d0005a47c6872590346f5ea8b247974689ac9 https://github.com/dovecot/core/commit/452d0005a47c6872590346f5ea8b247974689ac9 Author: Aki Tuomi Date: 2016-09-20 (Tue, 20 Sep 2016) Changed paths: M src/lib-dcrypt/Makefile.am Log Message: ----------- lib-dcrypt: Makefile.am fix Remove dcrypt.c from openssl library and add missing slash From noreply at github.com Tue Sep 20 09:00:17 2016 From: noreply at github.com (GitHub) Date: Tue, 20 Sep 2016 02:00:17 -0700 Subject: [dovecot/core] b03157: lib: Prevent crash in ioloop Message-ID: <57e0faa1dc142_574c3f9e9598f1342182e3@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: b03157a2c4bda87dfef52c591a35e95b260be15b https://github.com/dovecot/core/commit/b03157a2c4bda87dfef52c591a35e95b260be15b Author: Aki Tuomi Date: 2016-09-20 (Tue, 20 Sep 2016) Changed paths: M src/lib/ioloop.c Log Message: ----------- lib: Prevent crash in ioloop If only non-fd sources and no timeouts are in ioloop, prevent crash and unnecessary waiting when there are pending IOs. Commit: 7cf692d72a8118fd8eadec1d3f052b702f66e08c https://github.com/dovecot/core/commit/7cf692d72a8118fd8eadec1d3f052b702f66e08c Author: Aki Tuomi Date: 2016-09-20 (Tue, 20 Sep 2016) Changed paths: M src/lib/ioloop-epoll.c Log Message: ----------- lib: Ensure handler_context is not NULL handler context must not be NULL here. Compare: https://github.com/dovecot/core/compare/ec50efeec1c1...7cf692d72a81 From noreply at github.com Tue Sep 20 13:00:12 2016 From: noreply at github.com (GitHub) Date: Tue, 20 Sep 2016 06:00:12 -0700 Subject: [dovecot/core] f49f1c: lib-dcrypt: Set NOPLUGIN_LDFLAGS to empty Message-ID: <57e132dc864f2_40623fa34d1bb130971f1@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f49f1c5fa6a9a55a194e5ada042df134907278f4 https://github.com/dovecot/core/commit/f49f1c5fa6a9a55a194e5ada042df134907278f4 Author: Aki Tuomi Date: 2016-09-20 (Tue, 20 Sep 2016) Changed paths: M src/lib-dcrypt/Makefile.am Log Message: ----------- lib-dcrypt: Set NOPLUGIN_LDFLAGS to empty Avoids -Wl,--as-needed here From noreply at github.com Tue Sep 20 15:30:10 2016 From: noreply at github.com (GitHub) Date: Tue, 20 Sep 2016 08:30:10 -0700 Subject: [dovecot/core] bd6a80: lib-storage: remove unused internal_attribute argu... Message-ID: <57e156026c4e6_35583fbc439cd13477367@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: bd6a8056771b6150685dea319ab5a94e021d17f1 https://github.com/dovecot/core/commit/bd6a8056771b6150685dea319ab5a94e021d17f1 Author: Josef 'Jeff' Sipek Date: 2016-09-20 (Tue, 20 Sep 2016) Changed paths: M src/lib-storage/index/index-attribute.c M src/lib-storage/index/index-storage.h M src/lib-storage/mail-storage-private.h M src/lib-storage/mailbox-attribute-internal.c M src/lib-storage/mailbox-attribute.c M src/lib-storage/mailbox-attribute.h M src/plugins/acl/acl-attributes.c M src/plugins/acl/acl-storage.h Log Message: ----------- lib-storage: remove unused internal_attribute argument from attribute_{get,set} This removes an argument added in 9f37ef2a9192e7d47e3d7ac959080fd01120f2e9 but obsoleted (but not removed) in d1147c225f64596fc5eeb1cb2aab31b3c57d5215. Not only does this change simplify the codebase, it actually brings the API closer to what it was back in 2.2. From noreply at github.com Tue Sep 20 18:00:12 2016 From: noreply at github.com (GitHub) Date: Tue, 20 Sep 2016 11:00:12 -0700 Subject: [dovecot/core] abd420: imap-login: Honor nopipelining during preauth Message-ID: <57e1792c8225f_5a633fc8aac272b826803db@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: abd4203d97d6db19550fc45d6b6806b2deadb625 https://github.com/dovecot/core/commit/abd4203d97d6db19550fc45d6b6806b2deadb625 Author: Aki Tuomi Date: 2016-09-20 (Tue, 20 Sep 2016) Changed paths: M src/imap-login/imap-proxy.c Log Message: ----------- imap-login: Honor nopipelining during preauth Commit: c24150b68efb24c12e95ec101f382d5c40cd15c9 https://github.com/dovecot/core/commit/c24150b68efb24c12e95ec101f382d5c40cd15c9 Author: Aki Tuomi Date: 2016-09-20 (Tue, 20 Sep 2016) Changed paths: M src/imap-login/imap-proxy.c Log Message: ----------- imap-proxy: Fix typo in comment Compare: https://github.com/dovecot/core/compare/bd6a8056771b...c24150b68efb From noreply at github.com Tue Sep 20 19:30:13 2016 From: noreply at github.com (GitHub) Date: Tue, 20 Sep 2016 12:30:13 -0700 Subject: [dovecot/core] 9a6fe6: imap-login: Add missing brace Message-ID: <57e18e4535e54_783a3fb4d982913c720b7@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9a6fe618193d3029328a9b056d4435f135a64bfd https://github.com/dovecot/core/commit/9a6fe618193d3029328a9b056d4435f135a64bfd Author: Aki Tuomi Date: 2016-09-20 (Tue, 20 Sep 2016) Changed paths: M src/imap-login/imap-proxy.c Log Message: ----------- imap-login: Add missing brace From noreply at github.com Tue Sep 20 19:38:39 2016 From: noreply at github.com (GitHub) Date: Tue, 20 Sep 2016 12:38:39 -0700 Subject: [dovecot/pigeonhole] a43487: doveadm-sieve: Update attribute API usage Message-ID: <57e1903f52c8d_34b93fa92556113011667b@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: a43487489053f28a7aed09729b51b90d81902310 https://github.com/dovecot/pigeonhole/commit/a43487489053f28a7aed09729b51b90d81902310 Author: Josef 'Jeff' Sipek Date: 2016-09-20 (Tue, 20 Sep 2016) Changed paths: M src/plugins/doveadm-sieve/doveadm-sieve-sync.c Log Message: ----------- doveadm-sieve: Update attribute API usage From noreply at github.com Wed Sep 21 09:31:07 2016 From: noreply at github.com (GitHub) Date: Wed, 21 Sep 2016 02:31:07 -0700 Subject: [dovecot/core] 4c9caa: doveadm fs get: Fixed logging error messages. Message-ID: <57e2535bde192_12f3fe85d3df13c95923@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 4c9caab4525a8d59f76e6943f99a73e4dc6e75f5 https://github.com/dovecot/core/commit/4c9caab4525a8d59f76e6943f99a73e4dc6e75f5 Author: Timo Sirainen Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/doveadm/doveadm-fs.c Log Message: ----------- doveadm fs get: Fixed logging error messages. The error is in istream, not in fs. From noreply at github.com Wed Sep 21 11:00:12 2016 From: noreply at github.com (GitHub) Date: Wed, 21 Sep 2016 04:00:12 -0700 Subject: [dovecot/core] a81be8: lib: Fixed ostream-failure-at with blocking parent... Message-ID: <57e2683cae2ed_12983faa0b32513c72681@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: a81be83a3bb00b7b31b832f50bd8542e62a71891 https://github.com/dovecot/core/commit/a81be83a3bb00b7b31b832f50bd8542e62a71891 Author: Timo Sirainen Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/lib/ostream-failure-at.c Log Message: ----------- lib: Fixed ostream-failure-at with blocking parent stream. Blocking ostream returns either a full success or a full failure. It can't return that only n/m bytes were written. Fixes assert: Panic: file ostream.c: line 255 (o_stream_sendv_int): assertion failed: (!stream->blocking) From noreply at github.com Wed Sep 21 12:30:11 2016 From: noreply at github.com (GitHub) Date: Wed, 21 Sep 2016 05:30:11 -0700 Subject: [dovecot/core] bac642: lib: Fixed istream-chain when it has multiple "pre... Message-ID: <57e27d5320808_208d3fdb5188d1348107b@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: bac6427712674cd4b6146ef51f90c14eb9603db6 https://github.com/dovecot/core/commit/bac6427712674cd4b6146ef51f90c14eb9603db6 Author: Timo Sirainen Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/lib/istream-chain.c M src/lib/test-istream-chain.c Log Message: ----------- lib: Fixed istream-chain when it has multiple "previous streams". Fixes assert: Panic: file istream-chain.c: line 223 (i_stream_chain_read): assertion failed: (cur_data_pos == data_size) Unit test for it by Stephan Bosch. From noreply at github.com Wed Sep 21 12:30:15 2016 From: noreply at github.com (GitHub) Date: Wed, 21 Sep 2016 05:30:15 -0700 Subject: [dovecot/core] dca450: lib-dcrypt: Makefile.am fix Message-ID: <57e27d57d7e0e_44ec3fb44743113418095a@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: dca450b306f45867ea7783420463cfae67b27362 https://github.com/dovecot/core/commit/dca450b306f45867ea7783420463cfae67b27362 Author: Aki Tuomi Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/lib-dcrypt/Makefile.am Log Message: ----------- lib-dcrypt: Makefile.am fix Remove dcrypt.c from openssl library and add missing slash Commit: 5983575afd9a198dc3a845176d65b7bebfd1dfa3 https://github.com/dovecot/core/commit/5983575afd9a198dc3a845176d65b7bebfd1dfa3 Author: Aki Tuomi Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/lib-dcrypt/Makefile.am Log Message: ----------- lib-dcrypt: Set NOPLUGIN_LDFLAGS to empty Avoids -Wl,--as-needed here Commit: 4b7ae2a9f1df677ca5dc1a048ff268b225068839 https://github.com/dovecot/core/commit/4b7ae2a9f1df677ca5dc1a048ff268b225068839 Author: Aki Tuomi Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/imap-login/imap-proxy.c Log Message: ----------- imap-login: Honor nopipelining during preauth Commit: 24068f99bbf1ff2f5478b267d954e516f9d984f5 https://github.com/dovecot/core/commit/24068f99bbf1ff2f5478b267d954e516f9d984f5 Author: Aki Tuomi Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/imap-login/imap-proxy.c Log Message: ----------- imap-proxy: Fix typo in comment Commit: e26249c8cfed9de4e76db1d8abc31c06ced9e91a https://github.com/dovecot/core/commit/e26249c8cfed9de4e76db1d8abc31c06ced9e91a Author: Aki Tuomi Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/imap-login/imap-proxy.c Log Message: ----------- imap-login: Add missing brace Commit: ca0eec0d483ed1e9970b15b17230f2a785656ff5 https://github.com/dovecot/core/commit/ca0eec0d483ed1e9970b15b17230f2a785656ff5 Author: Timo Sirainen Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/doveadm/doveadm-fs.c Log Message: ----------- doveadm fs get: Fixed logging error messages. The error is in istream, not in fs. Commit: 946de454a6e2594717bdc4450164dd0db1e96b60 https://github.com/dovecot/core/commit/946de454a6e2594717bdc4450164dd0db1e96b60 Author: Timo Sirainen Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/lib/istream-chain.c M src/lib/test-istream-chain.c Log Message: ----------- lib: Fixed istream-chain when it has multiple "previous streams". Fixes assert: Panic: file istream-chain.c: line 223 (i_stream_chain_read): assertion failed: (cur_data_pos == data_size) Unit test for it by Stephan Bosch. Compare: https://github.com/dovecot/core/compare/7cf692d72a81...946de454a6e2 From noreply at github.com Wed Sep 21 13:00:09 2016 From: noreply at github.com (GitHub) Date: Wed, 21 Sep 2016 06:00:09 -0700 Subject: [dovecot/core] f2edbc: lib-dcrypt: Don't finalize encryption on o_stream_... Message-ID: <57e28459f37c6_131f3fbdecbb1130666eb@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f2edbc51be62d7da4a4b37a72f9832851f669caa https://github.com/dovecot/core/commit/f2edbc51be62d7da4a4b37a72f9832851f669caa Author: Timo Sirainen Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/lib-dcrypt/ostream-encrypt.c Log Message: ----------- lib-dcrypt: Don't finalize encryption on o_stream_flush() For example the default o_stream_uncork() implementation enforces flushing and it's probably better not to change that. In general there's really no reason to perform the finalization at flush when the stream can't be written to anymore (whereas lib-compression ostreams allow writes after flushes). From noreply at github.com Wed Sep 21 13:00:16 2016 From: noreply at github.com (GitHub) Date: Wed, 21 Sep 2016 06:00:16 -0700 Subject: [dovecot/core] bfed4b: lib-dcrypt: Don't finalize encryption on o_stream_... Message-ID: <57e2846084db_7b7d3fc5ecd8f1341617da@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: bfed4b149042b2b2a45bbc549c44c488c81553c5 https://github.com/dovecot/core/commit/bfed4b149042b2b2a45bbc549c44c488c81553c5 Author: Timo Sirainen Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/lib-dcrypt/ostream-encrypt.c Log Message: ----------- lib-dcrypt: Don't finalize encryption on o_stream_flush() For example the default o_stream_uncork() implementation enforces flushing and it's probably better not to change that. In general there's really no reason to perform the finalization at flush when the stream can't be written to anymore (whereas lib-compression ostreams allow writes after flushes). From noreply at github.com Wed Sep 21 13:30:11 2016 From: noreply at github.com (GitHub) Date: Wed, 21 Sep 2016 06:30:11 -0700 Subject: [dovecot/core] 1d4f01: lib: test-istream-chain fixes Message-ID: <57e28b6387374_5b303ff683ac713c1945a8@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 1d4f019ffe68c9faa20f71e1c06df0bbad54917e https://github.com/dovecot/core/commit/1d4f019ffe68c9faa20f71e1c06df0bbad54917e Author: Timo Sirainen Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/lib/test-istream-chain.c Log Message: ----------- lib: test-istream-chain fixes From noreply at github.com Wed Sep 21 18:00:12 2016 From: noreply at github.com (GitHub) Date: Wed, 21 Sep 2016 11:00:12 -0700 Subject: [dovecot/core] 2e5e20: login-proxy: Fixed "Host is down" never reseting i... Message-ID: <57e2caacaaed3_328f3fdd0bcdd138104976@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2e5e2047af69e850b8506c8c423f5d4102df9981 https://github.com/dovecot/core/commit/2e5e2047af69e850b8506c8c423f5d4102df9981 Author: Timo Sirainen Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/login-common/login-proxy.c Log Message: ----------- login-proxy: Fixed "Host is down" never reseting itself. Broken by c8eb8314a, which moved adding num_waiting_connections earlier. After that it was never 0 at the check time. From noreply at github.com Wed Sep 21 19:00:16 2016 From: noreply at github.com (GitHub) Date: Wed, 21 Sep 2016 12:00:16 -0700 Subject: [dovecot/core] e7d12f: lib: test-istream-chain fixes Message-ID: <57e2d8c058065_719e3fd3287c7140126545@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: e7d12f1883e191f3ee4dafb4a88f2a6bc143e915 https://github.com/dovecot/core/commit/e7d12f1883e191f3ee4dafb4a88f2a6bc143e915 Author: Timo Sirainen Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/lib/test-istream-chain.c Log Message: ----------- lib: test-istream-chain fixes Commit: 566c9a223ea01d0aa611401a889153cc8f43dc87 https://github.com/dovecot/core/commit/566c9a223ea01d0aa611401a889153cc8f43dc87 Author: Timo Sirainen Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/login-common/login-proxy.c Log Message: ----------- login-proxy: Fixed "Host is down" never reseting itself. Broken by c8eb8314a, which moved adding num_waiting_connections earlier. After that it was never 0 at the check time. Compare: https://github.com/dovecot/core/compare/bfed4b149042...566c9a223ea0 From noreply at github.com Thu Sep 22 11:00:12 2016 From: noreply at github.com (GitHub) Date: Thu, 22 Sep 2016 04:00:12 -0700 Subject: [dovecot/core] 5bcac2: dbox: mailbox_update() shouldn't reset pop3-uidl h... Message-ID: <57e3b9bc65244_57f3fc2af721134978c2@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 5bcac2212ca86e72289faa7db2c509841fbdbd59 https://github.com/dovecot/core/commit/5bcac2212ca86e72289faa7db2c509841fbdbd59 Author: Timo Sirainen Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/lib-storage/index/dbox-multi/mdbox-storage.c M src/lib-storage/index/dbox-single/sdbox-storage.c Log Message: ----------- dbox: mailbox_update() shouldn't reset pop3-uidl header. This broke reading migrated POP3 UIDLs. From noreply at github.com Thu Sep 22 12:00:12 2016 From: noreply at github.com (GitHub) Date: Thu, 22 Sep 2016 05:00:12 -0700 Subject: [dovecot/core] a415de: pop3-migration: "first POP3 msg" warning didn't ac... Message-ID: <57e3c7cce942d_65263fb5063f31301572a4@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: a415de5243c4a22df91496274762ca6637e9a104 https://github.com/dovecot/core/commit/a415de5243c4a22df91496274762ca6637e9a104 Author: Timo Sirainen Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/plugins/pop3-migration/pop3-migration-plugin.c Log Message: ----------- pop3-migration: "first POP3 msg" warning didn't actually show the first one. It was showing the first index in an array, which had nothing to do with being the first POP3 message number. Commit: f4b1d510a8b66c71ea588ed16f497944da035382 https://github.com/dovecot/core/commit/f4b1d510a8b66c71ea588ed16f497944da035382 Author: Timo Sirainen Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/lib-mail/message-header-hash.c Log Message: ----------- lib-mail: Removed obsolete comment about message_header_hash_more() pop3-migration plugin uses this function now, so it doesn't need to be kept in sync. Commit: b75eba4f65c7630d3691f07d22ff4bdfcac5054d https://github.com/dovecot/core/commit/b75eba4f65c7630d3691f07d22ff4bdfcac5054d Author: Timo Sirainen Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/doveadm/dsync/dsync-mail.c M src/lib-mail/message-header-hash.c M src/lib-mail/message-header-hash.h M src/lib-mail/test-message-header-hash.c M src/plugins/pop3-migration/pop3-migration-plugin.c Log Message: ----------- lib-mail: message_header_hash_more() now allows input in any slices. There wasn't necessarily any guarantees that the input would be sliced in such a way that the repeating '?' would be dropped the same way every time. Commit: 789645e6790507d99f900ecb7c48e1d65a015458 https://github.com/dovecot/core/commit/789645e6790507d99f900ecb7c48e1d65a015458 Author: Aki Tuomi Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/lib/ioloop.c Log Message: ----------- lib: Update ioloop attributes With pending IO, the ioloop attributes still need updating, instead of just returning. Commit: e5a55bb6b867ee3ed95ac216996ff2e24bd596cc https://github.com/dovecot/core/commit/e5a55bb6b867ee3ed95ac216996ff2e24bd596cc Author: Aki Tuomi Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/lib/test-ioloop.c Log Message: ----------- lib: Add test for pending io without timeouts Compare: https://github.com/dovecot/core/compare/5bcac2212ca8...e5a55bb6b867 From noreply at github.com Thu Sep 22 12:00:17 2016 From: noreply at github.com (GitHub) Date: Thu, 22 Sep 2016 05:00:17 -0700 Subject: [dovecot/core] 051db9: dbox: mailbox_update() shouldn't reset pop3-uidl h... Message-ID: <57e3c7d191274_749a3ffc4c72f140514f8@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 051db9c68a7743d03f3f40ea39b87565cff7ff44 https://github.com/dovecot/core/commit/051db9c68a7743d03f3f40ea39b87565cff7ff44 Author: Timo Sirainen Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/lib-storage/index/dbox-multi/mdbox-storage.c M src/lib-storage/index/dbox-single/sdbox-storage.c Log Message: ----------- dbox: mailbox_update() shouldn't reset pop3-uidl header. This broke reading migrated POP3 UIDLs. Commit: a3963433feb6d47b42fde78d166af04e58e21644 https://github.com/dovecot/core/commit/a3963433feb6d47b42fde78d166af04e58e21644 Author: Timo Sirainen Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/plugins/pop3-migration/pop3-migration-plugin.c Log Message: ----------- pop3-migration: "first POP3 msg" warning didn't actually show the first one. It was showing the first index in an array, which had nothing to do with being the first POP3 message number. Commit: a3caf917dbf0cdfe529b5e3dd4f9336a7cfdb4e4 https://github.com/dovecot/core/commit/a3caf917dbf0cdfe529b5e3dd4f9336a7cfdb4e4 Author: Timo Sirainen Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/lib-mail/message-header-hash.c Log Message: ----------- lib-mail: Removed obsolete comment about message_header_hash_more() pop3-migration plugin uses this function now, so it doesn't need to be kept in sync. Commit: 3cefb7d2990de3a12f58eeaf0634ea4bfb74dd5d https://github.com/dovecot/core/commit/3cefb7d2990de3a12f58eeaf0634ea4bfb74dd5d Author: Timo Sirainen Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/doveadm/dsync/dsync-mail.c M src/lib-mail/message-header-hash.c M src/lib-mail/message-header-hash.h M src/lib-mail/test-message-header-hash.c M src/plugins/pop3-migration/pop3-migration-plugin.c Log Message: ----------- lib-mail: message_header_hash_more() now allows input in any slices. There wasn't necessarily any guarantees that the input would be sliced in such a way that the repeating '?' would be dropped the same way every time. Commit: 34e1b3a81414e334d873406a9c421fd7cedb3b37 https://github.com/dovecot/core/commit/34e1b3a81414e334d873406a9c421fd7cedb3b37 Author: Aki Tuomi Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/lib/ioloop.c Log Message: ----------- lib: Update ioloop attributes With pending IO, the ioloop attributes still need updating, instead of just returning. Commit: b0f7c3f61fa428f14aceda64ca03a554dfb476ca https://github.com/dovecot/core/commit/b0f7c3f61fa428f14aceda64ca03a554dfb476ca Author: Aki Tuomi Date: 2016-09-22 (Thu, 22 Sep 2016) Changed paths: M src/lib/test-ioloop.c Log Message: ----------- lib: Add test for pending io without timeouts Compare: https://github.com/dovecot/core/compare/566c9a223ea0...b0f7c3f61fa4 From noreply at github.com Fri Sep 23 12:30:12 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Sep 2016 05:30:12 -0700 Subject: [dovecot/core] 666d85: login proxy: Don't leak connections if reconnect f... Message-ID: <57e520548cf35_3503fe112999138998f4@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 666d85f7060e04e8fb021f1347e853de28107e89 https://github.com/dovecot/core/commit/666d85f7060e04e8fb021f1347e853de28107e89 Author: Timo Sirainen Date: 2016-09-23 (Fri, 23 Sep 2016) Changed paths: M src/login-common/login-proxy.c Log Message: ----------- login proxy: Don't leak connections if reconnect fails with "Host is down" Double-disconnection was also attempting to close the same fd twice, but I think that couldn't have happened before this leak was fixed. From noreply at github.com Fri Sep 23 12:30:17 2016 From: noreply at github.com (GitHub) Date: Fri, 23 Sep 2016 05:30:17 -0700 Subject: [dovecot/core] 211d75: login proxy: Don't leak connections if reconnect f... Message-ID: <57e5205977e3a_380d3fba97931138696f5@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 211d75a91b69c8fea39fcf15b3d19da77ad3ff46 https://github.com/dovecot/core/commit/211d75a91b69c8fea39fcf15b3d19da77ad3ff46 Author: Timo Sirainen Date: 2016-09-23 (Fri, 23 Sep 2016) Changed paths: M src/login-common/login-proxy.c Log Message: ----------- login proxy: Don't leak connections if reconnect fails with "Host is down" Double-disconnection was also attempting to close the same fd twice, but I think that couldn't have happened before this leak was fixed. From noreply at github.com Mon Sep 26 13:00:17 2016 From: noreply at github.com (GitHub) Date: Mon, 26 Sep 2016 06:00:17 -0700 Subject: [dovecot/core] d05c38: lib-storage: document mailbox and server attribute... Message-ID: <57e91be179c96_50893ffc06fa5130116593@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: d05c38abdb117fd9c16a2ea44eb2e29632f0e8a5 https://github.com/dovecot/core/commit/d05c38abdb117fd9c16a2ea44eb2e29632f0e8a5 Author: Josef 'Jeff' Sipek Date: 2016-09-26 (Mon, 26 Sep 2016) Changed paths: M src/lib-storage/mailbox-attribute.h Log Message: ----------- lib-storage: document mailbox and server attribute handling Commit: f9c0271a202ad969b6997c8552f15c5324385d11 https://github.com/dovecot/core/commit/f9c0271a202ad969b6997c8552f15c5324385d11 Author: Josef 'Jeff' Sipek Date: 2016-09-26 (Mon, 26 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-mailbox-metadata.c Log Message: ----------- doveadm: lowercase attribute names before trying to parse them This now matches what the imap server does. Commit: 0878b1e492b7c10a2cb99ef479dbb8506992309a https://github.com/dovecot/core/commit/0878b1e492b7c10a2cb99ef479dbb8506992309a Author: Josef 'Jeff' Sipek Date: 2016-09-26 (Mon, 26 Sep 2016) Changed paths: M src/lib-storage/index/index-attribute.c Log Message: ----------- lib-storage: remove attribute accessibility checks index_storage_attribute_{set,get} should assume that the caller performed due diligence and checked whether or not the user is allowed to store under the key. Commit: c262cd36dd9f5e5c02b0cb34010f19db9d72c4c5 https://github.com/dovecot/core/commit/c262cd36dd9f5e5c02b0cb34010f19db9d72c4c5 Author: Josef 'Jeff' Sipek Date: 2016-09-26 (Mon, 26 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-mailbox-metadata.c M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-mail.h Log Message: ----------- doveadm: allow access to server attributes via empty mailbox name Commit: 70d190cb9e1223cbf8b33e3850bf1ce4a96ccfcf https://github.com/dovecot/core/commit/70d190cb9e1223cbf8b33e3850bf1ce4a96ccfcf Author: Josef 'Jeff' Sipek Date: 2016-09-26 (Mon, 26 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-mailbox-metadata.c Log Message: ----------- doveadm: refactor mailbox attribute get/set/unset/list to share more code Compare: https://github.com/dovecot/core/compare/211d75a91b69...70d190cb9e12 From noreply at github.com Mon Sep 26 14:30:14 2016 From: noreply at github.com (GitHub) Date: Mon, 26 Sep 2016 07:30:14 -0700 Subject: [dovecot/core] 9fa33a: dict-client: Remove timeout when there are only ba... Message-ID: <57e930f6c8d5a_26fb3f82831f913c921e5@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9fa33a0c56e1d9a09c72698097ee269fa04e07b1 https://github.com/dovecot/core/commit/9fa33a0c56e1d9a09c72698097ee269fa04e07b1 Author: Timo Sirainen Date: 2016-09-26 (Mon, 26 Sep 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Remove timeout when there are only background commands. Normally the timeout wasn't added in the first place, but it was if a non-background command was added first and it was followed by a background command. Commit: 8d72f209049edf50f5cd40c56efd2c0b33f892a2 https://github.com/dovecot/core/commit/8d72f209049edf50f5cd40c56efd2c0b33f892a2 Author: Timo Sirainen Date: 2016-09-26 (Mon, 26 Sep 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Don't return "Dict server timeout" too early. This could have happened when many dict commands were being run without the timeout being reset in the middle. Commit: e33462704d38d05c4109929da4923794f699e3cc https://github.com/dovecot/core/commit/e33462704d38d05c4109929da4923794f699e3cc Author: Timo Sirainen Date: 2016-09-26 (Mon, 26 Sep 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Fixed lock and ioloop wait timings in log messages. Previously it was logging the total amount of time spent on lock waits or on ioloop during the existence of the entire process, rather than how much time the command itself was spending on those. This wasn't very useful. Now it also tries to separate the time spent on the main ioloop and in dict_wait(). Compare: https://github.com/dovecot/core/compare/666d85f7060e...e33462704d38 From noreply at github.com Tue Sep 27 11:00:09 2016 From: noreply at github.com (GitHub) Date: Tue, 27 Sep 2016 04:00:09 -0700 Subject: [dovecot/core] f53849: dsync: Renamed "max sync size" parameter from -S t... Message-ID: <57ea5139f344b_6e8b3f9db526f13c8752d@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f538498d8ad0c7781c7aef6c08483b3ea1bea2cd https://github.com/dovecot/core/commit/f538498d8ad0c7781c7aef6c08483b3ea1bea2cd Author: Timo Sirainen Date: 2016-09-27 (Tue, 27 Sep 2016) Changed paths: M src/doveadm/doveadm-dsync.c Log Message: ----------- dsync: Renamed "max sync size" parameter from -S to -I. -S can't be used because it was already used for the generic socket path, so it didn't actually work. Commit: 93a4387a19cdb45cec27eb951c9fcdb31fe5b1d5 https://github.com/dovecot/core/commit/93a4387a19cdb45cec27eb951c9fcdb31fe5b1d5 Author: Timo Sirainen Date: 2016-09-27 (Tue, 27 Sep 2016) Changed paths: M src/doveadm/dsync/dsync-mailbox-export.c Log Message: ----------- dsync: Virtual sizes weren't exported properly with -I parameter. Although they were incorrectly being exported with -T parameter. This makes -I work without assert-crashing. Compare: https://github.com/dovecot/core/compare/e33462704d38...93a4387a19cd From noreply at github.com Tue Sep 27 11:00:15 2016 From: noreply at github.com (GitHub) Date: Tue, 27 Sep 2016 04:00:15 -0700 Subject: [dovecot/core] 35ed78: dsync: Renamed "max sync size" parameter from -S t... Message-ID: <57ea513f3f1d7_503c3fcb2693f1301060c3@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 35ed782d4c07b9a055145de95492bcca8cb9e290 https://github.com/dovecot/core/commit/35ed782d4c07b9a055145de95492bcca8cb9e290 Author: Timo Sirainen Date: 2016-09-27 (Tue, 27 Sep 2016) Changed paths: M src/doveadm/doveadm-dsync.c Log Message: ----------- dsync: Renamed "max sync size" parameter from -S to -I. -S can't be used because it was already used for the generic socket path, so it didn't actually work. Commit: 6d8be3298359a54ceef0758838a0118f89d7227b https://github.com/dovecot/core/commit/6d8be3298359a54ceef0758838a0118f89d7227b Author: Timo Sirainen Date: 2016-09-27 (Tue, 27 Sep 2016) Changed paths: M src/doveadm/dsync/dsync-mailbox-export.c Log Message: ----------- dsync: Virtual sizes weren't exported properly with -I parameter. Although they were incorrectly being exported with -T parameter. This makes -I work without assert-crashing. Compare: https://github.com/dovecot/core/compare/70d190cb9e12...6d8be3298359 From noreply at github.com Tue Sep 27 11:30:12 2016 From: noreply at github.com (GitHub) Date: Tue, 27 Sep 2016 04:30:12 -0700 Subject: [dovecot/core] bf5776: lib-storage: Update mailbox.recent_flags_count cor... Message-ID: <57ea5844207_6ea23feee6fa912c105528@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: bf57767df6be53431994f813a8b240b5be180972 https://github.com/dovecot/core/commit/bf57767df6be53431994f813a8b240b5be180972 Author: Timo Sirainen Date: 2016-09-27 (Tue, 27 Sep 2016) Changed paths: M src/lib-storage/mailbox-recent-flags.c Log Message: ----------- lib-storage: Update mailbox.recent_flags_count correctly. The counter was increased even if the UID was already in recent_flags. This is the only place where I found that recent_flags and recent_flags_count could become desynced (which they definitely were in a core dump), so hopefully this fixes assert-crashes like: Panic: file index-status.c: line 130 (index_storage_get_open_status): assertion failed: (status_r->recent <= status_r->messages) From noreply at github.com Tue Sep 27 11:30:14 2016 From: noreply at github.com (GitHub) Date: Tue, 27 Sep 2016 04:30:14 -0700 Subject: [dovecot/core] 8428e4: lib-storage: Update mailbox.recent_flags_count cor... Message-ID: <57ea584696e2b_368e3fb23dfbf14c22627@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 8428e40d8ec8b906882365f8c9a7036219c24dff https://github.com/dovecot/core/commit/8428e40d8ec8b906882365f8c9a7036219c24dff Author: Timo Sirainen Date: 2016-09-27 (Tue, 27 Sep 2016) Changed paths: M src/lib-storage/mailbox-recent-flags.c Log Message: ----------- lib-storage: Update mailbox.recent_flags_count correctly. The counter was increased even if the UID was already in recent_flags. This is the only place where I found that recent_flags and recent_flags_count could become desynced (which they definitely were in a core dump), so hopefully this fixes assert-crashes like: Panic: file index-status.c: line 130 (index_storage_get_open_status): assertion failed: (status_r->recent <= status_r->messages) From noreply at github.com Tue Sep 27 14:00:11 2016 From: noreply at github.com (GitHub) Date: Tue, 27 Sep 2016 07:00:11 -0700 Subject: [dovecot/core] f6f50f: master: Removed hardcoded listen() backlog limit. Message-ID: <57ea7b6b7f3de_71bb3fa54d73512c56963@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f6f50f528f6dce764065780bf88ee1acb2422b0a https://github.com/dovecot/core/commit/f6f50f528f6dce764065780bf88ee1acb2422b0a Author: Timo Sirainen Date: 2016-09-27 (Tue, 27 Sep 2016) Changed paths: M src/master/service-listen.c Log Message: ----------- master: Removed hardcoded listen() backlog limit. If it's already too large, the kernel will truncate it automatically. So there shouldn't be any reason for us to explicitly limit it. From noreply at github.com Wed Sep 28 12:00:11 2016 From: noreply at github.com (GitHub) Date: Wed, 28 Sep 2016 05:00:11 -0700 Subject: [dovecot/core] a75122: imap-hibernate: Accept RFC DONE\IDLE Message-ID: <57ebb0cb4d5ad_bfd3fe906a8b130663d2@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: a7512265bcded54af05e68e2383d11cb8638b513 https://github.com/dovecot/core/commit/a7512265bcded54af05e68e2383d11cb8638b513 Author: Aki Tuomi Date: 2016-09-28 (Wed, 28 Sep 2016) Changed paths: M src/imap-hibernate/imap-client.c Log Message: ----------- imap-hibernate: Accept RFC DONE\IDLE Change imap-hibernate to accept DONE\r\n IDLE\r\n as well, which is specified by RFC From noreply at github.com Thu Sep 29 07:30:10 2016 From: noreply at github.com (GitHub) Date: Thu, 29 Sep 2016 00:30:10 -0700 Subject: [dovecot/core] bc4f0a: doveadm-import: Use target user as source user Message-ID: <57ecc3022b185_17e03f843ced114c468a7@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: bc4f0aef7504adba18888997cb5530c9a39cfde7 https://github.com/dovecot/core/commit/bc4f0aef7504adba18888997cb5530c9a39cfde7 Author: Aki Tuomi Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-import.c Log Message: ----------- doveadm-import: Use target user as source user This is done to avoid spurious error messages caused by being ran as root. Commit: b35ac65c882e30c2d0c166fd37e5225806bf4b57 https://github.com/dovecot/core/commit/b35ac65c882e30c2d0c166fd37e5225806bf4b57 Author: Aki Tuomi Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-import.c Log Message: ----------- doveadm-import: Add -U parameter to specify source user When doing import, you can specify which user to use as source user. Commit: 042c55b2fd8cf13cb28e36b835739fc94e800739 https://github.com/dovecot/core/commit/042c55b2fd8cf13cb28e36b835739fc94e800739 Author: Aki Tuomi Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M doc/man/doveadm-import.1.in Log Message: ----------- doveadm-import: Update manpage Compare: https://github.com/dovecot/core/compare/a7512265bcde...042c55b2fd8c From noreply at github.com Thu Sep 29 10:30:15 2016 From: noreply at github.com (GitHub) Date: Thu, 29 Sep 2016 03:30:15 -0700 Subject: [dovecot/core] 351aa0: imap-hibernate: Accept RFC DONE\IDLE Message-ID: <57eced371ace_6e783fdb977e3134681a8@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 351aa01c6ea46fec7e5ed206b4cdc6d42a4e4e5f https://github.com/dovecot/core/commit/351aa01c6ea46fec7e5ed206b4cdc6d42a4e4e5f Author: Aki Tuomi Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M src/imap-hibernate/imap-client.c Log Message: ----------- imap-hibernate: Accept RFC DONE\IDLE Change imap-hibernate to accept DONE\r\n IDLE\r\n as well, which is specified by RFC Commit: e62a4b5b48e7bf5ce5a81442f2f2f6fb9830633f https://github.com/dovecot/core/commit/e62a4b5b48e7bf5ce5a81442f2f2f6fb9830633f Author: Aki Tuomi Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-import.c Log Message: ----------- doveadm-import: Use target user as source user This is done to avoid spurious error messages caused by being ran as root. Commit: 9811490b94b73949813d95ba2fb52cbf8b0ba4fe https://github.com/dovecot/core/commit/9811490b94b73949813d95ba2fb52cbf8b0ba4fe Author: Aki Tuomi Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M src/doveadm/doveadm-mail-import.c Log Message: ----------- doveadm-import: Add -U parameter to specify source user When doing import, you can specify which user to use as source user. Commit: c549d5104e11aa8b6f24111217adc9e2aa78c677 https://github.com/dovecot/core/commit/c549d5104e11aa8b6f24111217adc9e2aa78c677 Author: Aki Tuomi Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M doc/man/doveadm-import.1.in Log Message: ----------- doveadm-import: Update manpage Compare: https://github.com/dovecot/core/compare/8428e40d8ec8...c549d5104e11 From noreply at github.com Thu Sep 29 12:30:09 2016 From: noreply at github.com (GitHub) Date: Thu, 29 Sep 2016 05:30:09 -0700 Subject: [dovecot/core] fe9459: lib-storage: If mailbox_move() fails, reset mail_s... Message-ID: <57ed0951e6735_70fb3fb95d123134108372@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: fe9459ab43300c912dc4b16b8872411337f3a25f https://github.com/dovecot/core/commit/fe9459ab43300c912dc4b16b8872411337f3a25f Author: Timo Sirainen Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: If mailbox_move() fails, reset mail_save_context.moving==FALSE Commit: 05150df8fbda6b8fdfafcfb0aa9003f1da4ecaca https://github.com/dovecot/core/commit/05150df8fbda6b8fdfafcfb0aa9003f1da4ecaca Author: Timo Sirainen Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M src/lib-storage/mail-copy.c M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Don't reset mail_save_context.saving too early. If mailbox_save_using_mail() ended up in mail_storage_copy(), saving was set to FALSE before the copy() method was finished running. This caused e.g. notify plugin to think that this was a copy event instead of a save event. Added comments and asserts to clarify how the logic should work between all the different copying/moving/saving flags. Compare: https://github.com/dovecot/core/compare/042c55b2fd8c...05150df8fbda From noreply at github.com Fri Sep 30 10:00:10 2016 From: noreply at github.com (GitHub) Date: Fri, 30 Sep 2016 03:00:10 -0700 Subject: [dovecot/core] 9f7441: lib-storage: mail_user_dup() should duplicate also... Message-ID: <57ee37aa97c72_4b453fb450c4513c7038@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9f7441a47863d44ec303c7980b499b46b3d1671b https://github.com/dovecot/core/commit/9f7441a47863d44ec303c7980b499b46b3d1671b Author: Timo Sirainen Date: 2016-09-30 (Fri, 30 Sep 2016) Changed paths: M src/lib-storage/mail-user.c Log Message: ----------- lib-storage: mail_user_dup() should duplicate also userdb_fields. From noreply at github.com Fri Sep 30 12:00:11 2016 From: noreply at github.com (GitHub) Date: Fri, 30 Sep 2016 05:00:11 -0700 Subject: [dovecot/core] 856011: director: Ignore duplicates in director_servers se... Message-ID: <57ee53cb3c3ad_41e73fd42358f14c25770@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 85601125c9cae82957a57f7b02409c567a59300e https://github.com/dovecot/core/commit/85601125c9cae82957a57f7b02409c567a59300e Author: Timo Sirainen Date: 2016-09-30 (Fri, 30 Sep 2016) Changed paths: M src/director/director-host.c Log Message: ----------- director: Ignore duplicates in director_servers setting. From noreply at github.com Fri Sep 30 12:30:10 2016 From: noreply at github.com (GitHub) Date: Fri, 30 Sep 2016 05:30:10 -0700 Subject: [dovecot/core] f8a9af: lib-test: Allow test_istream_set_*() for test-istr... Message-ID: <57ee5ad27a84d_34413fa2f521b13c29cb@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f8a9af77130785a9d75b133862aa5c341a0b95e6 https://github.com/dovecot/core/commit/f8a9af77130785a9d75b133862aa5c341a0b95e6 Author: Timo Sirainen Date: 2016-09-30 (Fri, 30 Sep 2016) Changed paths: M src/lib-test/test-common.c Log Message: ----------- lib-test: Allow test_istream_set_*() for test-istream's children. It will internally find the test_istream from parents. This simplifies the testing code so that it doesn't have to keep track of both the test_istream and the final istream. Commit: b3987cf9620e7aba403dfd914fe76b19290713cc https://github.com/dovecot/core/commit/b3987cf9620e7aba403dfd914fe76b19290713cc Author: Timo Sirainen Date: 2016-09-30 (Fri, 30 Sep 2016) Changed paths: M src/lib-test/Makefile.am M src/lib-test/test-common.c A src/lib-test/test-istream.c Log Message: ----------- lib-test: Moved test_istream code to its own test-istream.c file. Commit: 11d88fd444070c67d09fe17e4dcb6c319d8833c2 https://github.com/dovecot/core/commit/11d88fd444070c67d09fe17e4dcb6c319d8833c2 Author: Timo Sirainen Date: 2016-09-30 (Fri, 30 Sep 2016) Changed paths: M src/lib-test/Makefile.am M src/lib-test/test-common.h A src/lib-test/test-ostream.c Log Message: ----------- lib-test: Added test_ostream for testing nonblocking ostreams. Compare: https://github.com/dovecot/core/compare/85601125c9ca...11d88fd44407