[dovecot/core] d7b997: lib-program-client: Use restrict-access
GitHub
noreply at github.com
Wed Oct 26 10:11:39 UTC 2016
Branch: refs/heads/release-2.2.26
Home: https://github.com/dovecot/core
Commit: d7b99734f301f0adce551fc9046c2b80a96a5e90
https://github.com/dovecot/core/commit/d7b99734f301f0adce551fc9046c2b80a96a5e90
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/program-client-local.c
M src/lib-program-client/program-client.h
M src/lib-program-client/test-program-client-local.c
M src/lib-program-client/test-program-client-remote.c
Log Message:
-----------
lib-program-client: Use restrict-access
This makes the program-client execution behave
more consistent to the rest of the core code.
Commit: 658ef8bb6209db4f8c9824d1f99731210b8450c1
https://github.com/dovecot/core/commit/658ef8bb6209db4f8c9824d1f99731210b8450c1
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/program-client-private.h
M src/lib-program-client/program-client-remote.c
M src/lib-program-client/program-client.c
Log Message:
-----------
lib-program-client: Disconnect asynchronously
Commit: ddc8331f7096aa30b00aa2359248c4e8db20ddb8
https://github.com/dovecot/core/commit/ddc8331f7096aa30b00aa2359248c4e8db20ddb8
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/program-client-local.c
M src/lib-program-client/program-client.c
Log Message:
-----------
lib-program-client: Use child-wait
This makes the client waiting asynchronous.
Commit: a178ab56f1034a9eefd652900fcedbe6b8d1cd8f
https://github.com/dovecot/core/commit/a178ab56f1034a9eefd652900fcedbe6b8d1cd8f
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/program-client-local.c
M src/lib-program-client/program-client-private.h
M src/lib-program-client/program-client.c
M src/lib-program-client/program-client.h
M src/lib-program-client/test-program-client-local.c
M src/lib-program-client/test-program-client-remote.c
Log Message:
-----------
lib-program-client: Use milliseconds in idle timeout
Commit: 3335722090c3ebd66f60d38eecb7b7ccb9418b0c
https://github.com/dovecot/core/commit/3335722090c3ebd66f60d38eecb7b7ccb9418b0c
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/program-client-local.c
M src/lib-program-client/program-client-private.h
M src/lib-program-client/program-client-remote.c
M src/lib-program-client/program-client.c
Log Message:
-----------
lib-program-client: Add switch_ioloop vfunc
This lets program-client backends do their own
special io loop switching.
Commit: f61107a1ecb84192d85e965243577eb117888a0b
https://github.com/dovecot/core/commit/f61107a1ecb84192d85e965243577eb117888a0b
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/program-client-remote.c
Log Message:
-----------
lib-program-client: Move version string to define
Commit: f805039c1bb0be2e3737170770af93853c16a28c
https://github.com/dovecot/core/commit/f805039c1bb0be2e3737170770af93853c16a28c
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/Makefile.am
Log Message:
-----------
lib-program-client: Disable valgrind
For local test, we can't use valgrind,
it's too unreliable (breaks execution sometimes).
Commit: 2973fd23b651773980c3ea683fa8a6a4fa3508a9
https://github.com/dovecot/core/commit/2973fd23b651773980c3ea683fa8a6a4fa3508a9
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/Makefile.am
M src/lib-program-client/test-program-client-local.c
Log Message:
-----------
lib-program-client: Fix local tests
Commit: 39d56312ab51569502bad28e935a20c2006ac6a3
https://github.com/dovecot/core/commit/39d56312ab51569502bad28e935a20c2006ac6a3
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/test-program-client-remote.c
Log Message:
-----------
lib-program-client: Backport test-program-client-unix
Commit: ffab4d100a52928c2e594f40ee81ae97284d14df
https://github.com/dovecot/core/commit/ffab4d100a52928c2e594f40ee81ae97284d14df
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/program-client.c
Log Message:
-----------
lib-program-client: Fix memory access problem
Commit: f7cb342e86299709f113224f5784b00418c1e700
https://github.com/dovecot/core/commit/f7cb342e86299709f113224f5784b00418c1e700
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M doc/example-config/dovecot-ldap.conf.ext
Log Message:
-----------
dovecot-ldap.conf.ext: Updated sasl_bind comment.
Commit: 6ca2eff8befb4e2e2623bdebb60a052ca2859d4d
https://github.com/dovecot/core/commit/6ca2eff8befb4e2e2623bdebb60a052ca2859d4d
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/plugins/push-notification/push-notification-driver-ox.c
Log Message:
-----------
push-notification: Error handling fix and cleanups.
Commit: 6f04fb1265453f991995361d0aba515cbaae7685
https://github.com/dovecot/core/commit/6f04fb1265453f991995361d0aba515cbaae7685
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M .gitignore
Log Message:
-----------
.gitignore: Updated to include auto-added m4/*
Commit: 9477b299d1912399f0457c1533e803c7d7986d39
https://github.com/dovecot/core/commit/9477b299d1912399f0457c1533e803c7d7986d39
Author: Josef 'Jeff' Sipek <jeff.sipek at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-storage/mailbox-list.c
Log Message:
-----------
lib-storage: clean up mailbox_list_create to improve readability
There is no reason to use mailbox_list_driver_find() here instead of
mailbox_list_find_class() as (1) we do not need the index into the list
driver array, and (2) dealing with double-pointers is harder than regular
pointers.
Commit: 6f8a425df95963cade66aaeb4f651ef710038583
https://github.com/dovecot/core/commit/6f8a425df95963cade66aaeb4f651ef710038583
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib/restrict-access.c
M src/lib/restrict-access.h
Log Message:
-----------
lib: Add drop_setuid_root for restrict_access
drop_setuid_root, when set to true, will detect
and try to drop getuid()==0. This is done by
recovering current effective UID to set->uid
if set->uid == -1, and then doing seteuid(0).
It will also drop out any other extra privileges,
such as extra groups not requested for.
Commit: 1d457281aa12f4b23d009740e0d417b69bc7ce4d
https://github.com/dovecot/core/commit/1d457281aa12f4b23d009740e0d417b69bc7ce4d
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/program-client-local.c
Log Message:
-----------
lib-program-client: Try drop setuid root by default
But not if root privileges are asked for.
Commit: ca44dad11c67b377c6a82edebc01d1a4dc3d06f5
https://github.com/dovecot/core/commit/ca44dad11c67b377c6a82edebc01d1a4dc3d06f5
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib/restrict-access.c
Log Message:
-----------
lib: Copy target_uid from restrict_access_settings
One cannot assign to set->uid, causing compile error.
Commit: b18b618bedd860622731786039deeb4c229b6468
https://github.com/dovecot/core/commit/b18b618bedd860622731786039deeb4c229b6468
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M src/lib-program-client/program-client-remote.c
Log Message:
-----------
lib-program-client: Correctly handle error code
Commit: 3a609904d003e4f652ddcf5bd44546af2659f820
https://github.com/dovecot/core/commit/3a609904d003e4f652ddcf5bd44546af2659f820
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-19 (Wed, 19 Oct 2016)
Changed paths:
M NEWS
M configure.ac
Log Message:
-----------
v2.2.26.rc1 released.
Commit: 9382f66f7667f1017e080673abd1ee2312cfa4b9
https://github.com/dovecot/core/commit/9382f66f7667f1017e080673abd1ee2312cfa4b9
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/login-common/login-proxy.c
Log Message:
-----------
login proxy: Hanging outgoing SSL connections caused using already-freed memory
This mainly happened when login proxy closed the connection due to connect
timeout. The ssl-proxy still had a reference and existed for a longer time.
If SSL handshake still succeeded afterwards, it now called
login_proxy_ssl_handshaked(), which accessed the already-freed proxy and
likely crashed.
Fixed the ssl-client proxy code specifically. Alternatively ssl_proxy_free()
could be calling ssl_proxy_destroy() always, but since ssl-server side of
the code seems to have been working fine, I don't want to accidentally
break it.
Commit: 25c5596ddc13644f9334109ce14b7567e4eef321
https://github.com/dovecot/core/commit/25c5596ddc13644f9334109ce14b7567e4eef321
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/auth/auth-request-var-expand.c
M src/auth/auth-request-var-expand.h
M src/auth/auth-request.c
M src/auth/auth-request.h
M src/lib-auth/auth-client-request.c
M src/lib-auth/auth-client.h
M src/login-common/client-common.h
M src/login-common/login-settings.c
M src/login-common/sasl-server.c
M src/login-common/ssl-proxy-openssl.c
Log Message:
-----------
auth: Pass local_name to auth-request
This allows using local_name in various places,
such as passdb/userdb queries.
Commit: 0718145c5340bd3441fff5f9af49669a018fd249
https://github.com/dovecot/core/commit/0718145c5340bd3441fff5f9af49669a018fd249
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/doveadm/client-connection-http.c
M src/doveadm/client-connection-private.h
M src/doveadm/client-connection.c
M src/doveadm/client-connection.h
M src/doveadm/doveadm.h
M src/doveadm/main.c
Log Message:
-----------
doveadm-server: Show incoming connection's IP and running command is process title.
Commit: 7de00b5cfd95e384bd63ac7a36805c4a755074d5
https://github.com/dovecot/core/commit/7de00b5cfd95e384bd63ac7a36805c4a755074d5
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/doveadm/doveadm-auth.c
Log Message:
-----------
doveadm user: If lookup fails, don't write it to the same line as header.
Commit: a96aaf10c1af81cbfbed16eef2abd66ed78e43b8
https://github.com/dovecot/core/commit/a96aaf10c1af81cbfbed16eef2abd66ed78e43b8
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/doveadm/Makefile.am
M src/doveadm/doveadm-master.c
R src/doveadm/doveadm-service.c
Log Message:
-----------
doveadm service stop: Moved command handling to doveadm-master.c
It's talking to master process, and there will be other non-service commands
that talk to the master process in the same way.
Commit: a22bb52f6bb8157816f57f5ba577eca980ff1f69
https://github.com/dovecot/core/commit/a22bb52f6bb8157816f57f5ba577eca980ff1f69
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/doveadm/doveadm-master.c
Log Message:
-----------
doveadm service stop: Code cleanup - Prepare for other service commands.
Commit: b6c6b081cb4258d5e1bf1587046ba02fe8d180f0
https://github.com/dovecot/core/commit/b6c6b081cb4258d5e1bf1587046ba02fe8d180f0
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/doveadm/doveadm-master.c
Log Message:
-----------
doveadm service stop: Convert to doveadm v2 API
Commit: 0269442eea4b5d6daea5a20a21d25b8632dad53e
https://github.com/dovecot/core/commit/0269442eea4b5d6daea5a20a21d25b8632dad53e
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/doveadm/doveadm-master.c
Log Message:
-----------
doveadm-master: Code cleanup - simplify sending command args to master.
This also escapes the parameters to make sure nothing bad can be sent.
Commit: 6cae1f3ed624de9fa76aa0e64ab9cff3132f83e3
https://github.com/dovecot/core/commit/6cae1f3ed624de9fa76aa0e64ab9cff3132f83e3
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/doveadm/doveadm-cmd.c
M src/doveadm/doveadm-cmd.h
M src/doveadm/doveadm-master.c
M src/master/master-client.c
Log Message:
-----------
Added "doveadm service status"
This allows asking for services' current status in master process.
Commit: c4e6628eb7ea3ccaf5d4dbbb645e701ca791a589
https://github.com/dovecot/core/commit/c4e6628eb7ea3ccaf5d4dbbb645e701ca791a589
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/doveadm/doveadm-cmd.c
M src/doveadm/doveadm-cmd.h
M src/doveadm/doveadm-master.c
M src/master/master-client.c
Log Message:
-----------
Added "doveadm process status"
This allows asking for processes' current status in master process.
Commit: 81ccedb6284788bf27d947ef03851c700eef2b79
https://github.com/dovecot/core/commit/81ccedb6284788bf27d947ef03851c700eef2b79
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/auth/auth-request-handler.c
Log Message:
-----------
auth: Fixed assert-crash on invalid auth-client input
For example if client sends invalid input like:
auth: Error: BUG: Authentication client sent unknown command: XYZ
Fixes crash:
auth: Panic: key not found from hash
Commit: fea477ac41324562e7c18385404dd63180a5b0a6
https://github.com/dovecot/core/commit/fea477ac41324562e7c18385404dd63180a5b0a6
Author: Stephan Bosch <stephan.bosch at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/lib-program-client/program-client-local.c
Log Message:
-----------
lib-program-client: Fixed boolean expressions.
Problems found with clang -Wstrict-bool.
Commit: af244a711b4a6203e869107b6b08504d1e9b04bf
https://github.com/dovecot/core/commit/af244a711b4a6203e869107b6b08504d1e9b04bf
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/login-common/client-common.c
Log Message:
-----------
login-common: Include local_name in login_var_expand_table
This way it can be used in login_log_format
Commit: 065efd7cd1a5f5c6ae19946b78c90a3f40f856cc
https://github.com/dovecot/core/commit/065efd7cd1a5f5c6ae19946b78c90a3f40f856cc
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/auth/auth-request.c
M src/lib-auth/auth-client-request.c
Log Message:
-----------
auth: Escape local_name
Commit: 2202915ace9fa63a8daefa0ed017730548276765
https://github.com/dovecot/core/commit/2202915ace9fa63a8daefa0ed017730548276765
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/lib-ldap/ldap-search.c
Log Message:
-----------
lib-ldap: Fixed compiling with OpenBSD
Commit: 7205301604b812e174a5e44d1013f59984937a86
https://github.com/dovecot/core/commit/7205301604b812e174a5e44d1013f59984937a86
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/imap-hibernate/imap-client.c
M src/lib-storage/mail-storage-service.c
M src/lib-storage/mail-user.c
Log Message:
-----------
%{auth_domain} shouldn't include the leading '@'
Commit: 9227c6f2040f426a79807fbac3e55d44c749d85b
https://github.com/dovecot/core/commit/9227c6f2040f426a79807fbac3e55d44c749d85b
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M src/pop3/pop3-client.c
Log Message:
-----------
pop3: Fix pop3_logout_format=%{deleted_size} expansion when there are no deletions
Should be "0", not empty string.
Commit: a626baeb59472238bf2f9347535f055b77a30e77
https://github.com/dovecot/core/commit/a626baeb59472238bf2f9347535f055b77a30e77
Author: Stephan Bosch <stephan at rename-it.nl>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M dovecot.m4
Log Message:
-----------
Added LIBDOVECOT_PUSH_NOTIFICATION_INCLUDE to dovecot.m4.
Commit: 62701b0a18e5e18b0999506f829959b48d98c870
https://github.com/dovecot/core/commit/62701b0a18e5e18b0999506f829959b48d98c870
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M Makefile.am
R cc-wrapper.sh.in
M configure.ac
M dovecot.m4
Log Message:
-----------
Moved cc-wrapper.sh handling to dovecot.m4
When configuring Dovecot --without-shared-libs and pointing external plugins
to uninstalled sources --with-dovecot, any binaries complied for plugins
weren't using cc-wrapper.sh, which could have caused runtime failures when
they attempted to load plugins dynamically. Now it's possible to add
DC_CC_WRAPPER to plugins' configure.ac to build with the cc-wrapper.sh.
Commit: 117e3b142a695e8b2dab6c11e996a4940f2971d2
https://github.com/dovecot/core/commit/117e3b142a695e8b2dab6c11e996a4940f2971d2
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M Makefile.am
M dovecot-config.in.in
M dovecot.m4
Log Message:
-----------
dovecot-config: Added dovecot_statedir
Commit: 57b6ff90e6a04e03ad2b7035fd8fa4dee4423564
https://github.com/dovecot/core/commit/57b6ff90e6a04e03ad2b7035fd8fa4dee4423564
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-20 (Thu, 20 Oct 2016)
Changed paths:
M dovecot.m4
Log Message:
-----------
dovecot.m4: Added DOVECOT_BINARY_LDFLAGS for future compatibility
Mainly to keep the serial number the same in v2.2 and v2.3 tree.
Commit: 9af3c0b71a3bfe361e101cf82c569485a998ba1c
https://github.com/dovecot/core/commit/9af3c0b71a3bfe361e101cf82c569485a998ba1c
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-22 (Sat, 22 Oct 2016)
Changed paths:
M configure.ac
Log Message:
-----------
configure: Improved checking if OpenSSL is too old for lib-dcrypt
Some OpenSSL versions had EC_KEY_new, but not other needed functions.
Commit: 959c2cf5c0468a11c8918a18a63a4690bfd3fce1
https://github.com/dovecot/core/commit/959c2cf5c0468a11c8918a18a63a4690bfd3fce1
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-22 (Sat, 22 Oct 2016)
Changed paths:
M src/lib-program-client/program-client.c
M src/lib-program-client/program-client.h
Log Message:
-----------
lib-program-client: Add URI based constructor
Commit: c8a3c8cacd7fbe06171c25d52a638a0a440e441c
https://github.com/dovecot/core/commit/c8a3c8cacd7fbe06171c25d52a638a0a440e441c
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/director/Makefile.am
M src/director/director-settings.c
M src/director/director-settings.h
M src/director/director.c
Log Message:
-----------
director: Support flush socket
This allows specifying an URI to execute
on user kill. It can be of form
exec:/path/to/bin, unix:/path/to/socket or
tcp:ip:port
The location is sent FLUSH username-hash
per killed user. You can execute some
action there, and you are expected to
return '+\nOK\n' as reply once you are
done.
Commit: bdda7143ac287cb79effe682985f505df30f5bd7
https://github.com/dovecot/core/commit/bdda7143ac287cb79effe682985f505df30f5bd7
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/director/director.c
Log Message:
-----------
director: Fix crash handling director_flush_socket when user is freed.
Commit: 4fd7c077a14c985e710fccdb1fabc9e4c83de761
https://github.com/dovecot/core/commit/4fd7c077a14c985e710fccdb1fabc9e4c83de761
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib/ioloop.c
Log Message:
-----------
lib: Ensure tv_r gets set in io_loop_get_wait_time
If this does not get reset here to 0 it can cause
errors or unpredictable behaviour in select/kqueue
polling, such as very long delays.
Commit: 6f8bf90ad4e759334756e004267466c7faaa1a26
https://github.com/dovecot/core/commit/6f8bf90ad4e759334756e004267466c7faaa1a26
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib/ioloop-kqueue.c
Log Message:
-----------
lib: Fix kqueue io_loop_get_wait_time usage
The code needs to take into consideration,
when there is no IO to be waited, but possibly
there is io_set_pending used, or just timeouts.
Commit: 54a8e37c755ff4316f397dbdcb11e6111fa0e845
https://github.com/dovecot/core/commit/54a8e37c755ff4316f397dbdcb11e6111fa0e845
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib/test-ioloop.c
Log Message:
-----------
lib: Add test for ioloop fd polling
Commit: bffa0a2936d273096f06f2428e91f82baccade46
https://github.com/dovecot/core/commit/bffa0a2936d273096f06f2428e91f82baccade46
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/master/service-process.c
Log Message:
-----------
master: If chrooted service's core wasn't dumped, suggest to unset the chroot.
Commit: d0a2dd56e41248e9cf497c21aeedd123fd6646e0
https://github.com/dovecot/core/commit/d0a2dd56e41248e9cf497c21aeedd123fd6646e0
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib-index/mail-cache-lookup.c
Log Message:
-----------
lib-index: Fix potential assert-crash when reading cache
Fixes:
Panic: file mail-cache-lookup.c: line 258 (mail_cache_lookup_iter_next): assertion failed: (ctx->offset != 0)
Broken by d33fc6c584718efd46159e1d8f46488b9dfc66f5
Commit: a4e044d1934a63c3fbe271d27136fae8512637bf
https://github.com/dovecot/core/commit/a4e044d1934a63c3fbe271d27136fae8512637bf
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib-index/mail-cache-transaction.c
Log Message:
-----------
lib-index: Fix potential error when reading from uncommitted cache transaction
If dovecot.index.cache is compressed during the transaction, the new cache
fields mapping doesn't necessarily match what is in the transaction.
Fixes:
Error: Corrupted index cache file .../dovecot.index.cache: field index too large (27 >= 17)
Although there may be other cache corruption errors it also fixes.
Commit: 8923deec4c5361cb9090c9b5d3c4e5c173bdc640
https://github.com/dovecot/core/commit/8923deec4c5361cb9090c9b5d3c4e5c173bdc640
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib/file-dotlock.c
M src/lib/file-lock.c
M src/lib/file-lock.h
Log Message:
-----------
lib: Add FILE_LOCK_SLOW_WARNING_MSECS environment.
Log a warning if any locking takes longer than the specified number of
milliseconds. This can be enabled globally with:
import_environment = $import_environment FILE_LOCK_SLOW_WARNING_MSECS=1000
Commit: f820a25aa0e27a087a3b7085f75165b65a7f67b8
https://github.com/dovecot/core/commit/f820a25aa0e27a087a3b7085f75165b65a7f67b8
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib/ioloop.c
M src/lib/ioloop.h
Log Message:
-----------
lib: Added ioloop_global_wait_usecs
This is helpful when multiple ioloops aren't used and
io_loop_get_wait_usecs() can't be easily used for all of them.
Commit: 1bea846fbfbf7a5cf78e33f11ced03b86b2349a4
https://github.com/dovecot/core/commit/1bea846fbfbf7a5cf78e33f11ced03b86b2349a4
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib-dict/dict-client.c
Log Message:
-----------
dict-client: Fix logging how much time was spent in other ioloops in slow lookup warnings.
The warning's idea is to show why the lookup could have been slow. We
differentiate between time spent in dict_wait() waiting only for the
dict result and time spent in other ioloops waiting for potentially other
things as well (and time spent waiting for locks during this time).
The previous code didn't work right when multiple ioloops were used, which
happened sometimes.
Also changed %u to %d just in case some calculation is wrong. It's nicer to
get a slightly negative value rather than a huge positive one.
Commit: 50ce4f6ed21fdb2b2b3bde5f41ccac825418b13f
https://github.com/dovecot/core/commit/50ce4f6ed21fdb2b2b3bde5f41ccac825418b13f
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib-http/http-client-connection.c
M src/lib-http/http-client-private.h
M src/lib-http/http-client-request.c
Log Message:
-----------
lib-http: Add ioloop and lock wait information to timeout messages.
It'll now log for example:
9007 Request timed out (Request sent 7.087 secs ago, 0.076 in other ioloops, 7.012 in locks, connected 7.087 secs ago)
Which points out that the problem wasn't really with the HTTP, but with
locking. This likely should be fixed in some way also in lib-http so that
it gives a bit of extra time for reading the request, but that's a separate
fix.
Commit: 89507f4c78191a636f54de651e726507d5a5fc26
https://github.com/dovecot/core/commit/89507f4c78191a636f54de651e726507d5a5fc26
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib/test-ioloop.c
Log Message:
-----------
lib: Fix compiler warnings in test-ioloop
Fixes:
test-ioloop.c:72: error: ignoring return value of ‘write’, declared with attribute warn_unused_result
Commit: ce9e46fe64054dd958da9a02f82838977a4c6a7c
https://github.com/dovecot/core/commit/ce9e46fe64054dd958da9a02f82838977a4c6a7c
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M configure.ac
Log Message:
-----------
configure: Fixed checking if OpenSSL is too old for lib-dcrypt
EVP_PKEY_CTX_set_ec_paramgen_curve_nid() is a macro, so it can't be checked
with AC_CHECK_LIB().
Commit: b909e9579d72684faaebbe3189cab6c012935a6b
https://github.com/dovecot/core/commit/b909e9579d72684faaebbe3189cab6c012935a6b
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib/file-lock.c
Log Message:
-----------
lib: With FILE_LOCK_SLOW_WARNING_MSECS log a warning also when keeping lock for long.
This can help catching which process kept the lock for too long.
Commit: c34b55bb980bff87b92627d876127da2db2c1779
https://github.com/dovecot/core/commit/c34b55bb980bff87b92627d876127da2db2c1779
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-24 (Mon, 24 Oct 2016)
Changed paths:
M src/lib-compression/istream-zlib.c
Log Message:
-----------
istream-zlib: "missing gz trailer" error message was wrong.
Commit: ae052aeecfcf162369cb009d55e81a308749ef02
https://github.com/dovecot/core/commit/ae052aeecfcf162369cb009d55e81a308749ef02
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/doveadm/doveadm-mail.c
Log Message:
-----------
doveadm: Rewind input early enough
Command input needs to be rewinded earlier
in doveadm_mail_next_user.
Commit: 5ea724b12e30529fc38a1f087248ed71c22ddfc0
https://github.com/dovecot/core/commit/5ea724b12e30529fc38a1f087248ed71c22ddfc0
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/lib-compression/istream-zlib.c
Log Message:
-----------
lib-compress: Don't assume too early that gz file continues after a trailer.
Some istreams don't have EOF immediately set after the gz trailer. This
fixes errors like "missing gz trailer at 1675"
Commit: 8663febb0735cba25b899f64c9f7f28de67ecc9f
https://github.com/dovecot/core/commit/8663febb0735cba25b899f64c9f7f28de67ecc9f
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/lib-compression/test-compression.c
Log Message:
-----------
lib-compression: Added file uncompression support for test-compression
This can be useful for debugging.
Commit: 5b3bfd871e84d9d70d205ebf73bc1a209eee782d
https://github.com/dovecot/core/commit/5b3bfd871e84d9d70d205ebf73bc1a209eee782d
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/lib-compression/test-compression.c
Log Message:
-----------
lib-compression: Added unit tests for reading .gz files
Commit: 1165c4b3b264dbf2cd2dd55a6913126f69fc35f8
https://github.com/dovecot/core/commit/1165c4b3b264dbf2cd2dd55a6913126f69fc35f8
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/imap-login/imap-login-client.c
Log Message:
-----------
imap-login: Skip NIL value in ID handler
NIL value can cause hard crash, depending what
the key is. For x-proxy-ttl, NIL will crash
on any system, x-originating-ip will crash on
some nss versions (e.g. centos 6.7).
Migitating factor here is that the NIL value is only
accepted from trusted network.
Commit: 3729762f734e96e79c7427c84d76e1a2691e87f9
https://github.com/dovecot/core/commit/3729762f734e96e79c7427c84d76e1a2691e87f9
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/lib-mail/mail-html2text.c
Log Message:
-----------
lib-mail: Support decimal/hexadecimal encoded entities
Add support for &#nnn; and &#xnnn; entities.
Commit: 9322aae41e99971d8c3442633fc46138f8a73447
https://github.com/dovecot/core/commit/9322aae41e99971d8c3442633fc46138f8a73447
Author: Aki Tuomi <aki.tuomi at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/lib-mail/test-mail-html2text.c
Log Message:
-----------
lib-mail: Add tests for dec/hexdec encoded entities
Commit: 40b639480f3c48e336913707dea11cf776eb8517
https://github.com/dovecot/core/commit/40b639480f3c48e336913707dea11cf776eb8517
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/doveadm-connection.c
Log Message:
-----------
director: Code cleanup - allow commands handlers to stop processing input
Now returning 0 exits the input reading without disconnecting client.
Commit: 6f4ef8c4be5c3d443cfa25b2e7b7b95b6676fe4d
https://github.com/dovecot/core/commit/6f4ef8c4be5c3d443cfa25b2e7b7b95b6676fe4d
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director.c
M src/director/director.h
M src/director/main.c
Log Message:
-----------
director: Call state_change_callback on user move timeout.
Commit: 6f5d4f71f6d270c9f04aac7abcb4746c26b6d1b0
https://github.com/dovecot/core/commit/6f5d4f71f6d270c9f04aac7abcb4746c26b6d1b0
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director.c
Log Message:
-----------
director: Code cleanup - Finish user move always in the same function.
Commit: 490ecf7d1cc8842f5fca3f336f0854e63f3a4210
https://github.com/dovecot/core/commit/490ecf7d1cc8842f5fca3f336f0854e63f3a4210
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director.c
M src/director/director.h
M src/director/main.c
Log Message:
-----------
director: Show in process title how many users are being moved.
Commit: b0c70a5e8309443c5872f013d57bfa1c90b0d11f
https://github.com/dovecot/core/commit/b0c70a5e8309443c5872f013d57bfa1c90b0d11f
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/doveadm-connection.c
Log Message:
-----------
director: Code cleanup - moved command handling to its own function.
Commit: e086c5434f05618c8d94a59f30eb36ff93f1b002
https://github.com/dovecot/core/commit/e086c5434f05618c8d94a59f30eb36ff93f1b002
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/doveadm-connection.c
Log Message:
-----------
director: Make sure IP address parsing works in DIRECTOR-ADD/REMOVE
We were passing the entire string through to net_addr2ip(). It seems that
inet_aton() stops at whitespace though, so this wasn't actually causing
errors at least on Linux.
Commit: b78c76d503adb18735a0f28330d58db3fb3bc57d
https://github.com/dovecot/core/commit/b78c76d503adb18735a0f28330d58db3fb3bc57d
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/doveadm-connection.c
Log Message:
-----------
director: USER-MOVE didn't handle non-hash username correctly.
The entire command line was being hashed instead of just the username.
Commit: 266725f60a2d8571ee4db8be198dec15a1cfbe8b
https://github.com/dovecot/core/commit/266725f60a2d8571ee4db8be198dec15a1cfbe8b
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/doveadm-connection.c
Log Message:
-----------
director: Code cleanup - Give tab-unescaped args to all doveadm command handlers.
Commit: 827bb6585dd19964eccba2a78a1ba3d8971bdfd0
https://github.com/dovecot/core/commit/827bb6585dd19964eccba2a78a1ba3d8971bdfd0
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director-connection.c
M src/director/director-host.h
Log Message:
-----------
director: If SYNCs are received during handshake, send them later.
This fixes delays during handshake:
Error: Ring SYNC appears to have got lost, resending
Commit: 85505297dce080660df5220a05cb66c370c63f3f
https://github.com/dovecot/core/commit/85505297dce080660df5220a05cb66c370c63f3f
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director-connection.c
Log Message:
-----------
director: Fix sending up/down state in handshakes.
They were never sent, because HOSTs were sent before director had waited for
the remote to send its version number. So sender thought that the remote's
minor_version was too old and it didn't send the up/down state at all.
This caused errors like:
Warning: director(10.0.0.30:9090/left): Host 10.0.0.30 is being updated before previous update had finished (up -> down) - setting to state=down vhosts=100
Error: director(10.0.0.30:9090/left): Director 10.0.0.30 SYNC request hosts don't match us - resending hosts (seq=6, remote hosts_hash=262126213, my hosts_hash=2458934259)
Commit: 283aea228754e9fc2fdcb3aebb73445415cba757
https://github.com/dovecot/core/commit/283aea228754e9fc2fdcb3aebb73445415cba757
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/doveadm/doveadm-director.c
Log Message:
-----------
doveadm director: Invalid parameters cause doveadm to fail silently.
doveadm_cmd_context.cmd doesn't point directly to doveadm_cmd_director.
Commit: 825dc91d3b11fea646bcda94c1a327e7d69bc8c0
https://github.com/dovecot/core/commit/825dc91d3b11fea646bcda94c1a327e7d69bc8c0
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director-connection.c
M src/director/user-directory.c
M src/director/user-directory.h
Log Message:
-----------
director: Log user's kill_state with a human-readable string.
Commit: 8ca411e827d61a44998bcec11b0fd976932046a2
https://github.com/dovecot/core/commit/8ca411e827d61a44998bcec11b0fd976932046a2
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director.c
Log Message:
-----------
director: If user move times out, log the state it was in at the time.
Commit: 309ad773ae70ecb28c7da9ff9c635442668010e8
https://github.com/dovecot/core/commit/309ad773ae70ecb28c7da9ff9c635442668010e8
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/doveadm-connection.c
M src/director/doveadm-connection.h
M src/director/main.c
M src/director/user-directory.h
Log Message:
-----------
director: HOST-RESET-USERS moves users more slowly now.
By default only 100 users can be moved in parallel. This can be overridden
with HOST-RESET-USERS parameter.
This delaying is especially useful when director_flush_socket is used to
avoid huge floods to the script service. Even without the socket it's still
good for avoiding unnecessary load spikes when all users are kicked at once
and they reconnect back at the same time.
Commit: f3afdea8a476341d818b5cee794b872e581ef006
https://github.com/dovecot/core/commit/f3afdea8a476341d818b5cee794b872e581ef006
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/doveadm/doveadm-director.c
Log Message:
-----------
doveadm director flush: Added --max-parallel parameter.
Commit: e8133938b0e5b4758677b078d5ccc21926d78b24
https://github.com/dovecot/core/commit/e8133938b0e5b4758677b078d5ccc21926d78b24
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director-connection.c
Log Message:
-----------
director: If user host conflict is detected, make sure new host is sent back.
USER-KICK-HASH was sent, but the sender didn't get back a USER reply with
the new host. This could have increased how long user's host differred in
directors.
Avoids repeating this error:
Error: User hash 2957018085 is being redirected to two hosts: 10.0.0.30 and 10.0.0.201 (old_ts=1477338836)
Commit: 45f7ffde889165c7b330fc98708fcbe595c78c05
https://github.com/dovecot/core/commit/45f7ffde889165c7b330fc98708fcbe595c78c05
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director.c
M src/director/user-directory.c
M src/director/user-directory.h
Log Message:
-----------
director: Prevent race conditions by adding USER_KILL_STATE_FLUSHING
In theory it's possible that a user is freed during a flush and added back
before flush is finished, possibly even being moved again. This check makes
sure that we don't finish such move unless we're actually at the correct
flushing state. (If there's another flush also running for the user it'll
be ignored.)
This is also useful for logging purposes.
Commit: 1976d64251d1544ea1410adf426cb3447b81c993
https://github.com/dovecot/core/commit/1976d64251d1544ea1410adf426cb3447b81c993
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director-connection.c
M src/director/director.c
Log Message:
-----------
director: Fix user move hangs when another move is triggered early.
Running "doveadm director flush" before the previous flush hadn't fully
finished could have caused users to hang until their move timeout:
director: Error: Finishing user 3249070169 move timed out, its state may now be inconsistent (state=waiting-for-everyone)
Commit: 5364c16b3e70a6a08837c20d96f651c1022fd336
https://github.com/dovecot/core/commit/5364c16b3e70a6a08837c20d96f651c1022fd336
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director-connection.c
M src/director/director.c
Log Message:
-----------
director: Improve debug logging output.
Commit: cc52ed5f04fa961249bcc2f4991527f9d7a4748e
https://github.com/dovecot/core/commit/cc52ed5f04fa961249bcc2f4991527f9d7a4748e
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/director.c
M src/director/user-directory.h
Log Message:
-----------
director: Execute director_flush_socket only from one director.
Having each director do it would be redundant since they're all supposed to
be performing the same flush task to the same backend.
Commit: 70d288659bb8ee2fb4a78239e196ab2a316c138b
https://github.com/dovecot/core/commit/70d288659bb8ee2fb4a78239e196ab2a316c138b
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/doveadm/doveadm-director.c
Log Message:
-----------
doveadm director dump: Fixed output to include LFs
Otherwise all the output will be mixed up in the same line.
Commit: 31e3c2060bf44dbd50e4d92e1e358306447557b1
https://github.com/dovecot/core/commit/31e3c2060bf44dbd50e4d92e1e358306447557b1
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-25 (Tue, 25 Oct 2016)
Changed paths:
M src/director/doveadm-connection.c
Log Message:
-----------
director: Fix HOST-RESET-USERS with host parameter.
The logic was reversed: It should flush the specified host, not some other
host. Broken by 11ee3b40320a31669bd717fecbe1e332dad4fd84
Commit: 6d1e5a3c5fc8cd9cf5217baf9221ee55c1ad47f6
https://github.com/dovecot/core/commit/6d1e5a3c5fc8cd9cf5217baf9221ee55c1ad47f6
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/director/director.c
M src/director/director.h
M src/director/user-directory.c
M src/director/user-directory.h
Log Message:
-----------
director: Code cleanup - move enum user_kill_state to director.h
This will be needed by following commits
Commit: a6f99e4d917db4dcce6570685620085983f4c9db
https://github.com/dovecot/core/commit/a6f99e4d917db4dcce6570685620085983f4c9db
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/director/director-connection.c
M src/director/director-request.c
M src/director/director.c
M src/director/doveadm-connection.c
M src/director/user-directory.c
M src/director/user-directory.h
Log Message:
-----------
director: Code cleanup - added USER_IS_BEING_KILLED() macro
Commit: 66e91d847e0e8090f39080b797df01e94a226fc4
https://github.com/dovecot/core/commit/66e91d847e0e8090f39080b797df01e94a226fc4
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/director/director.c
Log Message:
-----------
director: Code cleanup - rename director_kill_context.self to kill_is_self_initiated
Commit: 7b43489032fc53ef4cce4fb85de2e868914d4afd
https://github.com/dovecot/core/commit/7b43489032fc53ef4cce4fb85de2e868914d4afd
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/director/director-connection.c
M src/director/director.c
M src/director/director.h
M src/director/test-user-directory.c
M src/director/user-directory.c
M src/director/user-directory.h
Log Message:
-----------
director: Moved all user killing state to struct director_kill_context
This should make it a bit easier to understand the life time of user
killing. It also simplifies code by removing struct
director_user_kill_finish_ctx.
Finally, this already reduces memory usage with 32bit systems, and would
make it possible to reduce also on 64bit systems if timestamp is shrank to
31 bits and weak bit moved after it. I'm not sure if that would be better
for performance though. In any case it would provide free space for 4 extra
bytes if that were needed in future.
Commit: 83d28111bc7850f41b99c3d127ea6b0cc4015253
https://github.com/dovecot/core/commit/83d28111bc7850f41b99c3d127ea6b0cc4015253
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/director/director.h
M src/director/main.c
Log Message:
-----------
director: Code cleanup - global director is no longer needed.
Commit: 8da62da76a9eeb439c7e22d686e3cecba0213ecd
https://github.com/dovecot/core/commit/8da62da76a9eeb439c7e22d686e3cecba0213ecd
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/director/director.c
Log Message:
-----------
director: Code cleanup - moved user kill startup to its own function.
No functional changes.
Commit: d872e6443f865bced54da72ec480698e893d5e88
https://github.com/dovecot/core/commit/d872e6443f865bced54da72ec480698e893d5e88
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/director/director.c
Log Message:
-----------
director: User move - Don't try to kick user's connections if user wasn't even known.
Commit: 2162ea042610d00290de66ddd9796f0a6078f7b6
https://github.com/dovecot/core/commit/2162ea042610d00290de66ddd9796f0a6078f7b6
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/director/director.c
M src/director/director.h
Log Message:
-----------
director: Send user's old and new backend IPs to flush script.
If user was created due to the user-move, don't execute the flush script
since it wouldn't really have any work to do anyway.
Commit: 995121e82bd45c39d69e6943d9fb00158c1bb253
https://github.com/dovecot/core/commit/995121e82bd45c39d69e6943d9fb00158c1bb253
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/director/main.c
Log Message:
-----------
director: Avoid assert-crash at deinit if user moves are still being added.
Fixes:
Panic: file user-directory.c: line 312 (user_directory_deinit): assertion failed: (array_count(&dir->iters) == 0)
Commit: 977ce672812ecdff7f8d79073461c35a0656187e
https://github.com/dovecot/core/commit/977ce672812ecdff7f8d79073461c35a0656187e
Author: Martti Rannanjärvi <martti.rannanjarvi at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/doveadm/doveadm-print-pager.c
Log Message:
-----------
doveadm: \f\n only between pages in pager
No more \f\n in the end.
Commit: 5baa99e0302d2ca71a989800e24f3b3fa509a721
https://github.com/dovecot/core/commit/5baa99e0302d2ca71a989800e24f3b3fa509a721
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/doveadm/doveadm-print-pager.c
Log Message:
-----------
doveadm: "pager" formatter supports now DOVEADM_PRINT_HEADER_FLAG_HIDE_TITLE
Commit: 150b07f7ada23884277d2be45040b82dcf55cbef
https://github.com/dovecot/core/commit/150b07f7ada23884277d2be45040b82dcf55cbef
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/doveadm/doveadm-mail-fetch.c
M src/doveadm/doveadm-master.c
M src/doveadm/doveadm-print-pager.c
M src/doveadm/doveadm-print.h
Log Message:
-----------
doveadm: Code cleanup - add and use DOVEADM_PRINT_TYPE_PAGER macro
Commit: 17dc7ae8e36c27f8993da4de1f44fee034ca2cb5
https://github.com/dovecot/core/commit/17dc7ae8e36c27f8993da4de1f44fee034ca2cb5
Author: Timo Sirainen <timo.sirainen at dovecot.fi>
Date: 2016-10-26 (Wed, 26 Oct 2016)
Changed paths:
M src/doveadm/doveadm-fs.c
Log Message:
-----------
doveadm fs get: Use pager formatter by default to avoid extra LF at the end.
Compare: https://github.com/dovecot/core/compare/d7b99734f301^...17dc7ae8e36c
More information about the dovecot-cvs
mailing list