From noreply at github.com Mon Oct 3 08:30:10 2016 From: noreply at github.com (GitHub) Date: Mon, 03 Oct 2016 01:30:10 -0700 Subject: [dovecot/core] dfa23b: io: Add source filename Message-ID: <57f21712c6731_2b043f809a35113c3299e@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: dfa23b2ddc43f323112225facf7cd7191e62e02c https://github.com/dovecot/core/commit/dfa23b2ddc43f323112225facf7cd7191e62e02c Author: Aki Tuomi Date: 2016-10-03 (Mon, 03 Oct 2016) Changed paths: M src/lib/ioloop-notify-inotify.c M src/lib/ioloop-notify-kqueue.c M src/lib/ioloop-notify-none.c M src/lib/ioloop-private.h M src/lib/ioloop.c M src/lib/ioloop.h Log Message: ----------- io: Add source filename This will make debugging alot easier when you can see what the filename is as well. From noreply at github.com Mon Oct 3 09:00:11 2016 From: noreply at github.com (GitHub) Date: Mon, 03 Oct 2016 02:00:11 -0700 Subject: [dovecot/core] d60ff6: lib-test: Fix illegal memory access in test-ostrea... Message-ID: <57f21e1b1fb9f_54bc3f84eb66114c680fa@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d60ff60a7596df454560565016196182314e4419 https://github.com/dovecot/core/commit/d60ff60a7596df454560565016196182314e4419 Author: Aki Tuomi Date: 2016-10-03 (Mon, 03 Oct 2016) Changed paths: M src/lib-test/test-ostream.c Log Message: ----------- lib-test: Fix illegal memory access in test-ostream Commit: 27ba8acc6bb1a5a506337a51482f6d4c7833e8c9 https://github.com/dovecot/core/commit/27ba8acc6bb1a5a506337a51482f6d4c7833e8c9 Author: Aki Tuomi Date: 2016-10-03 (Mon, 03 Oct 2016) Changed paths: M src/lib-test/test-ostream.c Log Message: ----------- lib-test: Fix memory leak in test-ostream Commit: 61f962e8f32a4870d08fb6f2189fdf6a10fd1abb https://github.com/dovecot/core/commit/61f962e8f32a4870d08fb6f2189fdf6a10fd1abb Author: Stephan Bosch Date: 2016-10-03 (Mon, 03 Oct 2016) Changed paths: M src/lib/uri-util.c Log Message: ----------- lib: uri-util: Always fully check the syntax of percent encoding while parsing URI components. Commit: 957f71b0b0e5589b2e2a0086fb094edaee723c7a https://github.com/dovecot/core/commit/957f71b0b0e5589b2e2a0086fb094edaee723c7a Author: Stephan Bosch Date: 2016-10-03 (Mon, 03 Oct 2016) Changed paths: M src/lib-http/http-url.c Log Message: ----------- lib-http: uri: Removed unnecessary checking of percent encoding of query and fragment parts. This is now always performed in lib/uri-util. Commit: 458d877d84f62005e0ffc338f8591a8e2a36adad https://github.com/dovecot/core/commit/458d877d84f62005e0ffc338f8591a8e2a36adad Author: Stephan Bosch Date: 2016-10-03 (Mon, 03 Oct 2016) Changed paths: M src/lib/Makefile.am M src/lib/test-lib.inc A src/lib/test-uri.c M src/lib/uri-util.c M src/lib/uri-util.h Log Message: ----------- lib: uri-util: Implemented API to check generic URI syntax. This allows checking whether something is a valid URI of any type. This change adds a test suite for the generic URI syntax, which is currently the main purpose of the API addition. Apart from a few simple vality checks, the test suite also tests various URI examples from RFCs. Compare: https://github.com/dovecot/core/compare/dfa23b2ddc43...458d877d84f6 From noreply at github.com Tue Oct 4 18:25:21 2016 From: noreply at github.com (GitHub) Date: Tue, 04 Oct 2016 11:25:21 -0700 Subject: [dovecot/pigeonhole] 2ce32c: managesieve: The PUTSCRIPT command now allows uplo... Message-ID: <57f3f41162189_727d3ffc888fb14013779@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 2ce32c4c6bf91416a3bbb305d11b5247cbb7889a https://github.com/dovecot/pigeonhole/commit/2ce32c4c6bf91416a3bbb305d11b5247cbb7889a Author: Stephan Bosch Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/managesieve/cmd-putscript.c Log Message: ----------- managesieve: The PUTSCRIPT command now allows uploading empty Sieve scripts. There is no reason to forbid an empty Sieve script. Commit: 47635d883bd77a1682166ce08bbb32ab13d9ac4a https://github.com/dovecot/pigeonhole/commit/47635d883bd77a1682166ce08bbb32ab13d9ac4a Author: Stephan Bosch Date: 2016-09-21 (Wed, 21 Sep 2016) Changed paths: M src/lib-sieve/storage/file/sieve-file-storage-save.c Log Message: ----------- lib-sieve: file storage: Fixed handling of non-blocking input in save_continue(). Bug was exposed by previous change. Normally, this would not surface. Commit: da1ed8d945e46ad3f8deb48eca364eeb67c1ecd2 https://github.com/dovecot/pigeonhole/commit/da1ed8d945e46ad3f8deb48eca364eeb67c1ecd2 Author: Stephan Bosch Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M src/lib-sieve/plugins/variables/ext-variables-limits.h Log Message: ----------- lib-sieve: variables extension: Increased the maximum number of namespace elements in a variable name. Commit: 1bca1af3e6d6af42658934f10be4694e35cd8dc5 https://github.com/dovecot/pigeonhole/commit/1bca1af3e6d6af42658934f10be4694e35cd8dc5 Author: Stephan Bosch Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M src/lib-sieve/plugins/variables/ext-variables-arguments.c Log Message: ----------- lib-sieve: variables extension: Substitution of an invalid namespace canceled the substitution, rather than substituting the empty string. Commit: 2865e415a89c3d0ff3d7857efa051df85619b1e5 https://github.com/dovecot/pigeonhole/commit/2865e415a89c3d0ff3d7857efa051df85619b1e5 Author: Stephan Bosch Date: 2016-09-29 (Thu, 29 Sep 2016) Changed paths: M src/lib-sieve/plugins/environment/ext-environment-common.c M src/lib-sieve/plugins/environment/sieve-ext-environment.h M src/lib-sieve/plugins/vnd.dovecot/environment/ext-vnd-environment-items.c M src/plugins/imapsieve/ext-imapsieve-environment.c Log Message: ----------- lib-sieve: environment extension: Added support for wildcard environment items that are identified by a name prefix. Commit: c9324ac9741bae2a848cab90f6dd586c540b51a1 https://github.com/dovecot/pigeonhole/commit/c9324ac9741bae2a848cab90f6dd586c540b51a1 Author: Stephan Bosch Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M src/lib-sieve/plugins/environment/tst-environment.c Log Message: ----------- lib-sieve: environment extension: Improved runtime trace for a nonexistent environment item. Commit: 67c93ffd6dabccdf29a4057d94d201c44d909290 https://github.com/dovecot/pigeonhole/commit/67c93ffd6dabccdf29a4057d94d201c44d909290 Author: Stephan Bosch Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M INSTALL A doc/extensions/vnd.dovecot.environment.txt M doc/rfc/spec-bosch-sieve-dovecot-environment.txt M doc/rfc/xml/spec-bosch-sieve-dovecot-environment.xml M src/lib-sieve/plugins/vnd.dovecot/environment/ext-vnd-environment-items.c M tests/extensions/vnd.dovecot/environment/basic.svtest Log Message: ----------- lib-sieve: vnd.dovecot.environment extension: Added vnd.dovecot.config.* environment items. A "vnd.dovecot.config." environment item maps to the content of the matching sieve_env_ plugin setting. Commit: 8f959e8f44b43eb3b25eede81d0fa7f02ced471e https://github.com/dovecot/pigeonhole/commit/8f959e8f44b43eb3b25eede81d0fa7f02ced471e Author: Stephan Bosch Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M src/plugins/lda-sieve/lda-sieve-plugin.c Log Message: ----------- LDA Sieve plugin: Always use multiscript API for script execution. Removed special code path for single script. This is a remnant from times when the multiscript feature was still experimental. Commit: df19597c9495a1cc201906052cef15968957e83f https://github.com/dovecot/pigeonhole/commit/df19597c9495a1cc201906052cef15968957e83f Author: Stephan Bosch Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M src/lib-sieve/sieve-result.c M src/lib-sieve/sieve-result.h Log Message: ----------- lib-sieve: Added means to evaluate whether the result object executed a delivery action. Commit: bc99d7921e00ab88d80ea3a05506a77630bfb700 https://github.com/dovecot/pigeonhole/commit/bc99d7921e00ab88d80ea3a05506a77630bfb700 Author: Stephan Bosch Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M src/lib-sieve/sieve.c M src/lib-sieve/sieve.h Log Message: ----------- lib-sieve: Implemented support for running a "discard script" in the multiscript execution API. The "discard script" is run when the normal script sequence ends and the message is going to be discarded. Commit: 2ae18e519d2154fb733f608b5910c0a49ec78e5c https://github.com/dovecot/pigeonhole/commit/2ae18e519d2154fb733f608b5910c0a49ec78e5c Author: Stephan Bosch Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M INSTALL M doc/example-config/conf.d/90-sieve.conf M src/plugins/lda-sieve/lda-sieve-plugin.c Log Message: ----------- LDA Sieve plugin: Implemented support for a "discard script" that is run when the message is going to be discarded. This adds a new "sieve_discard" setting that points to the location of the "discard script". Once the normal scripts finish executing and the result is that the message will be discarded without being delivered anywhere, the "discard script" is executed. The discard script can prevent dropping the message, by executing alternative actions. If the discard script does nothing, the message is still discarded. Compare: https://github.com/dovecot/pigeonhole/compare/a43487489053...2ae18e519d21 From noreply at github.com Tue Oct 4 21:00:11 2016 From: noreply at github.com (GitHub) Date: Tue, 04 Oct 2016 14:00:11 -0700 Subject: [dovecot/core] 505561: imap: If mailbox is inconsistent after syncing, do... Message-ID: <57f4185b54092_55783fa3005ed1386457@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 505561860cdfee4eac51469fd27a59983ef72e8e https://github.com/dovecot/core/commit/505561860cdfee4eac51469fd27a59983ef72e8e Author: Timo Sirainen Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M src/imap/imap-sync.c Log Message: ----------- imap: If mailbox is inconsistent after syncing, don't try to sync message counts. This fixes (e.g. after doveadm force-resync): Panic: Message count decreased Commit: 2d33fd7fc78aae43175330c66636332de615c69f https://github.com/dovecot/core/commit/2d33fd7fc78aae43175330c66636332de615c69f Author: Timo Sirainen Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M src/lib-storage/index/index-sync.c Log Message: ----------- lib-storage: Make sure mailbox_sync*() fails if view is inconsistent afterwards. Commit: 407d64647d77771080eb75f800162014927f10c6 https://github.com/dovecot/core/commit/407d64647d77771080eb75f800162014927f10c6 Author: Timo Sirainen Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M src/lib-index/mail-index-view-sync.c Log Message: ----------- lib-index: Fixed potential assert-crash when view syncing sees a reset marker. It should never try to use main index map at that point, because view_sync_have_expunges() looks changes only before the reset marker. Fixes: Error: Index .../dovecot.index lost messages without expunging (36 -> 27) Commit: 83cd96ee87e8fb88b2467a1c51604961a5db3d71 https://github.com/dovecot/core/commit/83cd96ee87e8fb88b2467a1c51604961a5db3d71 Author: Timo Sirainen Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M src/lib-index/mail-index-view-sync.c Log Message: ----------- lib-index: When finding a view is reset, don't attempt any further syncing. This could cause various errors to be logged, such as: Error: Append with UID 7103, but next_uid = 7242 Commit: 96d1b0c8126121fdceff98144c932433e3fdeb92 https://github.com/dovecot/core/commit/96d1b0c8126121fdceff98144c932433e3fdeb92 Author: Timo Sirainen Date: 2016-10-04 (Tue, 04 Oct 2016) Changed paths: M src/lib-index/mail-index-view-sync.c Log Message: ----------- lib-index: If view syncing sees index is reset, always mark the view as inconsistent. Not only when the mailbox has messages, because that could still mess up assumptions about UIDs. A somewhat better check could have been to do this only when next_uid>1 (= there have been messages at some point in this mailbox), but it's safer to just always mark the view as inconsistent. Compare: https://github.com/dovecot/core/compare/458d877d84f6...96d1b0c81261 From noreply at github.com Wed Oct 5 08:00:12 2016 From: noreply at github.com (GitHub) Date: Wed, 05 Oct 2016 01:00:12 -0700 Subject: [dovecot/core] fbfdd1: lib-storage: autoexpunge mailboxes with wildcards ... Message-ID: <57f4b30c4eb0a_11f93fa87791d13870113@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: fbfdd1a757fa064787f3c10bf2f959dc640dd79c https://github.com/dovecot/core/commit/fbfdd1a757fa064787f3c10bf2f959dc640dd79c Author: Timo Sirainen Date: 2016-10-05 (Wed, 05 Oct 2016) Changed paths: M src/lib-storage/mail-autoexpunge.c Log Message: ----------- lib-storage: autoexpunge mailboxes with wildcards didn't work with namespace prefix. From noreply at github.com Wed Oct 5 12:30:11 2016 From: noreply at github.com (GitHub) Date: Wed, 05 Oct 2016 05:30:11 -0700 Subject: [dovecot/core] 27fdbf: plugins/fts - make storage errors more informative Message-ID: <57f4f2532a21a_641d3ff8e365513c1055f0@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 27fdbf79a2abd6feb7c503e46e63878c8a17127b https://github.com/dovecot/core/commit/27fdbf79a2abd6feb7c503e46e63878c8a17127b Author: Phil Carmody Date: 2016-10-05 (Wed, 05 Oct 2016) Changed paths: M src/plugins/fts/fts-storage.c Log Message: ----------- plugins/fts - make storage errors more informative There are 3 different ways to fail ending a transaction (one of which is itself just a record that something now unknown previously failed). Identify which one in the logs. Signed-off-by: Phil Carmody From noreply at github.com Wed Oct 5 16:00:11 2016 From: noreply at github.com (GitHub) Date: Wed, 05 Oct 2016 09:00:11 -0700 Subject: [dovecot/core] 830382: lib: If connect() fails with EADDRNOTAVAIL, retry ... Message-ID: <57f5238bcf7dd_6e6b3fbe6605d14c103276@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 830382ed5d7da056e209c0c76100dd940144c2c9 https://github.com/dovecot/core/commit/830382ed5d7da056e209c0c76100dd940144c2c9 Author: Timo Sirainen Date: 2016-10-05 (Wed, 05 Oct 2016) Changed paths: M src/lib/net.c Log Message: ----------- lib: If connect() fails with EADDRNOTAVAIL, retry it 4 more times. This is needed on busy systems. Nicely explained in: https://idea.popcount.org/2014-04-03-bind-before-connect/ From noreply at github.com Wed Oct 5 18:30:10 2016 From: noreply at github.com (GitHub) Date: Wed, 05 Oct 2016 11:30:10 -0700 Subject: [dovecot/core] 4036c1: lib-program-client: Add program-client from pigeon... Message-ID: <57f546b2e427f_24a03fadd7d9b13c111477@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 4036c1ca99d2c517f68a5b67a419ae7fdfd45300 https://github.com/dovecot/core/commit/4036c1ca99d2c517f68a5b67a419ae7fdfd45300 Author: Aki Tuomi Date: 2016-10-05 (Wed, 05 Oct 2016) Changed paths: M configure.ac M dovecot-config.in.in M src/Makefile.am A src/lib-program-client/Makefile.am A src/lib-program-client/program-client-local.c A src/lib-program-client/program-client-private.h A src/lib-program-client/program-client-remote.c A src/lib-program-client/program-client.c A src/lib-program-client/program-client.h Log Message: ----------- lib-program-client: Add program-client from pigeonhole From noreply at github.com Wed Oct 5 21:00:10 2016 From: noreply at github.com (GitHub) Date: Wed, 05 Oct 2016 14:00:10 -0700 Subject: [dovecot/core] b25ad2: lib-storage: Fixed assert-crash in mailbox_save_ca... Message-ID: <57f569da3b7f7_36e53fee9ecd114055689@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b25ad25cae4a8619405f3eb2fc82fee4c2f4eae1 https://github.com/dovecot/core/commit/b25ad25cae4a8619405f3eb2fc82fee4c2f4eae1 Author: Timo Sirainen Date: 2016-10-05 (Wed, 05 Oct 2016) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Fixed assert-crash in mailbox_save_cancel() Broken by 05150df8f. Fixes: Panic: file mail-storage.c: line 2137 (mailbox_save_context_reset): assertion failed: (ctx->saving) From noreply at github.com Wed Oct 5 21:30:14 2016 From: noreply at github.com (GitHub) Date: Wed, 05 Oct 2016 14:30:14 -0700 Subject: [dovecot/core] cf4bdc: lib: [ip]_free(mem) is now also guaranteed to set ... Message-ID: <57f570e6c7812_24993fc8cd18713c456d6@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: cf4bdceafe382cda0f3b7ff39c5327fa96a00fba https://github.com/dovecot/core/commit/cf4bdceafe382cda0f3b7ff39c5327fa96a00fba Author: Timo Sirainen Date: 2016-10-06 (Thu, 06 Oct 2016) Changed paths: M src/lib/imem.h M src/lib/mempool.h Log Message: ----------- lib: [ip]_free(mem) is now also guaranteed to set mem=NULL It was already doing it, but updated the macros and comments to make it clear that this won't change in future. Changing this would only make it more likely that bugs occur and the performance improvements would be close to nonexistent. Commit: ceace05582699dd86d6b41a20b87b1272b33352b https://github.com/dovecot/core/commit/ceace05582699dd86d6b41a20b87b1272b33352b Author: Timo Sirainen Date: 2016-10-06 (Thu, 06 Oct 2016) Changed paths: M src/lib/imem.h M src/lib/mempool-system.c M src/lib/mempool.h Log Message: ----------- lib: Simplify static checker's job for i_free() macro. Commit: b106236913cb4888b1996f956c9c1e9eb16d67c3 https://github.com/dovecot/core/commit/b106236913cb4888b1996f956c9c1e9eb16d67c3 Author: Timo Sirainen Date: 2016-10-06 (Thu, 06 Oct 2016) Changed paths: M src/lib-test/test-common.c M src/lib/data-stack.c M src/lib/data-stack.h Log Message: ----------- lib-test: Fixed assert-crash in test_exit() with --enable-static-checker Fixes: Panic: Missing t_pop() call Compare: https://github.com/dovecot/core/compare/b25ad25cae4a...b106236913cb From noreply at github.com Thu Oct 6 09:30:10 2016 From: noreply at github.com (GitHub) Date: Thu, 06 Oct 2016 02:30:10 -0700 Subject: [dovecot/core] 7f51e8: lib-index: Added test-mail-index-modseq unit test Message-ID: <57f619a229201_5f873facf89c7130148342@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7f51e8608944e19e02df8680f379c1a0d7e1a53b https://github.com/dovecot/core/commit/7f51e8608944e19e02df8680f379c1a0d7e1a53b Author: Timo Sirainen Date: 2016-10-06 (Thu, 06 Oct 2016) Changed paths: M src/lib-index/Makefile.am A src/lib-index/test-mail-index-modseq.c Log Message: ----------- lib-index: Added test-mail-index-modseq unit test From noreply at github.com Thu Oct 6 13:00:11 2016 From: noreply at github.com (GitHub) Date: Thu, 06 Oct 2016 06:00:11 -0700 Subject: [dovecot/core] c23ebb: imapc: Added imapc_max_line_length to limit maximu... Message-ID: <57f64adbbc8a7_9f63fa274d2313c1115f1@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c23ebb9b0e0b760ca8da16fde34ff33f5ece5e07 https://github.com/dovecot/core/commit/c23ebb9b0e0b760ca8da16fde34ff33f5ece5e07 Author: Timo Sirainen Date: 2016-10-06 (Thu, 06 Oct 2016) Changed paths: M src/lib-imap-client/imapc-client.c M src/lib-imap-client/imapc-client.h M src/lib-imap-client/imapc-connection.c M src/lib-storage/index/imapc/imapc-settings.c M src/lib-storage/index/imapc/imapc-settings.h M src/lib-storage/index/imapc/imapc-storage.c Log Message: ----------- imapc: Added imapc_max_line_length to limit maximum memory usage. The default is still unlimited, but this should be set to something smaller for untrusted servers. From noreply at github.com Sun Oct 9 20:00:10 2016 From: noreply at github.com (GitHub) Date: Sun, 09 Oct 2016 13:00:10 -0700 Subject: [dovecot/core] 0f27d0: log: Minor error logging and comment improvement. Message-ID: <57faa1ca3eda0_75953fc9e921113011052@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 0f27d0c9330143a8b08f6660d1dbe1cc921c209e https://github.com/dovecot/core/commit/0f27d0c9330143a8b08f6660d1dbe1cc921c209e Author: Timo Sirainen Date: 2016-10-09 (Sun, 09 Oct 2016) Changed paths: M src/log/log-connection.c Log Message: ----------- log: Minor error logging and comment improvement. Commit: 7f74811b78f8915e73dffc88bb49009e98b6846d https://github.com/dovecot/core/commit/7f74811b78f8915e73dffc88bb49009e98b6846d Author: Timo Sirainen Date: 2016-10-09 (Sun, 09 Oct 2016) Changed paths: M src/doveadm/client-connection-http.c M src/doveadm/doveadm-mail-save.c M src/doveadm/doveadm-mail.c M src/doveadm/dsync/dsync-mail.c M src/imap/cmd-append.c M src/lib-compression/istream-bzlib.c M src/lib-compression/istream-lz4.c M src/lib-compression/istream-lzma.c M src/lib-compression/istream-zlib.c M src/lib-dict-extra/dict-fs.c M src/lib-http/http-client-connection.c M src/lib-mail/istream-attachment-extractor.c M src/lib-storage/index/index-attachment.c M src/lib-storage/index/mbox/mbox-save.c M src/lib-storage/mail-copy.c M src/lib/istream-seekable.c Log Message: ----------- global: Make sure i_stream_read() calls handle 0 and -2 return values correctly. Compare: https://github.com/dovecot/core/compare/c23ebb9b0e0b...7f74811b78f8 From noreply at github.com Sun Oct 9 21:00:11 2016 From: noreply at github.com (GitHub) Date: Sun, 09 Oct 2016 14:00:11 -0700 Subject: [dovecot/core] e6ddcc: lib-compression: Fixed compler warnings and wrongl... Message-ID: <57faafdb31974_1b723fbe1a4d513082310@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e6ddcc51a59c03d5a1b9d6161822e454747c9c99 https://github.com/dovecot/core/commit/e6ddcc51a59c03d5a1b9d6161822e454747c9c99 Author: Timo Sirainen Date: 2016-10-09 (Sun, 09 Oct 2016) Changed paths: M src/lib-compression/istream-bzlib.c M src/lib-compression/istream-lz4.c M src/lib-compression/istream-lzma.c M src/lib-compression/istream-zlib.c Log Message: ----------- lib-compression: Fixed compler warnings and wrongly triggering asserts. Broken by 7f74811b7. From noreply at github.com Mon Oct 10 09:00:10 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 02:00:10 -0700 Subject: [dovecot/core] a11612: doveadm-sync: Document start date Message-ID: <57fb589a6c553_5bc43fbb0b389130830a5@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: a11612ec22e9286cf9753e56279fcd4ea8a74601 https://github.com/dovecot/core/commit/a11612ec22e9286cf9753e56279fcd4ea8a74601 Author: Aki Tuomi Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M doc/man/doveadm-sync.1.in M src/doveadm/doveadm-dsync.c Log Message: ----------- doveadm-sync: Document start date Commit: ee8294dbc7bb549557f6ba1264d66b55fbef69b6 https://github.com/dovecot/core/commit/ee8294dbc7bb549557f6ba1264d66b55fbef69b6 Author: Aki Tuomi Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/doveadm/doveadm-dsync.c M src/doveadm/dsync/dsync-brain-mailbox.c M src/doveadm/dsync/dsync-brain-private.h M src/doveadm/dsync/dsync-brain.c M src/doveadm/dsync/dsync-brain.h M src/doveadm/dsync/dsync-ibc-pipe.c M src/doveadm/dsync/dsync-ibc-stream.c M src/doveadm/dsync/dsync-ibc.h M src/doveadm/dsync/dsync-mail.h M src/doveadm/dsync/dsync-mailbox-import.c M src/doveadm/dsync/dsync-mailbox-import.h Log Message: ----------- doveadm-sync: Add end-date support Commit: 151fc06a4491e1b99867a81a92494863adb7a35e https://github.com/dovecot/core/commit/151fc06a4491e1b99867a81a92494863adb7a35e Author: Aki Tuomi Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M doc/man/doveadm-sync.1.in Log Message: ----------- doveadm-sync: Document end-date flag Compare: https://github.com/dovecot/core/compare/e6ddcc51a59c...151fc06a4491 From noreply at github.com Mon Oct 10 11:00:09 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 04:00:09 -0700 Subject: [dovecot/core] 03c653: lib-program-client: Whitespace fix Message-ID: <57fb74b9bc3b3_7b8c3ff5d6cdf1349305d@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 03c6532fe7aa3ddae23c99ff6bec78d8dd2e8165 https://github.com/dovecot/core/commit/03c6532fe7aa3ddae23c99ff6bec78d8dd2e8165 Author: Aki Tuomi Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Whitespace fix Commit: 98bc2ecdbfd4f2f20c3a5e96ae445072fbe22223 https://github.com/dovecot/core/commit/98bc2ecdbfd4f2f20c3a5e96ae445072fbe22223 Author: Aki Tuomi Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.c M src/lib-program-client/program-client.h Log Message: ----------- lib-program-client: Expose asynchronous API Commit: 9f29dfcbf3812c4f88ffb1c99b5a56b2e8091ea4 https://github.com/dovecot/core/commit/9f29dfcbf3812c4f88ffb1c99b5a56b2e8091ea4 Author: Aki Tuomi Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.h Log Message: ----------- lib-program-client: Rename remote to unix This is to make more clear that the call requires unix path and does not support TCP. There will be TCP based API too later. Commit: 0a017e924aa2490f6a54096d11e534b2a7554ebe https://github.com/dovecot/core/commit/0a017e924aa2490f6a54096d11e534b2a7554ebe Author: Aki Tuomi Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lib-program-client/Makefile.am A src/lib-program-client/test-program-client-local.c A src/lib-program-client/test-program-client-unix.c Log Message: ----------- lib-program-client: Add test suite for program client Compare: https://github.com/dovecot/core/compare/151fc06a4491...0a017e924aa2 From noreply at github.com Mon Oct 10 11:30:08 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 04:30:08 -0700 Subject: [dovecot/core] bc37ba: lmtp: Handle lmtp_user_concurrency_limit before lm... Message-ID: <57fb7bc0e8a77_3bc23fe6f3455140941b1@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: bc37bab86f0ae7b9d7149d2418340b88e6ef212f https://github.com/dovecot/core/commit/bc37bab86f0ae7b9d7149d2418340b88e6ef212f Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lmtp/commands.c Log Message: ----------- lmtp: Handle lmtp_user_concurrency_limit before lmtp_rcpt_check_quota The quota lookup is more expensive, so it shouldn't be done unnecessarily. From noreply at github.com Mon Oct 10 11:30:13 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 04:30:13 -0700 Subject: [dovecot/core] d8e11d: lib-program-client: Add program-client from pigeon... Message-ID: <57fb7bc58d0e9_7f1c3fd46b961138455d2@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: d8e11da242d38f036406427dab43e4c74ff84a92 https://github.com/dovecot/core/commit/d8e11da242d38f036406427dab43e4c74ff84a92 Author: Aki Tuomi Date: 2016-10-09 (Sun, 09 Oct 2016) Changed paths: M configure.ac M dovecot-config.in.in M src/Makefile.am A src/lib-program-client/Makefile.am A src/lib-program-client/program-client-local.c A src/lib-program-client/program-client-private.h A src/lib-program-client/program-client-remote.c A src/lib-program-client/program-client.c A src/lib-program-client/program-client.h Log Message: ----------- lib-program-client: Add program-client from pigeonhole Commit: de0de870a71b954820cc4ee22e74881fe2381b48 https://github.com/dovecot/core/commit/de0de870a71b954820cc4ee22e74881fe2381b48 Author: Aki Tuomi Date: 2016-10-09 (Sun, 09 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Whitespace fix Commit: 23933844c84e85df85b0aba2efe64389e4ed8105 https://github.com/dovecot/core/commit/23933844c84e85df85b0aba2efe64389e4ed8105 Author: Aki Tuomi Date: 2016-10-09 (Sun, 09 Oct 2016) Changed paths: M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.c M src/lib-program-client/program-client.h Log Message: ----------- lib-program-client: Expose asynchronous API Commit: e5e08bff9f8961a6cecc89d8899890f54c167bad https://github.com/dovecot/core/commit/e5e08bff9f8961a6cecc89d8899890f54c167bad Author: Aki Tuomi Date: 2016-10-09 (Sun, 09 Oct 2016) Changed paths: M src/lib-program-client/Makefile.am A src/lib-program-client/test-program-client-local.c A src/lib-program-client/test-program-client-remote.c Log Message: ----------- lib-program-client: Add test suite for program client Commit: a3217af3ccf62eaee263d72aa0fe6dcf60884e20 https://github.com/dovecot/core/commit/a3217af3ccf62eaee263d72aa0fe6dcf60884e20 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Avoid busy-looping while waiting for ostream to have space. Compare: https://github.com/dovecot/core/compare/c549d5104e11...a3217af3ccf6 From noreply at github.com Mon Oct 10 12:00:10 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 05:00:10 -0700 Subject: [dovecot/core] e564ff: cassandra: Added latency_aware_routing connect-par... Message-ID: <57fb82ca7e2d7_778f3fc27f7b713c153432@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e564ff0581fc44b78badf8da36e68f9f7a27807e https://github.com/dovecot/core/commit/e564ff0581fc44b78badf8da36e68f9f7a27807e Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Added latency_aware_routing connect-parameter. There's currently no way to change the default settings for it. Commit: 4755f8d37a2abb18f3783b4102c26fcd11a9f379 https://github.com/dovecot/core/commit/4755f8d37a2abb18f3783b4102c26fcd11a9f379 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-unix.c Log Message: ----------- lib-program-client: Compiler warning fixes Compare: https://github.com/dovecot/core/compare/bc37bab86f0a...4755f8d37a2a From noreply at github.com Mon Oct 10 12:00:13 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 05:00:13 -0700 Subject: [dovecot/core] 280368: lib-program-client: Compiler warning fixes Message-ID: <57fb82cd6935a_428e3fa3aae4d13414298f@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 280368615e60fc201c5b59798a9fe382f4acdafb https://github.com/dovecot/core/commit/280368615e60fc201c5b59798a9fe382f4acdafb Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-remote.c Log Message: ----------- lib-program-client: Compiler warning fixes From noreply at github.com Mon Oct 10 12:30:10 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 05:30:10 -0700 Subject: [dovecot/core] f24ede: imap-hibernate: Properly fix hibernation Message-ID: <57fb89d2b2f5c_58b33fa55cadf138527f1@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f24edebe360d3effe584a884aa7d119daf3fd371 https://github.com/dovecot/core/commit/f24edebe360d3effe584a884aa7d119daf3fd371 Author: Aki Tuomi Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c M src/imap-hibernate/imap-client.h M src/imap-hibernate/imap-hibernate-client.c M src/imap/imap-client-hibernate.c M src/imap/imap-master-client.c M src/imap/imap-state.c M src/imap/imap-state.h Log Message: ----------- imap-hibernate: Properly fix hibernation The previous fix did not properly fix hibernation as the clients still dropped out of hibernate. Also the tag used was no longer following. This change will track tag changes and keeps the hibernation process going on until the user enters something else than DONE\r\ntag IDLE\r\n in same packet. From noreply at github.com Mon Oct 10 15:30:10 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 08:30:10 -0700 Subject: [dovecot/core] a020eb: lib-storage: Added mail_user.session_create_time a... Message-ID: <57fbb402d1b8c_ef03fdb6a0a9134862e5@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: a020eb653b2620a989e4795adceb6136037327b2 https://github.com/dovecot/core/commit/a020eb653b2620a989e4795adceb6136037327b2 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage-service.h M src/lib-storage/mail-user.c M src/lib-storage/mail-user.h Log Message: ----------- lib-storage: Added mail_user.session_create_time and .session_restored Commit: 1e2b3bd82f2d4fbae0963f4a220df30b7b5ae628 https://github.com/dovecot/core/commit/1e2b3bd82f2d4fbae0963f4a220df30b7b5ae628 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c M src/imap-hibernate/imap-client.h M src/imap-hibernate/imap-hibernate-client.c M src/imap/imap-client-hibernate.c M src/imap/imap-master-client.c Log Message: ----------- imap-hibernate: Preserve mail_user.session_create_time through hibernation Commit: 55639052253ff28c6a0f569ae76dfda33e02c5f2 https://github.com/dovecot/core/commit/55639052253ff28c6a0f569ae76dfda33e02c5f2 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/plugins/quota/quota.c Log Message: ----------- quota: Don't execute quota_over_script if userdb lookup was over 10 secs ago Commit: 0c5ed44cf93523f5ae6d118501a79fff6dddf7d7 https://github.com/dovecot/core/commit/0c5ed44cf93523f5ae6d118501a79fff6dddf7d7 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/plugins/last-login/last-login-plugin.c Log Message: ----------- last-login: Don't execute last_login on IMAP unhibernation. Commit: ce1a6c9b82117d253df9acd77e54ac84dd8a247e https://github.com/dovecot/core/commit/ce1a6c9b82117d253df9acd77e54ac84dd8a247e Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/login-common/client-common-auth.c M src/login-common/client-common.h M src/login-common/login-common.h M src/login-common/main.c Log Message: ----------- *-login: Store user_* passdb fields to client->alt_usernames. Commit: adad68df4602d80639d7f28e4c7550fbafbd8d60 https://github.com/dovecot/core/commit/adad68df4602d80639d7f28e4c7550fbafbd8d60 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/doveadm/doveadm-proxy.c M src/login-common/login-proxy.c Log Message: ----------- doveadm proxy list: Show all user_* fields in output. Commit: 75af6e5ca2c4685e2316d27364ac7b00def7fed7 https://github.com/dovecot/core/commit/75af6e5ca2c4685e2316d27364ac7b00def7fed7 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/doveadm/doveadm-proxy.c M src/login-common/login-proxy.c Log Message: ----------- doveadm proxy kick: Added -f parameter. This works for all the user_* passdb fields. Commit: 9fc9965693110c250c6d6aa36ab60a77c934cc49 https://github.com/dovecot/core/commit/9fc9965693110c250c6d6aa36ab60a77c934cc49 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/doveadm/doveadm-proxy.c Log Message: ----------- doveadm proxy kick: Support multiple user parameters. Commit: 4a4fdb14788aec22dab8f1b91e9523233e5548dc https://github.com/dovecot/core/commit/4a4fdb14788aec22dab8f1b91e9523233e5548dc Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Escape username when handling USER-KICK. This could have caused problems if username parameter contained TABs or LFs, which of course shouldn't normally happen. Commit: 26f4264ece463fa14795c2d4a11fcc9875f544a1 https://github.com/dovecot/core/commit/26f4264ece463fa14795c2d4a11fcc9875f544a1 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director kick: Escape username properly. This only mattered if the username contained \001, TAB or LF characters, which isn't normal. Commit: bfef6891565ff9018ac92add6eae401e9352c657 https://github.com/dovecot/core/commit/bfef6891565ff9018ac92add6eae401e9352c657 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director.c M src/director/director.h M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director kick: Added -f parameter. This works for all the user_* passdb fields. Compare: https://github.com/dovecot/core/compare/f24edebe360d...bfef6891565f From noreply at github.com Mon Oct 10 15:55:56 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 08:55:56 -0700 Subject: [dovecot/core] 372b7c: auth: Introduce db_ldap_bind_sasl() function Message-ID: <57fbba0cabb98_5a633fc8aac272b829201bb@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 372b7c40bf035413dd3b9677f8f50f692b3602f0 https://github.com/dovecot/core/commit/372b7c40bf035413dd3b9677f8f50f692b3602f0 Author: Matwey V. Kornilov Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/auth/db-ldap.c Log Message: ----------- auth: Introduce db_ldap_bind_sasl() function Do refactoring in db_ldap_connect() before fixing the SASL bind issue in the next commit. Commit: adb497977f0719bb75df2afcf4932125d107de4b https://github.com/dovecot/core/commit/adb497977f0719bb75df2afcf4932125d107de4b Author: Matwey V. Kornilov Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/auth/db-ldap.c Log Message: ----------- auth: Fix default SASL bind for LDAP User may configure Dovecot to use SASL bind as default bind method. This can be the case when ldapi:/// (or ldaps:///) with SASL EXTERNAL is used. Currently, Dovecot returns LDAP connection to wrong bind state after first successful auth bind, LDAP simple bind always used to rebind. This may broke setup when ACL in LDAP configured not to allow search/bind for such simple bind. Compare: https://github.com/dovecot/core/compare/bfef6891565f...adb497977f07 From noreply at github.com Mon Oct 10 17:25:41 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 10:25:41 -0700 Subject: [dovecot/pigeonhole] 22f05f: lib-sieve: program-client was moved to dovecot cor... Message-ID: <57fbcf15c4445_22e63fcaf6f3b12c1916@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 22f05f11fe991e8213e51ec561fb2aae03c8898d https://github.com/dovecot/pigeonhole/commit/22f05f11fe991e8213e51ec561fb2aae03c8898d Author: Aki Tuomi Date: 2016-10-05 (Wed, 05 Oct 2016) Changed paths: M src/lib-sieve/util/Makefile.am R src/lib-sieve/util/program-client-local.c R src/lib-sieve/util/program-client-private.h R src/lib-sieve/util/program-client-remote.c R src/lib-sieve/util/program-client.c R src/lib-sieve/util/program-client.h Log Message: ----------- lib-sieve: program-client was moved to dovecot core Commit: 055537a30cd96a2ca8f03b7725922e08c034b910 https://github.com/dovecot/pigeonhole/commit/055537a30cd96a2ca8f03b7725922e08c034b910 Author: Stephan Bosch Date: 2016-10-06 (Thu, 06 Oct 2016) Changed paths: M src/plugins/doveadm-sieve/doveadm-sieve-sync.c Log Message: ----------- doveadm sieve plugin: sync: Fixed saving synchronized Sieve script. Assert failure could occur if the input buffer was full. Also, a small chance existed that not all data would be saved. Commit: a8fb53143504c3d2fcdcc5d42b29906480ace02a https://github.com/dovecot/pigeonhole/commit/a8fb53143504c3d2fcdcc5d42b29906480ace02a Author: Martti Rannanj?rvi Date: 2016-10-07 (Fri, 07 Oct 2016) Changed paths: M src/lib-sieve/util/Makefile.am Log Message: ----------- lib-sieve: restore realpath.h in Makefile.am Commit: 2a6ff60b8f206f7b09fe9f9974d5b3bd8fcfab34 https://github.com/dovecot/pigeonhole/commit/2a6ff60b8f206f7b09fe9f9974d5b3bd8fcfab34 Author: Stephan Bosch Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/plugins/sieve-extprograms/sieve-extprograms-common.c Log Message: ----------- Sieve extprograms plugin: Adjusted to program-client API change in Dovecot. program_client_remote_create() is now called program_client_unix_create(). Compare: https://github.com/dovecot/pigeonhole/compare/2ae18e519d21...2a6ff60b8f20 From noreply at github.com Mon Oct 10 17:38:20 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 10:38:20 -0700 Subject: [dovecot/pigeonhole] 2b3aaf: doveadm sieve plugin: sync: Fixed saving synchroni... Message-ID: <57fbd20c55610_fdd3fc7eb39313467ee@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: 2b3aaf3ff99bdf099b6d0e061a8ec8a86cce5869 https://github.com/dovecot/pigeonhole/commit/2b3aaf3ff99bdf099b6d0e061a8ec8a86cce5869 Author: Stephan Bosch Date: 2016-10-06 (Thu, 06 Oct 2016) Changed paths: M src/plugins/doveadm-sieve/doveadm-sieve-sync.c Log Message: ----------- doveadm sieve plugin: sync: Fixed saving synchronized Sieve script. Assert failure could occur if the input buffer was full. Also, a small chance existed that not all data would be saved. Commit: fe823824b806704df9ad0ff3cd65119f1b4cb61b https://github.com/dovecot/pigeonhole/commit/fe823824b806704df9ad0ff3cd65119f1b4cb61b Author: Aki Tuomi Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lib-sieve/util/Makefile.am R src/lib-sieve/util/program-client-local.c R src/lib-sieve/util/program-client-private.h R src/lib-sieve/util/program-client-remote.c R src/lib-sieve/util/program-client.c R src/lib-sieve/util/program-client.h Log Message: ----------- lib-sieve: program-client was moved to dovecot core Compare: https://github.com/dovecot/pigeonhole/compare/79be4c876008...fe823824b806 From noreply at github.com Mon Oct 10 18:00:10 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 11:00:10 -0700 Subject: [dovecot/core] 144e0b: auth: Compiler warning fix Message-ID: <57fbd72a3bd6c_21083f9e3df8113082258@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 144e0b545e5e1dac1fd825b4140b65bbf44ccb31 https://github.com/dovecot/core/commit/144e0b545e5e1dac1fd825b4140b65bbf44ccb31 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/auth/db-ldap.c Log Message: ----------- auth: Compiler warning fix From noreply at github.com Mon Oct 10 18:30:10 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 11:30:10 -0700 Subject: [dovecot/core] a694d1: lib-program-client: Fixed running test-program-cli... Message-ID: <57fbde32ce037_2c693fdbb323313c934bf@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: a694d17a2e867f1d35521c5d800d425220b3d3b7 https://github.com/dovecot/core/commit/a694d17a2e867f1d35521c5d800d425220b3d3b7 Author: Timo Sirainen Date: 2016-10-10 (Mon, 10 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-local.c Log Message: ----------- lib-program-client: Fixed running test-program-client-local as root. uid/gid == -1 isn't treated as "don't change" in here. From noreply at github.com Mon Oct 10 22:00:09 2016 From: noreply at github.com (GitHub) Date: Mon, 10 Oct 2016 15:00:09 -0700 Subject: [dovecot/core] d1a82a: lib-fs: Renamed internal i_stream_mail_read() to i... Message-ID: <57fc0f692663e_25393fdc503691305376b@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d1a82a2555792e9763cbaa04f895a04e10faaba4 https://github.com/dovecot/core/commit/d1a82a2555792e9763cbaa04f895a04e10faaba4 Author: Timo Sirainen Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M src/lib-fs/istream-fs-stats.c Log Message: ----------- lib-fs: Renamed internal i_stream_mail_read() to i_stream_fs_stats_read() Just to make backtraces look clearer. Originally forgot to change this after copy&pasting code from istream-mail.c From noreply at github.com Tue Oct 11 08:00:10 2016 From: noreply at github.com (GitHub) Date: Tue, 11 Oct 2016 01:00:10 -0700 Subject: [dovecot/core] 96e1ed: fs-metawrap: Don't assert-crash when trying to wri... Message-ID: <57fc9c0a906d6_7bb03ff35e90114032911@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 96e1ed172ae59cae6bc6e6ddd24d22a158e23dfe https://github.com/dovecot/core/commit/96e1ed172ae59cae6bc6e6ddd24d22a158e23dfe Author: Timo Sirainen Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M src/lib-fs/fs-metawrap.c M src/lib-fs/test-fs-metawrap.c Log Message: ----------- fs-metawrap: Don't assert-crash when trying to write an empty file. Fixes: Panic: file fs-metawrap.c: line 401 (fs_metawrap_write_stream_finish): assertion failed: (file->super_output->offset > 0 || file->super_output->stream_errno != 0) Commit: 004be038dfe290f71e3d4a4b14d88673e8b55fb2 https://github.com/dovecot/core/commit/004be038dfe290f71e3d4a4b14d88673e8b55fb2 Author: Timo Sirainen Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Fixed program_client_run() that succeeds rapidly. program_client_run_async() could have called the callback with result=0 before io_loop_run(). This happened with local client. Fixes in test-program-client-local: Panic: BUG: No IOs or timeouts set. Not waiting for infinity. Commit: 56774de9cdf7108a43c6b20060c506fe4f2652bb https://github.com/dovecot/core/commit/56774de9cdf7108a43c6b20060c506fe4f2652bb Author: Timo Sirainen Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-local.c Log Message: ----------- lib-program-client: Fixed potential panic in test-program-client-local If the run finished before io_loop_run(), it would panic with: Panic: BUG: No IOs or timeouts set. Not waiting for infinity. Compare: https://github.com/dovecot/core/compare/d1a82a255579...56774de9cdf7 From noreply at github.com Tue Oct 11 08:30:13 2016 From: noreply at github.com (GitHub) Date: Tue, 11 Oct 2016 01:30:13 -0700 Subject: [dovecot/core] a98be2: lib: iostream-temp: Fixed o_stream_send_istream() ... Message-ID: <57fca31565f1e_44053fc73280d14c86989@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: a98be204a4af67e4c8568881563c3691a7639400 https://github.com/dovecot/core/commit/a98be204a4af67e4c8568881563c3691a7639400 Author: Timo Sirainen Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M src/lib/iostream-temp.c Log Message: ----------- lib: iostream-temp: Fixed o_stream_send_istream() with >2GB files 8051312f9 wasn't quite enough. From noreply at github.com Tue Oct 11 14:30:09 2016 From: noreply at github.com (GitHub) Date: Tue, 11 Oct 2016 07:30:09 -0700 Subject: [dovecot/core] 63b557: auth: Don't re-insert userdb results from auth cac... Message-ID: <57fcf77182df8_4a3d3fea48d6b13c3258e@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 63b557b1c574699eb9793f038984f6fb9520ff6e https://github.com/dovecot/core/commit/63b557b1c574699eb9793f038984f6fb9520ff6e Author: Timo Sirainen Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: M src/auth/auth-request.c M src/auth/auth-request.h Log Message: ----------- auth: Don't re-insert userdb results from auth cache data back to cache. This was also breaking TTLs for the cached userdb results, because each re-insert reset the TTL. From noreply at github.com Tue Oct 11 21:31:22 2016 From: noreply at github.com (GitHub) Date: Tue, 11 Oct 2016 14:31:22 -0700 Subject: [dovecot/pigeonhole] a195bd: lib-sieve: vnd.dovecot.report extension: Added sup... Message-ID: <57fd5a2a51e81_67e13fc22c93113c102724@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: a195bd824fd60f06812e3b2161a7a8af748cae2d https://github.com/dovecot/pigeonhole/commit/a195bd824fd60f06812e3b2161a7a8af748cae2d Author: Stephan Bosch Date: 2016-10-11 (Tue, 11 Oct 2016) Changed paths: A doc/extensions/vnd.dovecot.report.txt M src/lib-sieve/plugins/vnd.dovecot/report/cmd-report.c M src/lib-sieve/plugins/vnd.dovecot/report/ext-vnd-report-common.c M src/lib-sieve/plugins/vnd.dovecot/report/ext-vnd-report-common.h M src/lib-sieve/plugins/vnd.dovecot/report/ext-vnd-report.c M tests/extensions/vnd.dovecot/report/execute.svtest Log Message: ----------- lib-sieve: vnd.dovecot.report extension: Added support for configuring the "From:" address used in the report. From noreply at github.com Wed Oct 12 12:00:09 2016 From: noreply at github.com (GitHub) Date: Wed, 12 Oct 2016 05:00:09 -0700 Subject: [dovecot/core] 3bfdab: auth: Pass userdb fields to worker Message-ID: <57fe25c9561c8_685a3f7ebf7271303912e@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 3bfdab77880db25dbdc8bf48c2cfc2d50b98e426 https://github.com/dovecot/core/commit/3bfdab77880db25dbdc8bf48c2cfc2d50b98e426 Author: Aki Tuomi Date: 2016-10-12 (Wed, 12 Oct 2016) Changed paths: M src/auth/auth-request.c M src/auth/auth-worker-client.c Log Message: ----------- auth: Pass userdb fields to worker If this is not done, then those userdb handlers that need access to userdb variables for e.g. interpolation, cannot access them. Commit: 8177c14444271eeec2bc3d965f7898322e16e358 https://github.com/dovecot/core/commit/8177c14444271eeec2bc3d965f7898322e16e358 Author: Aki Tuomi Date: 2016-10-12 (Wed, 12 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-unix.c Log Message: ----------- lib-program-client: Do not use /tmp in testing Compare: https://github.com/dovecot/core/compare/63b557b1c574...8177c1444427 From noreply at github.com Wed Oct 12 14:30:11 2016 From: noreply at github.com (GitHub) Date: Wed, 12 Oct 2016 07:30:11 -0700 Subject: [dovecot/core] 48e4a5: configure: Detect pandoc for building documentatio... Message-ID: <57fe48f3ac75f_603a3fb6146bd140789b@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 48e4a5c73f1ff446ad3812e3ed95e3fa261d1fe3 https://github.com/dovecot/core/commit/48e4a5c73f1ff446ad3812e3ed95e3fa261d1fe3 Author: Aki Tuomi Date: 2016-10-12 (Wed, 12 Oct 2016) Changed paths: M Makefile.am M configure.ac Log Message: ----------- configure: Detect pandoc for building documentation Commit: 16d9e9dd876bb0db022db0986907e9c369e99e02 https://github.com/dovecot/core/commit/16d9e9dd876bb0db022db0986907e9c369e99e02 Author: Aki Tuomi Date: 2016-10-12 (Wed, 12 Oct 2016) Changed paths: M .gitignore Log Message: ----------- git: Ignore README and INSTALL Commit: 73650a8873e384c24aba97f566d08ba866020997 https://github.com/dovecot/core/commit/73650a8873e384c24aba97f566d08ba866020997 Author: Aki Tuomi Date: 2016-10-12 (Wed, 12 Oct 2016) Changed paths: R README A README.md Log Message: ----------- README: Use markdown style Commit: 335ac4abc3f30859f9f9a47072d40271f4c85922 https://github.com/dovecot/core/commit/335ac4abc3f30859f9f9a47072d40271f4c85922 Author: Aki Tuomi Date: 2016-10-12 (Wed, 12 Oct 2016) Changed paths: R INSTALL A INSTALL.md M Makefile.am Log Message: ----------- INSTALL: Use markdown style Compare: https://github.com/dovecot/core/compare/8177c1444427...335ac4abc3f3 From noreply at github.com Thu Oct 13 06:30:10 2016 From: noreply at github.com (GitHub) Date: Wed, 12 Oct 2016 23:30:10 -0700 Subject: [dovecot/core] 5d7441: lib-dcrypt: fix comment of dovecot format v2 to us... Message-ID: <57ff29f237f94_701e3fb03f9431384866e@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 5d744144fef5057c210b994c5ca522edb8181714 https://github.com/dovecot/core/commit/5d744144fef5057c210b994c5ca522edb8181714 Author: Martti Rannanj?rvi Date: 2016-10-12 (Wed, 12 Oct 2016) Changed paths: M src/lib-dcrypt/dcrypt.h Log Message: ----------- lib-dcrypt: fix comment of dovecot format v2 to use colon Version 2 field separator was changed to colon. From noreply at github.com Thu Oct 13 11:00:16 2016 From: noreply at github.com (GitHub) Date: Thu, 13 Oct 2016 04:00:16 -0700 Subject: [dovecot/core] 67d2a4: dict-file: Don't leak a lock on temp file creation... Message-ID: <57ff69404be2_60753fe2e2127140393e5@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 67d2a4590e1a8ee95baefb6c070279d17a852a21 https://github.com/dovecot/core/commit/67d2a4590e1a8ee95baefb6c070279d17a852a21 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-dict/dict-file.c Log Message: ----------- dict-file: Don't leak a lock on temp file creation failure. Commit: 429441cacf798351f06755c5bef9ed848d090693 https://github.com/dovecot/core/commit/429441cacf798351f06755c5bef9ed848d090693 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/plugins/fts-squat/squat-uidlist.c Log Message: ----------- fts-squat: Fixed memory leak on corrupted uidlist handling Commit: 41f4efecd7ee37664b5c8877a76c0a5531990b27 https://github.com/dovecot/core/commit/41f4efecd7ee37664b5c8877a76c0a5531990b27 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/doveadm/doveadm-print.c Log Message: ----------- doveadm: Don't allow doveadm_print_header(title==NULL) anymore. It's not used anywhere, and if it was used it would have crashed with at least "tab" backend. Commit: a8fce6af6ad65be8f72c4759879927e8dc79e263 https://github.com/dovecot/core/commit/a8fce6af6ad65be8f72c4759879927e8dc79e263 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-ssl-iostream/iostream-openssl.c M src/lib-ssl-iostream/iostream-openssl.h M src/lib-ssl-iostream/iostream-ssl-private.h M src/lib-ssl-iostream/iostream-ssl.c Log Message: ----------- lib-ssl-iostream: Use more standard _init() & _deinit() to initialize SSL plugin This is mainly to make it easier for test programs to link to the plugin directly. Commit: 2d3cb95d21537b205e8afb8605eabc8a6429decf https://github.com/dovecot/core/commit/2d3cb95d21537b205e8afb8605eabc8a6429decf Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-http/Makefile.am M src/lib-http/test-http-client.c Log Message: ----------- lib-http: Link test-http-client libssl_iostream_openssl.so directly. This way it can be run without having to do make install first. Commit: 7cf115f85b430a31e453d303f685bcfc3c63b958 https://github.com/dovecot/core/commit/7cf115f85b430a31e453d303f685bcfc3c63b958 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-http/test-http-client.c M src/lib-ssl-iostream/iostream-openssl.c M src/lib-ssl-iostream/iostream-openssl.h M src/lib-ssl-iostream/iostream-ssl.c Log Message: ----------- lib-ssl-iostream: Fixed OpenSSL module to be actually initialized. Commit: 2d3f0550089ab215fda4865c1fa1ba6da6b4d76f https://github.com/dovecot/core/commit/2d3f0550089ab215fda4865c1fa1ba6da6b4d76f Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-ssl-iostream/iostream-ssl.c Log Message: ----------- lib-ssl-iostream: The final fix to make the SSL plugin loading not fail.. Commit: bf4a2429e449dbd9fe45693a7aba6ce4a5cf9992 https://github.com/dovecot/core/commit/bf4a2429e449dbd9fe45693a7aba6ce4a5cf9992 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib/ostream-failure-at.c Log Message: ----------- lib: Fixed ostream-failure-at with blocking parent stream. Blocking ostream returns either a full success or a full failure. It can't return that only n/m bytes were written. Fixes assert: Panic: file ostream.c: line 255 (o_stream_sendv_int): assertion failed: (!stream->blocking) Commit: 0b7991ead55a57109e4ca760878a3697f77f729f https://github.com/dovecot/core/commit/0b7991ead55a57109e4ca760878a3697f77f729f Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Remove timeout when there are only background commands. Normally the timeout wasn't added in the first place, but it was if a non-background command was added first and it was followed by a background command. Commit: d8dfef4c4af2e377d8bb62a7a1fce24cc06f34a9 https://github.com/dovecot/core/commit/d8dfef4c4af2e377d8bb62a7a1fce24cc06f34a9 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Don't return "Dict server timeout" too early. This could have happened when many dict commands were being run without the timeout being reset in the middle. Commit: b0f62923a93d1fbc74ef3d6697e871668d0cb499 https://github.com/dovecot/core/commit/b0f62923a93d1fbc74ef3d6697e871668d0cb499 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Fixed lock and ioloop wait timings in log messages. Previously it was logging the total amount of time spent on lock waits or on ioloop during the existence of the entire process, rather than how much time the command itself was spending on those. This wasn't very useful. Now it also tries to separate the time spent on the main ioloop and in dict_wait(). Commit: 0f1db26f33469d38eef7ec13523c022467e7aa5f https://github.com/dovecot/core/commit/0f1db26f33469d38eef7ec13523c022467e7aa5f Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/master/service-listen.c Log Message: ----------- master: Removed hardcoded listen() backlog limit. If it's already too large, the kernel will truncate it automatically. So there shouldn't be any reason for us to explicitly limit it. Commit: 88b127ba81d0f122b8406f72ab656cf6e59a0b86 https://github.com/dovecot/core/commit/88b127ba81d0f122b8406f72ab656cf6e59a0b86 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: If mailbox_move() fails, reset mail_save_context.moving==FALSE Commit: c94368100582f7aff217ccfaa1ffd73f7057f0c6 https://github.com/dovecot/core/commit/c94368100582f7aff217ccfaa1ffd73f7057f0c6 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-storage/mail-copy.c M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Don't reset mail_save_context.saving too early. If mailbox_save_using_mail() ended up in mail_storage_copy(), saving was set to FALSE before the copy() method was finished running. This caused e.g. notify plugin to think that this was a copy event instead of a save event. Added comments and asserts to clarify how the logic should work between all the different copying/moving/saving flags. Commit: de7259607e781068d6d5bf0f932fa42f5c56db21 https://github.com/dovecot/core/commit/de7259607e781068d6d5bf0f932fa42f5c56db21 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-storage/mail-user.c Log Message: ----------- lib-storage: mail_user_dup() should duplicate also userdb_fields. Commit: 97ad7d594fb78ff9f4d615dd73c491eb0e11cdd4 https://github.com/dovecot/core/commit/97ad7d594fb78ff9f4d615dd73c491eb0e11cdd4 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/director/director-host.c Log Message: ----------- director: Ignore duplicates in director_servers setting. Commit: 3def8e553c987012d4030e9ee5aa3eb8a2142e5e https://github.com/dovecot/core/commit/3def8e553c987012d4030e9ee5aa3eb8a2142e5e Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-test/test-common.c Log Message: ----------- lib-test: Allow test_istream_set_*() for test-istream's children. It will internally find the test_istream from parents. This simplifies the testing code so that it doesn't have to keep track of both the test_istream and the final istream. Commit: 364ce1d69baf69b2cf3524d4f7599570e77bacbd https://github.com/dovecot/core/commit/364ce1d69baf69b2cf3524d4f7599570e77bacbd Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-test/Makefile.am M src/lib-test/test-common.c A src/lib-test/test-istream.c Log Message: ----------- lib-test: Moved test_istream code to its own test-istream.c file. Commit: 70193d88f80ca220abecb0d1d1ec5d1ed726f9ff https://github.com/dovecot/core/commit/70193d88f80ca220abecb0d1d1ec5d1ed726f9ff Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-test/Makefile.am M src/lib-test/test-common.h A src/lib-test/test-ostream.c Log Message: ----------- lib-test: Added test_ostream for testing nonblocking ostreams. Commit: bf24499eb380512cd3aec3b8ae86d94f0684cbf7 https://github.com/dovecot/core/commit/bf24499eb380512cd3aec3b8ae86d94f0684cbf7 Author: Aki Tuomi Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib/ioloop-notify-inotify.c M src/lib/ioloop-notify-kqueue.c M src/lib/ioloop-notify-none.c M src/lib/ioloop-private.h M src/lib/ioloop.c M src/lib/ioloop.h Log Message: ----------- io: Add source filename This will make debugging alot easier when you can see what the filename is as well. Commit: 35fa25c7989c44c9bb49a0552880f4bff0a5ed6c https://github.com/dovecot/core/commit/35fa25c7989c44c9bb49a0552880f4bff0a5ed6c Author: Aki Tuomi Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-test/test-ostream.c Log Message: ----------- lib-test: Fix illegal memory access in test-ostream Commit: 42beb171fad3d233891dfeb6d79b353e09d9c84d https://github.com/dovecot/core/commit/42beb171fad3d233891dfeb6d79b353e09d9c84d Author: Aki Tuomi Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-test/test-ostream.c Log Message: ----------- lib-test: Fix memory leak in test-ostream Commit: 5b6dc4c53617362baf8713815621bebbeb38c8cc https://github.com/dovecot/core/commit/5b6dc4c53617362baf8713815621bebbeb38c8cc Author: Stephan Bosch Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib/uri-util.c Log Message: ----------- lib: uri-util: Always fully check the syntax of percent encoding while parsing URI components. Commit: 4cdd921730bf70061380a0db4049e2ff3a4a02ae https://github.com/dovecot/core/commit/4cdd921730bf70061380a0db4049e2ff3a4a02ae Author: Stephan Bosch Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-http/http-url.c Log Message: ----------- lib-http: uri: Removed unnecessary checking of percent encoding of query and fragment parts. This is now always performed in lib/uri-util. Commit: e32754a21898fc02cd544d532c493c2c59d5ef28 https://github.com/dovecot/core/commit/e32754a21898fc02cd544d532c493c2c59d5ef28 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/imap/imap-sync.c Log Message: ----------- imap: If mailbox is inconsistent after syncing, don't try to sync message counts. This fixes (e.g. after doveadm force-resync): Panic: Message count decreased Commit: c4a8f06a8cb03233d36e4c831be0f9f0c2a9046f https://github.com/dovecot/core/commit/c4a8f06a8cb03233d36e4c831be0f9f0c2a9046f Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-storage/index/index-sync.c Log Message: ----------- lib-storage: Make sure mailbox_sync*() fails if view is inconsistent afterwards. Commit: c7b935161f8d1be28208a51be59fce4e78c3f20a https://github.com/dovecot/core/commit/c7b935161f8d1be28208a51be59fce4e78c3f20a Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-index/mail-index-view-sync.c Log Message: ----------- lib-index: Fixed potential assert-crash when view syncing sees a reset marker. It should never try to use main index map at that point, because view_sync_have_expunges() looks changes only before the reset marker. Fixes: Error: Index .../dovecot.index lost messages without expunging (36 -> 27) Commit: 9bce4ed3844a7b5622b2e2a1d995e3dc75c2af41 https://github.com/dovecot/core/commit/9bce4ed3844a7b5622b2e2a1d995e3dc75c2af41 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-index/mail-index-view-sync.c Log Message: ----------- lib-index: When finding a view is reset, don't attempt any further syncing. This could cause various errors to be logged, such as: Error: Append with UID 7103, but next_uid = 7242 Commit: d8907e9b7b0319b02d217b89ee0ac1a8b4cf9b41 https://github.com/dovecot/core/commit/d8907e9b7b0319b02d217b89ee0ac1a8b4cf9b41 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-index/mail-index-view-sync.c Log Message: ----------- lib-index: If view syncing sees index is reset, always mark the view as inconsistent. Not only when the mailbox has messages, because that could still mess up assumptions about UIDs. A somewhat better check could have been to do this only when next_uid>1 (= there have been messages at some point in this mailbox), but it's safer to just always mark the view as inconsistent. Commit: f2dc727b40ee2aa256c4f41ec1d038b413a794dc https://github.com/dovecot/core/commit/f2dc727b40ee2aa256c4f41ec1d038b413a794dc Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-storage/mail-autoexpunge.c Log Message: ----------- lib-storage: autoexpunge mailboxes with wildcards didn't work with namespace prefix. Commit: 66bd5a6c84f779fe21c2f01750376bc879682408 https://github.com/dovecot/core/commit/66bd5a6c84f779fe21c2f01750376bc879682408 Author: Phil Carmody Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/plugins/fts/fts-storage.c Log Message: ----------- plugins/fts - make storage errors more informative There are 3 different ways to fail ending a transaction (one of which is itself just a record that something now unknown previously failed). Identify which one in the logs. Signed-off-by: Phil Carmody Commit: b816c98d4020af7bc15711c630521ccec5f25b3a https://github.com/dovecot/core/commit/b816c98d4020af7bc15711c630521ccec5f25b3a Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib/net.c Log Message: ----------- lib: If connect() fails with EADDRNOTAVAIL, retry it 4 more times. This is needed on busy systems. Nicely explained in: https://idea.popcount.org/2014-04-03-bind-before-connect/ Commit: 367aa5edb05b8debad532cce636cce8048eaf8e1 https://github.com/dovecot/core/commit/367aa5edb05b8debad532cce636cce8048eaf8e1 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Fixed assert-crash in mailbox_save_cancel() Broken by 05150df8f. Fixes: Panic: file mail-storage.c: line 2137 (mailbox_save_context_reset): assertion failed: (ctx->saving) Commit: 851a128fe59e369ff44a9435240fa9cd4a92d891 https://github.com/dovecot/core/commit/851a128fe59e369ff44a9435240fa9cd4a92d891 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-index/Makefile.am A src/lib-index/test-mail-index-modseq.c Log Message: ----------- lib-index: Added test-mail-index-modseq unit test Commit: 463fc801475fb7d710915a8fa7c9e0cc76ff6f5a https://github.com/dovecot/core/commit/463fc801475fb7d710915a8fa7c9e0cc76ff6f5a Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-imap-client/imapc-client.c M src/lib-imap-client/imapc-client.h M src/lib-imap-client/imapc-connection.c M src/lib-storage/index/imapc/imapc-settings.c M src/lib-storage/index/imapc/imapc-settings.h M src/lib-storage/index/imapc/imapc-storage.c Log Message: ----------- imapc: Added imapc_max_line_length to limit maximum memory usage. The default is still unlimited, but this should be set to something smaller for untrusted servers. Commit: 5cb85a03d0b345c06b8e3f9eceb73ca4284f0bce https://github.com/dovecot/core/commit/5cb85a03d0b345c06b8e3f9eceb73ca4284f0bce Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/log/log-connection.c Log Message: ----------- log: Minor error logging and comment improvement. Commit: 6a1110d8757bb72fd90f4fe0857fd3aeaf8920ff https://github.com/dovecot/core/commit/6a1110d8757bb72fd90f4fe0857fd3aeaf8920ff Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/doveadm/client-connection-http.c M src/doveadm/doveadm-mail-save.c M src/doveadm/doveadm-mail.c M src/doveadm/dsync/dsync-mail.c M src/imap/cmd-append.c M src/lib-compression/istream-bzlib.c M src/lib-compression/istream-lz4.c M src/lib-compression/istream-lzma.c M src/lib-compression/istream-zlib.c M src/lib-dict-extra/dict-fs.c M src/lib-http/http-client-connection.c M src/lib-mail/istream-attachment-extractor.c M src/lib-storage/index/index-attachment.c M src/lib-storage/index/mbox/mbox-save.c M src/lib-storage/mail-copy.c M src/lib/istream-seekable.c Log Message: ----------- global: Make sure i_stream_read() calls handle 0 and -2 return values correctly. Commit: f71958552f74bb0f71fc5e0735d8bfa93aed5592 https://github.com/dovecot/core/commit/f71958552f74bb0f71fc5e0735d8bfa93aed5592 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-compression/istream-bzlib.c M src/lib-compression/istream-lz4.c M src/lib-compression/istream-lzma.c M src/lib-compression/istream-zlib.c Log Message: ----------- lib-compression: Fixed compler warnings and wrongly triggering asserts. Broken by 7f74811b7. Commit: 4e02ed7954b39828f429cf645acf537c7ffc2c0e https://github.com/dovecot/core/commit/4e02ed7954b39828f429cf645acf537c7ffc2c0e Author: Aki Tuomi Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M doc/man/doveadm-sync.1.in M src/doveadm/doveadm-dsync.c Log Message: ----------- doveadm-sync: Document start date Commit: 69031c6abb8f016fdfee4ca3019c73f6412b2759 https://github.com/dovecot/core/commit/69031c6abb8f016fdfee4ca3019c73f6412b2759 Author: Aki Tuomi Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/doveadm/doveadm-dsync.c M src/doveadm/dsync/dsync-brain-mailbox.c M src/doveadm/dsync/dsync-brain-private.h M src/doveadm/dsync/dsync-brain.c M src/doveadm/dsync/dsync-brain.h M src/doveadm/dsync/dsync-ibc-pipe.c M src/doveadm/dsync/dsync-ibc-stream.c M src/doveadm/dsync/dsync-ibc.h M src/doveadm/dsync/dsync-mail.h M src/doveadm/dsync/dsync-mailbox-import.c M src/doveadm/dsync/dsync-mailbox-import.h Log Message: ----------- doveadm-sync: Add end-date support Commit: ba9270a399797f45c74b526ce6c49ecdaad37181 https://github.com/dovecot/core/commit/ba9270a399797f45c74b526ce6c49ecdaad37181 Author: Aki Tuomi Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M doc/man/doveadm-sync.1.in Log Message: ----------- doveadm-sync: Document end-date flag Commit: 4236767f671c5c7b9c5e6509cd394a6eb05cbb1b https://github.com/dovecot/core/commit/4236767f671c5c7b9c5e6509cd394a6eb05cbb1b Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lmtp/commands.c Log Message: ----------- lmtp: Handle lmtp_user_concurrency_limit before lmtp_rcpt_check_quota The quota lookup is more expensive, so it shouldn't be done unnecessarily. Commit: be7f2032d1fc34e24d2e1d2532b91543f8f2cb78 https://github.com/dovecot/core/commit/be7f2032d1fc34e24d2e1d2532b91543f8f2cb78 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-sql/driver-cassandra.c Log Message: ----------- cassandra: Added latency_aware_routing connect-parameter. There's currently no way to change the default settings for it. Commit: 3b5562aeb6796e33bd8c17ba59f364b38c71d366 https://github.com/dovecot/core/commit/3b5562aeb6796e33bd8c17ba59f364b38c71d366 Author: Aki Tuomi Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c M src/imap-hibernate/imap-client.h M src/imap-hibernate/imap-hibernate-client.c M src/imap/imap-client-hibernate.c M src/imap/imap-master-client.c M src/imap/imap-state.c M src/imap/imap-state.h Log Message: ----------- imap-hibernate: Properly fix hibernation The previous fix did not properly fix hibernation as the clients still dropped out of hibernate. Also the tag used was no longer following. This change will track tag changes and keeps the hibernation process going on until the user enters something else than DONE\r\ntag IDLE\r\n in same packet. Commit: 0e72564d0d5af972740ff73ab4952eb06785529b https://github.com/dovecot/core/commit/0e72564d0d5af972740ff73ab4952eb06785529b Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-storage-service.h M src/lib-storage/mail-user.c M src/lib-storage/mail-user.h Log Message: ----------- lib-storage: Added mail_user.session_create_time and .session_restored Commit: dcddd3ed88b4989bcf105afb50aca5b812234356 https://github.com/dovecot/core/commit/dcddd3ed88b4989bcf105afb50aca5b812234356 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c M src/imap-hibernate/imap-client.h M src/imap-hibernate/imap-hibernate-client.c M src/imap/imap-client-hibernate.c M src/imap/imap-master-client.c Log Message: ----------- imap-hibernate: Preserve mail_user.session_create_time through hibernation Commit: ec769b57dc94f7954799af6e5fd0e5b4b309cb28 https://github.com/dovecot/core/commit/ec769b57dc94f7954799af6e5fd0e5b4b309cb28 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/plugins/quota/quota.c Log Message: ----------- quota: Don't execute quota_over_script if userdb lookup was over 10 secs ago Commit: 2a736c0c3172230fc8f91f344e938b1eed062e24 https://github.com/dovecot/core/commit/2a736c0c3172230fc8f91f344e938b1eed062e24 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/plugins/last-login/last-login-plugin.c Log Message: ----------- last-login: Don't execute last_login on IMAP unhibernation. Commit: 27c3fd81fb5aeabbc9d13f57a4871ab9e923d37e https://github.com/dovecot/core/commit/27c3fd81fb5aeabbc9d13f57a4871ab9e923d37e Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/login-common/client-common-auth.c M src/login-common/client-common.h M src/login-common/login-common.h M src/login-common/main.c Log Message: ----------- *-login: Store user_* passdb fields to client->alt_usernames. Commit: c82b58c8abde455fb55bc1ac309071106e1b530e https://github.com/dovecot/core/commit/c82b58c8abde455fb55bc1ac309071106e1b530e Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/doveadm/doveadm-proxy.c M src/login-common/login-proxy.c Log Message: ----------- doveadm proxy list: Show all user_* fields in output. Commit: 124bfaead989fa1ccafb1112c4fccdf73af3da6f https://github.com/dovecot/core/commit/124bfaead989fa1ccafb1112c4fccdf73af3da6f Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/doveadm/doveadm-proxy.c M src/login-common/login-proxy.c Log Message: ----------- doveadm proxy kick: Added -f parameter. This works for all the user_* passdb fields. Commit: e07044df54448c45bdbcf8b4c1e08d75ae176239 https://github.com/dovecot/core/commit/e07044df54448c45bdbcf8b4c1e08d75ae176239 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/doveadm/doveadm-proxy.c Log Message: ----------- doveadm proxy kick: Support multiple user parameters. Commit: 51701893c21b4f13e150f3ac1a60da16d7b21e83 https://github.com/dovecot/core/commit/51701893c21b4f13e150f3ac1a60da16d7b21e83 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Escape username when handling USER-KICK. This could have caused problems if username parameter contained TABs or LFs, which of course shouldn't normally happen. Commit: 242005b278dcfc26602553c4c38b1b7e81b54354 https://github.com/dovecot/core/commit/242005b278dcfc26602553c4c38b1b7e81b54354 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director kick: Escape username properly. This only mattered if the username contained \001, TAB or LF characters, which isn't normal. Commit: 5bdbda01bddc60e5628afd76730504d0acf1c407 https://github.com/dovecot/core/commit/5bdbda01bddc60e5628afd76730504d0acf1c407 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director.c M src/director/director.h M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director kick: Added -f parameter. This works for all the user_* passdb fields. Commit: aae459582c1853debb12a225207e5b1dd1726310 https://github.com/dovecot/core/commit/aae459582c1853debb12a225207e5b1dd1726310 Author: Matwey V. Kornilov Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/auth/db-ldap.c Log Message: ----------- auth: Introduce db_ldap_bind_sasl() function Do refactoring in db_ldap_connect() before fixing the SASL bind issue in the next commit. Commit: 79d9a65e8f515327429db250e5fed1354035ea4d https://github.com/dovecot/core/commit/79d9a65e8f515327429db250e5fed1354035ea4d Author: Matwey V. Kornilov Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/auth/db-ldap.c Log Message: ----------- auth: Fix default SASL bind for LDAP User may configure Dovecot to use SASL bind as default bind method. This can be the case when ldapi:/// (or ldaps:///) with SASL EXTERNAL is used. Currently, Dovecot returns LDAP connection to wrong bind state after first successful auth bind, LDAP simple bind always used to rebind. This may broke setup when ACL in LDAP configured not to allow search/bind for such simple bind. Commit: 4d51949a6b1486b9b10fc5e23052453ffc7da9cb https://github.com/dovecot/core/commit/4d51949a6b1486b9b10fc5e23052453ffc7da9cb Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-local.c Log Message: ----------- lib-program-client: Fixed running test-program-client-local as root. uid/gid == -1 isn't treated as "don't change" in here. Commit: 8cf999a2bdf13784c3b939c997657b40b7818d66 https://github.com/dovecot/core/commit/8cf999a2bdf13784c3b939c997657b40b7818d66 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-fs/istream-fs-stats.c Log Message: ----------- lib-fs: Renamed internal i_stream_mail_read() to i_stream_fs_stats_read() Just to make backtraces look clearer. Originally forgot to change this after copy&pasting code from istream-mail.c Commit: 2c2d64ed30ba0770539d52fdd86e0155addbc3bc https://github.com/dovecot/core/commit/2c2d64ed30ba0770539d52fdd86e0155addbc3bc Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-fs/fs-metawrap.c M src/lib-fs/test-fs-metawrap.c Log Message: ----------- fs-metawrap: Don't assert-crash when trying to write an empty file. Fixes: Panic: file fs-metawrap.c: line 401 (fs_metawrap_write_stream_finish): assertion failed: (file->super_output->offset > 0 || file->super_output->stream_errno != 0) Commit: 282de4e528a22ea4da38f9b69a919fd5bac6ced5 https://github.com/dovecot/core/commit/282de4e528a22ea4da38f9b69a919fd5bac6ced5 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Fixed program_client_run() that succeeds rapidly. program_client_run_async() could have called the callback with result=0 before io_loop_run(). This happened with local client. Fixes in test-program-client-local: Panic: BUG: No IOs or timeouts set. Not waiting for infinity. Commit: d29c70425fbbbc6613583be8762008e49aca53c9 https://github.com/dovecot/core/commit/d29c70425fbbbc6613583be8762008e49aca53c9 Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-local.c Log Message: ----------- lib-program-client: Fixed potential panic in test-program-client-local If the run finished before io_loop_run(), it would panic with: Panic: BUG: No IOs or timeouts set. Not waiting for infinity. Commit: f7eed93e33209f45436301a6c93e0b0660f0265b https://github.com/dovecot/core/commit/f7eed93e33209f45436301a6c93e0b0660f0265b Author: Timo Sirainen Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/auth/auth-request.c M src/auth/auth-request.h Log Message: ----------- auth: Don't re-insert userdb results from auth cache data back to cache. This was also breaking TTLs for the cached userdb results, because each re-insert reset the TTL. Commit: 6a012765c15d835c1e0558fdd9419742959276a5 https://github.com/dovecot/core/commit/6a012765c15d835c1e0558fdd9419742959276a5 Author: Aki Tuomi Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/auth/auth-request.c M src/auth/auth-worker-client.c Log Message: ----------- auth: Pass userdb fields to worker If this is not done, then those userdb handlers that need access to userdb variables for e.g. interpolation, cannot access them. Compare: https://github.com/dovecot/core/compare/a98be204a4af...6a012765c15d From noreply at github.com Fri Oct 14 08:00:09 2016 From: noreply at github.com (GitHub) Date: Fri, 14 Oct 2016 01:00:09 -0700 Subject: [dovecot/core] c42c9f: lib-dcrypt: enc_key and pw must be NULL on storing... Message-ID: <58009089ae81d_43263fd8f94e313c42141@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c42c9ff351eadcc0bcfb73cb272b112198bbf756 https://github.com/dovecot/core/commit/c42c9ff351eadcc0bcfb73cb272b112198bbf756 Author: Martti Rannanj?rvi Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-dcrypt/dcrypt-openssl.c M src/lib-dcrypt/dcrypt.h M src/lib-dcrypt/test-crypto.c Log Message: ----------- lib-dcrypt: enc_key and pw must be NULL on storing unencrypted private key Add tests for password and key encryption, and get_info on them. Also give examples of valid cipher values for password and key encryption in dcrypt.h comment. From noreply at github.com Fri Oct 14 10:00:18 2016 From: noreply at github.com (GitHub) Date: Fri, 14 Oct 2016 03:00:18 -0700 Subject: [dovecot/core] be8323: lib: ostream-file: Renamed iov_size to iov_count e... Message-ID: <5800acb250960_2eb33fc50bfff1301038d@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: be83239bb8c5b95aa009a10682fff9d4cb42e862 https://github.com/dovecot/core/commit/be83239bb8c5b95aa009a10682fff9d4cb42e862 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib/ostream-file.c Log Message: ----------- lib: ostream-file: Renamed iov_size to iov_count everywhere and made it unsigned int for consistency. Commit: 660db45086fc5a391be752a036b303ea3c080990 https://github.com/dovecot/core/commit/660db45086fc5a391be752a036b303ea3c080990 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib/ostream-file.c Log Message: ----------- lib: ostream-file: Renamed o_stream_writev() to o_stream_file_writev_full(). Commit: 6853a869bd0d5bcb0c87e12266883209cd001b4e https://github.com/dovecot/core/commit/6853a869bd0d5bcb0c87e12266883209cd001b4e Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib/ostream-file.c Log Message: ----------- lib: ostream-file: Split o_stream_file_writev() from o_stream_file_writev_full(). Commit: 85df9a41315249c21f70b95df91b4dca9484cfb3 https://github.com/dovecot/core/commit/85df9a41315249c21f70b95df91b4dca9484cfb3 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib/Makefile.am A src/lib/ostream-file-private.h M src/lib/ostream-file.c Log Message: ----------- lib: ostream-file: Allow creating derived file output streams. Commit: 28926495ac71dd8333caeef1b2a487df6b5eeed9 https://github.com/dovecot/core/commit/28926495ac71dd8333caeef1b2a487df6b5eeed9 Author: Timo Sirainen Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib/ostream-buffer.c M src/lib/ostream-file.c M src/lib/ostream-null.c M src/lib/ostream.c M src/lib/ostream.h Log Message: ----------- lib: Added ostream.blocking boolean Similar to istream.blocking. Commit: dd0eaa55242978aeac1ed9a979921c2531c261a8 https://github.com/dovecot/core/commit/dd0eaa55242978aeac1ed9a979921c2531c261a8 Author: Timo Sirainen Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib/ostream-buffer.c Log Message: ----------- lib: Don't set ostream buffer as blocking Commit: 0dda73fd178bbe5ae78c2d7b7a97a4f2e1a0ceef https://github.com/dovecot/core/commit/0dda73fd178bbe5ae78c2d7b7a97a4f2e1a0ceef Author: Aki Tuomi Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib/uri-util.c Log Message: ----------- Revert "lib: uri-util: Always fully check the syntax of percent encoding while parsing URI components." This reverts commit 5b6dc4c53617362baf8713815621bebbeb38c8cc. Commit: 204ad3f019353467a5cc54bc46d244bfc0aa8074 https://github.com/dovecot/core/commit/204ad3f019353467a5cc54bc46d244bfc0aa8074 Author: Aki Tuomi Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib/uri-util.c Log Message: ----------- Revert "uri-util: Fixed assertion failure for invalid character in path segment." This reverts commit dbbdcc1224f81a40e746a09e6d44af7c4f24ff71. Commit: 6fd1b5dcc4fbdb6070c8065b9a65e639fe6f0bd1 https://github.com/dovecot/core/commit/6fd1b5dcc4fbdb6070c8065b9a65e639fe6f0bd1 Author: Aki Tuomi Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c Log Message: ----------- imap-hibernate: Adjust API usage for ostream Commit: ac80b9d2687ca4ca626dd4c2796c71649ec17fd4 https://github.com/dovecot/core/commit/ac80b9d2687ca4ca626dd4c2796c71649ec17fd4 Author: Aki Tuomi Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-index/test-mail-index-modseq.c Log Message: ----------- lib-index: unlink_directory has no error Compare: https://github.com/dovecot/core/compare/6a012765c15d...ac80b9d2687c From noreply at github.com Fri Oct 14 11:30:09 2016 From: noreply at github.com (GitHub) Date: Fri, 14 Oct 2016 04:30:09 -0700 Subject: [dovecot/core] 9a025a: lib-dcrypt: str_new to t_str_new in some test-cryp... Message-ID: <5800c1c1be329_361e3fd27b7d11344608a@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9a025a74699b66f0a083ffaab530348bf2fa60cb https://github.com/dovecot/core/commit/9a025a74699b66f0a083ffaab530348bf2fa60cb Author: Martti Rannanj?rvi Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-dcrypt/test-crypto.c Log Message: ----------- lib-dcrypt: str_new to t_str_new in some test-crypto tests str_new from default_pool was not properly freed. From noreply at github.com Fri Oct 14 20:44:55 2016 From: noreply at github.com (GitHub) Date: Fri, 14 Oct 2016 13:44:55 -0700 Subject: [dovecot/pigeonhole] da828b: Removed the test suite's valgrind handling in favo... Message-ID: <580143c7a15bd_645a3fd8ea28b13c69874@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: da828b84831656ec1ef2a2ded76c53abe133ffe6 https://github.com/dovecot/pigeonhole/commit/da828b84831656ec1ef2a2ded76c53abe133ffe6 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M .gitignore M Makefile.am M configure.ac M dovecot-pigeonhole.m4 Log Message: ----------- Removed the test suite's valgrind handling in favor of the generic implementation Dovecot provides. Commit: ba83950d050a878c18b6eca74d30930db0e6e802 https://github.com/dovecot/pigeonhole/commit/ba83950d050a878c18b6eca74d30930db0e6e802 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/mime/cmd-extracttext.c M src/lib-sieve/plugins/mime/ext-extracttext.c Log Message: ----------- Fixed copyright notices. Commit: d4fb1ff760e55aad5066eed702cebaeb3c80192a https://github.com/dovecot/pigeonhole/commit/d4fb1ff760e55aad5066eed702cebaeb3c80192a Author: Martti Rannanj?rvi Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/util/edit-mail.c Log Message: ----------- lib-sieve: MAIL_FETCH_UIDL_FILE_NAME to MAIL_FETCH_STORAGE_ID: MAIL_FETCH_UIDL_FILE_NAME was removed from core. Commit: 78b00a3b59c2a322f7966b33a556848dc0b7176d https://github.com/dovecot/pigeonhole/commit/78b00a3b59c2a322f7966b33a556848dc0b7176d Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/relational/mcht-value.c Log Message: ----------- lib-sieve: relational extension: Removed dead default in switch statement. Minor complaint by Coverity. Commit: f0ceddc8531a72b6010a64524f8b2b85aa490871 https://github.com/dovecot/pigeonhole/commit/f0ceddc8531a72b6010a64524f8b2b85aa490871 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/storage/ldap/sieve-ldap-db.c Log Message: ----------- lib-sieve: ldap storage: Removed useless NULL checks. Caused minor complaints by Coverity. Commit: 18b0aed6fe1b27b78f92f8afd75d82e70aee595b https://github.com/dovecot/pigeonhole/commit/18b0aed6fe1b27b78f92f8afd75d82e70aee595b Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/relational/mcht-value.c Log Message: ----------- lib-sieve: relational extension: Replaced return statement with i_unreached() in mcht_value_match_key(). Coverity still complained. Commit: 45d8d47ea8999c3903a292534f6a57429caf8254 https://github.com/dovecot/pigeonhole/commit/45d8d47ea8999c3903a292534f6a57429caf8254 Author: Aki Tuomi Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M tests/deprecated/imapflags/errors.svtest M tests/deprecated/notify/errors.svtest Log Message: ----------- tests/deprecated: Fix typo Commit: 3ac69765047dc5df05a8ee2780c48929e4a41d97 https://github.com/dovecot/pigeonhole/commit/3ac69765047dc5df05a8ee2780c48929e4a41d97 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-managesieve/managesieve-parser.c Log Message: ----------- lib-managesieve: managesieve-parser: Fixed function return types to be bool rather than int. Found with clang -Wstrict-bool. Commit: 44b80a98be32d52f44582c9eadb2708825ce5114 https://github.com/dovecot/pigeonhole/commit/44b80a98be32d52f44582c9eadb2708825ce5114 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/ext-encoded-character.c Log Message: ----------- lib-sieve: encoded-character extension: Fixed function return types to be bool rather than int. Found with clang -Wstrict-bool. Commit: 671796ff4bcc9bcff7170a5fe2b29bb8d0b13e88 https://github.com/dovecot/pigeonhole/commit/671796ff4bcc9bcff7170a5fe2b29bb8d0b13e88 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/mcht-contains.c M src/lib-sieve/mcht-is.c M src/lib-sieve/mcht-matches.c Log Message: ----------- lib-sieve: match types: Fixed match function return values to be int rather than bool. Found with clang -Wstrict-bool. Commit: 34913ff88d0a823b84e27b20005828004368d961 https://github.com/dovecot/pigeonhole/commit/34913ff88d0a823b84e27b20005828004368d961 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/enotify/cmd-notify.c M src/lib-sieve/plugins/enotify/ext-enotify-common.c M src/lib-sieve/plugins/enotify/mailto/ntfy-mailto.c M src/lib-sieve/plugins/enotify/mailto/uri-mailto.c M src/lib-sieve/plugins/enotify/vmodf-encodeurl.c Log Message: ----------- lib-sieve: enotify extension: Fixed various bool vs. int/pointer mixups. Found with clang -Wstrict-bool. Commit: 8a78f04752e0a152d8f74c4eb59d59f2be2c5b5e https://github.com/dovecot/pigeonhole/commit/8a78f04752e0a152d8f74c4eb59d59f2be2c5b5e Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/include/cmd-include.c M src/lib-sieve/plugins/include/ext-include-common.c Log Message: ----------- lib-sieve: include extension: Fixed various bool vs. int mixups. Found with clang -Wstrict-bool. Commit: 812c7fe051983743c8db1f30eefd4b4e8e3b291e https://github.com/dovecot/pigeonhole/commit/812c7fe051983743c8db1f30eefd4b4e8e3b291e Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/index/tag-index.c Log Message: ----------- lib-sieve: index extension: Fixed a bool vs. int mixup. Found with clang -Wstrict-bool. Commit: 762774550898e960fd561041a62ec06328d79f9f https://github.com/dovecot/pigeonhole/commit/762774550898e960fd561041a62ec06328d79f9f Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/mailbox/tst-mailboxexists.c Log Message: ----------- lib-sieve: mailbox extension: Fixed invalid use of sieve_ast_stringlist_map(). Mixed up bool and int return types. Found with clang -Wstrict-bool. Commit: 348ab9393286bf3a25ea1ce58bcf86bd946920f9 https://github.com/dovecot/pigeonhole/commit/348ab9393286bf3a25ea1ce58bcf86bd946920f9 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/metadata/tst-metadataexists.c Log Message: ----------- lib-sieve: metadata extension: Fixed invalid use of sieve_ast_stringlist_map(). Mixed up bool and int return types. Found with clang -Wstrict-bool. Commit: 437415615dae22315481c1b0a436b7e7781fa876 https://github.com/dovecot/pigeonhole/commit/437415615dae22315481c1b0a436b7e7781fa876 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/notify/cmd-notify.c Log Message: ----------- lib-sieve: deprecated notify extension: Fixed various bool vs. int/pointer mixups. Found with clang -Wstrict-bool. Commit: e44f695718eb60634cf560e9cb9273594f8bd6fb https://github.com/dovecot/pigeonhole/commit/e44f695718eb60634cf560e9cb9273594f8bd6fb Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/regex/mcht-regex.c Log Message: ----------- lib-sieve: regex extension: Fixed invalid use of sieve_ast_stringlist_map(). Mixed up bool and int return types. Found with clang -Wstrict-bool. Commit: 6f3f6fe1b174e587f9d9b88f9fdecf77a243eec5 https://github.com/dovecot/pigeonhole/commit/6f3f6fe1b174e587f9d9b88f9fdecf77a243eec5 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/vacation/cmd-vacation.c Log Message: ----------- lib-sieve: vacation extension: Fixed invalid evaluation of the mail_get_headers() return value. Found with clang -Wstrict-bool. Commit: d8e27b064de75505b18bb8ae35f3ca5012e3d5c4 https://github.com/dovecot/pigeonhole/commit/d8e27b064de75505b18bb8ae35f3ca5012e3d5c4 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/ext-reject.c M src/lib-sieve/sieve-actions.c M src/lib-sieve/sieve-actions.h Log Message: ----------- lib-sieve: reject extension: Fixed varius bool vs. int mixups. Found with clang -Wstrict-bool. Commit: 31300080900b641ff43470b1d55af81071c7b46c https://github.com/dovecot/pigeonhole/commit/31300080900b641ff43470b1d55af81071c7b46c Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/testsuite/cmd-test-message.c M src/testsuite/testsuite-binary.c M src/testsuite/testsuite-script.c Log Message: ----------- testsuite: Fixed various bool vs. int mixups. Found with clang -Wstrict-bool. Commit: cf2d912b02a5e2678599c2e5a0b18a9e98058900 https://github.com/dovecot/pigeonhole/commit/cf2d912b02a5e2678599c2e5a0b18a9e98058900 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/sieve-tools/sieve-filter.c Log Message: ----------- sieve-filter: Fixed a bool vs. int mixup. Found with clang -Wstrict-bool. Commit: 181300b5ad9ef6fd45d0b0a8a84a6f73e0a56f35 https://github.com/dovecot/pigeonhole/commit/181300b5ad9ef6fd45d0b0a8a84a6f73e0a56f35 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/sieve-script-private.h M src/lib-sieve/storage/dict/sieve-dict-script.c M src/lib-sieve/storage/ldap/sieve-ldap-script.c Log Message: ----------- lib-sieve: script: The return type of binary_dump_metadata() is supposed to be bool rather than int. Found with clang -Wstrict-bool. Commit: 5d2cd8f56e28c4f22af074e5abd2a6693284bfe9 https://github.com/dovecot/pigeonhole/commit/5d2cd8f56e28c4f22af074e5abd2a6693284bfe9 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/sieve-actions.c M src/lib-sieve/sieve-actions.h M src/lib-sieve/sieve-types.h M src/plugins/imapsieve/imap-sieve.c M src/plugins/lda-sieve/lda-sieve-plugin.c M src/sieve-tools/sieve-test.c Log Message: ----------- lib-sieve: The return type of duplicate_check() is supposed to be bool rather than int. Found with clang -Wstrict-bool. Commit: cb5fb48be1f741159b98485b3c30a8b7ea540f17 https://github.com/dovecot/pigeonhole/commit/cb5fb48be1f741159b98485b3c30a8b7ea540f17 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/storage/file/sieve-file-storage-active.c Log Message: ----------- lib-sieve: file storage: The try_hardlink parameter of file_copy() is of type bool, rather than int. Found with clang -Wstrict-bool. Commit: 0757c93db3a1d1c9c19a3cf4f5a9a5029c764217 https://github.com/dovecot/pigeonhole/commit/0757c93db3a1d1c9c19a3cf4f5a9a5029c764217 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/managesieve/managesieve-client.c Log Message: ----------- managesieve: Fixed various bool vs. int mixups. Found with clang -Wstrict-bool. Commit: fb5f3c42eebbc2ef93f05e86e85be3f884d8bed0 https://github.com/dovecot/pigeonhole/commit/fb5f3c42eebbc2ef93f05e86e85be3f884d8bed0 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/plugins/sieve-extprograms/cmd-execute.c M src/plugins/sieve-extprograms/cmd-filter.c M src/plugins/sieve-extprograms/sieve-extprograms-common.c Log Message: ----------- extprograms plugin: Fixed various bool vs. int mixups. Found with clang -Wstrict-bool. Commit: c45e215394b5e10c4cc8cc5514e653907086efd2 https://github.com/dovecot/pigeonhole/commit/c45e215394b5e10c4cc8cc5514e653907086efd2 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/plugins/doveadm-sieve/doveadm-sieve-cmd.c M src/plugins/doveadm-sieve/doveadm-sieve-cmd.h Log Message: ----------- doveadm sieve plugin: Removed unused 'subscriptions' field from command context. Addresses a FIXME. Caused a warning with clang -Wstrict-bool. Commit: 0e88c05d870329c2ecddc32c2dc94d93e1f929eb https://github.com/dovecot/pigeonhole/commit/0e88c05d870329c2ecddc32c2dc94d93e1f929eb Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/mcht-is.c M src/lib-sieve/sieve-address-parts.c M src/lib-sieve/sieve-address.c M src/lib-sieve/sieve-binary-file.c M src/lib-sieve/sieve-binary.c M src/lib-sieve/sieve-code.c M src/lib-sieve/sieve-commands.c M src/lib-sieve/sieve-parser.c M src/lib-sieve/sieve-result.c M src/lib-sieve/sieve-storage.c M src/lib-sieve/sieve-stringlist.c M src/lib-sieve/sieve.c M src/lib-sieve/tst-exists.c Log Message: ----------- lib-sieve: Fixed various bool vs. int/pointer mixups. Found with clang -Wstrict-bool. Commit: 68806ea243d811a08532a5ccccbf848a57d81b12 https://github.com/dovecot/pigeonhole/commit/68806ea243d811a08532a5ccccbf848a57d81b12 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/storage/ldap/sieve-ldap-storage-settings.c Log Message: ----------- lib-sieve: ldap storage: Fixed bool vs. int mixup in function call. Found with clang -Wstrict-bool. Commit: ceebdaa2124e22065dbd4cbf60f4635d0798fe15 https://github.com/dovecot/pigeonhole/commit/ceebdaa2124e22065dbd4cbf60f4635d0798fe15 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/managesieve/cmd-deletescript.c M src/managesieve/cmd-getscript.c M src/managesieve/cmd-putscript.c M src/managesieve/cmd-renamescript.c M src/managesieve/cmd-setactive.c M src/managesieve/managesieve-client.c M src/managesieve/managesieve-client.h Log Message: ----------- Adjusted client_read_string_args() prototype to handle CLang warning. Clang -Wvargargs complained about passing a bool argument to va_start(). Commit: e2d6a3f7cd42ee7d619305b2f4ec90796851f914 https://github.com/dovecot/pigeonhole/commit/e2d6a3f7cd42ee7d619305b2f4ec90796851f914 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/managesieve/cmd-putscript.c Log Message: ----------- managesieve: The PUTSCRIPT command now allows uploading empty Sieve scripts. There is no reason to forbid an empty Sieve script. Commit: cd5cbb4d60749610abd5fe1fc3345465e83cc8f8 https://github.com/dovecot/pigeonhole/commit/cd5cbb4d60749610abd5fe1fc3345465e83cc8f8 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/variables/ext-variables-limits.h Log Message: ----------- lib-sieve: variables extension: Increased the maximum number of namespace elements in a variable name. Commit: 420d433fac150b87e24dd45ad8589b939dea8bee https://github.com/dovecot/pigeonhole/commit/420d433fac150b87e24dd45ad8589b939dea8bee Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/variables/ext-variables-arguments.c Log Message: ----------- lib-sieve: variables extension: Substitution of an invalid namespace canceled the substitution, rather than substituting the empty string. Commit: 600cadffd250ea95197e0774df0a06315aa982cc https://github.com/dovecot/pigeonhole/commit/600cadffd250ea95197e0774df0a06315aa982cc Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/environment/ext-environment-common.c M src/lib-sieve/plugins/environment/sieve-ext-environment.h M src/lib-sieve/plugins/vnd.dovecot/environment/ext-vnd-environment-items.c M src/plugins/imapsieve/ext-imapsieve-environment.c Log Message: ----------- lib-sieve: environment extension: Added support for wildcard environment items that are identified by a name prefix. Commit: b201a8986bd8652627be3e81665741c1762b7dee https://github.com/dovecot/pigeonhole/commit/b201a8986bd8652627be3e81665741c1762b7dee Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/plugins/environment/tst-environment.c Log Message: ----------- lib-sieve: environment extension: Improved runtime trace for a nonexistent environment item. Commit: 08ba39458ead56c3d6030098df3e7a1631a06ee4 https://github.com/dovecot/pigeonhole/commit/08ba39458ead56c3d6030098df3e7a1631a06ee4 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M INSTALL A doc/extensions/vnd.dovecot.environment.txt M doc/rfc/spec-bosch-sieve-dovecot-environment.txt M doc/rfc/xml/spec-bosch-sieve-dovecot-environment.xml M src/lib-sieve/plugins/vnd.dovecot/environment/ext-vnd-environment-items.c M tests/extensions/vnd.dovecot/environment/basic.svtest Log Message: ----------- lib-sieve: vnd.dovecot.environment extension: Added vnd.dovecot.config.* environment items. A "vnd.dovecot.config." environment item maps to the content of the matching sieve_env_ plugin setting. Commit: e7f11d3ca20b62179b6c4d0db208cb87f38d0568 https://github.com/dovecot/pigeonhole/commit/e7f11d3ca20b62179b6c4d0db208cb87f38d0568 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/plugins/lda-sieve/lda-sieve-plugin.c Log Message: ----------- LDA Sieve plugin: Always use multiscript API for script execution. Removed special code path for single script. This is a remnant from times when the multiscript feature was still experimental. Commit: d46a960654938e35776ec898f31e1f83d137a582 https://github.com/dovecot/pigeonhole/commit/d46a960654938e35776ec898f31e1f83d137a582 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/sieve-result.c M src/lib-sieve/sieve-result.h Log Message: ----------- lib-sieve: Added means to evaluate whether the result object executed a delivery action.# Commit: d1d6866894c7367f18272b136c2f316d186b2287 https://github.com/dovecot/pigeonhole/commit/d1d6866894c7367f18272b136c2f316d186b2287 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-sieve/sieve.c M src/lib-sieve/sieve.h Log Message: ----------- lib-sieve: Implemented support for running a "discard script" in the multiscript execution API. The "discard script" is run when the normal script sequence ends and the message is going to be discarded. Commit: a04dc95408f5aa2f563ac41011c84c6b3f40c7cc https://github.com/dovecot/pigeonhole/commit/a04dc95408f5aa2f563ac41011c84c6b3f40c7cc Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M INSTALL M doc/example-config/conf.d/90-sieve.conf M src/plugins/lda-sieve/lda-sieve-plugin.c Log Message: ----------- LDA Sieve plugin: Implemented support for a "discard script" that is run when the message is going to be discarded. This adds a new "sieve_discard" setting that points to the location of the "discard script". Once the normal scripts finish executing and the result is that the message will be discarded without being delivered anywhere, the "discard script" is executed. The discard script can prevent dropping the message, by executing alternative actions. If the discard script does nothing, the message is still discarded. Commit: fac92b52761d7889bd66071b2f2d6b4d25c95e69 https://github.com/dovecot/pigeonhole/commit/fac92b52761d7889bd66071b2f2d6b4d25c95e69 Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: A doc/extensions/vnd.dovecot.report.txt M src/lib-sieve/plugins/vnd.dovecot/report/cmd-report.c M src/lib-sieve/plugins/vnd.dovecot/report/ext-vnd-report-common.c M src/lib-sieve/plugins/vnd.dovecot/report/ext-vnd-report-common.h M src/lib-sieve/plugins/vnd.dovecot/report/ext-vnd-report.c M tests/extensions/vnd.dovecot/report/execute.svtest Log Message: ----------- lib-sieve: vnd.dovecot.report extension: Added support for configuring the "From:" address used in the report. Compare: https://github.com/dovecot/pigeonhole/compare/fe823824b806...fac92b52761d From noreply at github.com Fri Oct 14 22:30:14 2016 From: noreply at github.com (GitHub) Date: Fri, 14 Oct 2016 15:30:14 -0700 Subject: [dovecot/core] 76c9f1: uri-util: Fixed assertion failure for invalid char... Message-ID: <58015c76c0563_65a03feabfccd140122729@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 76c9f1451cc12ec53942be01382ec62dcb4bcd5b https://github.com/dovecot/core/commit/76c9f1451cc12ec53942be01382ec62dcb4bcd5b Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib/uri-util.c Log Message: ----------- uri-util: Fixed assertion failure for invalid character in path segment. Commit: f1df3b34a90d16d6ed811cf1b444ffd08622e37a https://github.com/dovecot/core/commit/f1df3b34a90d16d6ed811cf1b444ffd08622e37a Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib/uri-util.c M src/lib/uri-util.h Log Message: ----------- uri-util: Added public function for parsing single percent encoding instances. Commit: c73322faf2af5053870d4eac0440267eef0fd26f https://github.com/dovecot/core/commit/c73322faf2af5053870d4eac0440267eef0fd26f Author: Stephan Bosch Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib/uri-util.c Log Message: ----------- lib: uri-util: Always fully check the syntax of percent encoding while parsing URI components. Compare: https://github.com/dovecot/core/compare/ac80b9d2687c...c73322faf2af From noreply at github.com Sat Oct 15 06:30:09 2016 From: noreply at github.com (GitHub) Date: Fri, 14 Oct 2016 23:30:09 -0700 Subject: [dovecot/core] 58ba06: lib-dcrypt: Fix uninitialized memory Message-ID: <5801ccf117c65_54c43fb29ca69134111340@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 58ba06268d710a19118963d4de2665ea1100653a https://github.com/dovecot/core/commit/58ba06268d710a19118963d4de2665ea1100653a Author: Aki Tuomi Date: 2016-10-14 (Fri, 14 Oct 2016) Changed paths: M src/lib-dcrypt/dcrypt-openssl.c M src/lib-dcrypt/test-crypto.c Log Message: ----------- lib-dcrypt: Fix uninitialized memory From noreply at github.com Sat Oct 15 10:31:17 2016 From: noreply at github.com (GitHub) Date: Sat, 15 Oct 2016 03:31:17 -0700 Subject: [dovecot/pigeonhole] d18e9b: Sieve exprograms plugin: Adjusted to changes in Do... Message-ID: <5802057597a8e_370d3fdd7c1931306585f@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: d18e9b537d7bdaa88722c1132e3263dd46af95e0 https://github.com/dovecot/pigeonhole/commit/d18e9b537d7bdaa88722c1132e3263dd46af95e0 Author: Stephan Bosch Date: 2016-10-13 (Thu, 13 Oct 2016) Changed paths: M src/plugins/sieve-extprograms/sieve-extprograms-common.c Log Message: ----------- Sieve exprograms plugin: Adjusted to changes in Dovecot program-client API. Commit: bcad633418fb7c8ef8e627053090363e4971f123 https://github.com/dovecot/pigeonhole/commit/bcad633418fb7c8ef8e627053090363e4971f123 Author: Stephan Bosch Date: 2016-10-15 (Sat, 15 Oct 2016) Changed paths: M src/plugins/lda-sieve/lda-sieve-plugin.c Log Message: ----------- LDA Sieve plugin: Fixed assert failure caused by earlier sieve_discard changes. The simplest case in which all normal scripts maintain the (implicit) keep action triggered an assert failure. Fixed by restructuring the script execution loop to make it easy to understand. Now handles each case explicitly. Compare: https://github.com/dovecot/pigeonhole/compare/a195bd824fd6...bcad633418fb From noreply at github.com Sat Oct 15 10:31:42 2016 From: noreply at github.com (GitHub) Date: Sat, 15 Oct 2016 03:31:42 -0700 Subject: [dovecot/pigeonhole] 63f9b4: LDA Sieve plugin: Fixed assert failure caused by e... Message-ID: <5802058ef1bc1_33d43fab72cf5140824a5@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: 63f9b42f20cf0bd26b981be8a08f01b48e23517f https://github.com/dovecot/pigeonhole/commit/63f9b42f20cf0bd26b981be8a08f01b48e23517f Author: Stephan Bosch Date: 2016-10-15 (Sat, 15 Oct 2016) Changed paths: M src/plugins/lda-sieve/lda-sieve-plugin.c Log Message: ----------- LDA Sieve plugin: Fixed assert failure caused by earlier sieve_discard changes. The simplest case in which all normal scripts maintain the (implicit) keep action triggered an assert failure. Fixed by restructuring the script execution loop to make it easy to understand. Now handles each case explicitly. From noreply at github.com Sun Oct 16 20:00:09 2016 From: noreply at github.com (GitHub) Date: Sun, 16 Oct 2016 13:00:09 -0700 Subject: [dovecot/core] db5fdf: lib-storage: Use MAILDIR_INFO_SEP_S Message-ID: <5803dc49e8ed8_6baf3ffa64d0313c1386f2@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: db5fdf605555d43ca7abeaeb9cba0dcb178f2688 https://github.com/dovecot/core/commit/db5fdf605555d43ca7abeaeb9cba0dcb178f2688 Author: Aki Tuomi Date: 2016-10-16 (Sun, 16 Oct 2016) Changed paths: M src/lib-storage/index/maildir/maildir-sync-index.c M src/lib-storage/index/maildir/maildir-uidlist.c Log Message: ----------- lib-storage: Use MAILDIR_INFO_SEP_S Replace hardcoded : with MAILDIR_INFO_SEP_S From noreply at github.com Sun Oct 16 22:30:12 2016 From: noreply at github.com (GitHub) Date: Sun, 16 Oct 2016 15:30:12 -0700 Subject: [dovecot/core] 933d16: auth: Compiler warning fix Message-ID: <5803ff741342b_3df43f883c4f913443258@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 933d16f4bd223e2495a8699ca63860a31f5cd77b https://github.com/dovecot/core/commit/933d16f4bd223e2495a8699ca63860a31f5cd77b Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/auth/db-ldap.c Log Message: ----------- auth: Compiler warning fix From noreply at github.com Mon Oct 17 07:30:11 2016 From: noreply at github.com (GitHub) Date: Mon, 17 Oct 2016 00:30:11 -0700 Subject: [dovecot/core] 46e5bb: lib-fs: Lazily initialize timings to save memory. Message-ID: <58047e033cd07_1cba3f881da4312c73262@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 46e5bbded013e2bc415e8277a0d937b59ca59785 https://github.com/dovecot/core/commit/46e5bbded013e2bc415e8277a0d937b59ca59785 Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-fs/fs-api.c Log Message: ----------- lib-fs: Lazily initialize timings to save memory. From noreply at github.com Mon Oct 17 08:00:10 2016 From: noreply at github.com (GitHub) Date: Mon, 17 Oct 2016 01:00:10 -0700 Subject: [dovecot/core] e13d38: lib-dcrypt: change unit test ec curve to secp521r1 Message-ID: <5804850aa1abb_46393fee26b351381056a3@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e13d38a112072c65f8872e289593b3a611631b70 https://github.com/dovecot/core/commit/e13d38a112072c65f8872e289593b3a611631b70 Author: Martti Rannanj?rvi Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-dcrypt/test-crypto.c Log Message: ----------- lib-dcrypt: change unit test ec curve to secp521r1 This curve is more common, so unit tests will pass on more machines. From noreply at github.com Mon Oct 17 10:00:11 2016 From: noreply at github.com (GitHub) Date: Mon, 17 Oct 2016 03:00:11 -0700 Subject: [dovecot/core] 5b45af: sdbox: Removed duplicated code. Message-ID: <5804a12b42341_7de73fcbe7e3913812425c@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 5b45af6a8881270e567fe11fe9e8e167b2a2d96b https://github.com/dovecot/core/commit/5b45af6a8881270e567fe11fe9e8e167b2a2d96b Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-storage/index/dbox-single/sdbox-storage.c Log Message: ----------- sdbox: Removed duplicated code. Commit: 4c649f0338c2031afdd62a503c336e3f74bc9954 https://github.com/dovecot/core/commit/4c649f0338c2031afdd62a503c336e3f74bc9954 Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-fs/fs-api.c Log Message: ----------- lib-fs: Optimize changing FS_METADATA_INTERNAL_PREFIX metadata. file->metadata_changed doesn't need to change in that situation. It's used by fs-metawrap to find out if it needs to rewrite metadata during a write, but internal metadata isn't written to its header. Commit: 5b302b077a61204beb6852b89927952840458ccb https://github.com/dovecot/core/commit/5b302b077a61204beb6852b89927952840458ccb Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-fs/fs-api-private.h M src/lib-fs/fs-api.c Log Message: ----------- lib-fs: Added internal fs_metadata_find() helper function Commit: ece461287e52e22104e881313cea34bc77616a61 https://github.com/dovecot/core/commit/ece461287e52e22104e881313cea34bc77616a61 Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-fs/fs-api.h M src/lib-fs/fs-dict.c M src/lib-fs/fs-posix.c Log Message: ----------- lib-fs: Added FS_METADATA_WRITE_FNAME to allow renaming a file being written. Compare: https://github.com/dovecot/core/compare/e13d38a11207...ece461287e52 From noreply at github.com Mon Oct 17 20:08:42 2016 From: noreply at github.com (GitHub) Date: Mon, 17 Oct 2016 13:08:42 -0700 Subject: [dovecot/core] 9b5fa7: lib-mail: Fixed infinite loop in istream-attachmen... Message-ID: <58052fca39414_7d363fd827ee7138120419@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9b5fa7fdd9b9f1f61eaddda48036df200fc5e56e https://github.com/dovecot/core/commit/9b5fa7fdd9b9f1f61eaddda48036df200fc5e56e Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-mail/istream-attachment-extractor.c Log Message: ----------- lib-mail: Fixed infinite loop in istream-attachment-extractor Broken by 7f74811b7. Pretty much any larger attachment going through this istream had a good potential of going into an infinite loop. From noreply at github.com Mon Oct 17 20:30:14 2016 From: noreply at github.com (GitHub) Date: Mon, 17 Oct 2016 13:30:14 -0700 Subject: [dovecot/core] ee4b08: lib-dcrypt: fix comment of dovecot format v2 to us... Message-ID: <580534d6609f9_15fc3fb32dab712c5889@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: ee4b08625772dd0686ca5c52ac4ce574084dbe19 https://github.com/dovecot/core/commit/ee4b08625772dd0686ca5c52ac4ce574084dbe19 Author: Martti Rannanj?rvi Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-dcrypt/dcrypt.h Log Message: ----------- lib-dcrypt: fix comment of dovecot format v2 to use colon Version 2 field separator was changed to colon. Commit: ae0f3892a489a92b962677699f6c8e353ad309ce https://github.com/dovecot/core/commit/ae0f3892a489a92b962677699f6c8e353ad309ce Author: Martti Rannanj?rvi Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-dcrypt/dcrypt-openssl.c M src/lib-dcrypt/dcrypt.h M src/lib-dcrypt/test-crypto.c Log Message: ----------- lib-dcrypt: enc_key and pw must be NULL on storing unencrypted private key Add tests for password and key encryption, and get_info on them. Also give examples of valid cipher values for password and key encryption in dcrypt.h comment. Commit: 0e828752a6a500982c72fe15b5037adce1698dc9 https://github.com/dovecot/core/commit/0e828752a6a500982c72fe15b5037adce1698dc9 Author: Martti Rannanj?rvi Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-dcrypt/test-crypto.c Log Message: ----------- lib-dcrypt: str_new to t_str_new in some test-crypto tests str_new from default_pool was not properly freed. Commit: 54b9c839868b4d83bf5ce4798eed8a3363ff30c8 https://github.com/dovecot/core/commit/54b9c839868b4d83bf5ce4798eed8a3363ff30c8 Author: Aki Tuomi Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-dcrypt/dcrypt-openssl.c M src/lib-dcrypt/test-crypto.c Log Message: ----------- lib-dcrypt: Fix uninitialized memory Commit: 3f86b946121f24c58d842fcc81942e5d1b657adb https://github.com/dovecot/core/commit/3f86b946121f24c58d842fcc81942e5d1b657adb Author: Aki Tuomi Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-storage/index/maildir/maildir-sync-index.c M src/lib-storage/index/maildir/maildir-uidlist.c Log Message: ----------- lib-storage: Use MAILDIR_INFO_SEP_S Replace hardcoded : with MAILDIR_INFO_SEP_S Commit: 8b28c54beaa075c25174bb92598946a5001311d4 https://github.com/dovecot/core/commit/8b28c54beaa075c25174bb92598946a5001311d4 Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-fs/fs-api.c Log Message: ----------- lib-fs: Lazily initialize timings to save memory. Commit: 84a75fabdd3e7faf739ab5df7670c446e96eec3b https://github.com/dovecot/core/commit/84a75fabdd3e7faf739ab5df7670c446e96eec3b Author: Martti Rannanj?rvi Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-dcrypt/test-crypto.c Log Message: ----------- lib-dcrypt: change unit test ec curve to secp521r1 This curve is more common, so unit tests will pass on more machines. Commit: f6c5b41f9f739d5e6243fbabd27377dd476c1961 https://github.com/dovecot/core/commit/f6c5b41f9f739d5e6243fbabd27377dd476c1961 Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-storage/index/dbox-single/sdbox-storage.c Log Message: ----------- sdbox: Removed duplicated code. Commit: c4fc9842706ee59c7169fa4a2b770be178a8b9a3 https://github.com/dovecot/core/commit/c4fc9842706ee59c7169fa4a2b770be178a8b9a3 Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-fs/fs-api.c Log Message: ----------- lib-fs: Optimize changing FS_METADATA_INTERNAL_PREFIX metadata. file->metadata_changed doesn't need to change in that situation. It's used by fs-metawrap to find out if it needs to rewrite metadata during a write, but internal metadata isn't written to its header. Commit: e11fd3241e0df1576b47d29e5b0d9754e5c00483 https://github.com/dovecot/core/commit/e11fd3241e0df1576b47d29e5b0d9754e5c00483 Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-fs/fs-api-private.h M src/lib-fs/fs-api.c Log Message: ----------- lib-fs: Added internal fs_metadata_find() helper function Commit: a8dca04dbcd7c415f53f266bdb8dc13532024a67 https://github.com/dovecot/core/commit/a8dca04dbcd7c415f53f266bdb8dc13532024a67 Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-fs/fs-api.h M src/lib-fs/fs-dict.c M src/lib-fs/fs-posix.c Log Message: ----------- lib-fs: Added FS_METADATA_WRITE_FNAME to allow renaming a file being written. Commit: da00d765f21394fd78af24a728eb7566935e7df6 https://github.com/dovecot/core/commit/da00d765f21394fd78af24a728eb7566935e7df6 Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-mail/istream-attachment-extractor.c Log Message: ----------- lib-mail: Fixed infinite loop in istream-attachment-extractor Broken by 7f74811b7. Pretty much any larger attachment going through this istream had a good potential of going into an infinite loop. Compare: https://github.com/dovecot/core/compare/933d16f4bd22...da00d765f213 From noreply at github.com Mon Oct 17 21:00:10 2016 From: noreply at github.com (GitHub) Date: Mon, 17 Oct 2016 14:00:10 -0700 Subject: [dovecot/core] 4f051c: lib-dict: Duplicate result value in mempool Message-ID: <58053bdaaa9fc_27653fe1abc4113011316e@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 4f051c3082080b9d69ef12c3720c683cff34b0da https://github.com/dovecot/core/commit/4f051c3082080b9d69ef12c3720c683cff34b0da Author: Aki Tuomi Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- lib-dict: Duplicate result value in mempool Duplicate the result value already in callback to avoid it getting lost during async calls. Reported & tested by Pierre Jaury. Commit: 6acd1a48e1377e74d3008288e5e95e006f41265c https://github.com/dovecot/core/commit/6acd1a48e1377e74d3008288e5e95e006f41265c Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-dict/dict-private.h M src/lib-dict/dict.c M src/lib-dict/dict.h Log Message: ----------- lib-dict: Added dict_iterate_set_limit() Commit: c27757ca7ce5eddaa91f04f19d675a400d45512a https://github.com/dovecot/core/commit/c27757ca7ce5eddaa91f04f19d675a400d45512a Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-dict/dict-sql.c Log Message: ----------- dict-sql: Error handling fix & code cleanup Only the first sql_dict_iterate_next_query() error was handled correctly. Commit: 4de62480228fb0a4d55e6892d13bc1722b562ee3 https://github.com/dovecot/core/commit/4de62480228fb0a4d55e6892d13bc1722b562ee3 Author: Timo Sirainen Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-dict/dict-sql.c Log Message: ----------- dict-sql: Use LIMIT in SQL queries with dict_iterate_set_limit() Commit: 1db4d7625835a673dcb864374174bd342107a47c https://github.com/dovecot/core/commit/1db4d7625835a673dcb864374174bd342107a47c Author: Aki Tuomi Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/auth/auth-policy.c Log Message: ----------- auth-policy: Use request's pool instead of new pool This fixes existing memory leak in auth_report, which is caused by using separate memory pool instead of request's pool. Thank you for Andrea Carpani for extensive debugging. Commit: 46b0db4a0d5b4a626323b39d14f0f407825b4a61 https://github.com/dovecot/core/commit/46b0db4a0d5b4a626323b39d14f0f407825b4a61 Author: Aki Tuomi Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib/strfuncs.c M src/lib/strfuncs.h Log Message: ----------- lib: Add null_strcasecmp Commit: c19c44f87ef3fe40cae4be9a86ee9327a7370e46 https://github.com/dovecot/core/commit/c19c44f87ef3fe40cae4be9a86ee9327a7370e46 Author: Aki Tuomi Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/config/config-filter.c Log Message: ----------- config: Compare local_name case insensitive DNS and certificate names should be compared case insensitive. Compare: https://github.com/dovecot/core/compare/9b5fa7fdd9b9...c19c44f87ef3 From noreply at github.com Mon Oct 17 22:30:11 2016 From: noreply at github.com (GitHub) Date: Mon, 17 Oct 2016 15:30:11 -0700 Subject: [dovecot/core] 85c1b6: lib-imap: Don't write a broken Content-Type as tex... Message-ID: <580550f3ea8bd_72f93f959fe6313c282c9@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 85c1b6c22e6e7383b67947f6f633fc9f7bed9d19 https://github.com/dovecot/core/commit/85c1b6c22e6e7383b67947f6f633fc9f7bed9d19 Author: Timo Sirainen Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/lib-imap/imap-bodystructure.c Log Message: ----------- lib-imap: Don't write a broken Content-Type as text/plain to BODYSTRUCTURE Mainly because it doesn't match with MESSAGE_PART_FLAG_TEXT in message_part. Commit: 7f7f771254839e77ffaabbc7fa745a061cd55a9c https://github.com/dovecot/core/commit/7f7f771254839e77ffaabbc7fa745a061cd55a9c Author: Timo Sirainen Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/lib-imap/imap-bodystructure.c Log Message: ----------- lib-imap: imap_bodystructure_parse() ignores text/plain flag mismatch for now. Maybe we can enable it some day far into the future, but for now this just causes unnecessary cache file rebuilds. Commit: 13961419ca9710eb80c254e00510c58c466f3c08 https://github.com/dovecot/core/commit/13961419ca9710eb80c254e00510c58c466f3c08 Author: Timo Sirainen Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/lib-mail/istream-attachment-extractor.c M src/lib-mail/message-decoder.c M src/lib-mail/message-parser.c M src/lib-mail/message-search.c M src/plugins/fts/fts-build-mail.c Log Message: ----------- global: Handle broken Content-Type headers consistently. 1) Only the first Content-Type header is used. (Simpler than using the last.) 2) Invalid Content-Types are parsed as far as we can. This is mainly to make sure they aren't treated as missing Content-Types, which could cause them to become text/plain. Commit: 5e55914597b8f92b83543d133a8c07d808b3f3dd https://github.com/dovecot/core/commit/5e55914597b8f92b83543d133a8c07d808b3f3dd Author: Steffen Templin Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- push-notification: Add unseen count to OX driver. Commit: 282323a5269a0121d9407f098680bf8e7e02f47c https://github.com/dovecot/core/commit/282323a5269a0121d9407f098680bf8e7e02f47c Author: Steffen Templin Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- push-notification: Re-open mailbox and sync it to get unseen count. Commit: 3722c793bbea1495000de35815d31091a75f3f9c https://github.com/dovecot/core/commit/3722c793bbea1495000de35815d31091a75f3f9c Author: Steffen Templin Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- push-notification: Resolve indentation problem Compare: https://github.com/dovecot/core/compare/c19c44f87ef3...3722c793bbea From noreply at github.com Tue Oct 18 07:00:10 2016 From: noreply at github.com (GitHub) Date: Tue, 18 Oct 2016 00:00:10 -0700 Subject: [dovecot/core] 7900eb: lib-storage: treat empty root_dir as an empty stri... Message-ID: <5805c87ae12a1_1e6a3fbca0f5f130303f9@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7900eb30bac4a46b259522c58362884661483d7c https://github.com/dovecot/core/commit/7900eb30bac4a46b259522c58362884661483d7c Author: Josef 'Jeff' Sipek Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: treat empty root_dir as an empty string Commit: 1f4d459111419a47021e677839439f2e2ca78ad5 https://github.com/dovecot/core/commit/1f4d459111419a47021e677839439f2e2ca78ad5 Author: Josef 'Jeff' Sipek Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/lib-storage/index/imapc/imapc-settings.h M src/lib-storage/index/imapc/imapc-storage.c Log Message: ----------- imapc: use serialized settings as unique_root_dir Without this, it is not possible to instantiate multiple imapc storages. Any attempts to will result in multiple namespaces sharing the same storage, regardless of if that was the intention. Commit: 1c62887aa7a5f0c6b9c5b956176a6e3182777fa0 https://github.com/dovecot/core/commit/1c62887aa7a5f0c6b9c5b956176a6e3182777fa0 Author: Josef 'Jeff' Sipek Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/lib-storage/index/imapc/imapc-list.c Log Message: ----------- imapc: don't mix positional and designated initialization Compare: https://github.com/dovecot/core/compare/3722c793bbea...1c62887aa7a5 From noreply at github.com Tue Oct 18 08:00:10 2016 From: noreply at github.com (GitHub) Date: Tue, 18 Oct 2016 01:00:10 -0700 Subject: [dovecot/core] 8add90: lib-fs: Fixed fs_metadata_find() to actually work Message-ID: <5805d68a1fd0e_65ad3f867ad1113c9078d@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8add900109e3782e6441d820d8808b72b20600fb https://github.com/dovecot/core/commit/8add900109e3782e6441d820d8808b72b20600fb Author: Timo Sirainen Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/lib-fs/fs-api.c Log Message: ----------- lib-fs: Fixed fs_metadata_find() to actually work From noreply at github.com Tue Oct 18 10:30:13 2016 From: noreply at github.com (GitHub) Date: Tue, 18 Oct 2016 03:30:13 -0700 Subject: [dovecot/core] 335e24: lib-fs: Fixed fs_metadata_find() to actually work Message-ID: <5805f9b57fbee_5e123ff496a3913c5981d@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 335e2460ee938286ffd0459a644a138683148212 https://github.com/dovecot/core/commit/335e2460ee938286ffd0459a644a138683148212 Author: Timo Sirainen Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/lib-fs/fs-api.c Log Message: ----------- lib-fs: Fixed fs_metadata_find() to actually work From noreply at github.com Wed Oct 19 11:00:09 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 04:00:09 -0700 Subject: [dovecot/core] e0aab2: doveadm: trim doveadm dump dcrypt-key input Message-ID: <58075239447fc_2a6f3ff50941d12c141693@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e0aab219abe1db069906f227541cd179a94dd8d9 https://github.com/dovecot/core/commit/e0aab219abe1db069906f227541cd179a94dd8d9 Author: Martti Rannanj?rvi Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/doveadm/doveadm-dump-dcrypt-key.c Log Message: ----------- doveadm: trim doveadm dump dcrypt-key input dcrypt does not like extra newlines at the end of a key. Commit: b594d84b9f44f875e75099ee0abe843bd826842f https://github.com/dovecot/core/commit/b594d84b9f44f875e75099ee0abe843bd826842f Author: Martti Rannanj?rvi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-dcrypt/test-crypto.c Log Message: ----------- lib-dcrypt: add a test for password change Test that you can encrypt a key with password, encrypt a key with the password protected key, change the password, and still load a key that you encrypted with the key encrypted using the first password. Commit: 08d8de8e25e2a130563911fea8378ab24bf8fc9d https://github.com/dovecot/core/commit/08d8de8e25e2a130563911fea8378ab24bf8fc9d Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-storage/mailbox-uidvalidity.c Log Message: ----------- lib-storage: Make sure mailbox_uidvalidity_next() doesn't return 0. 0 isn't a valid IMAP UIDVALIDITY, and Dovecot treats 0 as "not assigned". Compare: https://github.com/dovecot/core/compare/8add900109e3...08d8de8e25e2 From noreply at github.com Wed Oct 19 12:00:11 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 05:00:11 -0700 Subject: [dovecot/core] 7725d6: lib: Add reference counting to child_wait_pid Message-ID: <5807604b74b79_4b1b3fec7fd7912c597f3@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7725d60aeaa59589dc56331a000763cb799e3c9b https://github.com/dovecot/core/commit/7725d60aeaa59589dc56331a000763cb799e3c9b Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib/child-wait.c Log Message: ----------- lib: Add reference counting to child_wait_pid Commit: 1acc8d6538864577b8f40cc4e1ca922a62f52327 https://github.com/dovecot/core/commit/1acc8d6538864577b8f40cc4e1ca922a62f52327 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client.h M src/lib-program-client/test-program-client-local.c M src/lib-program-client/test-program-client-unix.c Log Message: ----------- lib-program-client: Use restrict-access This makes the program-client execution behave more consistent to the rest of the core code. Commit: 097dbdf543bc5d1689c5570f5faaec1e864e3a87 https://github.com/dovecot/core/commit/097dbdf543bc5d1689c5570f5faaec1e864e3a87 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Disconnect asynchronously Commit: 4fbe0d10901a80b27aacc9d9e6848e30e5fe727d https://github.com/dovecot/core/commit/4fbe0d10901a80b27aacc9d9e6848e30e5fe727d Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Use child-wait This makes the client waiting asynchronous. Commit: 17541ea25593c656060199715051db2c1eef221d https://github.com/dovecot/core/commit/17541ea25593c656060199715051db2c1eef221d Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client.c M src/lib-program-client/program-client.h M src/lib-program-client/test-program-client-local.c M src/lib-program-client/test-program-client-unix.c Log Message: ----------- lib-program-client: Use milliseconds in idle timeout Commit: 204afc1f4f37a4f1cb53ff44b993a661cc45bf5d https://github.com/dovecot/core/commit/204afc1f4f37a4f1cb53ff44b993a661cc45bf5d Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Add switch_ioloop vfunc This lets program-client backends do their own special io loop switching. Commit: 366f669495b4b507084e43a56c0a9d201f120b7d https://github.com/dovecot/core/commit/366f669495b4b507084e43a56c0a9d201f120b7d Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.h Log Message: ----------- lib-program-client: Add TCP client support Commit: 3f67fea2e5a12390d280315c37c80302a9dab683 https://github.com/dovecot/core/commit/3f67fea2e5a12390d280315c37c80302a9dab683 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/Makefile.am A src/lib-program-client/test-program-client-net.c Log Message: ----------- lib-program-client: Add tests for TCP client Commit: 80521bcdd28b22818480a6e6e1ae84230e19c1ba https://github.com/dovecot/core/commit/80521bcdd28b22818480a6e6e1ae84230e19c1ba Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client.c M src/lib-program-client/program-client.h Log Message: ----------- lib-program-client: Add URI based constructor Commit: 1c0dd964c40f9457af090128a4a5e96f23197020 https://github.com/dovecot/core/commit/1c0dd964c40f9457af090128a4a5e96f23197020 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-remote.c Log Message: ----------- lib-program-client: Move version string to define Commit: 541446ac8ee3730ffd028c4071340dcc0cb63abb https://github.com/dovecot/core/commit/541446ac8ee3730ffd028c4071340dcc0cb63abb Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-unix.c Log Message: ----------- lib-program-client: Make sure we delay output in test This is to ensure that the client does not prematurely disconnect before output is sent. Commit: a371ea8bd48d45548cd7aa16d4f5aeb38ba48c91 https://github.com/dovecot/core/commit/a371ea8bd48d45548cd7aa16d4f5aeb38ba48c91 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/Makefile.am M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.c M src/lib-program-client/program-client.h M src/lib-program-client/test-program-client-net.c Log Message: ----------- lib-program-client: Add support for iostream-dot This is also made mandatory for TCP client. Commit: 867b2e27d87b6b7dbe28e5ec08b3f1514bb92e7d https://github.com/dovecot/core/commit/867b2e27d87b6b7dbe28e5ec08b3f1514bb92e7d Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/Makefile.am Log Message: ----------- lib-program-client: Disable valgrind For local test, we can't use valgrind, it's too unreliable (breaks execution sometimes). Commit: 1be27c35ea17fccd83c54e2acc66eb8c44d1a8fe https://github.com/dovecot/core/commit/1be27c35ea17fccd83c54e2acc66eb8c44d1a8fe Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.c M src/lib-program-client/program-client.h Log Message: ----------- lib-program-client: Whitespace fixes Compare: https://github.com/dovecot/core/compare/08d8de8e25e2...1be27c35ea17 From noreply at github.com Wed Oct 19 13:00:13 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 06:00:13 -0700 Subject: [dovecot/core] d97dad: lib-dict: Duplicate result value in mempool Message-ID: <58076e5df056f_76713ffd759fd14013585@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: d97dad4bbcacd6a38b271bde57a2f60ba0a5d7fd https://github.com/dovecot/core/commit/d97dad4bbcacd6a38b271bde57a2f60ba0a5d7fd Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- lib-dict: Duplicate result value in mempool Duplicate the result value already in callback to avoid it getting lost during async calls. Reported & tested by Pierre Jaury. Commit: 1b69afd91e9b38b935190c5683e9f83a189c68aa https://github.com/dovecot/core/commit/1b69afd91e9b38b935190c5683e9f83a189c68aa Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-dict/dict-private.h M src/lib-dict/dict.c M src/lib-dict/dict.h Log Message: ----------- lib-dict: Added dict_iterate_set_limit() Commit: df6bf0202815c053fd1d9ed16e792445dcd182bb https://github.com/dovecot/core/commit/df6bf0202815c053fd1d9ed16e792445dcd182bb Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-dict/dict-sql.c Log Message: ----------- dict-sql: Use LIMIT in SQL queries with dict_iterate_set_limit() Commit: d88f6e11c97d2b74de3e5343e82b4630f16157a2 https://github.com/dovecot/core/commit/d88f6e11c97d2b74de3e5343e82b4630f16157a2 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/auth/auth-policy.c Log Message: ----------- auth-policy: Use request's pool instead of new pool This fixes existing memory leak in auth_report, which is caused by using separate memory pool instead of request's pool. Thank you for Andrea Carpani for extensive debugging. Commit: 8e104e2bce03c1cb410b1aff5100a0e1074c11ca https://github.com/dovecot/core/commit/8e104e2bce03c1cb410b1aff5100a0e1074c11ca Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib/strfuncs.c M src/lib/strfuncs.h Log Message: ----------- lib: Add null_strcasecmp Commit: 72d1b1675b702c65b79875d5aad4a306c7370c96 https://github.com/dovecot/core/commit/72d1b1675b702c65b79875d5aad4a306c7370c96 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/config/config-filter.c Log Message: ----------- config: Compare local_name case insensitive DNS and certificate names should be compared case insensitive. Commit: ad485aeb133ab81cde6fa153c38f64f79320cf5d https://github.com/dovecot/core/commit/ad485aeb133ab81cde6fa153c38f64f79320cf5d Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-imap/imap-bodystructure.c Log Message: ----------- lib-imap: Don't write a broken Content-Type as text/plain to BODYSTRUCTURE Mainly because it doesn't match with MESSAGE_PART_FLAG_TEXT in message_part. Commit: c0c6115e007ab0efdd56ee8fa2b83d8cc007e159 https://github.com/dovecot/core/commit/c0c6115e007ab0efdd56ee8fa2b83d8cc007e159 Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-imap/imap-bodystructure.c Log Message: ----------- lib-imap: imap_bodystructure_parse() ignores text/plain flag mismatch for now. Maybe we can enable it some day far into the future, but for now this just causes unnecessary cache file rebuilds. Commit: 6a44e1eeedcad65f226489eaec8dd997b8e174e4 https://github.com/dovecot/core/commit/6a44e1eeedcad65f226489eaec8dd997b8e174e4 Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-mail/istream-attachment-extractor.c M src/lib-mail/message-decoder.c M src/lib-mail/message-parser.c M src/lib-mail/message-search.c M src/plugins/fts/fts-build-mail.c Log Message: ----------- global: Handle broken Content-Type headers consistently. 1) Only the first Content-Type header is used. (Simpler than using the last.) 2) Invalid Content-Types are parsed as far as we can. This is mainly to make sure they aren't treated as missing Content-Types, which could cause them to become text/plain. Commit: 3a23ef7adc3f8d4831b38e7334814e6456332441 https://github.com/dovecot/core/commit/3a23ef7adc3f8d4831b38e7334814e6456332441 Author: Steffen Templin Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- push-notification: Add unseen count to OX driver. Commit: 35aba69ff0beca2c28a2b4197e2a447c60f2d3fd https://github.com/dovecot/core/commit/35aba69ff0beca2c28a2b4197e2a447c60f2d3fd Author: Steffen Templin Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- push-notification: Re-open mailbox and sync it to get unseen count. Commit: 78cd02d1c0d7af2f7983993ce4f4dba7f0a708aa https://github.com/dovecot/core/commit/78cd02d1c0d7af2f7983993ce4f4dba7f0a708aa Author: Steffen Templin Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- push-notification: Resolve indentation problem Commit: 19fe8753f654d7e6e308142253d78d7c2c59b35a https://github.com/dovecot/core/commit/19fe8753f654d7e6e308142253d78d7c2c59b35a Author: Martti Rannanj?rvi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/doveadm/doveadm-dump-dcrypt-key.c Log Message: ----------- doveadm: trim doveadm dump dcrypt-key input dcrypt does not like extra newlines at the end of a key. Commit: 81465037782a81cee81845c5cb39beb050251ba3 https://github.com/dovecot/core/commit/81465037782a81cee81845c5cb39beb050251ba3 Author: Martti Rannanj?rvi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-dcrypt/test-crypto.c Log Message: ----------- lib-dcrypt: add a test for password change Test that you can encrypt a key with password, encrypt a key with the password protected key, change the password, and still load a key that you encrypted with the key encrypted using the first password. Commit: d8c5d6f4e3e7a623fa4f93d61dbda720d926c3c3 https://github.com/dovecot/core/commit/d8c5d6f4e3e7a623fa4f93d61dbda720d926c3c3 Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-storage/mailbox-uidvalidity.c Log Message: ----------- lib-storage: Make sure mailbox_uidvalidity_next() doesn't return 0. 0 isn't a valid IMAP UIDVALIDITY, and Dovecot treats 0 as "not assigned". Commit: 338bc725b24c78bf973c219e45a8a47e3a492139 https://github.com/dovecot/core/commit/338bc725b24c78bf973c219e45a8a47e3a492139 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib/child-wait.c Log Message: ----------- lib: Add reference counting to child_wait_pid Compare: https://github.com/dovecot/core/compare/335e2460ee93...338bc725b24c From noreply at github.com Wed Oct 19 14:00:09 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 07:00:09 -0700 Subject: [dovecot/core] bdaa7e: lib-program-client: Fix local tests Message-ID: <58077c69af253_3e433fb6073af140730f@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: bdaa7eb956fb87c21d37cfb8bf9b4ab47e3216f9 https://github.com/dovecot/core/commit/bdaa7eb956fb87c21d37cfb8bf9b4ab47e3216f9 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/Makefile.am M src/lib-program-client/test-program-client-local.c Log Message: ----------- lib-program-client: Fix local tests Commit: 9b7b07d70c25c51be54d3b070216872ddaab6e6e https://github.com/dovecot/core/commit/9b7b07d70c25c51be54d3b070216872ddaab6e6e Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Fix memory access problem Compare: https://github.com/dovecot/core/compare/1be27c35ea17...9b7b07d70c25 From noreply at github.com Wed Oct 19 14:00:15 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 07:00:15 -0700 Subject: [dovecot/core] d568ba: lib-program-client: Use restrict-access Message-ID: <58077c6f30e0c_3a983fde8cd9f134461c5@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: d568bab9df2dbf5b6c7eafc90d9b9affbaeb8e46 https://github.com/dovecot/core/commit/d568bab9df2dbf5b6c7eafc90d9b9affbaeb8e46 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client.h M src/lib-program-client/test-program-client-local.c M src/lib-program-client/test-program-client-remote.c Log Message: ----------- lib-program-client: Use restrict-access This makes the program-client execution behave more consistent to the rest of the core code. Commit: 444f4d846f6212cc9e699d13896b5e0e6fd1eb85 https://github.com/dovecot/core/commit/444f4d846f6212cc9e699d13896b5e0e6fd1eb85 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Disconnect asynchronously Commit: 6d1ea5284c9195a198657017664922d93f124ce7 https://github.com/dovecot/core/commit/6d1ea5284c9195a198657017664922d93f124ce7 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Use child-wait This makes the client waiting asynchronous. Commit: c1b5185df30f5aeca80b29d1fd30f9c57380e5a5 https://github.com/dovecot/core/commit/c1b5185df30f5aeca80b29d1fd30f9c57380e5a5 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client.c M src/lib-program-client/program-client.h M src/lib-program-client/test-program-client-local.c M src/lib-program-client/test-program-client-remote.c Log Message: ----------- lib-program-client: Use milliseconds in idle timeout Commit: 11d5906da1a5055346d1e07acaaef2690538cfdc https://github.com/dovecot/core/commit/11d5906da1a5055346d1e07acaaef2690538cfdc Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Add switch_ioloop vfunc This lets program-client backends do their own special io loop switching. Commit: e39f1f404fa8168bbefd91cb0851798daace9225 https://github.com/dovecot/core/commit/e39f1f404fa8168bbefd91cb0851798daace9225 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-remote.c Log Message: ----------- lib-program-client: Move version string to define Commit: 7842be89d1b5016bd812251cb9384280ec8b23c1 https://github.com/dovecot/core/commit/7842be89d1b5016bd812251cb9384280ec8b23c1 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/Makefile.am Log Message: ----------- lib-program-client: Disable valgrind For local test, we can't use valgrind, it's too unreliable (breaks execution sometimes). Commit: d7b1c76ea26e9d6487efd248d410e242fd38c183 https://github.com/dovecot/core/commit/d7b1c76ea26e9d6487efd248d410e242fd38c183 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/Makefile.am M src/lib-program-client/test-program-client-local.c Log Message: ----------- lib-program-client: Fix local tests Commit: 4cf10a8b0efb2261534e64045dba1ab0e2980819 https://github.com/dovecot/core/commit/4cf10a8b0efb2261534e64045dba1ab0e2980819 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-remote.c Log Message: ----------- lib-program-client: Backport test-program-client-unix Commit: ddc39602084a4c454d2fb989cfc916fe90e18b7e https://github.com/dovecot/core/commit/ddc39602084a4c454d2fb989cfc916fe90e18b7e Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Fix memory access problem Compare: https://github.com/dovecot/core/compare/338bc725b24c...ddc39602084a From noreply at github.com Wed Oct 19 14:35:12 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 07:35:12 -0700 Subject: [dovecot/pigeonhole] 85680b: lib-sieve: result object: Fixed bug in detection o... Message-ID: <580784a02b928_7cfc3f89b5f9913c12524f@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 85680b40d0c7247fb3183c1f39c246f7299cdfd4 https://github.com/dovecot/pigeonhole/commit/85680b40d0c7247fb3183c1f39c246f7299cdfd4 Author: Stephan Bosch Date: 2016-10-17 (Mon, 17 Oct 2016) Changed paths: M src/lib-sieve/sieve-result.c Log Message: ----------- lib-sieve: result object: Fixed bug in detection of the execution of delivery action. Sequential exections would override a previously flagged delivery, which is wrong. This caused the sieve_discard feature to trigger for messages that were actually delivered somewhere by an earlier script in the sequence. Commit: 905db12098c2c5c3cfd9dd7e22fef471f801d726 https://github.com/dovecot/pigeonhole/commit/905db12098c2c5c3cfd9dd7e22fef471f801d726 Author: Stephan Bosch Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/plugins/sieve-extprograms/sieve-extprograms-common.c Log Message: ----------- Sieve extprograms plugin: Adjusted to more changes in Dovecot program-client API. Compare: https://github.com/dovecot/pigeonhole/compare/bcad633418fb...905db12098c2 From noreply at github.com Wed Oct 19 15:03:59 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 08:03:59 -0700 Subject: [dovecot/pigeonhole] 069063: lib-sieve: result object: Fixed bug in detection o... Message-ID: <58078b5f5cb8d_23753ffcb270d1381308aa@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: 0690631e96b4ff7a3b9251d19a405368fbcd21fb https://github.com/dovecot/pigeonhole/commit/0690631e96b4ff7a3b9251d19a405368fbcd21fb Author: Stephan Bosch Date: 2016-10-18 (Tue, 18 Oct 2016) Changed paths: M src/lib-sieve/sieve-result.c Log Message: ----------- lib-sieve: result object: Fixed bug in detection of the execution of delivery action. Sequential exections would override a previously flagged delivery, which is wrong. This caused the sieve_discard feature to trigger for messages that were actually delivered somewhere by an earlier script in the sequence. Commit: e0ed585e9d97f414c3e631a849ba2d36cbe16220 https://github.com/dovecot/pigeonhole/commit/e0ed585e9d97f414c3e631a849ba2d36cbe16220 Author: Stephan Bosch Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/plugins/sieve-extprograms/sieve-extprograms-common.c Log Message: ----------- Sieve exprograms plugin: Adjusted to changes in Dovecot program-client API. Commit: 4736cb30daa4b12303dc1999580e5674946af5f7 https://github.com/dovecot/pigeonhole/commit/4736cb30daa4b12303dc1999580e5674946af5f7 Author: Stephan Bosch Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/plugins/sieve-extprograms/sieve-extprograms-common.c Log Message: ----------- Sieve extprograms plugin: Adjusted to more changes in Dovecot program-client API. Compare: https://github.com/dovecot/pigeonhole/compare/63f9b42f20cf...4736cb30daa4 From noreply at github.com Wed Oct 19 15:30:14 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 08:30:14 -0700 Subject: [dovecot/core] ace297: dovecot-ldap.conf.ext: Updated sasl_bind comment. Message-ID: <58079186843f7_7b7f3fb8d94451346106e@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: ace297d8b586c5a80ed21e34556d5c1a9792cb55 https://github.com/dovecot/core/commit/ace297d8b586c5a80ed21e34556d5c1a9792cb55 Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M doc/example-config/dovecot-ldap.conf.ext Log Message: ----------- dovecot-ldap.conf.ext: Updated sasl_bind comment. From noreply at github.com Wed Oct 19 15:30:10 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 08:30:10 -0700 Subject: [dovecot/core] bad0f9: dovecot-ldap.conf.ext: Updated sasl_bind comment. Message-ID: <580791821eeb2_2cb43fb435aeb130787f9@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: bad0f9dae6147848577d2f8911878d7fe3cef44c https://github.com/dovecot/core/commit/bad0f9dae6147848577d2f8911878d7fe3cef44c Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M doc/example-config/dovecot-ldap.conf.ext Log Message: ----------- dovecot-ldap.conf.ext: Updated sasl_bind comment. From noreply at github.com Wed Oct 19 17:00:08 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 10:00:08 -0700 Subject: [dovecot/core] f94833: push-notification: Error handling fix and cleanups... Message-ID: <5807a698cf91c_78a33fc8b2f75138324ba@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f948338e87fe0af30e2370b6d663654765b3c5bb https://github.com/dovecot/core/commit/f948338e87fe0af30e2370b6d663654765b3c5bb Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- push-notification: Error handling fix and cleanups. From noreply at github.com Wed Oct 19 17:00:13 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 10:00:13 -0700 Subject: [dovecot/core] 67e755: push-notification: Error handling fix and cleanups... Message-ID: <5807a69dc1c05_53b73f7f1dd7913884055@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 67e75543f2f77d328cd5d8cd0d6a0d7723cddbd8 https://github.com/dovecot/core/commit/67e75543f2f77d328cd5d8cd0d6a0d7723cddbd8 Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- push-notification: Error handling fix and cleanups. From noreply at github.com Wed Oct 19 17:03:26 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 10:03:26 -0700 Subject: [dovecot/pigeonhole] ff56aa: Updated dovecot.m4. Message-ID: <5807a75e4f773_13e13f881a28f140146628@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: ff56aa3353c5f2c0cd5d675889998bc8976d320a https://github.com/dovecot/pigeonhole/commit/ff56aa3353c5f2c0cd5d675889998bc8976d320a Author: Stephan Bosch Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M m4/dovecot.m4 Log Message: ----------- Updated dovecot.m4. From noreply at github.com Wed Oct 19 17:02:59 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 10:02:59 -0700 Subject: [dovecot/pigeonhole] 4d5a94: Updated dovecot.m4. Message-ID: <5807a743bf6a9_38193f9d3b7ab134536a6@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 4d5a944869b97e320501c009b8937839d126276e https://github.com/dovecot/pigeonhole/commit/4d5a944869b97e320501c009b8937839d126276e Author: Stephan Bosch Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M m4/dovecot.m4 Log Message: ----------- Updated dovecot.m4. From noreply at github.com Wed Oct 19 17:30:09 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 10:30:09 -0700 Subject: [dovecot/core] ac2def: lib-storage: clean up mailbox_list_create to impro... Message-ID: <5807ada18d917_5bca3f98b92af1348626e@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: ac2defed599a97c4a71a9e90ba185929dfe59226 https://github.com/dovecot/core/commit/ac2defed599a97c4a71a9e90ba185929dfe59226 Author: Josef 'Jeff' Sipek Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-storage/mailbox-list.c Log Message: ----------- lib-storage: clean up mailbox_list_create to improve readability There is no reason to use mailbox_list_driver_find() here instead of mailbox_list_find_class() as (1) we do not need the index into the list driver array, and (2) dealing with double-pointers is harder than regular pointers. Commit: ea42ee9ebd6f96e771c16e3fee705fa2e6fe609d https://github.com/dovecot/core/commit/ea42ee9ebd6f96e771c16e3fee705fa2e6fe609d Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib/restrict-access.c M src/lib/restrict-access.h Log Message: ----------- lib: Add drop_setuid_root for restrict_access drop_setuid_root, when set to true, will detect and try to drop getuid()==0. This is done by recovering current effective UID to set->uid if set->uid == -1, and then doing seteuid(0). It will also drop out any other extra privileges, such as extra groups not requested for. Commit: 2558976f0b03852ba673d75d0af6850a61e733ce https://github.com/dovecot/core/commit/2558976f0b03852ba673d75d0af6850a61e733ce Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c Log Message: ----------- lib-program-client: Try drop setuid root by default But not if root privileges are asked for. Compare: https://github.com/dovecot/core/compare/f948338e87fe...2558976f0b03 From noreply at github.com Wed Oct 19 17:30:13 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 10:30:13 -0700 Subject: [dovecot/core] 28f8fb: .gitignore: Updated to include auto-added m4/* Message-ID: <5807ada519999_2e2e3fea6488113c356d4@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 28f8fb717e0f958603088e406f4e9de2b4692c5b https://github.com/dovecot/core/commit/28f8fb717e0f958603088e406f4e9de2b4692c5b Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M .gitignore Log Message: ----------- .gitignore: Updated to include auto-added m4/* Commit: de4ac43c338ff86e68d20ebc60970427fa044c13 https://github.com/dovecot/core/commit/de4ac43c338ff86e68d20ebc60970427fa044c13 Author: Josef 'Jeff' Sipek Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-storage/mailbox-list.c Log Message: ----------- lib-storage: clean up mailbox_list_create to improve readability There is no reason to use mailbox_list_driver_find() here instead of mailbox_list_find_class() as (1) we do not need the index into the list driver array, and (2) dealing with double-pointers is harder than regular pointers. Commit: eda95c8ee0dd6f6679c9f090b71986b750acf454 https://github.com/dovecot/core/commit/eda95c8ee0dd6f6679c9f090b71986b750acf454 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib/restrict-access.c M src/lib/restrict-access.h Log Message: ----------- lib: Add drop_setuid_root for restrict_access drop_setuid_root, when set to true, will detect and try to drop getuid()==0. This is done by recovering current effective UID to set->uid if set->uid == -1, and then doing seteuid(0). It will also drop out any other extra privileges, such as extra groups not requested for. Commit: 13cb1cfd7e529b2dadb112e8aac7eb01c56cf4a4 https://github.com/dovecot/core/commit/13cb1cfd7e529b2dadb112e8aac7eb01c56cf4a4 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c Log Message: ----------- lib-program-client: Try drop setuid root by default But not if root privileges are asked for. Compare: https://github.com/dovecot/core/compare/67e75543f2f7...13cb1cfd7e52 From noreply at github.com Wed Oct 19 18:30:09 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 11:30:09 -0700 Subject: [dovecot/core] 42efa9: lib: Copy target_uid from restrict_access_settings Message-ID: <5807bbb156c95_11453fd28c27113859e7@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 42efa99e84af3eec6a7d23a8796034da114e0a24 https://github.com/dovecot/core/commit/42efa99e84af3eec6a7d23a8796034da114e0a24 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib/restrict-access.c Log Message: ----------- lib: Copy target_uid from restrict_access_settings One cannot assign to set->uid, causing compile error. From noreply at github.com Wed Oct 19 19:00:10 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 12:00:10 -0700 Subject: [dovecot/core] 76516c: lib-program-client: Correctly handle error code Message-ID: <5807c2baba216_2d573f967215913463687@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 76516caaa8bdaed1f3c21cc02f2156915cb89d40 https://github.com/dovecot/core/commit/76516caaa8bdaed1f3c21cc02f2156915cb89d40 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-remote.c Log Message: ----------- lib-program-client: Correctly handle error code Commit: e6ba63471b1451b48e1185492c33d7bf58be884d https://github.com/dovecot/core/commit/e6ba63471b1451b48e1185492c33d7bf58be884d Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Deduplicate flush statement It can be done below by splitting the else if into separate if statement. Compare: https://github.com/dovecot/core/compare/42efa99e84af...e6ba63471b14 From noreply at github.com Wed Oct 19 19:00:15 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 12:00:15 -0700 Subject: [dovecot/core] 33e297: lib: Copy target_uid from restrict_access_settings Message-ID: <5807c2bfd3be1_f6b3fb10510914057689@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 33e297cf3aa37d808af73abfb004048d477ae78e https://github.com/dovecot/core/commit/33e297cf3aa37d808af73abfb004048d477ae78e Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib/restrict-access.c Log Message: ----------- lib: Copy target_uid from restrict_access_settings One cannot assign to set->uid, causing compile error. Commit: fdcd289cc3bcddb71a69130f7c645643872d04c3 https://github.com/dovecot/core/commit/fdcd289cc3bcddb71a69130f7c645643872d04c3 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-remote.c Log Message: ----------- lib-program-client: Correctly handle error code Compare: https://github.com/dovecot/core/compare/13cb1cfd7e52...fdcd289cc3bc From noreply at github.com Wed Oct 19 21:30:09 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 14:30:09 -0700 Subject: [dovecot/core] 3781fc: Fixed copyright notice. Message-ID: <5807e5e199bb1_78553fbf61e57134145493@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 3781fc206f179f288da3974d85f7ab0f10fe453a https://github.com/dovecot/core/commit/3781fc206f179f288da3974d85f7ab0f10fe453a Author: Stephan Bosch Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib/test-uri.c Log Message: ----------- Fixed copyright notice. From noreply at github.com Thu Oct 20 00:43:02 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 17:43:02 -0700 Subject: [dovecot/pigeonhole] ca0cd6: lib-sieve: vnd.dovecot.report extension: Added Dov... Message-ID: <580813169420d_25c53fd3918cb14038399@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: ca0cd69e8504125f1e82281a61f646b7176e42ca https://github.com/dovecot/pigeonhole/commit/ca0cd69e8504125f1e82281a61f646b7176e42ca Author: Stephan Bosch Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib-sieve/plugins/vnd.dovecot/report/cmd-report.c M tests/extensions/vnd.dovecot/report/execute.svtest Log Message: ----------- lib-sieve: vnd.dovecot.report extension: Added Dovecot-Reporting-User field, which contains the e-mail address of the user sending the report. From noreply at github.com Thu Oct 20 00:43:32 2016 From: noreply at github.com (GitHub) Date: Wed, 19 Oct 2016 17:43:32 -0700 Subject: [dovecot/pigeonhole] 9824bd: lib-sieve: vnd.dovecot.report extension: Added Dov... Message-ID: <580813346676e_5c13fd46ee8f134107851@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: 9824bde159883000d1e7a7a96d91c318b8409db1 https://github.com/dovecot/pigeonhole/commit/9824bde159883000d1e7a7a96d91c318b8409db1 Author: Stephan Bosch Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib-sieve/plugins/vnd.dovecot/report/cmd-report.c M tests/extensions/vnd.dovecot/report/execute.svtest Log Message: ----------- lib-sieve: vnd.dovecot.report extension: Added Dovecot-Reporting-User field, which contains the e-mail address of the user sending the report. From noreply at github.com Thu Oct 20 08:00:11 2016 From: noreply at github.com (GitHub) Date: Thu, 20 Oct 2016 01:00:11 -0700 Subject: [dovecot/core] b60f51: lib-program-client: Linking fix. Message-ID: <5808798bb4666_2b6c3f9cc1fcd134566c4@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b60f51bfcc7d96659efa332a40726cf760693aca https://github.com/dovecot/core/commit/b60f51bfcc7d96659efa332a40726cf760693aca Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib-program-client/Makefile.am Log Message: ----------- lib-program-client: Linking fix. From noreply at github.com Thu Oct 20 08:14:38 2016 From: noreply at github.com (GitHub) Date: Thu, 20 Oct 2016 01:14:38 -0700 Subject: [dovecot/core] c67082: login proxy: Hanging outgoing SSL connections caus... Message-ID: <58087cee166dc_2dd13ffb34f75138627c0@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c67082dca6eda730c2bb07cdef242b1b8ee09929 https://github.com/dovecot/core/commit/c67082dca6eda730c2bb07cdef242b1b8ee09929 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/login-common/login-proxy.c Log Message: ----------- login proxy: Hanging outgoing SSL connections caused using already-freed memory This mainly happened when login proxy closed the connection due to connect timeout. The ssl-proxy still had a reference and existed for a longer time. If SSL handshake still succeeded afterwards, it now called login_proxy_ssl_handshaked(), which accessed the already-freed proxy and likely crashed. Fixed the ssl-client proxy code specifically. Alternatively ssl_proxy_free() could be calling ssl_proxy_destroy() always, but since ssl-server side of the code seems to have been working fine, I don't want to accidentally break it. From noreply at github.com Thu Oct 20 10:30:11 2016 From: noreply at github.com (GitHub) Date: Thu, 20 Oct 2016 03:30:11 -0700 Subject: [dovecot/core] fe791e: auth: Pass local_name to auth-request Message-ID: <58089cb314648_2adc3fa5b5473138155697@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: fe791e96fdf796f7d8997ee0515b163dc5eddd72 https://github.com/dovecot/core/commit/fe791e96fdf796f7d8997ee0515b163dc5eddd72 Author: Aki Tuomi Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/auth/auth-request-var-expand.c M src/auth/auth-request-var-expand.h M src/auth/auth-request.c M src/auth/auth-request.h M src/lib-auth/auth-client-request.c M src/lib-auth/auth-client.h M src/login-common/client-common.h M src/login-common/login-settings.c M src/login-common/sasl-server.c M src/login-common/ssl-proxy-openssl.c Log Message: ----------- auth: Pass local_name to auth-request This allows using local_name in various places, such as passdb/userdb queries. Commit: 5e327e031d1591f8bff17b67eba7139afbd36cdd https://github.com/dovecot/core/commit/5e327e031d1591f8bff17b67eba7139afbd36cdd Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/client-connection-http.c M src/doveadm/client-connection-private.h M src/doveadm/client-connection.c M src/doveadm/client-connection.h M src/doveadm/doveadm.h M src/doveadm/main.c Log Message: ----------- doveadm-server: Show incoming connection's IP and running command is process title. Compare: https://github.com/dovecot/core/compare/c67082dca6ed...5e327e031d15 From noreply at github.com Thu Oct 20 12:02:57 2016 From: noreply at github.com (GitHub) Date: Thu, 20 Oct 2016 05:02:57 -0700 Subject: [dovecot/core] f7bc2f: doveadm user: If lookup fails, don't write it to t... Message-ID: <5808b271bab68_3ed3f8067a711341009ec@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f7bc2f7085bcd31618c540c12ffd185da37352d3 https://github.com/dovecot/core/commit/f7bc2f7085bcd31618c540c12ffd185da37352d3 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-auth.c Log Message: ----------- doveadm user: If lookup fails, don't write it to the same line as header. Commit: c7713320cd35e77543f1bdc7229988a160dae322 https://github.com/dovecot/core/commit/c7713320cd35e77543f1bdc7229988a160dae322 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/Makefile.am M src/doveadm/doveadm-master.c R src/doveadm/doveadm-service.c Log Message: ----------- doveadm service stop: Moved command handling to doveadm-master.c It's talking to master process, and there will be other non-service commands that talk to the master process in the same way. Commit: 7237f2f0a577413e12662228ee2039425fd2f5b0 https://github.com/dovecot/core/commit/7237f2f0a577413e12662228ee2039425fd2f5b0 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-master.c Log Message: ----------- doveadm service stop: Code cleanup - Prepare for other service commands. Commit: de41dbb482990a4be10ca9033cf881a850ccdc50 https://github.com/dovecot/core/commit/de41dbb482990a4be10ca9033cf881a850ccdc50 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-master.c Log Message: ----------- doveadm service stop: Convert to doveadm v2 API Commit: 27bb267255b36d34c638c34a1ade611962f00772 https://github.com/dovecot/core/commit/27bb267255b36d34c638c34a1ade611962f00772 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-master.c Log Message: ----------- doveadm-master: Code cleanup - simplify sending command args to master. This also escapes the parameters to make sure nothing bad can be sent. Commit: eba7f36feec8d02c4c394e55ff4effd47e33d311 https://github.com/dovecot/core/commit/eba7f36feec8d02c4c394e55ff4effd47e33d311 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm-cmd.h M src/doveadm/doveadm-master.c M src/master/master-client.c Log Message: ----------- Added "doveadm service status" This allows asking for services' current status in master process. Commit: d78f1ac9dc0f3e6c64cebe9ee331ec6b3c160e89 https://github.com/dovecot/core/commit/d78f1ac9dc0f3e6c64cebe9ee331ec6b3c160e89 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm-cmd.h M src/doveadm/doveadm-master.c M src/master/master-client.c Log Message: ----------- Added "doveadm process status" This allows asking for processes' current status in master process. Compare: https://github.com/dovecot/core/compare/5e327e031d15...d78f1ac9dc0f From noreply at github.com Thu Oct 20 12:12:44 2016 From: noreply at github.com (GitHub) Date: Thu, 20 Oct 2016 05:12:44 -0700 Subject: [dovecot/core] 3a3c78: login proxy: Hanging outgoing SSL connections caus... Message-ID: <5808b4bc1c3aa_409d3fd94c43b13c6829c@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 3a3c7835b26bd396881fce47cf15b9eeb37c42a9 https://github.com/dovecot/core/commit/3a3c7835b26bd396881fce47cf15b9eeb37c42a9 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/login-common/login-proxy.c Log Message: ----------- login proxy: Hanging outgoing SSL connections caused using already-freed memory This mainly happened when login proxy closed the connection due to connect timeout. The ssl-proxy still had a reference and existed for a longer time. If SSL handshake still succeeded afterwards, it now called login_proxy_ssl_handshaked(), which accessed the already-freed proxy and likely crashed. Fixed the ssl-client proxy code specifically. Alternatively ssl_proxy_free() could be calling ssl_proxy_destroy() always, but since ssl-server side of the code seems to have been working fine, I don't want to accidentally break it. Commit: 588e91edfc85a1abe1a2c486ed8fbdfe22bc3c19 https://github.com/dovecot/core/commit/588e91edfc85a1abe1a2c486ed8fbdfe22bc3c19 Author: Aki Tuomi Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/auth/auth-request-var-expand.c M src/auth/auth-request-var-expand.h M src/auth/auth-request.c M src/auth/auth-request.h M src/lib-auth/auth-client-request.c M src/lib-auth/auth-client.h M src/login-common/client-common.h M src/login-common/login-settings.c M src/login-common/sasl-server.c M src/login-common/ssl-proxy-openssl.c Log Message: ----------- auth: Pass local_name to auth-request This allows using local_name in various places, such as passdb/userdb queries. Commit: cbff70d5506826af9a4b30d7dc13feae8aca5942 https://github.com/dovecot/core/commit/cbff70d5506826af9a4b30d7dc13feae8aca5942 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/client-connection-http.c M src/doveadm/client-connection-private.h M src/doveadm/client-connection.c M src/doveadm/client-connection.h M src/doveadm/doveadm.h M src/doveadm/main.c Log Message: ----------- doveadm-server: Show incoming connection's IP and running command is process title. Commit: bc185e31846ce9fd4b12a4f216010b8a2fd621ae https://github.com/dovecot/core/commit/bc185e31846ce9fd4b12a4f216010b8a2fd621ae Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-auth.c Log Message: ----------- doveadm user: If lookup fails, don't write it to the same line as header. Commit: 7fa3afc2857c1128724275dbc41a76d1910e5a65 https://github.com/dovecot/core/commit/7fa3afc2857c1128724275dbc41a76d1910e5a65 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/Makefile.am M src/doveadm/doveadm-master.c R src/doveadm/doveadm-service.c Log Message: ----------- doveadm service stop: Moved command handling to doveadm-master.c It's talking to master process, and there will be other non-service commands that talk to the master process in the same way. Commit: ae1884edce9a9e47b4cfcec5f73c91e28592bf78 https://github.com/dovecot/core/commit/ae1884edce9a9e47b4cfcec5f73c91e28592bf78 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-master.c Log Message: ----------- doveadm service stop: Code cleanup - Prepare for other service commands. Commit: bcab4a375b082d76cf6336b65eb5e69bff9b36ec https://github.com/dovecot/core/commit/bcab4a375b082d76cf6336b65eb5e69bff9b36ec Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-master.c Log Message: ----------- doveadm service stop: Convert to doveadm v2 API Commit: 02db6679456ef8b30a281ac997f7c0b5239495c2 https://github.com/dovecot/core/commit/02db6679456ef8b30a281ac997f7c0b5239495c2 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-master.c Log Message: ----------- doveadm-master: Code cleanup - simplify sending command args to master. This also escapes the parameters to make sure nothing bad can be sent. Commit: 7c4cbc92cec6c34fb7ba9fdcfd0bbd8de8106c51 https://github.com/dovecot/core/commit/7c4cbc92cec6c34fb7ba9fdcfd0bbd8de8106c51 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm-cmd.h M src/doveadm/doveadm-master.c M src/master/master-client.c Log Message: ----------- Added "doveadm service status" This allows asking for services' current status in master process. Commit: 6516a748202ee1bd45dc84d745d3d644824886d8 https://github.com/dovecot/core/commit/6516a748202ee1bd45dc84d745d3d644824886d8 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm-cmd.h M src/doveadm/doveadm-master.c M src/master/master-client.c Log Message: ----------- Added "doveadm process status" This allows asking for processes' current status in master process. Compare: https://github.com/dovecot/core/compare/fdcd289cc3bc...6516a748202e From noreply at github.com Thu Oct 20 12:30:09 2016 From: noreply at github.com (GitHub) Date: Thu, 20 Oct 2016 05:30:09 -0700 Subject: [dovecot/core] 80838a: dovecot-config: Added dovecot_statedir Message-ID: <5808b8d1b084_40823f85f1a3913c124325@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 80838a8bb1fbcc6ad781172448fd0cbc8d423612 https://github.com/dovecot/core/commit/80838a8bb1fbcc6ad781172448fd0cbc8d423612 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M Makefile.am M dovecot-config.in.in M m4/dovecot.m4 Log Message: ----------- dovecot-config: Added dovecot_statedir From noreply at github.com Thu Oct 20 14:00:10 2016 From: noreply at github.com (GitHub) Date: Thu, 20 Oct 2016 07:00:10 -0700 Subject: [dovecot/core] 395168: auth: Fixed assert-crash on invalid auth-client in... Message-ID: <5808cdea451e4_135e3f82cade1138977c4@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 3951689971f3478e910507c1078cf0123de63866 https://github.com/dovecot/core/commit/3951689971f3478e910507c1078cf0123de63866 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/auth/auth-request-handler.c Log Message: ----------- auth: Fixed assert-crash on invalid auth-client input For example if client sends invalid input like: auth: Error: BUG: Authentication client sent unknown command: XYZ Fixes crash: auth: Panic: key not found from hash From noreply at github.com Thu Oct 20 14:30:09 2016 From: noreply at github.com (GitHub) Date: Thu, 20 Oct 2016 07:30:09 -0700 Subject: [dovecot/core] 6aecc2: lib-program-client: Gave variables pointing to a p... Message-ID: <5808d4f1c1838_14e93ff8dd00114c495c4@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 6aecc29b894bf0eb6784d212eec13cb37c72951c https://github.com/dovecot/core/commit/6aecc29b894bf0eb6784d212eec13cb37c72951c Author: Stephan Bosch Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-remote.c Log Message: ----------- lib-program-client: Gave variables pointing to a program-client more logical names. Was still based on when it was called the script-client. Commit: 59cd0982252ea1a416f9ed04fd083697ba31fb3a https://github.com/dovecot/core/commit/59cd0982252ea1a416f9ed04fd083697ba31fb3a Author: Stephan Bosch Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-remote.c Log Message: ----------- lib-program-client: Fixed boolean expressions. Problems found with clang -Wstrict-bool. Commit: 1210c14c3526330202b199185c3675cdda876cd5 https://github.com/dovecot/core/commit/1210c14c3526330202b199185c3675cdda876cd5 Author: Stephan Bosch Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib-storage/mail-storage.c Log Message: ----------- lib-storage: Fixed a boolean expression. Problem found with clang -Wstrict-bool. Commit: 290b91ad6f5ea9e44b2d86b68dd80f0313cd2c57 https://github.com/dovecot/core/commit/290b91ad6f5ea9e44b2d86b68dd80f0313cd2c57 Author: Aki Tuomi Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/login-common/client-common.c Log Message: ----------- login-common: Include local_name in login_var_expand_table This way it can be used in login_log_format Commit: 0b808b62a679c81f59958392507fd0f6b5bd4e34 https://github.com/dovecot/core/commit/0b808b62a679c81f59958392507fd0f6b5bd4e34 Author: Aki Tuomi Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/auth/auth-request.c M src/lib-auth/auth-client-request.c Log Message: ----------- auth: Escape local_name Compare: https://github.com/dovecot/core/compare/3951689971f3...0b808b62a679 From noreply at github.com Thu Oct 20 16:00:10 2016 From: noreply at github.com (GitHub) Date: Thu, 20 Oct 2016 09:00:10 -0700 Subject: [dovecot/core] 5e8e8f: lib-ldap: Fixed compiling with OpenBSD Message-ID: <5808ea0adee4b_151d3f8c9c405138398dc@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 5e8e8fb01389cc04a77e173c57b2d66a2f863370 https://github.com/dovecot/core/commit/5e8e8fb01389cc04a77e173c57b2d66a2f863370 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib-ldap/ldap-search.c Log Message: ----------- lib-ldap: Fixed compiling with OpenBSD Commit: 761585b5c8798d39fbb2fb6a72667719a47bef6f https://github.com/dovecot/core/commit/761585b5c8798d39fbb2fb6a72667719a47bef6f Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-user.c Log Message: ----------- %{auth_domain} shouldn't include the leading '@' Commit: e40aeca4aa0e7009949a101e7ce661057486378b https://github.com/dovecot/core/commit/e40aeca4aa0e7009949a101e7ce661057486378b Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/pop3/pop3-client.c Log Message: ----------- pop3: Fix pop3_logout_format=%{deleted_size} expansion when there are no deletions Should be "0", not empty string. Commit: f915d2f0b7c106055b40af0be99504aebae3edaa https://github.com/dovecot/core/commit/f915d2f0b7c106055b40af0be99504aebae3edaa Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib/strfuncs.h Log Message: ----------- lib: Added i_strchr_to_next() Commit: 4b1781e4c64be52e25b5994e5242dbe696cc7d29 https://github.com/dovecot/core/commit/4b1781e4c64be52e25b5994e5242dbe696cc7d29 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/auth/auth-request-var-expand.c M src/auth/auth-worker-client.c M src/auth/db-ldap.c M src/auth/userdb-passwd-file.c M src/imap-hibernate/imap-client.c M src/lib-dict/dict-client.c M src/lib-imap-client/imapc-connection.c M src/lib-mail/mail-user-hash.c M src/lib-storage/index/shared/shared-storage.c M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-user.c M src/lib-storage/mailbox-list.c M src/login-common/client-common.c M src/stats/mail-user.c Log Message: ----------- global: Use i_strchr_to_next() wherever useful. Commit: acfda38b75d0f0e899ef692fef01593bd56ed85e https://github.com/dovecot/core/commit/acfda38b75d0f0e899ef692fef01593bd56ed85e Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c M src/imap/imap-client.c M src/lib-lda/mail-deliver.c M src/lib-lda/mail-send.c M src/lib-mail/mail-user-hash.c M src/lib-storage/index/shared/shared-storage.c M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-user.c M src/login-common/client-common.c M src/login-common/login-settings.c M src/plugins/acl/acl-shared-storage.c M src/pop3/pop3-client.c M src/pop3/pop3-commands.c Log Message: ----------- global: Try to initialize var_expand_tab[] directly. This avoids accidents with the array numbering being wrong. Compare: https://github.com/dovecot/core/compare/0b808b62a679...acfda38b75d0 From noreply at github.com Thu Oct 20 20:30:10 2016 From: noreply at github.com (GitHub) Date: Thu, 20 Oct 2016 13:30:10 -0700 Subject: [dovecot/core] ef0c36: global: Code cleanup - Use t_strsplit_tabescaped()... Message-ID: <58092952b571a_6d553fcf1824f140390f6@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: ef0c36aa8114feee80aa696d9cb8106140371243 https://github.com/dovecot/core/commit/ef0c36aa8114feee80aa696d9cb8106140371243 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/client-connection.c M src/doveadm/doveadm-stats.c M src/indexer/indexer-client.c M src/lib-auth/auth-master.c M src/lib-master/master-login.c M src/stats/client.c M src/util/script-login.c Log Message: ----------- global: Code cleanup - Use t_strsplit_tabescaped() to avoid str_tabunescape() Commit: 7a60e1dc9e93ef3f7c7fe1af6385a0bfa1e31bc3 https://github.com/dovecot/core/commit/7a60e1dc9e93ef3f7c7fe1af6385a0bfa1e31bc3 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/anvil/anvil-connection.c M src/auth/auth-fields.c M src/auth/auth-master-connection.c M src/auth/auth-request-handler.c M src/auth/passdb-blocking.c M src/auth/passdb-cache.c M src/config/config-connection.c M src/director/director-connection.c M src/director/director-test.c M src/director/doveadm-connection.c M src/director/login-connection.c M src/doveadm/doveadm-director.c M src/doveadm/doveadm-penalty.c M src/doveadm/doveadm-proxy.c M src/doveadm/doveadm-replicator.c M src/doveadm/doveadm-who.c M src/doveadm/dsync/dsync-ibc-stream.c M src/indexer/indexer-client.c M src/ipc/ipc-connection.c M src/lib-auth/auth-master.c M src/lib-auth/auth-server-connection.c M src/lib-master/master-login-auth.c M src/lib-master/master-service-settings.c M src/login-common/login-proxy.c M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- global: Replaced t_strsplit_tab() calls with t_strsplit_tabescaped() This is useful especially in auth code to support LFs in extra fields. Other pieces of code were also tab-escaping strings, but never unescaping them. Usually it didn't matter, because nobody would use the escaped characters. Still, the code wasn't exactly behaving correctly. One downside to this change is that it's now possible to pass through TABs, CRs and LFs through the various protocols. In theory this shouldn't cause any problems, but combined with other bugs this could trigger some security problems. Commit: e8a936d1e264fa1d161b00ce77e2bfdf4a3b3219 https://github.com/dovecot/core/commit/e8a936d1e264fa1d161b00ce77e2bfdf4a3b3219 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib/test-strescape.c Log Message: ----------- lib: Added unit tests for string tabescaping. Compare: https://github.com/dovecot/core/compare/acfda38b75d0...e8a936d1e264 From noreply at github.com Thu Oct 20 20:30:13 2016 From: noreply at github.com (GitHub) Date: Thu, 20 Oct 2016 13:30:13 -0700 Subject: [dovecot/core] 3459db: auth: Fixed assert-crash on invalid auth-client in... Message-ID: <58092955d4cba_445a3fd2fd1a114c1011da@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 3459db0f8f772d64e71ea5f097c97d2390af6e73 https://github.com/dovecot/core/commit/3459db0f8f772d64e71ea5f097c97d2390af6e73 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/auth/auth-request-handler.c Log Message: ----------- auth: Fixed assert-crash on invalid auth-client input For example if client sends invalid input like: auth: Error: BUG: Authentication client sent unknown command: XYZ Fixes crash: auth: Panic: key not found from hash Commit: 18a85e214e2576f4070c5f2e20b00931366cb7cd https://github.com/dovecot/core/commit/18a85e214e2576f4070c5f2e20b00931366cb7cd Author: Stephan Bosch Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c Log Message: ----------- lib-program-client: Fixed boolean expressions. Problems found with clang -Wstrict-bool. Commit: d80ade0ca261d0ee8114ec098404e02c5aabf755 https://github.com/dovecot/core/commit/d80ade0ca261d0ee8114ec098404e02c5aabf755 Author: Aki Tuomi Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/login-common/client-common.c Log Message: ----------- login-common: Include local_name in login_var_expand_table This way it can be used in login_log_format Commit: d24a5ebd6dc087fba1c41cbf2249ccf47db12ea9 https://github.com/dovecot/core/commit/d24a5ebd6dc087fba1c41cbf2249ccf47db12ea9 Author: Aki Tuomi Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/auth/auth-request.c M src/lib-auth/auth-client-request.c Log Message: ----------- auth: Escape local_name Commit: d3489519afbef7c2c7dc3fe5e62aaefdfe1c4853 https://github.com/dovecot/core/commit/d3489519afbef7c2c7dc3fe5e62aaefdfe1c4853 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib-ldap/ldap-search.c Log Message: ----------- lib-ldap: Fixed compiling with OpenBSD Commit: ada6d5fe1a4dee7764fd73f9b790f26b50a92611 https://github.com/dovecot/core/commit/ada6d5fe1a4dee7764fd73f9b790f26b50a92611 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-user.c Log Message: ----------- %{auth_domain} shouldn't include the leading '@' Commit: 406dfb5c615dfbd4cf7586b0c4ab21cc8e26c334 https://github.com/dovecot/core/commit/406dfb5c615dfbd4cf7586b0c4ab21cc8e26c334 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/pop3/pop3-client.c Log Message: ----------- pop3: Fix pop3_logout_format=%{deleted_size} expansion when there are no deletions Should be "0", not empty string. Commit: e4a48fe67b67a63c280643af840e3bdd51538c29 https://github.com/dovecot/core/commit/e4a48fe67b67a63c280643af840e3bdd51538c29 Author: Stephan Bosch Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M dovecot.m4 Log Message: ----------- Added LIBDOVECOT_PUSH_NOTIFICATION_INCLUDE to dovecot.m4. Commit: 7adf84cd0ed9bfaf0d1f4cce6111b3cb4e1943d6 https://github.com/dovecot/core/commit/7adf84cd0ed9bfaf0d1f4cce6111b3cb4e1943d6 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M Makefile.am R cc-wrapper.sh.in M configure.ac M dovecot.m4 Log Message: ----------- Moved cc-wrapper.sh handling to dovecot.m4 When configuring Dovecot --without-shared-libs and pointing external plugins to uninstalled sources --with-dovecot, any binaries complied for plugins weren't using cc-wrapper.sh, which could have caused runtime failures when they attempted to load plugins dynamically. Now it's possible to add DC_CC_WRAPPER to plugins' configure.ac to build with the cc-wrapper.sh. Commit: d10043f6f772f2db7a2ec2b8a0f4476ec9b68050 https://github.com/dovecot/core/commit/d10043f6f772f2db7a2ec2b8a0f4476ec9b68050 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M Makefile.am M dovecot-config.in.in M dovecot.m4 Log Message: ----------- dovecot-config: Added dovecot_statedir Commit: 9896dde16fbc7f182bfdb891d31e8bb99dc05a4e https://github.com/dovecot/core/commit/9896dde16fbc7f182bfdb891d31e8bb99dc05a4e Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M dovecot.m4 Log Message: ----------- dovecot.m4: Added DOVECOT_BINARY_LDFLAGS for future compatibility Mainly to keep the serial number the same in v2.2 and v2.3 tree. Compare: https://github.com/dovecot/core/compare/6516a748202e...9896dde16fbc From noreply at github.com Fri Oct 21 09:00:09 2016 From: noreply at github.com (GitHub) Date: Fri, 21 Oct 2016 02:00:09 -0700 Subject: [dovecot/core] 28f799: imap-hibernate: Fix "DONE" handling. Message-ID: <5809d91941ab3_7fd93fa72be79138676cb@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 28f7995610134e3d3be1d493d4ce6328b204182b https://github.com/dovecot/core/commit/28f7995610134e3d3be1d493d4ce6328b204182b Author: Timo Sirainen Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c Log Message: ----------- imap-hibernate: Fix "DONE" handling. 1. If only "DONE\r\n" was sent, it randomly failed with BAD because of out-of-bounds buffer read. 2. If "DONE\r\n" was followed by a command tag but no space afterwards, we kept waiting for the input to continue. But since the DONE was already sent, we should break the IDLE already at that point without any further waiting. From noreply at github.com Fri Oct 21 10:30:09 2016 From: noreply at github.com (GitHub) Date: Fri, 21 Oct 2016 03:30:09 -0700 Subject: [dovecot/core] 4a1972: lib-program-client: Change program_client_create()... Message-ID: <5809ee318abc9_20e03f9e3c46b13455589@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 4a197212360f75bfc89254bfd5bc4a31151fe4b4 https://github.com/dovecot/core/commit/4a197212360f75bfc89254bfd5bc4a31151fe4b4 Author: Timo Sirainen Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/lib-program-client/program-client.c M src/lib-program-client/program-client.h Log Message: ----------- lib-program-client: Change program_client_create() API to return error string. From noreply at github.com Fri Oct 21 11:48:24 2016 From: noreply at github.com (GitHub) Date: Fri, 21 Oct 2016 04:48:24 -0700 Subject: [dovecot/core] d83aa9: doveadm: Rewind input early enough Message-ID: <580a008823221_2d463f7f1b96913012458e@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d83aa942767d377dadce82bb25a46aa96959b42b https://github.com/dovecot/core/commit/d83aa942767d377dadce82bb25a46aa96959b42b Author: Aki Tuomi Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/doveadm/doveadm-mail.c Log Message: ----------- doveadm: Rewind input early enough Command input needs to be rewinded earlier in doveadm_mail_next_user. From noreply at github.com Fri Oct 21 13:18:39 2016 From: noreply at github.com (GitHub) Date: Fri, 21 Oct 2016 06:18:39 -0700 Subject: [dovecot/core] 958e5a: director: Fix shutdown_clients=no to not break Message-ID: <580a15aff2dcf_23373f89975d313432140@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 958e5ae51a755558b6d022a39b194614726b4225 https://github.com/dovecot/core/commit/958e5ae51a755558b6d022a39b194614726b4225 Author: Timo Sirainen Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/director/main.c Log Message: ----------- director: Fix shutdown_clients=no to not break The director process must shut down even with with shutdown_clients=no. Otherwise the two director processes will try to keep competing with each others and log errors like: director: Warning: Director 10.0.0.123:9090/right disconnected us with reason: Replacing with new incoming connection director: Warning: Director 10.0.0.123:9090/right disconnected us with reason: Replacing with 10.0.0.124:9090 From noreply at github.com Fri Oct 21 13:42:29 2016 From: noreply at github.com (GitHub) Date: Fri, 21 Oct 2016 06:42:29 -0700 Subject: [dovecot/core] 92c810: program-client-unix: Don't retry connecting to UNI... Message-ID: <580a1b45d64f6_53963f885a9d912c1254c1@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 92c8109f71ed1b801806fba307e3032306bbcbaf https://github.com/dovecot/core/commit/92c8109f71ed1b801806fba307e3032306bbcbaf Author: Timo Sirainen Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/lib-program-client/program-client-remote.c Log Message: ----------- program-client-unix: Don't retry connecting to UNIX socket. Especially with async connections this will just block the whole process when there are errors. From noreply at github.com Fri Oct 21 13:42:31 2016 From: noreply at github.com (GitHub) Date: Fri, 21 Oct 2016 06:42:31 -0700 Subject: [dovecot/core] 85e2e5: lib-program-client: Add URI based constructor Message-ID: <580a1b479291a_41b63fddce0fb130111165@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 85e2e5645019681cf53b113a8df3cf56ff87e3a6 https://github.com/dovecot/core/commit/85e2e5645019681cf53b113a8df3cf56ff87e3a6 Author: Aki Tuomi Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/lib-program-client/program-client.c M src/lib-program-client/program-client.h Log Message: ----------- lib-program-client: Add URI based constructor From noreply at github.com Fri Oct 21 17:06:19 2016 From: noreply at github.com (GitHub) Date: Fri, 21 Oct 2016 10:06:19 -0700 Subject: [dovecot/pigeonhole] 2292a6: lib-sieve: code dumper: Fixed T_BEGIN { ... } T_EN... Message-ID: <580a4b0b45c7b_43123fe18861d13c1004d3@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-0.4 Home: https://github.com/dovecot/pigeonhole Commit: 2292a6d41bb0276fa6f91c6950352255871bc885 https://github.com/dovecot/pigeonhole/commit/2292a6d41bb0276fa6f91c6950352255871bc885 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/lib-sieve/sieve-code-dumper.c Log Message: ----------- lib-sieve: code dumper: Fixed T_BEGIN { ... } T_END block violation. Commit: 7e72cb6adc583474bda8b38610adb1194e3d11c6 https://github.com/dovecot/pigeonhole/commit/7e72cb6adc583474bda8b38610adb1194e3d11c6 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/lib-sieve/plugins/vacation/cmd-vacation.c M tests/extensions/vacation/reply.svtest Log Message: ----------- lib-sieve: vacation extension: Use Microsoft X-Auto-Response-Suppress header to prevent unwanted responses. We've seen a few situations where Pigeonhole and Microsoft products start a useless machine conversation. At least older versions of Outlook ignore the standards on multiple points to make this happen. We prevent this now by recognizing and generating the X-Auto-Response-Suppress header. Commit: f57c46ce252071d393e96caf47693bd061eed2e2 https://github.com/dovecot/pigeonhole/commit/f57c46ce252071d393e96caf47693bd061eed2e2 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/managesieve/managesieve-client.c M src/managesieve/managesieve-settings.c M src/managesieve/managesieve-settings.h Log Message: ----------- managesieve: Added rawlog_dir setting to store ManageSieve traffic logs. This at least partially replaces the "rawlog" post-login binary. For now the "rawlog" binary supports some parameters, which aren't configurable for rawlog_dir. Commit: 6e8b01c628a7faefb6521442dc9108d5ae8c6aee https://github.com/dovecot/pigeonhole/commit/6e8b01c628a7faefb6521442dc9108d5ae8c6aee Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/testsuite/Makefile.am Log Message: ----------- testsuite: Cleanup spurious test output. Commit: 623ae77e829685bddec58cb29e44524059769096 https://github.com/dovecot/pigeonhole/commit/623ae77e829685bddec58cb29e44524059769096 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M NEWS Log Message: ----------- Added v0.4.15 to NEWS. Compare: https://github.com/dovecot/pigeonhole/compare/9824bde15988...623ae77e8296 From noreply at github.com Fri Oct 21 17:06:31 2016 From: noreply at github.com (GitHub) Date: Fri, 21 Oct 2016 10:06:31 -0700 Subject: [dovecot/pigeonhole] 38750f: imapsieve plugin: Removed spurious pool field from... Message-ID: <580a4b17b3867_33d03fb61944f138105237@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/tags/dovecot-ee-2.2.25.5-12 Home: https://github.com/dovecot/pigeonhole Commit: 38750f9b5196da4891be304dae856bf522e12f29 https://github.com/dovecot/pigeonhole/commit/38750f9b5196da4891be304dae856bf522e12f29 Author: Stephan Bosch Date: 2016-08-10 (Wed, 10 Aug 2016) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Removed spurious pool field from imap_sieve_user struct. Commit: 147a0eac2ca3c12760a447928a337e42f9a2eef8 https://github.com/dovecot/pigeonhole/commit/147a0eac2ca3c12760a447928a337e42f9a2eef8 Author: Stephan Bosch Date: 2016-08-10 (Wed, 10 Aug 2016) Changed paths: M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- imapsieve plugin: Fixed crash occurring when a mailbox is opened for a user before the imap client object is created. Commit: c3d763cbc98ba45ebb8ba7045e6e19a00a67a94e https://github.com/dovecot/pigeonhole/commit/c3d763cbc98ba45ebb8ba7045e6e19a00a67a94e Author: Stephan Bosch Date: 2016-08-23 (Tue, 23 Aug 2016) Changed paths: M src/sieve-tools/sieve-test.c Log Message: ----------- sieve-test: Forgot to disable error handling for dummy SMTP output stream. Commit: 145b2901bd00e5eeef565f262842a902cb9fc3a6 https://github.com/dovecot/pigeonhole/commit/145b2901bd00e5eeef565f262842a902cb9fc3a6 Author: Timo Sirainen Date: 2016-08-23 (Tue, 23 Aug 2016) Changed paths: M src/lib-sieve-tool/mail-raw.c M src/lib-sieve/storage/file/sieve-file-storage-active.c M src/lib-sieve/storage/file/sieve-file-storage-save.c M src/lib-sieve/util/program-client.c M src/sieve-tools/sieve-test.c Log Message: ----------- Use i_unlink() to improve unexpected unlink() error messages. Commit: 6f71a1fb4aa5d1052d2cc3c47f042c6a4bf1317e https://github.com/dovecot/pigeonhole/commit/6f71a1fb4aa5d1052d2cc3c47f042c6a4bf1317e Author: Stephan Bosch Date: 2016-08-23 (Tue, 23 Aug 2016) Changed paths: M src/lib-sieve/util/program-client.c Log Message: ----------- lib-sieve: util: program-client: Fixed position of the seekable stream for the output of remote programs. It would now make the output of the script service seekable, rather than the output of the program. This adds a '+' at the end of the data. This showed up for the extprograms filter command. Commit: 8bb051ee186b8c0ad2c5e676999a1a3c0900b102 https://github.com/dovecot/pigeonhole/commit/8bb051ee186b8c0ad2c5e676999a1a3c0900b102 Author: Stephan Bosch Date: 2016-08-30 (Tue, 30 Aug 2016) Changed paths: M src/plugins/doveadm-sieve/doveadm-sieve-sync.c Log Message: ----------- doveadm sieve plugin: sync: Fixed handling of unknown attribute timestamps. Compare: https://github.com/dovecot/pigeonhole/compare/38750f9b5196^...8bb051ee186b From noreply at github.com Fri Oct 21 17:08:04 2016 From: noreply at github.com (GitHub) Date: Fri, 21 Oct 2016 10:08:04 -0700 Subject: [dovecot/pigeonhole] 663f8c: lib-sieve: code dumper: Fixed T_BEGIN { ... } T_EN... Message-ID: <580a4b741a91c_38f23fe8be34314059597@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/pigeonhole Commit: 663f8cc556e4f20ff1213bb73fbb6a7a1b1c9f1f https://github.com/dovecot/pigeonhole/commit/663f8cc556e4f20ff1213bb73fbb6a7a1b1c9f1f Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/lib-sieve/sieve-code-dumper.c Log Message: ----------- lib-sieve: code dumper: Fixed T_BEGIN { ... } T_END block violation. Commit: 32e7781dcda07428bd42831d1938a5c000d1c543 https://github.com/dovecot/pigeonhole/commit/32e7781dcda07428bd42831d1938a5c000d1c543 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/lib-sieve/sieve-address-source.c M src/lib-sieve/sieve-settings.c M src/lib-sieve/util/Makefile.am R src/lib-sieve/util/strtrim.c R src/lib-sieve/util/strtrim.h M src/plugins/imapsieve/imap-sieve-storage.c Log Message: ----------- lib-sieve: util: Removed Pigeonhole's own version of t_str_trim(), since it is now available in Dovecot. Commit: 036d5191fd5683b6c221b8dc080c9a6da1faf4c2 https://github.com/dovecot/pigeonhole/commit/036d5191fd5683b6c221b8dc080c9a6da1faf4c2 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/lib-sieve/plugins/vacation/cmd-vacation.c M tests/extensions/vacation/reply.svtest Log Message: ----------- lib-sieve: vacation extension: Use Microsoft X-Auto-Response-Suppress header to prevent unwanted responses. We've seen a few situations where Pigeonhole and Microsoft products start a useless machine conversation. At least older versions of Outlook ignore the standards on multiple points to make this happen. We prevent this now by recognizing and generating the X-Auto-Response-Suppress header. Commit: 74ab3713a2ff72f6628737ce23986614d53bdcc7 https://github.com/dovecot/pigeonhole/commit/74ab3713a2ff72f6628737ce23986614d53bdcc7 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/managesieve/managesieve-client.c M src/managesieve/managesieve-settings.c M src/managesieve/managesieve-settings.h Log Message: ----------- managesieve: Added rawlog_dir setting to store ManageSieve traffic logs. This at least partially replaces the "rawlog" post-login binary. For now the "rawlog" binary supports some parameters, which aren't configurable for rawlog_dir. Commit: c5ed66bccd5d25d1ea52297bbcdb31ff621b432e https://github.com/dovecot/pigeonhole/commit/c5ed66bccd5d25d1ea52297bbcdb31ff621b432e Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/testsuite/Makefile.am Log Message: ----------- testsuite: Cleanup spurious test output. Compare: https://github.com/dovecot/pigeonhole/compare/ca0cd69e8504...c5ed66bccd5d From noreply at github.com Fri Oct 21 17:05:57 2016 From: noreply at github.com (GitHub) Date: Fri, 21 Oct 2016 10:05:57 -0700 Subject: [dovecot/pigeonhole] 2292a6: lib-sieve: code dumper: Fixed T_BEGIN { ... } T_EN... Message-ID: <580a4af5395a0_1ac43fc4f622713089263@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/release-0.4.16 Home: https://github.com/dovecot/pigeonhole Commit: 2292a6d41bb0276fa6f91c6950352255871bc885 https://github.com/dovecot/pigeonhole/commit/2292a6d41bb0276fa6f91c6950352255871bc885 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/lib-sieve/sieve-code-dumper.c Log Message: ----------- lib-sieve: code dumper: Fixed T_BEGIN { ... } T_END block violation. Commit: 7e72cb6adc583474bda8b38610adb1194e3d11c6 https://github.com/dovecot/pigeonhole/commit/7e72cb6adc583474bda8b38610adb1194e3d11c6 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/lib-sieve/plugins/vacation/cmd-vacation.c M tests/extensions/vacation/reply.svtest Log Message: ----------- lib-sieve: vacation extension: Use Microsoft X-Auto-Response-Suppress header to prevent unwanted responses. We've seen a few situations where Pigeonhole and Microsoft products start a useless machine conversation. At least older versions of Outlook ignore the standards on multiple points to make this happen. We prevent this now by recognizing and generating the X-Auto-Response-Suppress header. Commit: f57c46ce252071d393e96caf47693bd061eed2e2 https://github.com/dovecot/pigeonhole/commit/f57c46ce252071d393e96caf47693bd061eed2e2 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/managesieve/managesieve-client.c M src/managesieve/managesieve-settings.c M src/managesieve/managesieve-settings.h Log Message: ----------- managesieve: Added rawlog_dir setting to store ManageSieve traffic logs. This at least partially replaces the "rawlog" post-login binary. For now the "rawlog" binary supports some parameters, which aren't configurable for rawlog_dir. Commit: 6e8b01c628a7faefb6521442dc9108d5ae8c6aee https://github.com/dovecot/pigeonhole/commit/6e8b01c628a7faefb6521442dc9108d5ae8c6aee Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M src/testsuite/Makefile.am Log Message: ----------- testsuite: Cleanup spurious test output. Commit: 623ae77e829685bddec58cb29e44524059769096 https://github.com/dovecot/pigeonhole/commit/623ae77e829685bddec58cb29e44524059769096 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M NEWS Log Message: ----------- Added v0.4.15 to NEWS. Commit: fed855416f2ffd5c261ecd01baed615911b165c4 https://github.com/dovecot/pigeonhole/commit/fed855416f2ffd5c261ecd01baed615911b165c4 Author: Stephan Bosch Date: 2016-10-21 (Fri, 21 Oct 2016) Changed paths: M NEWS M configure.ac Log Message: ----------- Released v0.4.16.rc1 for Dovecot v2.2.26.rc1. Compare: https://github.com/dovecot/pigeonhole/compare/2292a6d41bb0^...fed855416f2f From noreply at github.com Sat Oct 22 10:00:13 2016 From: noreply at github.com (GitHub) Date: Sat, 22 Oct 2016 03:00:13 -0700 Subject: [dovecot/core] d6c1b8: configure: Improved checking if OpenSSL is too old... Message-ID: <580b38ad5802_3f3b3fe2d431f1401106d4@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: d6c1b8c4c32874fe352e4d6af2a53f3fe14822bd https://github.com/dovecot/core/commit/d6c1b8c4c32874fe352e4d6af2a53f3fe14822bd Author: Timo Sirainen Date: 2016-10-22 (Sat, 22 Oct 2016) Changed paths: M configure.ac Log Message: ----------- configure: Improved checking if OpenSSL is too old for lib-dcrypt Some OpenSSL versions had EC_KEY_new, but not other needed functions. From noreply at github.com Sat Oct 22 10:30:08 2016 From: noreply at github.com (GitHub) Date: Sat, 22 Oct 2016 03:30:08 -0700 Subject: [dovecot/core] 120d33: configure: Improved checking if OpenSSL is too old... Message-ID: <580b3fb07ddb1_70f03fc8d7e7f13c308ca@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 120d33c71c0c9ede4b43fd3f86bbd925cae07cbe https://github.com/dovecot/core/commit/120d33c71c0c9ede4b43fd3f86bbd925cae07cbe Author: Timo Sirainen Date: 2016-10-22 (Sat, 22 Oct 2016) Changed paths: M m4/ssl.m4 Log Message: ----------- configure: Improved checking if OpenSSL is too old for lib-dcrypt Some OpenSSL versions had EC_KEY_new, but not other needed functions. From noreply at github.com Sat Oct 22 17:30:09 2016 From: noreply at github.com (GitHub) Date: Sat, 22 Oct 2016 10:30:09 -0700 Subject: [dovecot/core] cf7857: director: Support flush socket Message-ID: <580ba221afc3c_3f5b3fbe304f3138478ba@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: cf7857bce68a33cdabe88bb15568e21921eb5ac7 https://github.com/dovecot/core/commit/cf7857bce68a33cdabe88bb15568e21921eb5ac7 Author: Aki Tuomi Date: 2016-10-22 (Sat, 22 Oct 2016) Changed paths: M src/director/Makefile.am M src/director/director-settings.c M src/director/director-settings.h M src/director/director.c Log Message: ----------- director: Support flush socket This allows specifying an URI to execute on user kill. It can be of form exec:/path/to/bin, unix:/path/to/socket or tcp:ip:port The location is sent FLUSH username-hash per killed user. You can execute some action there, and you are expected to return '+\nOK\n' as reply once you are done. From noreply at github.com Sat Oct 22 20:00:09 2016 From: noreply at github.com (GitHub) Date: Sat, 22 Oct 2016 13:00:09 -0700 Subject: [dovecot/core] 9faac5: director: Fix crash handling director_flush_socket... Message-ID: <580bc549cb9ff_40523fed38ec113824315@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9faac59f664d4003d1412278ac8db4aad1c2067c https://github.com/dovecot/core/commit/9faac59f664d4003d1412278ac8db4aad1c2067c Author: Timo Sirainen Date: 2016-10-22 (Sat, 22 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Fix crash handling director_flush_socket when user is freed. From noreply at github.com Mon Oct 24 09:30:11 2016 From: noreply at github.com (GitHub) Date: Mon, 24 Oct 2016 02:30:11 -0700 Subject: [dovecot/core] 3e41b3: lib: Ensure tv_r gets set in io_loop_get_wait_time Message-ID: <580dd4a336445_78863fde845b313012877a@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 3e41b3d0cf90bbc1c229abb98cad944373316362 https://github.com/dovecot/core/commit/3e41b3d0cf90bbc1c229abb98cad944373316362 Author: Aki Tuomi Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/ioloop.c Log Message: ----------- lib: Ensure tv_r gets set in io_loop_get_wait_time If this does not get reset here to 0 it can cause errors or unpredictable behaviour in select/kqueue polling, such as very long delays. Commit: d0d5df1cf96e040999080cdb747aca11f3cba0b2 https://github.com/dovecot/core/commit/d0d5df1cf96e040999080cdb747aca11f3cba0b2 Author: Aki Tuomi Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/ioloop-kqueue.c Log Message: ----------- lib: Fix kqueue io_loop_get_wait_time usage The code needs to take into consideration, when there is no IO to be waited, but possibly there is io_set_pending used, or just timeouts. Commit: cca98b5accbfff773731a206950114acb8dcacfd https://github.com/dovecot/core/commit/cca98b5accbfff773731a206950114acb8dcacfd Author: Aki Tuomi Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/test-ioloop.c Log Message: ----------- lib: Add test for ioloop fd polling Compare: https://github.com/dovecot/core/compare/9faac59f664d...cca98b5accbf From noreply at github.com Mon Oct 24 10:00:10 2016 From: noreply at github.com (GitHub) Date: Mon, 24 Oct 2016 03:00:10 -0700 Subject: [dovecot/core] e1c08b: master: If chrooted service's core wasn't dumped, ... Message-ID: <580ddbaa3e8b2_67993fb1cc9b1140133020@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: e1c08b1d9ba29f55462914451b5d5d6959ebd144 https://github.com/dovecot/core/commit/e1c08b1d9ba29f55462914451b5d5d6959ebd144 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/master/service-process.c Log Message: ----------- master: If chrooted service's core wasn't dumped, suggest to unset the chroot. Commit: 96a4e105f7c990a786af909bf710eb6431c1f227 https://github.com/dovecot/core/commit/96a4e105f7c990a786af909bf710eb6431c1f227 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-index/mail-cache-lookup.c Log Message: ----------- lib-index: Fix potential assert-crash when reading cache Fixes: Panic: file mail-cache-lookup.c: line 258 (mail_cache_lookup_iter_next): assertion failed: (ctx->offset != 0) Broken by d33fc6c584718efd46159e1d8f46488b9dfc66f5 Compare: https://github.com/dovecot/core/compare/cca98b5accbf...96a4e105f7c9 From noreply at github.com Mon Oct 24 11:00:12 2016 From: noreply at github.com (GitHub) Date: Mon, 24 Oct 2016 04:00:12 -0700 Subject: [dovecot/core] 1c783b: lib-index: Fix potential error when reading from u... Message-ID: <580de9bc8a379_1d6d3fb91e59b13810592@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 1c783b6d9cbdf0cdb84507472f0aa6a50a1861cd https://github.com/dovecot/core/commit/1c783b6d9cbdf0cdb84507472f0aa6a50a1861cd Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-index/mail-cache-transaction.c Log Message: ----------- lib-index: Fix potential error when reading from uncommitted cache transaction If dovecot.index.cache is compressed during the transaction, the new cache fields mapping doesn't necessarily match what is in the transaction. Fixes: Error: Corrupted index cache file .../dovecot.index.cache: field index too large (27 >= 17) Although there may be other cache corruption errors it also fixes. From noreply at github.com Mon Oct 24 11:30:12 2016 From: noreply at github.com (GitHub) Date: Mon, 24 Oct 2016 04:30:12 -0700 Subject: [dovecot/core] f83fd8: lib: Add FILE_LOCK_SLOW_WARNING_MSECS environment. Message-ID: <580df0c4a247_45ca3fe233387138453f9@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f83fd83f9c6708d198748e714aa947cad9362c02 https://github.com/dovecot/core/commit/f83fd83f9c6708d198748e714aa947cad9362c02 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/file-dotlock.c M src/lib/file-lock.c M src/lib/file-lock.h Log Message: ----------- lib: Add FILE_LOCK_SLOW_WARNING_MSECS environment. Log a warning if any locking takes longer than the specified number of milliseconds. This can be enabled globally with: import_environment = $import_environment FILE_LOCK_SLOW_WARNING_MSECS=1000 Commit: d327ea02dc39399e8b231d0c833ed94c3be20bce https://github.com/dovecot/core/commit/d327ea02dc39399e8b231d0c833ed94c3be20bce Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/ioloop.c M src/lib/ioloop.h Log Message: ----------- lib: Added ioloop_global_wait_usecs This is helpful when multiple ioloops aren't used and io_loop_get_wait_usecs() can't be easily used for all of them. Commit: e55b5cf82e6d109c658e0b5049cae1ba8edd3b91 https://github.com/dovecot/core/commit/e55b5cf82e6d109c658e0b5049cae1ba8edd3b91 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Fix logging how much time was spent in other ioloops in slow lookup warnings. The warning's idea is to show why the lookup could have been slow. We differentiate between time spent in dict_wait() waiting only for the dict result and time spent in other ioloops waiting for potentially other things as well (and time spent waiting for locks during this time). The previous code didn't work right when multiple ioloops were used, which happened sometimes. Also changed %u to %d just in case some calculation is wrong. It's nicer to get a slightly negative value rather than a huge positive one. Commit: 86ab71bf134573e45dd9ab6bde9d55da4c44fc48 https://github.com/dovecot/core/commit/86ab71bf134573e45dd9ab6bde9d55da4c44fc48 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-http/http-client-connection.c M src/lib-http/http-client-private.h M src/lib-http/http-client-request.c Log Message: ----------- lib-http: Add ioloop and lock wait information to timeout messages. It'll now log for example: 9007 Request timed out (Request sent 7.087 secs ago, 0.076 in other ioloops, 7.012 in locks, connected 7.087 secs ago) Which points out that the problem wasn't really with the HTTP, but with locking. This likely should be fixed in some way also in lib-http so that it gives a bit of extra time for reading the request, but that's a separate fix. Compare: https://github.com/dovecot/core/compare/1c783b6d9cbd...86ab71bf1345 From noreply at github.com Mon Oct 24 11:30:17 2016 From: noreply at github.com (GitHub) Date: Mon, 24 Oct 2016 04:30:17 -0700 Subject: [dovecot/core] a64e49: director: Support flush socket Message-ID: <580df0c923839_6343fcf361d5138373f1@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: a64e49f98394012ccd41b80810da3c3a710b5d74 https://github.com/dovecot/core/commit/a64e49f98394012ccd41b80810da3c3a710b5d74 Author: Aki Tuomi Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/director/Makefile.am M src/director/director-settings.c M src/director/director-settings.h M src/director/director.c Log Message: ----------- director: Support flush socket This allows specifying an URI to execute on user kill. It can be of form exec:/path/to/bin, unix:/path/to/socket or tcp:ip:port The location is sent FLUSH username-hash per killed user. You can execute some action there, and you are expected to return '+\nOK\n' as reply once you are done. Commit: 0b94b5ac4ce47403ba6417b4f17420d13292759f https://github.com/dovecot/core/commit/0b94b5ac4ce47403ba6417b4f17420d13292759f Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Fix crash handling director_flush_socket when user is freed. Commit: 4397b24216ac3cd38f9cc9ebd44ed4d3f8d1e3cb https://github.com/dovecot/core/commit/4397b24216ac3cd38f9cc9ebd44ed4d3f8d1e3cb Author: Aki Tuomi Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/ioloop.c Log Message: ----------- lib: Ensure tv_r gets set in io_loop_get_wait_time If this does not get reset here to 0 it can cause errors or unpredictable behaviour in select/kqueue polling, such as very long delays. Commit: 0fe6b129cd5b5ff39970cb05312163cdfb394ef6 https://github.com/dovecot/core/commit/0fe6b129cd5b5ff39970cb05312163cdfb394ef6 Author: Aki Tuomi Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/ioloop-kqueue.c Log Message: ----------- lib: Fix kqueue io_loop_get_wait_time usage The code needs to take into consideration, when there is no IO to be waited, but possibly there is io_set_pending used, or just timeouts. Commit: 676e11491a3af80dcca0eb3e43618f3917d42927 https://github.com/dovecot/core/commit/676e11491a3af80dcca0eb3e43618f3917d42927 Author: Aki Tuomi Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/test-ioloop.c Log Message: ----------- lib: Add test for ioloop fd polling Commit: 60ae7391ca216adb3ba69471a240b859a3be8ba4 https://github.com/dovecot/core/commit/60ae7391ca216adb3ba69471a240b859a3be8ba4 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/master/service-process.c Log Message: ----------- master: If chrooted service's core wasn't dumped, suggest to unset the chroot. Commit: a07d6171ae7f9bcb416f12d1bb763f0a6dd7fdab https://github.com/dovecot/core/commit/a07d6171ae7f9bcb416f12d1bb763f0a6dd7fdab Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-index/mail-cache-lookup.c Log Message: ----------- lib-index: Fix potential assert-crash when reading cache Fixes: Panic: file mail-cache-lookup.c: line 258 (mail_cache_lookup_iter_next): assertion failed: (ctx->offset != 0) Broken by d33fc6c584718efd46159e1d8f46488b9dfc66f5 Commit: 3f4795112d13f80b4aff9051f5e68060a80a69bd https://github.com/dovecot/core/commit/3f4795112d13f80b4aff9051f5e68060a80a69bd Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-index/mail-cache-transaction.c Log Message: ----------- lib-index: Fix potential error when reading from uncommitted cache transaction If dovecot.index.cache is compressed during the transaction, the new cache fields mapping doesn't necessarily match what is in the transaction. Fixes: Error: Corrupted index cache file .../dovecot.index.cache: field index too large (27 >= 17) Although there may be other cache corruption errors it also fixes. Commit: 62ce1acee43b0f310f11f5134af035aa58a01451 https://github.com/dovecot/core/commit/62ce1acee43b0f310f11f5134af035aa58a01451 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/file-dotlock.c M src/lib/file-lock.c M src/lib/file-lock.h Log Message: ----------- lib: Add FILE_LOCK_SLOW_WARNING_MSECS environment. Log a warning if any locking takes longer than the specified number of milliseconds. This can be enabled globally with: import_environment = $import_environment FILE_LOCK_SLOW_WARNING_MSECS=1000 Commit: ba356aeff8ad25e66a0e24d588b5e5649e87d233 https://github.com/dovecot/core/commit/ba356aeff8ad25e66a0e24d588b5e5649e87d233 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/ioloop.c M src/lib/ioloop.h Log Message: ----------- lib: Added ioloop_global_wait_usecs This is helpful when multiple ioloops aren't used and io_loop_get_wait_usecs() can't be easily used for all of them. Commit: 240efa297b913351200371f56ae0d8d70d5f6f16 https://github.com/dovecot/core/commit/240efa297b913351200371f56ae0d8d70d5f6f16 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Fix logging how much time was spent in other ioloops in slow lookup warnings. The warning's idea is to show why the lookup could have been slow. We differentiate between time spent in dict_wait() waiting only for the dict result and time spent in other ioloops waiting for potentially other things as well (and time spent waiting for locks during this time). The previous code didn't work right when multiple ioloops were used, which happened sometimes. Also changed %u to %d just in case some calculation is wrong. It's nicer to get a slightly negative value rather than a huge positive one. Commit: 940795053b1818967ffc77f560fe2f2d49913b73 https://github.com/dovecot/core/commit/940795053b1818967ffc77f560fe2f2d49913b73 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-http/http-client-connection.c M src/lib-http/http-client-private.h M src/lib-http/http-client-request.c Log Message: ----------- lib-http: Add ioloop and lock wait information to timeout messages. It'll now log for example: 9007 Request timed out (Request sent 7.087 secs ago, 0.076 in other ioloops, 7.012 in locks, connected 7.087 secs ago) Which points out that the problem wasn't really with the HTTP, but with locking. This likely should be fixed in some way also in lib-http so that it gives a bit of extra time for reading the request, but that's a separate fix. Compare: https://github.com/dovecot/core/compare/d6c1b8c4c328...940795053b18 From noreply at github.com Mon Oct 24 13:30:10 2016 From: noreply at github.com (GitHub) Date: Mon, 24 Oct 2016 06:30:10 -0700 Subject: [dovecot/core] d54edc: lib: Fix compiler warnings in test-ioloop Message-ID: <580e0ce2cb806_223c3fb301f2d1381477f9@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: d54edc1ad7b71020f6726363308985e0658657fb https://github.com/dovecot/core/commit/d54edc1ad7b71020f6726363308985e0658657fb Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/test-ioloop.c Log Message: ----------- lib: Fix compiler warnings in test-ioloop Fixes: test-ioloop.c:72: error: ignoring return value of ?write?, declared with attribute warn_unused_result Commit: 43f6d195de7f26c137594374b96e43ede933205f https://github.com/dovecot/core/commit/43f6d195de7f26c137594374b96e43ede933205f Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M m4/ssl.m4 Log Message: ----------- configure: Fixed checking if OpenSSL is too old for lib-dcrypt EVP_PKEY_CTX_set_ec_paramgen_curve_nid() is a macro, so it can't be checked with AC_CHECK_LIB(). Compare: https://github.com/dovecot/core/compare/86ab71bf1345...43f6d195de7f From noreply at github.com Mon Oct 24 14:00:53 2016 From: noreply at github.com (GitHub) Date: Mon, 24 Oct 2016 07:00:53 -0700 Subject: [dovecot/core] cab3ca: lib: Fix compiler warnings in test-ioloop Message-ID: <580e14158f1f8_40e93fd663137134718d5@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: cab3ca184ac3be0c5fac349f2c2c4cb94e1eba92 https://github.com/dovecot/core/commit/cab3ca184ac3be0c5fac349f2c2c4cb94e1eba92 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/test-ioloop.c Log Message: ----------- lib: Fix compiler warnings in test-ioloop Fixes: test-ioloop.c:72: error: ignoring return value of ?write?, declared with attribute warn_unused_result Commit: 71ceef4ac10b054534759718f3bd2e8fe4d1ab68 https://github.com/dovecot/core/commit/71ceef4ac10b054534759718f3bd2e8fe4d1ab68 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M configure.ac Log Message: ----------- configure: Fixed checking if OpenSSL is too old for lib-dcrypt EVP_PKEY_CTX_set_ec_paramgen_curve_nid() is a macro, so it can't be checked with AC_CHECK_LIB(). Compare: https://github.com/dovecot/core/compare/940795053b18...71ceef4ac10b From noreply at github.com Mon Oct 24 14:31:09 2016 From: noreply at github.com (GitHub) Date: Mon, 24 Oct 2016 07:31:09 -0700 Subject: [dovecot/core] 1ea0aa: lib: With FILE_LOCK_SLOW_WARNING_MSECS log a warni... Message-ID: <580e1b2dd730e_47733ff1ed8fd13410901e@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 1ea0aa8e14e843f2776746776a429b0a1aae299d https://github.com/dovecot/core/commit/1ea0aa8e14e843f2776746776a429b0a1aae299d Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/file-lock.c Log Message: ----------- lib: With FILE_LOCK_SLOW_WARNING_MSECS log a warning also when keeping lock for long. This can help catching which process kept the lock for too long. Commit: bc06e3827e86250d24a7741c61f8582f1c1f7121 https://github.com/dovecot/core/commit/bc06e3827e86250d24a7741c61f8582f1c1f7121 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-compression/istream-zlib.c Log Message: ----------- istream-zlib: "missing gz trailer" error message was wrong. Compare: https://github.com/dovecot/core/compare/43f6d195de7f...bc06e3827e86 From noreply at github.com Mon Oct 24 14:31:14 2016 From: noreply at github.com (GitHub) Date: Mon, 24 Oct 2016 07:31:14 -0700 Subject: [dovecot/core] 5611e2: lib: With FILE_LOCK_SLOW_WARNING_MSECS log a warni... Message-ID: <580e1b3266e21_72513fa469801130978f7@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 5611e2339ea861ce0e354ada40d1fd25ba0425cc https://github.com/dovecot/core/commit/5611e2339ea861ce0e354ada40d1fd25ba0425cc Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/file-lock.c Log Message: ----------- lib: With FILE_LOCK_SLOW_WARNING_MSECS log a warning also when keeping lock for long. This can help catching which process kept the lock for too long. Commit: bee600bb342d9cc132e4279458a60731b2887211 https://github.com/dovecot/core/commit/bee600bb342d9cc132e4279458a60731b2887211 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-compression/istream-zlib.c Log Message: ----------- istream-zlib: "missing gz trailer" error message was wrong. Compare: https://github.com/dovecot/core/compare/71ceef4ac10b...bee600bb342d From noreply at github.com Mon Oct 24 16:30:10 2016 From: noreply at github.com (GitHub) Date: Mon, 24 Oct 2016 09:30:10 -0700 Subject: [dovecot/core] 0757cf: lib-compress: Don't assume too early that gz file ... Message-ID: <580e371256de5_2fb13fe88678d1348696d@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 0757cf450c35c2fe848106b652487785579a5162 https://github.com/dovecot/core/commit/0757cf450c35c2fe848106b652487785579a5162 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-compression/istream-zlib.c Log Message: ----------- lib-compress: Don't assume too early that gz file continues after a trailer. Some istreams don't have EOF immediately set after the gz trailer. This fixes errors like "missing gz trailer at 1675" Commit: 697a4fbe2d9cd776b8ceecb0c907a7ad55d3153e https://github.com/dovecot/core/commit/697a4fbe2d9cd776b8ceecb0c907a7ad55d3153e Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-compression/test-compression.c Log Message: ----------- lib-compression: Added file uncompression support for test-compression This can be useful for debugging. Commit: e7f31dfdcf5c51983bc4a489d69714f763128c18 https://github.com/dovecot/core/commit/e7f31dfdcf5c51983bc4a489d69714f763128c18 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-compression/test-compression.c Log Message: ----------- lib-compression: Added unit tests for reading .gz files Compare: https://github.com/dovecot/core/compare/bc06e3827e86...e7f31dfdcf5c From noreply at github.com Tue Oct 25 09:30:12 2016 From: noreply at github.com (GitHub) Date: Tue, 25 Oct 2016 02:30:12 -0700 Subject: [dovecot/core] 60cc5a: doveadm: Rewind input early enough Message-ID: <580f2624bfd4f_6ccc3fa28858b12c8885f@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 60cc5afcaef1fb9c6971d13254ba3de8d390e092 https://github.com/dovecot/core/commit/60cc5afcaef1fb9c6971d13254ba3de8d390e092 Author: Aki Tuomi Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/doveadm/doveadm-mail.c Log Message: ----------- doveadm: Rewind input early enough Command input needs to be rewinded earlier in doveadm_mail_next_user. From noreply at github.com Tue Oct 25 17:30:13 2016 From: noreply at github.com (GitHub) Date: Tue, 25 Oct 2016 10:30:13 -0700 Subject: [dovecot/core] f42024: imap-login: Skip NIL value in ID handler Message-ID: <580f96a553f5_4fdb3fb1a766f13c62134@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f42024ba93867e2424fafef878ed3c01914c6141 https://github.com/dovecot/core/commit/f42024ba93867e2424fafef878ed3c01914c6141 Author: Aki Tuomi Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/imap-login/imap-login-client.c Log Message: ----------- imap-login: Skip NIL value in ID handler NIL value can cause hard crash, depending what the key is. For x-proxy-ttl, NIL will crash on any system, x-originating-ip will crash on some nss versions (e.g. centos 6.7). Migitating factor here is that the NIL value is only accepted from trusted network. Commit: eb0cfb4f325faba850d85ee96ddec5ac6deedf89 https://github.com/dovecot/core/commit/eb0cfb4f325faba850d85ee96ddec5ac6deedf89 Author: Aki Tuomi Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-mail/mail-html2text.c Log Message: ----------- lib-mail: Support decimal/hexadecimal encoded entities Add support for &#nnn; and &#xnnn; entities. Commit: 1fce089d565e560450a25c3e901e066a50fdb6bf https://github.com/dovecot/core/commit/1fce089d565e560450a25c3e901e066a50fdb6bf Author: Aki Tuomi Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-mail/test-mail-html2text.c Log Message: ----------- lib-mail: Add tests for dec/hexdec encoded entities Compare: https://github.com/dovecot/core/compare/e7f31dfdcf5c...1fce089d565e From noreply at github.com Tue Oct 25 18:00:13 2016 From: noreply at github.com (GitHub) Date: Tue, 25 Oct 2016 11:00:13 -0700 Subject: [dovecot/core] 3c3001: director: Code cleanup - allow commands handlers t... Message-ID: <580f9dadee4aa_70d23fdd44bb513c2545d@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 3c3001681da75afc68578a180ec8f8b2d6dfacfa https://github.com/dovecot/core/commit/3c3001681da75afc68578a180ec8f8b2d6dfacfa Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Code cleanup - allow commands handlers to stop processing input Now returning 0 exits the input reading without disconnecting client. Commit: ffedd89747e11373c0dd3a172d3e94e0cf724fd7 https://github.com/dovecot/core/commit/ffedd89747e11373c0dd3a172d3e94e0cf724fd7 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h M src/director/main.c Log Message: ----------- director: Call state_change_callback on user move timeout. Commit: 3751234328db786e53680f4df21a4d10b446e252 https://github.com/dovecot/core/commit/3751234328db786e53680f4df21a4d10b446e252 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Code cleanup - Finish user move always in the same function. Commit: d3bae1f9d2448e5c398145ea250849ec12583845 https://github.com/dovecot/core/commit/d3bae1f9d2448e5c398145ea250849ec12583845 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h M src/director/main.c Log Message: ----------- director: Show in process title how many users are being moved. Commit: 9ba1a38e2fa5ffe9d0db83c4a14a6552bcff3181 https://github.com/dovecot/core/commit/9ba1a38e2fa5ffe9d0db83c4a14a6552bcff3181 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Code cleanup - moved command handling to its own function. Commit: 49ec317299dedfbc27be79ab97d5b7a8ba7a4eac https://github.com/dovecot/core/commit/49ec317299dedfbc27be79ab97d5b7a8ba7a4eac Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Make sure IP address parsing works in DIRECTOR-ADD/REMOVE We were passing the entire string through to net_addr2ip(). It seems that inet_aton() stops at whitespace though, so this wasn't actually causing errors at least on Linux. Commit: 60835f193436504acd13acc09928c4b4ff6934d8 https://github.com/dovecot/core/commit/60835f193436504acd13acc09928c4b4ff6934d8 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: USER-MOVE didn't handle non-hash username correctly. The entire command line was being hashed instead of just the username. Commit: 892e25e1c0caad62ced087d9eba2741a59e3d9ce https://github.com/dovecot/core/commit/892e25e1c0caad62ced087d9eba2741a59e3d9ce Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Code cleanup - Give tab-unescaped args to all doveadm command handlers. Commit: 67cb14c7fb54a031818228522dc7255d5cd00f0a https://github.com/dovecot/core/commit/67cb14c7fb54a031818228522dc7255d5cd00f0a Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director-host.h Log Message: ----------- director: If SYNCs are received during handshake, send them later. This fixes delays during handshake: Error: Ring SYNC appears to have got lost, resending Commit: a9ade104616bbb81c34cc6f8bfde5dab0571afac https://github.com/dovecot/core/commit/a9ade104616bbb81c34cc6f8bfde5dab0571afac Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c Log Message: ----------- director: Fix sending up/down state in handshakes. They were never sent, because HOSTs were sent before director had waited for the remote to send its version number. So sender thought that the remote's minor_version was too old and it didn't send the up/down state at all. This caused errors like: Warning: director(10.0.0.30:9090/left): Host 10.0.0.30 is being updated before previous update had finished (up -> down) - setting to state=down vhosts=100 Error: director(10.0.0.30:9090/left): Director 10.0.0.30 SYNC request hosts don't match us - resending hosts (seq=6, remote hosts_hash=262126213, my hosts_hash=2458934259) Commit: 3d76809be2f9f3b5b4110e58eae8613e7c1d6fb7 https://github.com/dovecot/core/commit/3d76809be2f9f3b5b4110e58eae8613e7c1d6fb7 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director: Invalid parameters cause doveadm to fail silently. doveadm_cmd_context.cmd doesn't point directly to doveadm_cmd_director. Commit: ade4a0e1a8f4bc3467f4fcff9c219558fe348abf https://github.com/dovecot/core/commit/ade4a0e1a8f4bc3467f4fcff9c219558fe348abf Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Log user's kill_state with a human-readable string. Commit: 3c89b4794ac52cc229b2b1dcec2324b490539c30 https://github.com/dovecot/core/commit/3c89b4794ac52cc229b2b1dcec2324b490539c30 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: If user move times out, log the state it was in at the time. Commit: 11ee3b40320a31669bd717fecbe1e332dad4fd84 https://github.com/dovecot/core/commit/11ee3b40320a31669bd717fecbe1e332dad4fd84 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c M src/director/doveadm-connection.h M src/director/main.c M src/director/user-directory.h Log Message: ----------- director: HOST-RESET-USERS moves users more slowly now. By default only 100 users can be moved in parallel. This can be overridden with HOST-RESET-USERS parameter. This delaying is especially useful when director_flush_socket is used to avoid huge floods to the script service. Even without the socket it's still good for avoiding unnecessary load spikes when all users are kicked at once and they reconnect back at the same time. Commit: b79120aa36d1b7935c9aef8b0a7cf3f1045a36ca https://github.com/dovecot/core/commit/b79120aa36d1b7935c9aef8b0a7cf3f1045a36ca Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director flush: Added --max-parallel parameter. Commit: fb9dfa9ea15abdbf248021cfb7bf2846410116e6 https://github.com/dovecot/core/commit/fb9dfa9ea15abdbf248021cfb7bf2846410116e6 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c Log Message: ----------- director: If user host conflict is detected, make sure new host is sent back. USER-KICK-HASH was sent, but the sender didn't get back a USER reply with the new host. This could have increased how long user's host differred in directors. Avoids repeating this error: Error: User hash 2957018085 is being redirected to two hosts: 10.0.0.30 and 10.0.0.201 (old_ts=1477338836) Commit: f9c76559302e6485f59ab0e6050b76fd6d268fee https://github.com/dovecot/core/commit/f9c76559302e6485f59ab0e6050b76fd6d268fee Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Prevent race conditions by adding USER_KILL_STATE_FLUSHING In theory it's possible that a user is freed during a flush and added back before flush is finished, possibly even being moved again. This check makes sure that we don't finish such move unless we're actually at the correct flushing state. (If there's another flush also running for the user it'll be ignored.) This is also useful for logging purposes. Commit: fd882f791279d0bb0cbf15ccec75cff9f6b399cc https://github.com/dovecot/core/commit/fd882f791279d0bb0cbf15ccec75cff9f6b399cc Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director.c Log Message: ----------- director: Fix user move hangs when another move is triggered early. Running "doveadm director flush" before the previous flush hadn't fully finished could have caused users to hang until their move timeout: director: Error: Finishing user 3249070169 move timed out, its state may now be inconsistent (state=waiting-for-everyone) Commit: 0874d7a4fa15322318c71291f0134ff7cc49bbb8 https://github.com/dovecot/core/commit/0874d7a4fa15322318c71291f0134ff7cc49bbb8 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director.c Log Message: ----------- director: Improve debug logging output. Commit: 6af8cc0573832465c621bcd91634e15461e8bf58 https://github.com/dovecot/core/commit/6af8cc0573832465c621bcd91634e15461e8bf58 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/user-directory.h Log Message: ----------- director: Execute director_flush_socket only from one director. Having each director do it would be redundant since they're all supposed to be performing the same flush task to the same backend. Commit: 3cbc0cb7c454ad5132dd335a7ae47bd6f5da2aa6 https://github.com/dovecot/core/commit/3cbc0cb7c454ad5132dd335a7ae47bd6f5da2aa6 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director dump: Fixed output to include LFs Otherwise all the output will be mixed up in the same line. Compare: https://github.com/dovecot/core/compare/1fce089d565e...3cbc0cb7c454 From noreply at github.com Tue Oct 25 18:30:10 2016 From: noreply at github.com (GitHub) Date: Tue, 25 Oct 2016 11:30:10 -0700 Subject: [dovecot/core] 9954af: director: Fix HOST-RESET-USERS with host parameter... Message-ID: <580fa4b29fb0c_58093f85c8c5113c453ba@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9954af4b72850a7c3158c99b444d49a529109c4d https://github.com/dovecot/core/commit/9954af4b72850a7c3158c99b444d49a529109c4d Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Fix HOST-RESET-USERS with host parameter. The logic was reversed: It should flush the specified host, not some other host. Broken by 11ee3b40320a31669bd717fecbe1e332dad4fd84 From noreply at github.com Tue Oct 25 18:30:15 2016 From: noreply at github.com (GitHub) Date: Tue, 25 Oct 2016 11:30:15 -0700 Subject: [dovecot/core] 446d84: lib-compress: Don't assume too early that gz file ... Message-ID: <580fa4b756b2a_65c93fd49d8ed134611cb@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 446d84d4d1d7eada12471916ae3b2c7eaa5e1bbb https://github.com/dovecot/core/commit/446d84d4d1d7eada12471916ae3b2c7eaa5e1bbb Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-compression/istream-zlib.c Log Message: ----------- lib-compress: Don't assume too early that gz file continues after a trailer. Some istreams don't have EOF immediately set after the gz trailer. This fixes errors like "missing gz trailer at 1675" Commit: 4b55ea6c3ba6d55a6d3598f234187ce778deccb9 https://github.com/dovecot/core/commit/4b55ea6c3ba6d55a6d3598f234187ce778deccb9 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-compression/test-compression.c Log Message: ----------- lib-compression: Added file uncompression support for test-compression This can be useful for debugging. Commit: 3c692ac90359d5872b33ae7f0239d8a8005539f6 https://github.com/dovecot/core/commit/3c692ac90359d5872b33ae7f0239d8a8005539f6 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-compression/test-compression.c Log Message: ----------- lib-compression: Added unit tests for reading .gz files Commit: 769240367c7c2d4bbc59162da8f6f5a8e92feb6d https://github.com/dovecot/core/commit/769240367c7c2d4bbc59162da8f6f5a8e92feb6d Author: Aki Tuomi Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/imap-login/imap-login-client.c Log Message: ----------- imap-login: Skip NIL value in ID handler NIL value can cause hard crash, depending what the key is. For x-proxy-ttl, NIL will crash on any system, x-originating-ip will crash on some nss versions (e.g. centos 6.7). Migitating factor here is that the NIL value is only accepted from trusted network. Commit: 74fc4d6fac6c2c7e17603b7741e4d72f9f5fa66d https://github.com/dovecot/core/commit/74fc4d6fac6c2c7e17603b7741e4d72f9f5fa66d Author: Aki Tuomi Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-mail/mail-html2text.c Log Message: ----------- lib-mail: Support decimal/hexadecimal encoded entities Add support for &#nnn; and &#xnnn; entities. Commit: a9b39bd30b2fc597232d703f66496436ce8e8a9f https://github.com/dovecot/core/commit/a9b39bd30b2fc597232d703f66496436ce8e8a9f Author: Aki Tuomi Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-mail/test-mail-html2text.c Log Message: ----------- lib-mail: Add tests for dec/hexdec encoded entities Commit: c98b47e54a6ff36066516efccb16dd44127e8a11 https://github.com/dovecot/core/commit/c98b47e54a6ff36066516efccb16dd44127e8a11 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Code cleanup - allow commands handlers to stop processing input Now returning 0 exits the input reading without disconnecting client. Commit: b99248eb9ad331e700734ac10be8ce7dfbdb5a95 https://github.com/dovecot/core/commit/b99248eb9ad331e700734ac10be8ce7dfbdb5a95 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h M src/director/main.c Log Message: ----------- director: Call state_change_callback on user move timeout. Commit: 4d0d0b9ebb304ecef10f48ef374d00dd75b681a5 https://github.com/dovecot/core/commit/4d0d0b9ebb304ecef10f48ef374d00dd75b681a5 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Code cleanup - Finish user move always in the same function. Commit: 4bc6ff052b650810685237f5c1341470e33cc6a9 https://github.com/dovecot/core/commit/4bc6ff052b650810685237f5c1341470e33cc6a9 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h M src/director/main.c Log Message: ----------- director: Show in process title how many users are being moved. Commit: 30a1cb8754bef11738cc176218b21d43555eb9fc https://github.com/dovecot/core/commit/30a1cb8754bef11738cc176218b21d43555eb9fc Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Code cleanup - moved command handling to its own function. Commit: b7d3b04efff252c1ffe5fada92717366f6965391 https://github.com/dovecot/core/commit/b7d3b04efff252c1ffe5fada92717366f6965391 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Make sure IP address parsing works in DIRECTOR-ADD/REMOVE We were passing the entire string through to net_addr2ip(). It seems that inet_aton() stops at whitespace though, so this wasn't actually causing errors at least on Linux. Commit: 9bf84e4140fe32e6a556d6156db7ce8b1e663ff4 https://github.com/dovecot/core/commit/9bf84e4140fe32e6a556d6156db7ce8b1e663ff4 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: USER-MOVE didn't handle non-hash username correctly. The entire command line was being hashed instead of just the username. Commit: d4845ae4564ba34e9e1082e233b554c521bb703e https://github.com/dovecot/core/commit/d4845ae4564ba34e9e1082e233b554c521bb703e Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Code cleanup - Give tab-unescaped args to all doveadm command handlers. Commit: 7322a8911f79677200c5df1ab6aab6d95f066ff9 https://github.com/dovecot/core/commit/7322a8911f79677200c5df1ab6aab6d95f066ff9 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director-host.h Log Message: ----------- director: If SYNCs are received during handshake, send them later. This fixes delays during handshake: Error: Ring SYNC appears to have got lost, resending Commit: 5a8bc5b29256e01c7f6c5b0b1a740576d79d45fb https://github.com/dovecot/core/commit/5a8bc5b29256e01c7f6c5b0b1a740576d79d45fb Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c Log Message: ----------- director: Fix sending up/down state in handshakes. They were never sent, because HOSTs were sent before director had waited for the remote to send its version number. So sender thought that the remote's minor_version was too old and it didn't send the up/down state at all. This caused errors like: Warning: director(10.0.0.30:9090/left): Host 10.0.0.30 is being updated before previous update had finished (up -> down) - setting to state=down vhosts=100 Error: director(10.0.0.30:9090/left): Director 10.0.0.30 SYNC request hosts don't match us - resending hosts (seq=6, remote hosts_hash=262126213, my hosts_hash=2458934259) Commit: e235070817370d41159cbd5f14b2ca27720d48bf https://github.com/dovecot/core/commit/e235070817370d41159cbd5f14b2ca27720d48bf Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director: Invalid parameters cause doveadm to fail silently. doveadm_cmd_context.cmd doesn't point directly to doveadm_cmd_director. Commit: e275b15161fd2eb4d23a7d99d4e72cb7acfae2a2 https://github.com/dovecot/core/commit/e275b15161fd2eb4d23a7d99d4e72cb7acfae2a2 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Log user's kill_state with a human-readable string. Commit: 535c94c686520f4dc19cee94306104f9c0cec5dd https://github.com/dovecot/core/commit/535c94c686520f4dc19cee94306104f9c0cec5dd Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: If user move times out, log the state it was in at the time. Commit: 4a9870f2bb188d9cfa20e9576a8812368ddefd9e https://github.com/dovecot/core/commit/4a9870f2bb188d9cfa20e9576a8812368ddefd9e Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c M src/director/doveadm-connection.h M src/director/main.c M src/director/user-directory.h Log Message: ----------- director: HOST-RESET-USERS moves users more slowly now. By default only 100 users can be moved in parallel. This can be overridden with HOST-RESET-USERS parameter. This delaying is especially useful when director_flush_socket is used to avoid huge floods to the script service. Even without the socket it's still good for avoiding unnecessary load spikes when all users are kicked at once and they reconnect back at the same time. Commit: 2e52280f8738ebf0739fa3e72e515e28a7bd27c3 https://github.com/dovecot/core/commit/2e52280f8738ebf0739fa3e72e515e28a7bd27c3 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director flush: Added --max-parallel parameter. Commit: 50d96a7656432f1c22014664798ed98a2647bc67 https://github.com/dovecot/core/commit/50d96a7656432f1c22014664798ed98a2647bc67 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c Log Message: ----------- director: If user host conflict is detected, make sure new host is sent back. USER-KICK-HASH was sent, but the sender didn't get back a USER reply with the new host. This could have increased how long user's host differred in directors. Avoids repeating this error: Error: User hash 2957018085 is being redirected to two hosts: 10.0.0.30 and 10.0.0.201 (old_ts=1477338836) Commit: 50d882ded1a22d5d8e286bada75aeecfa0258ac9 https://github.com/dovecot/core/commit/50d882ded1a22d5d8e286bada75aeecfa0258ac9 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Prevent race conditions by adding USER_KILL_STATE_FLUSHING In theory it's possible that a user is freed during a flush and added back before flush is finished, possibly even being moved again. This check makes sure that we don't finish such move unless we're actually at the correct flushing state. (If there's another flush also running for the user it'll be ignored.) This is also useful for logging purposes. Commit: 9eba5d4ca4ac239115bf21456b82fc07c342167a https://github.com/dovecot/core/commit/9eba5d4ca4ac239115bf21456b82fc07c342167a Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director.c Log Message: ----------- director: Fix user move hangs when another move is triggered early. Running "doveadm director flush" before the previous flush hadn't fully finished could have caused users to hang until their move timeout: director: Error: Finishing user 3249070169 move timed out, its state may now be inconsistent (state=waiting-for-everyone) Commit: b59011b74dbfc8904f78ed513ec39f68cba58db6 https://github.com/dovecot/core/commit/b59011b74dbfc8904f78ed513ec39f68cba58db6 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director.c Log Message: ----------- director: Improve debug logging output. Commit: 58722083c71c2372e6ffc22ff203f32c265c8c65 https://github.com/dovecot/core/commit/58722083c71c2372e6ffc22ff203f32c265c8c65 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/user-directory.h Log Message: ----------- director: Execute director_flush_socket only from one director. Having each director do it would be redundant since they're all supposed to be performing the same flush task to the same backend. Commit: 7929dac291e26cec6c4f256670a0651ae980f67e https://github.com/dovecot/core/commit/7929dac291e26cec6c4f256670a0651ae980f67e Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director dump: Fixed output to include LFs Otherwise all the output will be mixed up in the same line. Compare: https://github.com/dovecot/core/compare/60cc5afcaef1...7929dac291e2 From noreply at github.com Tue Oct 25 20:30:14 2016 From: noreply at github.com (GitHub) Date: Tue, 25 Oct 2016 13:30:14 -0700 Subject: [dovecot/core] ccb431: director: Fix HOST-RESET-USERS with host parameter... Message-ID: <580fc0d651fd5_78913fe5e06f9130425df@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: ccb431749072ef0e964f8780927276f2009d02a8 https://github.com/dovecot/core/commit/ccb431749072ef0e964f8780927276f2009d02a8 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Fix HOST-RESET-USERS with host parameter. The logic was reversed: It should flush the specified host, not some other host. Broken by 11ee3b40320a31669bd717fecbe1e332dad4fd84 From noreply at github.com Tue Oct 25 21:00:10 2016 From: noreply at github.com (GitHub) Date: Tue, 25 Oct 2016 14:00:10 -0700 Subject: [dovecot/core] b1d5d6: lib-lda: Add back subject sanitization to mail sen... Message-ID: <580fc7da92aad_6f9e3fde05def13412779@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b1d5d687ddc3ebf65b9416c435321062e57c98b9 https://github.com/dovecot/core/commit/b1d5d687ddc3ebf65b9416c435321062e57c98b9 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-lda/mail-send.c Log Message: ----------- lib-lda: Add back subject sanitization to mail sending. Broken by acfda38b75d0f0e899ef692fef01593bd56ed85e From noreply at github.com Wed Oct 26 10:00:12 2016 From: noreply at github.com (GitHub) Date: Wed, 26 Oct 2016 03:00:12 -0700 Subject: [dovecot/core] c13fce: director: Code cleanup - move enum user_kill_state... Message-ID: <58107eac27c38_714b3fcd8c4c91389734e@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: c13fce16374a6fa8d127742c527498d38e777789 https://github.com/dovecot/core/commit/c13fce16374a6fa8d127742c527498d38e777789 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Code cleanup - move enum user_kill_state to director.h This will be needed by following commits Commit: 79ee504bdf920f01e12e28f238799bf2616489df https://github.com/dovecot/core/commit/79ee504bdf920f01e12e28f238799bf2616489df Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director-request.c M src/director/director.c M src/director/doveadm-connection.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Code cleanup - added USER_IS_BEING_KILLED() macro Commit: 778a9861ee39eb23ec443a03cde832e3e31d7d37 https://github.com/dovecot/core/commit/778a9861ee39eb23ec443a03cde832e3e31d7d37 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Code cleanup - rename director_kill_context.self to kill_is_self_initiated Commit: 1b7cd57585d8c2f133dd612d2d5d9c775595659f https://github.com/dovecot/core/commit/1b7cd57585d8c2f133dd612d2d5d9c775595659f Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director.c M src/director/director.h M src/director/test-user-directory.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Moved all user killing state to struct director_kill_context This should make it a bit easier to understand the life time of user killing. It also simplifies code by removing struct director_user_kill_finish_ctx. Finally, this already reduces memory usage with 32bit systems, and would make it possible to reduce also on 64bit systems if timestamp is shrank to 31 bits and weak bit moved after it. I'm not sure if that would be better for performance though. In any case it would provide free space for 4 extra bytes if that were needed in future. Commit: 8cafec427a378daf68c253929232d498509d548c https://github.com/dovecot/core/commit/8cafec427a378daf68c253929232d498509d548c Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.h M src/director/main.c Log Message: ----------- director: Code cleanup - global director is no longer needed. Commit: 3404b66f3fda78955be9b6891ce5f5d6e13ef97a https://github.com/dovecot/core/commit/3404b66f3fda78955be9b6891ce5f5d6e13ef97a Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Code cleanup - moved user kill startup to its own function. No functional changes. Commit: aad23ef1531748997776e50a5272a2fc8e022f04 https://github.com/dovecot/core/commit/aad23ef1531748997776e50a5272a2fc8e022f04 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: User move - Don't try to kick user's connections if user wasn't even known. Commit: b93ec4e5b569e1216d0c7a6f28cbdccfe4fb32ca https://github.com/dovecot/core/commit/b93ec4e5b569e1216d0c7a6f28cbdccfe4fb32ca Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h Log Message: ----------- director: Send user's old and new backend IPs to flush script. If user was created due to the user-move, don't execute the flush script since it wouldn't really have any work to do anyway. Commit: faa01447c2f699b63ceccf129430a9ed46458083 https://github.com/dovecot/core/commit/faa01447c2f699b63ceccf129430a9ed46458083 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/main.c Log Message: ----------- director: Avoid assert-crash at deinit if user moves are still being added. Fixes: Panic: file user-directory.c: line 312 (user_directory_deinit): assertion failed: (array_count(&dir->iters) == 0) Commit: ec186c47c50bafcb66c5ac183b390c023cdf3fe5 https://github.com/dovecot/core/commit/ec186c47c50bafcb66c5ac183b390c023cdf3fe5 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/doveadm/doveadm-print-pager.c Log Message: ----------- doveadm: "pager" formatter supports now DOVEADM_PRINT_HEADER_FLAG_HIDE_TITLE Commit: a4a7440a1033203c48d5f0174b3d85514b79f3a0 https://github.com/dovecot/core/commit/a4a7440a1033203c48d5f0174b3d85514b79f3a0 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/doveadm/doveadm-mail-fetch.c M src/doveadm/doveadm-master.c M src/doveadm/doveadm-print-pager.c M src/doveadm/doveadm-print.h Log Message: ----------- doveadm: Code cleanup - add and use DOVEADM_PRINT_TYPE_PAGER macro Commit: f65486adb62eb4c817cfad2deaf8befea3012787 https://github.com/dovecot/core/commit/f65486adb62eb4c817cfad2deaf8befea3012787 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/doveadm/doveadm-fs.c Log Message: ----------- doveadm fs get: Use pager formatter by default to avoid extra LF at the end. Compare: https://github.com/dovecot/core/compare/b1d5d687ddc3...f65486adb62e From noreply at github.com Wed Oct 26 10:11:39 2016 From: noreply at github.com (GitHub) Date: Wed, 26 Oct 2016 03:11:39 -0700 Subject: [dovecot/core] d7b997: lib-program-client: Use restrict-access Message-ID: <5810815b29ca2_558b3f8f6f93513c67550@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/release-2.2.26 Home: https://github.com/dovecot/core Commit: d7b99734f301f0adce551fc9046c2b80a96a5e90 https://github.com/dovecot/core/commit/d7b99734f301f0adce551fc9046c2b80a96a5e90 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client.h M src/lib-program-client/test-program-client-local.c M src/lib-program-client/test-program-client-remote.c Log Message: ----------- lib-program-client: Use restrict-access This makes the program-client execution behave more consistent to the rest of the core code. Commit: 658ef8bb6209db4f8c9824d1f99731210b8450c1 https://github.com/dovecot/core/commit/658ef8bb6209db4f8c9824d1f99731210b8450c1 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Disconnect asynchronously Commit: ddc8331f7096aa30b00aa2359248c4e8db20ddb8 https://github.com/dovecot/core/commit/ddc8331f7096aa30b00aa2359248c4e8db20ddb8 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Use child-wait This makes the client waiting asynchronous. Commit: a178ab56f1034a9eefd652900fcedbe6b8d1cd8f https://github.com/dovecot/core/commit/a178ab56f1034a9eefd652900fcedbe6b8d1cd8f Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client.c M src/lib-program-client/program-client.h M src/lib-program-client/test-program-client-local.c M src/lib-program-client/test-program-client-remote.c Log Message: ----------- lib-program-client: Use milliseconds in idle timeout Commit: 3335722090c3ebd66f60d38eecb7b7ccb9418b0c https://github.com/dovecot/core/commit/3335722090c3ebd66f60d38eecb7b7ccb9418b0c Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-private.h M src/lib-program-client/program-client-remote.c M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Add switch_ioloop vfunc This lets program-client backends do their own special io loop switching. Commit: f61107a1ecb84192d85e965243577eb117888a0b https://github.com/dovecot/core/commit/f61107a1ecb84192d85e965243577eb117888a0b Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-remote.c Log Message: ----------- lib-program-client: Move version string to define Commit: f805039c1bb0be2e3737170770af93853c16a28c https://github.com/dovecot/core/commit/f805039c1bb0be2e3737170770af93853c16a28c Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/Makefile.am Log Message: ----------- lib-program-client: Disable valgrind For local test, we can't use valgrind, it's too unreliable (breaks execution sometimes). Commit: 2973fd23b651773980c3ea683fa8a6a4fa3508a9 https://github.com/dovecot/core/commit/2973fd23b651773980c3ea683fa8a6a4fa3508a9 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/Makefile.am M src/lib-program-client/test-program-client-local.c Log Message: ----------- lib-program-client: Fix local tests Commit: 39d56312ab51569502bad28e935a20c2006ac6a3 https://github.com/dovecot/core/commit/39d56312ab51569502bad28e935a20c2006ac6a3 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-remote.c Log Message: ----------- lib-program-client: Backport test-program-client-unix Commit: ffab4d100a52928c2e594f40ee81ae97284d14df https://github.com/dovecot/core/commit/ffab4d100a52928c2e594f40ee81ae97284d14df Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Fix memory access problem Commit: f7cb342e86299709f113224f5784b00418c1e700 https://github.com/dovecot/core/commit/f7cb342e86299709f113224f5784b00418c1e700 Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M doc/example-config/dovecot-ldap.conf.ext Log Message: ----------- dovecot-ldap.conf.ext: Updated sasl_bind comment. Commit: 6ca2eff8befb4e2e2623bdebb60a052ca2859d4d https://github.com/dovecot/core/commit/6ca2eff8befb4e2e2623bdebb60a052ca2859d4d Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/plugins/push-notification/push-notification-driver-ox.c Log Message: ----------- push-notification: Error handling fix and cleanups. Commit: 6f04fb1265453f991995361d0aba515cbaae7685 https://github.com/dovecot/core/commit/6f04fb1265453f991995361d0aba515cbaae7685 Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M .gitignore Log Message: ----------- .gitignore: Updated to include auto-added m4/* Commit: 9477b299d1912399f0457c1533e803c7d7986d39 https://github.com/dovecot/core/commit/9477b299d1912399f0457c1533e803c7d7986d39 Author: Josef 'Jeff' Sipek Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-storage/mailbox-list.c Log Message: ----------- lib-storage: clean up mailbox_list_create to improve readability There is no reason to use mailbox_list_driver_find() here instead of mailbox_list_find_class() as (1) we do not need the index into the list driver array, and (2) dealing with double-pointers is harder than regular pointers. Commit: 6f8a425df95963cade66aaeb4f651ef710038583 https://github.com/dovecot/core/commit/6f8a425df95963cade66aaeb4f651ef710038583 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib/restrict-access.c M src/lib/restrict-access.h Log Message: ----------- lib: Add drop_setuid_root for restrict_access drop_setuid_root, when set to true, will detect and try to drop getuid()==0. This is done by recovering current effective UID to set->uid if set->uid == -1, and then doing seteuid(0). It will also drop out any other extra privileges, such as extra groups not requested for. Commit: 1d457281aa12f4b23d009740e0d417b69bc7ce4d https://github.com/dovecot/core/commit/1d457281aa12f4b23d009740e0d417b69bc7ce4d Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c Log Message: ----------- lib-program-client: Try drop setuid root by default But not if root privileges are asked for. Commit: ca44dad11c67b377c6a82edebc01d1a4dc3d06f5 https://github.com/dovecot/core/commit/ca44dad11c67b377c6a82edebc01d1a4dc3d06f5 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib/restrict-access.c Log Message: ----------- lib: Copy target_uid from restrict_access_settings One cannot assign to set->uid, causing compile error. Commit: b18b618bedd860622731786039deeb4c229b6468 https://github.com/dovecot/core/commit/b18b618bedd860622731786039deeb4c229b6468 Author: Aki Tuomi Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M src/lib-program-client/program-client-remote.c Log Message: ----------- lib-program-client: Correctly handle error code Commit: 3a609904d003e4f652ddcf5bd44546af2659f820 https://github.com/dovecot/core/commit/3a609904d003e4f652ddcf5bd44546af2659f820 Author: Timo Sirainen Date: 2016-10-19 (Wed, 19 Oct 2016) Changed paths: M NEWS M configure.ac Log Message: ----------- v2.2.26.rc1 released. Commit: 9382f66f7667f1017e080673abd1ee2312cfa4b9 https://github.com/dovecot/core/commit/9382f66f7667f1017e080673abd1ee2312cfa4b9 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/login-common/login-proxy.c Log Message: ----------- login proxy: Hanging outgoing SSL connections caused using already-freed memory This mainly happened when login proxy closed the connection due to connect timeout. The ssl-proxy still had a reference and existed for a longer time. If SSL handshake still succeeded afterwards, it now called login_proxy_ssl_handshaked(), which accessed the already-freed proxy and likely crashed. Fixed the ssl-client proxy code specifically. Alternatively ssl_proxy_free() could be calling ssl_proxy_destroy() always, but since ssl-server side of the code seems to have been working fine, I don't want to accidentally break it. Commit: 25c5596ddc13644f9334109ce14b7567e4eef321 https://github.com/dovecot/core/commit/25c5596ddc13644f9334109ce14b7567e4eef321 Author: Aki Tuomi Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/auth/auth-request-var-expand.c M src/auth/auth-request-var-expand.h M src/auth/auth-request.c M src/auth/auth-request.h M src/lib-auth/auth-client-request.c M src/lib-auth/auth-client.h M src/login-common/client-common.h M src/login-common/login-settings.c M src/login-common/sasl-server.c M src/login-common/ssl-proxy-openssl.c Log Message: ----------- auth: Pass local_name to auth-request This allows using local_name in various places, such as passdb/userdb queries. Commit: 0718145c5340bd3441fff5f9af49669a018fd249 https://github.com/dovecot/core/commit/0718145c5340bd3441fff5f9af49669a018fd249 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/client-connection-http.c M src/doveadm/client-connection-private.h M src/doveadm/client-connection.c M src/doveadm/client-connection.h M src/doveadm/doveadm.h M src/doveadm/main.c Log Message: ----------- doveadm-server: Show incoming connection's IP and running command is process title. Commit: 7de00b5cfd95e384bd63ac7a36805c4a755074d5 https://github.com/dovecot/core/commit/7de00b5cfd95e384bd63ac7a36805c4a755074d5 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-auth.c Log Message: ----------- doveadm user: If lookup fails, don't write it to the same line as header. Commit: a96aaf10c1af81cbfbed16eef2abd66ed78e43b8 https://github.com/dovecot/core/commit/a96aaf10c1af81cbfbed16eef2abd66ed78e43b8 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/Makefile.am M src/doveadm/doveadm-master.c R src/doveadm/doveadm-service.c Log Message: ----------- doveadm service stop: Moved command handling to doveadm-master.c It's talking to master process, and there will be other non-service commands that talk to the master process in the same way. Commit: a22bb52f6bb8157816f57f5ba577eca980ff1f69 https://github.com/dovecot/core/commit/a22bb52f6bb8157816f57f5ba577eca980ff1f69 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-master.c Log Message: ----------- doveadm service stop: Code cleanup - Prepare for other service commands. Commit: b6c6b081cb4258d5e1bf1587046ba02fe8d180f0 https://github.com/dovecot/core/commit/b6c6b081cb4258d5e1bf1587046ba02fe8d180f0 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-master.c Log Message: ----------- doveadm service stop: Convert to doveadm v2 API Commit: 0269442eea4b5d6daea5a20a21d25b8632dad53e https://github.com/dovecot/core/commit/0269442eea4b5d6daea5a20a21d25b8632dad53e Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-master.c Log Message: ----------- doveadm-master: Code cleanup - simplify sending command args to master. This also escapes the parameters to make sure nothing bad can be sent. Commit: 6cae1f3ed624de9fa76aa0e64ab9cff3132f83e3 https://github.com/dovecot/core/commit/6cae1f3ed624de9fa76aa0e64ab9cff3132f83e3 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm-cmd.h M src/doveadm/doveadm-master.c M src/master/master-client.c Log Message: ----------- Added "doveadm service status" This allows asking for services' current status in master process. Commit: c4e6628eb7ea3ccaf5d4dbbb645e701ca791a589 https://github.com/dovecot/core/commit/c4e6628eb7ea3ccaf5d4dbbb645e701ca791a589 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm-cmd.h M src/doveadm/doveadm-master.c M src/master/master-client.c Log Message: ----------- Added "doveadm process status" This allows asking for processes' current status in master process. Commit: 81ccedb6284788bf27d947ef03851c700eef2b79 https://github.com/dovecot/core/commit/81ccedb6284788bf27d947ef03851c700eef2b79 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/auth/auth-request-handler.c Log Message: ----------- auth: Fixed assert-crash on invalid auth-client input For example if client sends invalid input like: auth: Error: BUG: Authentication client sent unknown command: XYZ Fixes crash: auth: Panic: key not found from hash Commit: fea477ac41324562e7c18385404dd63180a5b0a6 https://github.com/dovecot/core/commit/fea477ac41324562e7c18385404dd63180a5b0a6 Author: Stephan Bosch Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib-program-client/program-client-local.c Log Message: ----------- lib-program-client: Fixed boolean expressions. Problems found with clang -Wstrict-bool. Commit: af244a711b4a6203e869107b6b08504d1e9b04bf https://github.com/dovecot/core/commit/af244a711b4a6203e869107b6b08504d1e9b04bf Author: Aki Tuomi Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/login-common/client-common.c Log Message: ----------- login-common: Include local_name in login_var_expand_table This way it can be used in login_log_format Commit: 065efd7cd1a5f5c6ae19946b78c90a3f40f856cc https://github.com/dovecot/core/commit/065efd7cd1a5f5c6ae19946b78c90a3f40f856cc Author: Aki Tuomi Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/auth/auth-request.c M src/lib-auth/auth-client-request.c Log Message: ----------- auth: Escape local_name Commit: 2202915ace9fa63a8daefa0ed017730548276765 https://github.com/dovecot/core/commit/2202915ace9fa63a8daefa0ed017730548276765 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/lib-ldap/ldap-search.c Log Message: ----------- lib-ldap: Fixed compiling with OpenBSD Commit: 7205301604b812e174a5e44d1013f59984937a86 https://github.com/dovecot/core/commit/7205301604b812e174a5e44d1013f59984937a86 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c M src/lib-storage/mail-storage-service.c M src/lib-storage/mail-user.c Log Message: ----------- %{auth_domain} shouldn't include the leading '@' Commit: 9227c6f2040f426a79807fbac3e55d44c749d85b https://github.com/dovecot/core/commit/9227c6f2040f426a79807fbac3e55d44c749d85b Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M src/pop3/pop3-client.c Log Message: ----------- pop3: Fix pop3_logout_format=%{deleted_size} expansion when there are no deletions Should be "0", not empty string. Commit: a626baeb59472238bf2f9347535f055b77a30e77 https://github.com/dovecot/core/commit/a626baeb59472238bf2f9347535f055b77a30e77 Author: Stephan Bosch Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M dovecot.m4 Log Message: ----------- Added LIBDOVECOT_PUSH_NOTIFICATION_INCLUDE to dovecot.m4. Commit: 62701b0a18e5e18b0999506f829959b48d98c870 https://github.com/dovecot/core/commit/62701b0a18e5e18b0999506f829959b48d98c870 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M Makefile.am R cc-wrapper.sh.in M configure.ac M dovecot.m4 Log Message: ----------- Moved cc-wrapper.sh handling to dovecot.m4 When configuring Dovecot --without-shared-libs and pointing external plugins to uninstalled sources --with-dovecot, any binaries complied for plugins weren't using cc-wrapper.sh, which could have caused runtime failures when they attempted to load plugins dynamically. Now it's possible to add DC_CC_WRAPPER to plugins' configure.ac to build with the cc-wrapper.sh. Commit: 117e3b142a695e8b2dab6c11e996a4940f2971d2 https://github.com/dovecot/core/commit/117e3b142a695e8b2dab6c11e996a4940f2971d2 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M Makefile.am M dovecot-config.in.in M dovecot.m4 Log Message: ----------- dovecot-config: Added dovecot_statedir Commit: 57b6ff90e6a04e03ad2b7035fd8fa4dee4423564 https://github.com/dovecot/core/commit/57b6ff90e6a04e03ad2b7035fd8fa4dee4423564 Author: Timo Sirainen Date: 2016-10-20 (Thu, 20 Oct 2016) Changed paths: M dovecot.m4 Log Message: ----------- dovecot.m4: Added DOVECOT_BINARY_LDFLAGS for future compatibility Mainly to keep the serial number the same in v2.2 and v2.3 tree. Commit: 9af3c0b71a3bfe361e101cf82c569485a998ba1c https://github.com/dovecot/core/commit/9af3c0b71a3bfe361e101cf82c569485a998ba1c Author: Timo Sirainen Date: 2016-10-22 (Sat, 22 Oct 2016) Changed paths: M configure.ac Log Message: ----------- configure: Improved checking if OpenSSL is too old for lib-dcrypt Some OpenSSL versions had EC_KEY_new, but not other needed functions. Commit: 959c2cf5c0468a11c8918a18a63a4690bfd3fce1 https://github.com/dovecot/core/commit/959c2cf5c0468a11c8918a18a63a4690bfd3fce1 Author: Aki Tuomi Date: 2016-10-22 (Sat, 22 Oct 2016) Changed paths: M src/lib-program-client/program-client.c M src/lib-program-client/program-client.h Log Message: ----------- lib-program-client: Add URI based constructor Commit: c8a3c8cacd7fbe06171c25d52a638a0a440e441c https://github.com/dovecot/core/commit/c8a3c8cacd7fbe06171c25d52a638a0a440e441c Author: Aki Tuomi Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/director/Makefile.am M src/director/director-settings.c M src/director/director-settings.h M src/director/director.c Log Message: ----------- director: Support flush socket This allows specifying an URI to execute on user kill. It can be of form exec:/path/to/bin, unix:/path/to/socket or tcp:ip:port The location is sent FLUSH username-hash per killed user. You can execute some action there, and you are expected to return '+\nOK\n' as reply once you are done. Commit: bdda7143ac287cb79effe682985f505df30f5bd7 https://github.com/dovecot/core/commit/bdda7143ac287cb79effe682985f505df30f5bd7 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Fix crash handling director_flush_socket when user is freed. Commit: 4fd7c077a14c985e710fccdb1fabc9e4c83de761 https://github.com/dovecot/core/commit/4fd7c077a14c985e710fccdb1fabc9e4c83de761 Author: Aki Tuomi Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/ioloop.c Log Message: ----------- lib: Ensure tv_r gets set in io_loop_get_wait_time If this does not get reset here to 0 it can cause errors or unpredictable behaviour in select/kqueue polling, such as very long delays. Commit: 6f8bf90ad4e759334756e004267466c7faaa1a26 https://github.com/dovecot/core/commit/6f8bf90ad4e759334756e004267466c7faaa1a26 Author: Aki Tuomi Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/ioloop-kqueue.c Log Message: ----------- lib: Fix kqueue io_loop_get_wait_time usage The code needs to take into consideration, when there is no IO to be waited, but possibly there is io_set_pending used, or just timeouts. Commit: 54a8e37c755ff4316f397dbdcb11e6111fa0e845 https://github.com/dovecot/core/commit/54a8e37c755ff4316f397dbdcb11e6111fa0e845 Author: Aki Tuomi Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/test-ioloop.c Log Message: ----------- lib: Add test for ioloop fd polling Commit: bffa0a2936d273096f06f2428e91f82baccade46 https://github.com/dovecot/core/commit/bffa0a2936d273096f06f2428e91f82baccade46 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/master/service-process.c Log Message: ----------- master: If chrooted service's core wasn't dumped, suggest to unset the chroot. Commit: d0a2dd56e41248e9cf497c21aeedd123fd6646e0 https://github.com/dovecot/core/commit/d0a2dd56e41248e9cf497c21aeedd123fd6646e0 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-index/mail-cache-lookup.c Log Message: ----------- lib-index: Fix potential assert-crash when reading cache Fixes: Panic: file mail-cache-lookup.c: line 258 (mail_cache_lookup_iter_next): assertion failed: (ctx->offset != 0) Broken by d33fc6c584718efd46159e1d8f46488b9dfc66f5 Commit: a4e044d1934a63c3fbe271d27136fae8512637bf https://github.com/dovecot/core/commit/a4e044d1934a63c3fbe271d27136fae8512637bf Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-index/mail-cache-transaction.c Log Message: ----------- lib-index: Fix potential error when reading from uncommitted cache transaction If dovecot.index.cache is compressed during the transaction, the new cache fields mapping doesn't necessarily match what is in the transaction. Fixes: Error: Corrupted index cache file .../dovecot.index.cache: field index too large (27 >= 17) Although there may be other cache corruption errors it also fixes. Commit: 8923deec4c5361cb9090c9b5d3c4e5c173bdc640 https://github.com/dovecot/core/commit/8923deec4c5361cb9090c9b5d3c4e5c173bdc640 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/file-dotlock.c M src/lib/file-lock.c M src/lib/file-lock.h Log Message: ----------- lib: Add FILE_LOCK_SLOW_WARNING_MSECS environment. Log a warning if any locking takes longer than the specified number of milliseconds. This can be enabled globally with: import_environment = $import_environment FILE_LOCK_SLOW_WARNING_MSECS=1000 Commit: f820a25aa0e27a087a3b7085f75165b65a7f67b8 https://github.com/dovecot/core/commit/f820a25aa0e27a087a3b7085f75165b65a7f67b8 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/ioloop.c M src/lib/ioloop.h Log Message: ----------- lib: Added ioloop_global_wait_usecs This is helpful when multiple ioloops aren't used and io_loop_get_wait_usecs() can't be easily used for all of them. Commit: 1bea846fbfbf7a5cf78e33f11ced03b86b2349a4 https://github.com/dovecot/core/commit/1bea846fbfbf7a5cf78e33f11ced03b86b2349a4 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-dict/dict-client.c Log Message: ----------- dict-client: Fix logging how much time was spent in other ioloops in slow lookup warnings. The warning's idea is to show why the lookup could have been slow. We differentiate between time spent in dict_wait() waiting only for the dict result and time spent in other ioloops waiting for potentially other things as well (and time spent waiting for locks during this time). The previous code didn't work right when multiple ioloops were used, which happened sometimes. Also changed %u to %d just in case some calculation is wrong. It's nicer to get a slightly negative value rather than a huge positive one. Commit: 50ce4f6ed21fdb2b2b3bde5f41ccac825418b13f https://github.com/dovecot/core/commit/50ce4f6ed21fdb2b2b3bde5f41ccac825418b13f Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-http/http-client-connection.c M src/lib-http/http-client-private.h M src/lib-http/http-client-request.c Log Message: ----------- lib-http: Add ioloop and lock wait information to timeout messages. It'll now log for example: 9007 Request timed out (Request sent 7.087 secs ago, 0.076 in other ioloops, 7.012 in locks, connected 7.087 secs ago) Which points out that the problem wasn't really with the HTTP, but with locking. This likely should be fixed in some way also in lib-http so that it gives a bit of extra time for reading the request, but that's a separate fix. Commit: 89507f4c78191a636f54de651e726507d5a5fc26 https://github.com/dovecot/core/commit/89507f4c78191a636f54de651e726507d5a5fc26 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/test-ioloop.c Log Message: ----------- lib: Fix compiler warnings in test-ioloop Fixes: test-ioloop.c:72: error: ignoring return value of ?write?, declared with attribute warn_unused_result Commit: ce9e46fe64054dd958da9a02f82838977a4c6a7c https://github.com/dovecot/core/commit/ce9e46fe64054dd958da9a02f82838977a4c6a7c Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M configure.ac Log Message: ----------- configure: Fixed checking if OpenSSL is too old for lib-dcrypt EVP_PKEY_CTX_set_ec_paramgen_curve_nid() is a macro, so it can't be checked with AC_CHECK_LIB(). Commit: b909e9579d72684faaebbe3189cab6c012935a6b https://github.com/dovecot/core/commit/b909e9579d72684faaebbe3189cab6c012935a6b Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib/file-lock.c Log Message: ----------- lib: With FILE_LOCK_SLOW_WARNING_MSECS log a warning also when keeping lock for long. This can help catching which process kept the lock for too long. Commit: c34b55bb980bff87b92627d876127da2db2c1779 https://github.com/dovecot/core/commit/c34b55bb980bff87b92627d876127da2db2c1779 Author: Timo Sirainen Date: 2016-10-24 (Mon, 24 Oct 2016) Changed paths: M src/lib-compression/istream-zlib.c Log Message: ----------- istream-zlib: "missing gz trailer" error message was wrong. Commit: ae052aeecfcf162369cb009d55e81a308749ef02 https://github.com/dovecot/core/commit/ae052aeecfcf162369cb009d55e81a308749ef02 Author: Aki Tuomi Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/doveadm/doveadm-mail.c Log Message: ----------- doveadm: Rewind input early enough Command input needs to be rewinded earlier in doveadm_mail_next_user. Commit: 5ea724b12e30529fc38a1f087248ed71c22ddfc0 https://github.com/dovecot/core/commit/5ea724b12e30529fc38a1f087248ed71c22ddfc0 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-compression/istream-zlib.c Log Message: ----------- lib-compress: Don't assume too early that gz file continues after a trailer. Some istreams don't have EOF immediately set after the gz trailer. This fixes errors like "missing gz trailer at 1675" Commit: 8663febb0735cba25b899f64c9f7f28de67ecc9f https://github.com/dovecot/core/commit/8663febb0735cba25b899f64c9f7f28de67ecc9f Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-compression/test-compression.c Log Message: ----------- lib-compression: Added file uncompression support for test-compression This can be useful for debugging. Commit: 5b3bfd871e84d9d70d205ebf73bc1a209eee782d https://github.com/dovecot/core/commit/5b3bfd871e84d9d70d205ebf73bc1a209eee782d Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-compression/test-compression.c Log Message: ----------- lib-compression: Added unit tests for reading .gz files Commit: 1165c4b3b264dbf2cd2dd55a6913126f69fc35f8 https://github.com/dovecot/core/commit/1165c4b3b264dbf2cd2dd55a6913126f69fc35f8 Author: Aki Tuomi Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/imap-login/imap-login-client.c Log Message: ----------- imap-login: Skip NIL value in ID handler NIL value can cause hard crash, depending what the key is. For x-proxy-ttl, NIL will crash on any system, x-originating-ip will crash on some nss versions (e.g. centos 6.7). Migitating factor here is that the NIL value is only accepted from trusted network. Commit: 3729762f734e96e79c7427c84d76e1a2691e87f9 https://github.com/dovecot/core/commit/3729762f734e96e79c7427c84d76e1a2691e87f9 Author: Aki Tuomi Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-mail/mail-html2text.c Log Message: ----------- lib-mail: Support decimal/hexadecimal encoded entities Add support for &#nnn; and &#xnnn; entities. Commit: 9322aae41e99971d8c3442633fc46138f8a73447 https://github.com/dovecot/core/commit/9322aae41e99971d8c3442633fc46138f8a73447 Author: Aki Tuomi Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/lib-mail/test-mail-html2text.c Log Message: ----------- lib-mail: Add tests for dec/hexdec encoded entities Commit: 40b639480f3c48e336913707dea11cf776eb8517 https://github.com/dovecot/core/commit/40b639480f3c48e336913707dea11cf776eb8517 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Code cleanup - allow commands handlers to stop processing input Now returning 0 exits the input reading without disconnecting client. Commit: 6f4ef8c4be5c3d443cfa25b2e7b7b95b6676fe4d https://github.com/dovecot/core/commit/6f4ef8c4be5c3d443cfa25b2e7b7b95b6676fe4d Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h M src/director/main.c Log Message: ----------- director: Call state_change_callback on user move timeout. Commit: 6f5d4f71f6d270c9f04aac7abcb4746c26b6d1b0 https://github.com/dovecot/core/commit/6f5d4f71f6d270c9f04aac7abcb4746c26b6d1b0 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Code cleanup - Finish user move always in the same function. Commit: 490ecf7d1cc8842f5fca3f336f0854e63f3a4210 https://github.com/dovecot/core/commit/490ecf7d1cc8842f5fca3f336f0854e63f3a4210 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h M src/director/main.c Log Message: ----------- director: Show in process title how many users are being moved. Commit: b0c70a5e8309443c5872f013d57bfa1c90b0d11f https://github.com/dovecot/core/commit/b0c70a5e8309443c5872f013d57bfa1c90b0d11f Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Code cleanup - moved command handling to its own function. Commit: e086c5434f05618c8d94a59f30eb36ff93f1b002 https://github.com/dovecot/core/commit/e086c5434f05618c8d94a59f30eb36ff93f1b002 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Make sure IP address parsing works in DIRECTOR-ADD/REMOVE We were passing the entire string through to net_addr2ip(). It seems that inet_aton() stops at whitespace though, so this wasn't actually causing errors at least on Linux. Commit: b78c76d503adb18735a0f28330d58db3fb3bc57d https://github.com/dovecot/core/commit/b78c76d503adb18735a0f28330d58db3fb3bc57d Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: USER-MOVE didn't handle non-hash username correctly. The entire command line was being hashed instead of just the username. Commit: 266725f60a2d8571ee4db8be198dec15a1cfbe8b https://github.com/dovecot/core/commit/266725f60a2d8571ee4db8be198dec15a1cfbe8b Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Code cleanup - Give tab-unescaped args to all doveadm command handlers. Commit: 827bb6585dd19964eccba2a78a1ba3d8971bdfd0 https://github.com/dovecot/core/commit/827bb6585dd19964eccba2a78a1ba3d8971bdfd0 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director-host.h Log Message: ----------- director: If SYNCs are received during handshake, send them later. This fixes delays during handshake: Error: Ring SYNC appears to have got lost, resending Commit: 85505297dce080660df5220a05cb66c370c63f3f https://github.com/dovecot/core/commit/85505297dce080660df5220a05cb66c370c63f3f Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c Log Message: ----------- director: Fix sending up/down state in handshakes. They were never sent, because HOSTs were sent before director had waited for the remote to send its version number. So sender thought that the remote's minor_version was too old and it didn't send the up/down state at all. This caused errors like: Warning: director(10.0.0.30:9090/left): Host 10.0.0.30 is being updated before previous update had finished (up -> down) - setting to state=down vhosts=100 Error: director(10.0.0.30:9090/left): Director 10.0.0.30 SYNC request hosts don't match us - resending hosts (seq=6, remote hosts_hash=262126213, my hosts_hash=2458934259) Commit: 283aea228754e9fc2fdcb3aebb73445415cba757 https://github.com/dovecot/core/commit/283aea228754e9fc2fdcb3aebb73445415cba757 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director: Invalid parameters cause doveadm to fail silently. doveadm_cmd_context.cmd doesn't point directly to doveadm_cmd_director. Commit: 825dc91d3b11fea646bcda94c1a327e7d69bc8c0 https://github.com/dovecot/core/commit/825dc91d3b11fea646bcda94c1a327e7d69bc8c0 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Log user's kill_state with a human-readable string. Commit: 8ca411e827d61a44998bcec11b0fd976932046a2 https://github.com/dovecot/core/commit/8ca411e827d61a44998bcec11b0fd976932046a2 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: If user move times out, log the state it was in at the time. Commit: 309ad773ae70ecb28c7da9ff9c635442668010e8 https://github.com/dovecot/core/commit/309ad773ae70ecb28c7da9ff9c635442668010e8 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c M src/director/doveadm-connection.h M src/director/main.c M src/director/user-directory.h Log Message: ----------- director: HOST-RESET-USERS moves users more slowly now. By default only 100 users can be moved in parallel. This can be overridden with HOST-RESET-USERS parameter. This delaying is especially useful when director_flush_socket is used to avoid huge floods to the script service. Even without the socket it's still good for avoiding unnecessary load spikes when all users are kicked at once and they reconnect back at the same time. Commit: f3afdea8a476341d818b5cee794b872e581ef006 https://github.com/dovecot/core/commit/f3afdea8a476341d818b5cee794b872e581ef006 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director flush: Added --max-parallel parameter. Commit: e8133938b0e5b4758677b078d5ccc21926d78b24 https://github.com/dovecot/core/commit/e8133938b0e5b4758677b078d5ccc21926d78b24 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c Log Message: ----------- director: If user host conflict is detected, make sure new host is sent back. USER-KICK-HASH was sent, but the sender didn't get back a USER reply with the new host. This could have increased how long user's host differred in directors. Avoids repeating this error: Error: User hash 2957018085 is being redirected to two hosts: 10.0.0.30 and 10.0.0.201 (old_ts=1477338836) Commit: 45f7ffde889165c7b330fc98708fcbe595c78c05 https://github.com/dovecot/core/commit/45f7ffde889165c7b330fc98708fcbe595c78c05 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Prevent race conditions by adding USER_KILL_STATE_FLUSHING In theory it's possible that a user is freed during a flush and added back before flush is finished, possibly even being moved again. This check makes sure that we don't finish such move unless we're actually at the correct flushing state. (If there's another flush also running for the user it'll be ignored.) This is also useful for logging purposes. Commit: 1976d64251d1544ea1410adf426cb3447b81c993 https://github.com/dovecot/core/commit/1976d64251d1544ea1410adf426cb3447b81c993 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director.c Log Message: ----------- director: Fix user move hangs when another move is triggered early. Running "doveadm director flush" before the previous flush hadn't fully finished could have caused users to hang until their move timeout: director: Error: Finishing user 3249070169 move timed out, its state may now be inconsistent (state=waiting-for-everyone) Commit: 5364c16b3e70a6a08837c20d96f651c1022fd336 https://github.com/dovecot/core/commit/5364c16b3e70a6a08837c20d96f651c1022fd336 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director.c Log Message: ----------- director: Improve debug logging output. Commit: cc52ed5f04fa961249bcc2f4991527f9d7a4748e https://github.com/dovecot/core/commit/cc52ed5f04fa961249bcc2f4991527f9d7a4748e Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/director.c M src/director/user-directory.h Log Message: ----------- director: Execute director_flush_socket only from one director. Having each director do it would be redundant since they're all supposed to be performing the same flush task to the same backend. Commit: 70d288659bb8ee2fb4a78239e196ab2a316c138b https://github.com/dovecot/core/commit/70d288659bb8ee2fb4a78239e196ab2a316c138b Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/doveadm/doveadm-director.c Log Message: ----------- doveadm director dump: Fixed output to include LFs Otherwise all the output will be mixed up in the same line. Commit: 31e3c2060bf44dbd50e4d92e1e358306447557b1 https://github.com/dovecot/core/commit/31e3c2060bf44dbd50e4d92e1e358306447557b1 Author: Timo Sirainen Date: 2016-10-25 (Tue, 25 Oct 2016) Changed paths: M src/director/doveadm-connection.c Log Message: ----------- director: Fix HOST-RESET-USERS with host parameter. The logic was reversed: It should flush the specified host, not some other host. Broken by 11ee3b40320a31669bd717fecbe1e332dad4fd84 Commit: 6d1e5a3c5fc8cd9cf5217baf9221ee55c1ad47f6 https://github.com/dovecot/core/commit/6d1e5a3c5fc8cd9cf5217baf9221ee55c1ad47f6 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Code cleanup - move enum user_kill_state to director.h This will be needed by following commits Commit: a6f99e4d917db4dcce6570685620085983f4c9db https://github.com/dovecot/core/commit/a6f99e4d917db4dcce6570685620085983f4c9db Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director-request.c M src/director/director.c M src/director/doveadm-connection.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Code cleanup - added USER_IS_BEING_KILLED() macro Commit: 66e91d847e0e8090f39080b797df01e94a226fc4 https://github.com/dovecot/core/commit/66e91d847e0e8090f39080b797df01e94a226fc4 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Code cleanup - rename director_kill_context.self to kill_is_self_initiated Commit: 7b43489032fc53ef4cce4fb85de2e868914d4afd https://github.com/dovecot/core/commit/7b43489032fc53ef4cce4fb85de2e868914d4afd Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director.c M src/director/director.h M src/director/test-user-directory.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Moved all user killing state to struct director_kill_context This should make it a bit easier to understand the life time of user killing. It also simplifies code by removing struct director_user_kill_finish_ctx. Finally, this already reduces memory usage with 32bit systems, and would make it possible to reduce also on 64bit systems if timestamp is shrank to 31 bits and weak bit moved after it. I'm not sure if that would be better for performance though. In any case it would provide free space for 4 extra bytes if that were needed in future. Commit: 83d28111bc7850f41b99c3d127ea6b0cc4015253 https://github.com/dovecot/core/commit/83d28111bc7850f41b99c3d127ea6b0cc4015253 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.h M src/director/main.c Log Message: ----------- director: Code cleanup - global director is no longer needed. Commit: 8da62da76a9eeb439c7e22d686e3cecba0213ecd https://github.com/dovecot/core/commit/8da62da76a9eeb439c7e22d686e3cecba0213ecd Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Code cleanup - moved user kill startup to its own function. No functional changes. Commit: d872e6443f865bced54da72ec480698e893d5e88 https://github.com/dovecot/core/commit/d872e6443f865bced54da72ec480698e893d5e88 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: User move - Don't try to kick user's connections if user wasn't even known. Commit: 2162ea042610d00290de66ddd9796f0a6078f7b6 https://github.com/dovecot/core/commit/2162ea042610d00290de66ddd9796f0a6078f7b6 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h Log Message: ----------- director: Send user's old and new backend IPs to flush script. If user was created due to the user-move, don't execute the flush script since it wouldn't really have any work to do anyway. Commit: 995121e82bd45c39d69e6943d9fb00158c1bb253 https://github.com/dovecot/core/commit/995121e82bd45c39d69e6943d9fb00158c1bb253 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/main.c Log Message: ----------- director: Avoid assert-crash at deinit if user moves are still being added. Fixes: Panic: file user-directory.c: line 312 (user_directory_deinit): assertion failed: (array_count(&dir->iters) == 0) Commit: 977ce672812ecdff7f8d79073461c35a0656187e https://github.com/dovecot/core/commit/977ce672812ecdff7f8d79073461c35a0656187e Author: Martti Rannanj?rvi Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/doveadm/doveadm-print-pager.c Log Message: ----------- doveadm: \f\n only between pages in pager No more \f\n in the end. Commit: 5baa99e0302d2ca71a989800e24f3b3fa509a721 https://github.com/dovecot/core/commit/5baa99e0302d2ca71a989800e24f3b3fa509a721 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/doveadm/doveadm-print-pager.c Log Message: ----------- doveadm: "pager" formatter supports now DOVEADM_PRINT_HEADER_FLAG_HIDE_TITLE Commit: 150b07f7ada23884277d2be45040b82dcf55cbef https://github.com/dovecot/core/commit/150b07f7ada23884277d2be45040b82dcf55cbef Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/doveadm/doveadm-mail-fetch.c M src/doveadm/doveadm-master.c M src/doveadm/doveadm-print-pager.c M src/doveadm/doveadm-print.h Log Message: ----------- doveadm: Code cleanup - add and use DOVEADM_PRINT_TYPE_PAGER macro Commit: 17dc7ae8e36c27f8993da4de1f44fee034ca2cb5 https://github.com/dovecot/core/commit/17dc7ae8e36c27f8993da4de1f44fee034ca2cb5 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/doveadm/doveadm-fs.c Log Message: ----------- doveadm fs get: Use pager formatter by default to avoid extra LF at the end. Compare: https://github.com/dovecot/core/compare/d7b99734f301^...17dc7ae8e36c From noreply at github.com Wed Oct 26 10:30:13 2016 From: noreply at github.com (GitHub) Date: Wed, 26 Oct 2016 03:30:13 -0700 Subject: [dovecot/core] bd9848: director: Code cleanup - move enum user_kill_state... Message-ID: <581085b526f67_49a43febe6c4d134530df@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: bd984825690e1dd175494872287384bd5598423b https://github.com/dovecot/core/commit/bd984825690e1dd175494872287384bd5598423b Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Code cleanup - move enum user_kill_state to director.h This will be needed by following commits Commit: 21f9786272b6f78a4a0ac72421349bcb7fd42fb4 https://github.com/dovecot/core/commit/21f9786272b6f78a4a0ac72421349bcb7fd42fb4 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director-request.c M src/director/director.c M src/director/doveadm-connection.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Code cleanup - added USER_IS_BEING_KILLED() macro Commit: 7d3ede1afd6ef96e71a5a120c08799d1e36be395 https://github.com/dovecot/core/commit/7d3ede1afd6ef96e71a5a120c08799d1e36be395 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Code cleanup - rename director_kill_context.self to kill_is_self_initiated Commit: 6f93a3dcb3c9bfe4145f376588e0e798a75f3527 https://github.com/dovecot/core/commit/6f93a3dcb3c9bfe4145f376588e0e798a75f3527 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director-connection.c M src/director/director.c M src/director/director.h M src/director/test-user-directory.c M src/director/user-directory.c M src/director/user-directory.h Log Message: ----------- director: Moved all user killing state to struct director_kill_context This should make it a bit easier to understand the life time of user killing. It also simplifies code by removing struct director_user_kill_finish_ctx. Finally, this already reduces memory usage with 32bit systems, and would make it possible to reduce also on 64bit systems if timestamp is shrank to 31 bits and weak bit moved after it. I'm not sure if that would be better for performance though. In any case it would provide free space for 4 extra bytes if that were needed in future. Commit: 5c3b438e987bf52778ff21b2f1d1e515a1f080cf https://github.com/dovecot/core/commit/5c3b438e987bf52778ff21b2f1d1e515a1f080cf Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.h M src/director/main.c Log Message: ----------- director: Code cleanup - global director is no longer needed. Commit: 9309b3baafe62cd38698edea02fb11357005fde0 https://github.com/dovecot/core/commit/9309b3baafe62cd38698edea02fb11357005fde0 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: Code cleanup - moved user kill startup to its own function. No functional changes. Commit: 06da11f17408f39294798d42766e091a881aa3f1 https://github.com/dovecot/core/commit/06da11f17408f39294798d42766e091a881aa3f1 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c Log Message: ----------- director: User move - Don't try to kick user's connections if user wasn't even known. Commit: d0268f2a817fd57c2f6d927f8166f3f964a9cb25 https://github.com/dovecot/core/commit/d0268f2a817fd57c2f6d927f8166f3f964a9cb25 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/director.c M src/director/director.h Log Message: ----------- director: Send user's old and new backend IPs to flush script. If user was created due to the user-move, don't execute the flush script since it wouldn't really have any work to do anyway. Commit: 00e99bcbf9c9adb6b28a4aafac88cb7aba98ce41 https://github.com/dovecot/core/commit/00e99bcbf9c9adb6b28a4aafac88cb7aba98ce41 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/director/main.c Log Message: ----------- director: Avoid assert-crash at deinit if user moves are still being added. Fixes: Panic: file user-directory.c: line 312 (user_directory_deinit): assertion failed: (array_count(&dir->iters) == 0) Commit: 9c12525ea807c5e300ad1da91ec0286937cc00ec https://github.com/dovecot/core/commit/9c12525ea807c5e300ad1da91ec0286937cc00ec Author: Martti Rannanj?rvi Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/doveadm/doveadm-print-pager.c Log Message: ----------- doveadm: \f\n only between pages in pager No more \f\n in the end. Commit: 98193d1a9235256c02777b5b17a1d1f77823e4b3 https://github.com/dovecot/core/commit/98193d1a9235256c02777b5b17a1d1f77823e4b3 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/doveadm/doveadm-print-pager.c Log Message: ----------- doveadm: "pager" formatter supports now DOVEADM_PRINT_HEADER_FLAG_HIDE_TITLE Commit: 9dc970171d487e3a8241e2af4b773c50e67020f5 https://github.com/dovecot/core/commit/9dc970171d487e3a8241e2af4b773c50e67020f5 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/doveadm/doveadm-mail-fetch.c M src/doveadm/doveadm-master.c M src/doveadm/doveadm-print-pager.c M src/doveadm/doveadm-print.h Log Message: ----------- doveadm: Code cleanup - add and use DOVEADM_PRINT_TYPE_PAGER macro Commit: 2cc140b663e23ccc8b89b406851f176ee77ff931 https://github.com/dovecot/core/commit/2cc140b663e23ccc8b89b406851f176ee77ff931 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/doveadm/doveadm-fs.c Log Message: ----------- doveadm fs get: Use pager formatter by default to avoid extra LF at the end. Compare: https://github.com/dovecot/core/compare/ccb431749072...2cc140b663e2 From noreply at github.com Wed Oct 26 12:00:13 2016 From: noreply at github.com (GitHub) Date: Wed, 26 Oct 2016 05:00:13 -0700 Subject: [dovecot/core] 243c18: lib: Fixed net_str2port*() comments Message-ID: <58109acd2dbef_16ff3f9ff392912c297b7@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 243c1821db2143d76cb6c57a249ec5a7d4031578 https://github.com/dovecot/core/commit/243c1821db2143d76cb6c57a249ec5a7d4031578 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/lib/net.h Log Message: ----------- lib: Fixed net_str2port*() comments From noreply at github.com Wed Oct 26 15:30:21 2016 From: noreply at github.com (GitHub) Date: Wed, 26 Oct 2016 08:30:21 -0700 Subject: [dovecot/core] 00bcc8: Compiler warning fixes with -Wstrict-bool Message-ID: <5810cc0d3ee2b_6a803fc9356f113c1266f9@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 00bcc83b18793b9ec5e5d264480a88bf78b10b33 https://github.com/dovecot/core/commit/00bcc83b18793b9ec5e5d264480a88bf78b10b33 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/lib-compression/test-compression.c M src/lib-sql/driver-cassandra.c Log Message: ----------- Compiler warning fixes with -Wstrict-bool From noreply at github.com Wed Oct 26 16:00:09 2016 From: noreply at github.com (GitHub) Date: Wed, 26 Oct 2016 09:00:09 -0700 Subject: [dovecot/core] a0c576: lib-program-client: Retry connection on EAGAIN Message-ID: <5810d309e2cbe_38333fef866ab14c2422a@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: a0c57666729eacf4fe1429ae6fa7e8af61f94edd https://github.com/dovecot/core/commit/a0c57666729eacf4fe1429ae6fa7e8af61f94edd Author: Aki Tuomi Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/lib-program-client/program-client-remote.c Log Message: ----------- lib-program-client: Retry connection on EAGAIN Commit: 67574bb43936e39d5be32626e986df6e787a296f https://github.com/dovecot/core/commit/67574bb43936e39d5be32626e986df6e787a296f Author: Aki Tuomi Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/lib-program-client/program-client.c Log Message: ----------- lib-program-client: Remove code duplication The content is sent on connected already. Do not send it early in async connect. Commit: def2e150b2901e9ad74d83392fceb6a5e22ecdb0 https://github.com/dovecot/core/commit/def2e150b2901e9ad74d83392fceb6a5e22ecdb0 Author: Timo Sirainen Date: 2016-10-26 (Wed, 26 Oct 2016) Changed paths: M src/login-common/main.c Log Message: ----------- *-login: Removed enforcing maximum calculated fd limit. Just use the regular ulimit. Login process has become complicated enough that counting the exact fd size isn't so easy anymore. Also apparently this low fd limit is causing errors with new Linux kernels: pop3-login: Error: fd_send(pop3, 18) failed: Too many references: cannot splice Compare: https://github.com/dovecot/core/compare/00bcc83b1879...def2e150b290 From noreply at github.com Wed Oct 26 22:00:11 2016 From: noreply at github.com (GitHub) Date: Wed, 26 Oct 2016 15:00:11 -0700 Subject: [dovecot/core] 7bab7c: doveadm dump: Dump mailbox names in mailbox.list.i... Message-ID: <5811276bd1f05_70e73fe5ac6751345443f@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 7bab7c949c28f3b72fde43604111c349de9b9063 https://github.com/dovecot/core/commit/7bab7c949c28f3b72fde43604111c349de9b9063 Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/doveadm/doveadm-dump-index.c Log Message: ----------- doveadm dump: Dump mailbox names in mailbox.list.index's header. From noreply at github.com Wed Oct 26 22:00:15 2016 From: noreply at github.com (GitHub) Date: Wed, 26 Oct 2016 15:00:15 -0700 Subject: [dovecot/core] 2db8fb: lib: Fixed net_str2port*() comments Message-ID: <5811276fcc3a_4ebc3f93b80af13c83416@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 2db8fb669b481cd5baa3c6ff09a85eeef0a966e9 https://github.com/dovecot/core/commit/2db8fb669b481cd5baa3c6ff09a85eeef0a966e9 Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/lib/net.h Log Message: ----------- lib: Fixed net_str2port*() comments Commit: 2a77c83b6400ba025bd6d78e236ce4be80d23ee1 https://github.com/dovecot/core/commit/2a77c83b6400ba025bd6d78e236ce4be80d23ee1 Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/lib-compression/test-compression.c M src/lib-sql/driver-cassandra.c Log Message: ----------- Compiler warning fixes with -Wstrict-bool Commit: 7d33533ce3aa5a373033451896ccdfc1a01bdcf9 https://github.com/dovecot/core/commit/7d33533ce3aa5a373033451896ccdfc1a01bdcf9 Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/login-common/main.c Log Message: ----------- *-login: Removed enforcing maximum calculated fd limit. Just use the regular ulimit. Login process has become complicated enough that counting the exact fd size isn't so easy anymore. Also apparently this low fd limit is causing errors with new Linux kernels: pop3-login: Error: fd_send(pop3, 18) failed: Too many references: cannot splice Commit: 1f6e271318d7e26dae6d726a71884ab761f8c374 https://github.com/dovecot/core/commit/1f6e271318d7e26dae6d726a71884ab761f8c374 Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/doveadm/doveadm-dump-index.c Log Message: ----------- doveadm dump: Dump mailbox names in mailbox.list.index's header. Compare: https://github.com/dovecot/core/compare/2cc140b663e2...1f6e271318d7 From noreply at github.com Thu Oct 27 05:30:09 2016 From: noreply at github.com (GitHub) Date: Wed, 26 Oct 2016 22:30:09 -0700 Subject: [dovecot/core] 832830: doveadm: fix compile warning in doveadm-dump-index Message-ID: <581190e13fe14_69753fc3d6f0913075195@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 83283069024cd941b566e6d4cc233b67ed511504 https://github.com/dovecot/core/commit/83283069024cd941b566e6d4cc233b67ed511504 Author: Martti Rannanj?rvi Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/doveadm/doveadm-dump-index.c Log Message: ----------- doveadm: fix compile warning in doveadm-dump-index From noreply at github.com Thu Oct 27 06:00:12 2016 From: noreply at github.com (GitHub) Date: Wed, 26 Oct 2016 23:00:12 -0700 Subject: [dovecot/core] 21aaa6: lib-storage: rename get_real_mail to get_backend_m... Message-ID: <581197ecdb1f6_7c873f9e9e6f514077276@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 21aaa6affb9f134112b75b5db737309fc35ef1cf https://github.com/dovecot/core/commit/21aaa6affb9f134112b75b5db737309fc35ef1cf Author: Martti Rannanj?rvi Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/lib-storage/fail-mail.c M src/lib-storage/index/cydir/cydir-mail.c M src/lib-storage/index/dbox-multi/mdbox-mail.c M src/lib-storage/index/dbox-single/sdbox-mail.c M src/lib-storage/index/imapc/imapc-mail.c M src/lib-storage/index/index-mail.c M src/lib-storage/index/index-mail.h M src/lib-storage/index/maildir/maildir-mail.c M src/lib-storage/index/mbox/mbox-mail.c M src/lib-storage/index/pop3c/pop3c-mail.c M src/lib-storage/index/raw/raw-mail.c M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.h M src/lib-storage/mail.c M src/plugins/virtual/virtual-mail.c Log Message: ----------- lib-storage: rename get_real_mail to get_backend_mail Also change the function signature so that it returns an int to indicate success or failure. From noreply at github.com Thu Oct 27 07:30:14 2016 From: noreply at github.com (GitHub) Date: Thu, 27 Oct 2016 00:30:14 -0700 Subject: [dovecot/core] 2732f2: imap-hibernate: Fix "DONE" handling. Message-ID: <5811ad0685953_70dd3f97044c9138133194@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 2732f22367cb674c0c0599530497c839eac41162 https://github.com/dovecot/core/commit/2732f22367cb674c0c0599530497c839eac41162 Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c Log Message: ----------- imap-hibernate: Fix "DONE" handling. 1. If only "DONE\r\n" was sent, it randomly failed with BAD because of out-of-bounds buffer read. 2. If "DONE\r\n" was followed by a command tag but no space afterwards, we kept waiting for the input to continue. But since the DONE was already sent, we should break the IDLE already at that point without any further waiting. Commit: 0db2a56763517f5639caae2db9f2a3c25c08f335 https://github.com/dovecot/core/commit/0db2a56763517f5639caae2db9f2a3c25c08f335 Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/director/main.c Log Message: ----------- director: Fix shutdown_clients=no to not break The director process must shut down even with with shutdown_clients=no. Otherwise the two director processes will try to keep competing with each others and log errors like: director: Warning: Director 10.0.0.123:9090/right disconnected us with reason: Replacing with new incoming connection director: Warning: Director 10.0.0.123:9090/right disconnected us with reason: Replacing with 10.0.0.124:9090 Commit: f0c3eb66d9ec4e943d35f62fe5a74f466c948531 https://github.com/dovecot/core/commit/f0c3eb66d9ec4e943d35f62fe5a74f466c948531 Author: Martti Rannanj?rvi Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/doveadm/doveadm-dump-index.c Log Message: ----------- doveadm: fix compile warning in doveadm-dump-index Compare: https://github.com/dovecot/core/compare/1f6e271318d7...f0c3eb66d9ec From noreply at github.com Thu Oct 27 08:30:14 2016 From: noreply at github.com (GitHub) Date: Thu, 27 Oct 2016 01:30:14 -0700 Subject: [dovecot/core] 9199e3: lib-auth: Minor debug logging improvement. Message-ID: <5811bb1626c3_418f3fb59101b1301092a0@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 9199e32b86d2de2fb7b73b6ec03b5c205b995490 https://github.com/dovecot/core/commit/9199e32b86d2de2fb7b73b6ec03b5c205b995490 Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/lib-auth/auth-master.c Log Message: ----------- lib-auth: Minor debug logging improvement. Include "PASS" or "USER" in the prefix to make it clear what the reply is for. From noreply at github.com Thu Oct 27 10:30:09 2016 From: noreply at github.com (GitHub) Date: Thu, 27 Oct 2016 03:30:09 -0700 Subject: [dovecot/core] 5507b0: lib-compression: Fixed fd leak in unit test Message-ID: <5811d73122e74_5df33fb090fad1301193d2@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 5507b0c7e5106e88e038c24f8067ef8d1be4fbaa https://github.com/dovecot/core/commit/5507b0c7e5106e88e038c24f8067ef8d1be4fbaa Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/lib-compression/test-compression.c Log Message: ----------- lib-compression: Fixed fd leak in unit test From noreply at github.com Thu Oct 27 13:03:36 2016 From: noreply at github.com (GitHub) Date: Thu, 27 Oct 2016 06:03:36 -0700 Subject: [dovecot/core] f9c052: imap-hibernate: Fix "DONE" handling. Message-ID: <5811fb284b4d9_63fb3ffa5b9b7130922a8@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/release-2.2.26 Home: https://github.com/dovecot/core Commit: f9c05266efc5fc665b0563521a78853fe445167e https://github.com/dovecot/core/commit/f9c05266efc5fc665b0563521a78853fe445167e Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/imap-hibernate/imap-client.c Log Message: ----------- imap-hibernate: Fix "DONE" handling. 1. If only "DONE\r\n" was sent, it randomly failed with BAD because of out-of-bounds buffer read. 2. If "DONE\r\n" was followed by a command tag but no space afterwards, we kept waiting for the input to continue. But since the DONE was already sent, we should break the IDLE already at that point without any further waiting. Commit: 92bcb6337fdc07d245a1a640324a84fad7abad31 https://github.com/dovecot/core/commit/92bcb6337fdc07d245a1a640324a84fad7abad31 Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/director/main.c Log Message: ----------- director: Fix shutdown_clients=no to not break The director process must shut down even with with shutdown_clients=no. Otherwise the two director processes will try to keep competing with each others and log errors like: director: Warning: Director 10.0.0.123:9090/right disconnected us with reason: Replacing with new incoming connection director: Warning: Director 10.0.0.123:9090/right disconnected us with reason: Replacing with 10.0.0.124:9090 Commit: 54d654098032d96975b70749b505fae538e97f7a https://github.com/dovecot/core/commit/54d654098032d96975b70749b505fae538e97f7a Author: Timo Sirainen Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M NEWS M configure.ac Log Message: ----------- Released v2.2.26. Compare: https://github.com/dovecot/core/compare/17dc7ae8e36c...54d654098032 From noreply at github.com Thu Oct 27 14:00:13 2016 From: noreply at github.com (GitHub) Date: Thu, 27 Oct 2016 07:00:13 -0700 Subject: [dovecot/core] 4f59e6: auth: Remove i_assert for credentials scheme Message-ID: <5812086d2024c_55633fabe1e771341057d7@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 4f59e604bf77eca0f0eb0e7d9d6111578c58ed25 https://github.com/dovecot/core/commit/4f59e604bf77eca0f0eb0e7d9d6111578c58ed25 Author: Aki Tuomi Date: 2016-10-27 (Thu, 27 Oct 2016) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Remove i_assert for credentials scheme From noreply at github.com Fri Oct 28 09:30:10 2016 From: noreply at github.com (GitHub) Date: Fri, 28 Oct 2016 02:30:10 -0700 Subject: [dovecot/core] 2c96c5: auth: Fix crash when exporting passdb fields to au... Message-ID: <58131aa264cc7_454a3ff1b0b8b140697c1@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 2c96c5156117a830f497bdd41518816242944920 https://github.com/dovecot/core/commit/2c96c5156117a830f497bdd41518816242944920 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Fix crash when exporting passdb fields to auth-worker that have NULL values From noreply at github.com Fri Oct 28 10:00:10 2016 From: noreply at github.com (GitHub) Date: Fri, 28 Oct 2016 03:00:10 -0700 Subject: [dovecot/core] 026d97: auth-worker: Fix potential crash when importing pa... Message-ID: <581321aab9971_5dbb3fc92b86d13c31511@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 026d971be5201aed5ccf60138900770e42cf0de5 https://github.com/dovecot/core/commit/026d971be5201aed5ccf60138900770e42cf0de5 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/auth/auth-request.c M src/auth/auth-worker-client.c Log Message: ----------- auth-worker: Fix potential crash when importing passdb/userdb fields without value. These were being converted to NULL values in auth-worker, while elsewhere they were converted to "". Changed to "" here as well and added asserts to make sure they won't happen again. Most of the NULL values would have been fine, but overriding any IP/port fields would have caused a crash when trying to parse the value. From noreply at github.com Fri Oct 28 11:00:10 2016 From: noreply at github.com (GitHub) Date: Fri, 28 Oct 2016 04:00:10 -0700 Subject: [dovecot/core] 05c1d3: lib: Removed t_strsplit_tab() Message-ID: <58132fba28627_5c5c3fa1de8e91341808e@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 05c1d362cc69d18840d9c37b563f01ba25fc2634 https://github.com/dovecot/core/commit/05c1d362cc69d18840d9c37b563f01ba25fc2634 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/lib/strfuncs.c M src/lib/strfuncs.h M src/lib/test-strfuncs.c Log Message: ----------- lib: Removed t_strsplit_tab() It's too easy to use it accidentally instead of using t_strsplit_tabescaped(). It's also rarely what is actually wanted. From noreply at github.com Fri Oct 28 14:11:54 2016 From: noreply at github.com (GitHub) Date: Fri, 28 Oct 2016 07:11:54 -0700 Subject: [dovecot/core] 870bf3: lib-program-client: Fix building with compilers th... Message-ID: <58135caa9c3e2_439c3fcd3dcfb13410579a@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 870bf394d43e653dd7669093a12bafbfc0b8fe92 https://github.com/dovecot/core/commit/870bf394d43e653dd7669093a12bafbfc0b8fe92 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-net.c M src/lib-program-client/test-program-client-unix.c Log Message: ----------- lib-program-client: Fix building with compilers that have no typeof() Commit: 5546faab383f222004796a8170bc8baafa35c5bf https://github.com/dovecot/core/commit/5546faab383f222004796a8170bc8baafa35c5bf Author: Paul Howarth Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M m4/ssl.m4 Log Message: ----------- configure: Improve check for OpenSSL without EC support The original test was for EC_KEY_new but some systems had that and not EVP_PKEY_CTX_new_id, so the test was switched to that function. However, Fedora releases 12 through 17 have EVP_PKEY_CTX_new_id but not EC_KEY_new. So we need to test for both functions before enabling the dcrypt build. Compare: https://github.com/dovecot/core/compare/05c1d362cc69...5546faab383f From noreply at github.com Fri Oct 28 14:11:58 2016 From: noreply at github.com (GitHub) Date: Fri, 28 Oct 2016 07:11:58 -0700 Subject: [dovecot/core] 42f190: lib-program-client: Fix building with compilers th... Message-ID: <58135caea8ab3_3bd03fbd53615134317d8@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 42f190c1d4ed42268fccef722fee6f3c20c137ce https://github.com/dovecot/core/commit/42f190c1d4ed42268fccef722fee6f3c20c137ce Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-remote.c Log Message: ----------- lib-program-client: Fix building with compilers that have no typeof() Commit: 4a349dc84530ca87759605b419f2fdda51860492 https://github.com/dovecot/core/commit/4a349dc84530ca87759605b419f2fdda51860492 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/lib-auth/auth-master.c Log Message: ----------- lib-auth: Minor debug logging improvement. Include "PASS" or "USER" in the prefix to make it clear what the reply is for. Commit: 2d10495244362d7f596906d689e5892e32a02434 https://github.com/dovecot/core/commit/2d10495244362d7f596906d689e5892e32a02434 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/lib-compression/test-compression.c Log Message: ----------- lib-compression: Fixed fd leak in unit test Commit: 9b59f54e72f0b70456552dc71ad7afd7773278ff https://github.com/dovecot/core/commit/9b59f54e72f0b70456552dc71ad7afd7773278ff Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Fix crash when exporting passdb fields to auth-worker that have NULL values Commit: c2b23ae95fbfc2ac8eec89b1f92d4a477fd1da75 https://github.com/dovecot/core/commit/c2b23ae95fbfc2ac8eec89b1f92d4a477fd1da75 Author: Paul Howarth Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M configure.ac Log Message: ----------- configure: Improve check for OpenSSL without EC support The original test was for EC_KEY_new but some systems had that and not EVP_PKEY_CTX_new_id, so the test was switched to that function. However, Fedora releases 12 through 17 have EVP_PKEY_CTX_new_id but not EC_KEY_new. So we need to test for both functions before enabling the dcrypt build. Compare: https://github.com/dovecot/core/compare/4f59e604bf77...c2b23ae95fbf From noreply at github.com Fri Oct 28 16:56:46 2016 From: noreply at github.com (GitHub) Date: Fri, 28 Oct 2016 09:56:46 -0700 Subject: [dovecot/core] ca978d: auth: Remove i_assert for credentials scheme Message-ID: <5813834ee342e_49753f9371e8b13037930@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/tags/2.2.26.0 Home: https://github.com/dovecot/core Commit: ca978dbe2475a5d0199c87f8bc227b6cd2bfcced https://github.com/dovecot/core/commit/ca978dbe2475a5d0199c87f8bc227b6cd2bfcced Author: Aki Tuomi Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Remove i_assert for credentials scheme Commit: c8ce538d06ae8785aaed7f36ff5be67193703270 https://github.com/dovecot/core/commit/c8ce538d06ae8785aaed7f36ff5be67193703270 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Fix crash when exporting passdb fields to auth-worker that have NULL values Commit: 3b4c7a5309f4c1ca73f68ab95ec7f3b549e77696 https://github.com/dovecot/core/commit/3b4c7a5309f4c1ca73f68ab95ec7f3b549e77696 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-remote.c Log Message: ----------- lib-program-client: Fix building with compilers that have no typeof() Commit: 9e110864e579deeda3c6885b37cc62d7f5b3e94f https://github.com/dovecot/core/commit/9e110864e579deeda3c6885b37cc62d7f5b3e94f Author: Paul Howarth Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M configure.ac Log Message: ----------- configure: Improve check for OpenSSL without EC support The original test was for EC_KEY_new but some systems had that and not EVP_PKEY_CTX_new_id, so the test was switched to that function. However, Fedora releases 12 through 17 have EVP_PKEY_CTX_new_id but not EC_KEY_new. So we need to test for both functions before enabling the dcrypt build. Commit: e6ce8250ffed945f942863e3a55ac5348a94a219 https://github.com/dovecot/core/commit/e6ce8250ffed945f942863e3a55ac5348a94a219 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/doveadm/dsync/dsync-brain-mailbox.c Log Message: ----------- dsync: Fix potential assert on mailbox deinit. Should have happened only in somewhat rare error conditions that require resyncing. Fixes: Panic: file dsync-brain-mailbox.c: line 358 (dsync_brain_sync_mailbox_deinit): assertion failed: (brain->failed || brain->sync_type == DSYNC_BRAIN_SYNC_TYPE_CHANGED) Commit: 23d1de6521efb2ceb619ee549619deb2fa9d1a1e https://github.com/dovecot/core/commit/23d1de6521efb2ceb619ee549619deb2fa9d1a1e Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M NEWS M configure.ac Log Message: ----------- Released v2.2.26.0. Compare: https://github.com/dovecot/core/compare/ca978dbe2475^...23d1de6521ef From noreply at github.com Fri Oct 28 17:00:10 2016 From: noreply at github.com (GitHub) Date: Fri, 28 Oct 2016 10:00:10 -0700 Subject: [dovecot/core] f43ce6: dsync: Fix potential assert on mailbox deinit. Message-ID: <5813841a4351b_5c5c3fa1de8e913421411@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: f43ce62fa945f597e8a48e09c53d46dcc95445d4 https://github.com/dovecot/core/commit/f43ce62fa945f597e8a48e09c53d46dcc95445d4 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/doveadm/dsync/dsync-brain-mailbox.c Log Message: ----------- dsync: Fix potential assert on mailbox deinit. Should have happened only in somewhat rare error conditions that require resyncing. Fixes: Panic: file dsync-brain-mailbox.c: line 358 (dsync_brain_sync_mailbox_deinit): assertion failed: (brain->failed || brain->sync_type == DSYNC_BRAIN_SYNC_TYPE_CHANGED) From noreply at github.com Fri Oct 28 17:00:16 2016 From: noreply at github.com (GitHub) Date: Fri, 28 Oct 2016 10:00:16 -0700 Subject: [dovecot/core] 42f520: dsync: Fix potential assert on mailbox deinit. Message-ID: <581384203215b_4fa83fec4582113c49820@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master-2.2 Home: https://github.com/dovecot/core Commit: 42f5200012b86c3e4a1f358564bf879d9c93faa9 https://github.com/dovecot/core/commit/42f5200012b86c3e4a1f358564bf879d9c93faa9 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/doveadm/dsync/dsync-brain-mailbox.c Log Message: ----------- dsync: Fix potential assert on mailbox deinit. Should have happened only in somewhat rare error conditions that require resyncing. Fixes: Panic: file dsync-brain-mailbox.c: line 358 (dsync_brain_sync_mailbox_deinit): assertion failed: (brain->failed || brain->sync_type == DSYNC_BRAIN_SYNC_TYPE_CHANGED) From noreply at github.com Fri Oct 28 19:00:09 2016 From: noreply at github.com (GitHub) Date: Fri, 28 Oct 2016 12:00:09 -0700 Subject: [dovecot/core] b73cfe: configure: Fix link ordering Message-ID: <5813a039c75da_4f2e3fa7b0f8114026797@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: b73cfe3eaba286babe9279e558947ccbe1d96286 https://github.com/dovecot/core/commit/b73cfe3eaba286babe9279e558947ccbe1d96286 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M configure.ac Log Message: ----------- configure: Fix link ordering libprogram_client.la needs to be before libdns.la From noreply at github.com Fri Oct 28 19:31:06 2016 From: noreply at github.com (GitHub) Date: Fri, 28 Oct 2016 12:31:06 -0700 Subject: [dovecot/core] ca978d: auth: Remove i_assert for credentials scheme Message-ID: <5813a77a90c36_47cf3f7f62fad130593f8@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/release-2.2.26 Home: https://github.com/dovecot/core Commit: ca978dbe2475a5d0199c87f8bc227b6cd2bfcced https://github.com/dovecot/core/commit/ca978dbe2475a5d0199c87f8bc227b6cd2bfcced Author: Aki Tuomi Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Remove i_assert for credentials scheme Commit: c8ce538d06ae8785aaed7f36ff5be67193703270 https://github.com/dovecot/core/commit/c8ce538d06ae8785aaed7f36ff5be67193703270 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/auth/auth-request.c Log Message: ----------- auth: Fix crash when exporting passdb fields to auth-worker that have NULL values Commit: 3b4c7a5309f4c1ca73f68ab95ec7f3b549e77696 https://github.com/dovecot/core/commit/3b4c7a5309f4c1ca73f68ab95ec7f3b549e77696 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/lib-program-client/test-program-client-remote.c Log Message: ----------- lib-program-client: Fix building with compilers that have no typeof() Commit: 9e110864e579deeda3c6885b37cc62d7f5b3e94f https://github.com/dovecot/core/commit/9e110864e579deeda3c6885b37cc62d7f5b3e94f Author: Paul Howarth Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M configure.ac Log Message: ----------- configure: Improve check for OpenSSL without EC support The original test was for EC_KEY_new but some systems had that and not EVP_PKEY_CTX_new_id, so the test was switched to that function. However, Fedora releases 12 through 17 have EVP_PKEY_CTX_new_id but not EC_KEY_new. So we need to test for both functions before enabling the dcrypt build. Commit: e6ce8250ffed945f942863e3a55ac5348a94a219 https://github.com/dovecot/core/commit/e6ce8250ffed945f942863e3a55ac5348a94a219 Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M src/doveadm/dsync/dsync-brain-mailbox.c Log Message: ----------- dsync: Fix potential assert on mailbox deinit. Should have happened only in somewhat rare error conditions that require resyncing. Fixes: Panic: file dsync-brain-mailbox.c: line 358 (dsync_brain_sync_mailbox_deinit): assertion failed: (brain->failed || brain->sync_type == DSYNC_BRAIN_SYNC_TYPE_CHANGED) Commit: 23d1de6521efb2ceb619ee549619deb2fa9d1a1e https://github.com/dovecot/core/commit/23d1de6521efb2ceb619ee549619deb2fa9d1a1e Author: Timo Sirainen Date: 2016-10-28 (Fri, 28 Oct 2016) Changed paths: M NEWS M configure.ac Log Message: ----------- Released v2.2.26.0. Compare: https://github.com/dovecot/core/compare/54d654098032...23d1de6521ef From noreply at github.com Sun Oct 30 22:39:51 2016 From: noreply at github.com (GitHub) Date: Sun, 30 Oct 2016 15:39:51 -0700 Subject: [dovecot/pigeonhole] 1dc4c7: Released v0.4.16 for Dovecot v2.2.26.0. Message-ID: <581676b744071_39793f8f07ce1140103519@hookshot-fe4-cp1-prd.iad.github.net.mail> Branch: refs/heads/release-0.4.16 Home: https://github.com/dovecot/pigeonhole Commit: 1dc4c735c2be6c8d5118df7d4d0f3dc9207e4318 https://github.com/dovecot/pigeonhole/commit/1dc4c735c2be6c8d5118df7d4d0f3dc9207e4318 Author: Stephan Bosch Date: 2016-10-30 (Sun, 30 Oct 2016) Changed paths: M NEWS M configure.ac Log Message: ----------- Released v0.4.16 for Dovecot v2.2.26.0. From noreply at github.com Mon Oct 31 15:00:11 2016 From: noreply at github.com (GitHub) Date: Mon, 31 Oct 2016 08:00:11 -0700 Subject: [dovecot/core] 8a20f9: lib: Add function to see if lib is initialized Message-ID: <58175c7bd666c_11d43fe84770f14c76842@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 8a20f964980a779f64d064a45cdc50952d9a20be https://github.com/dovecot/core/commit/8a20f964980a779f64d064a45cdc50952d9a20be Author: Aki Tuomi Date: 2016-10-31 (Mon, 31 Oct 2016) Changed paths: M src/lib/lib.c M src/lib/lib.h Log Message: ----------- lib: Add function to see if lib is initialized This is needed by test-lib to prevent double init/deinit. Commit: 955f324bfd9e7b5962977108cf7e8a6028a021c7 https://github.com/dovecot/core/commit/955f324bfd9e7b5962977108cf7e8a6028a021c7 Author: Aki Tuomi Date: 2016-10-31 (Mon, 31 Oct 2016) Changed paths: M src/lib-test/test-common.c Log Message: ----------- lib-test: Do not init/deinit library twice If lib is initialized, do not initialize or deinitialize library. This is done to allow using master_service in unit tests which also wants to perform lib init and deinit itself. Compare: https://github.com/dovecot/core/compare/b73cfe3eaba2...955f324bfd9e From noreply at github.com Mon Oct 31 17:30:11 2016 From: noreply at github.com (GitHub) Date: Mon, 31 Oct 2016 10:30:11 -0700 Subject: [dovecot/core] ba1b95: fs-randomfail: "write" probability was reversed. Message-ID: <58177fa33aef3_6a763f908e2a91403672c@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: ba1b959d6bd83a0e3d6a3f927844543376019eac https://github.com/dovecot/core/commit/ba1b959d6bd83a0e3d6a3f927844543376019eac Author: Timo Sirainen Date: 2016-10-31 (Mon, 31 Oct 2016) Changed paths: M src/lib-fs/fs-randomfail.c Log Message: ----------- fs-randomfail: "write" probability was reversed. 0 meant 100% while 100 meant 0% From noreply at github.com Mon Oct 31 21:00:13 2016 From: noreply at github.com (GitHub) Date: Mon, 31 Oct 2016 14:00:13 -0700 Subject: [dovecot/core] 59a82d: mdbox: Fix assert-crash caused by race condition w... Message-ID: <5817b0dd4e838_1ac83f92a63e513495566@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/dovecot/core Commit: 59a82d4b3adeef388aa66435e3fe9d9a37290c1b https://github.com/dovecot/core/commit/59a82d4b3adeef388aa66435e3fe9d9a37290c1b Author: Timo Sirainen Date: 2016-10-31 (Mon, 31 Oct 2016) Changed paths: M src/lib-storage/index/dbox-multi/mdbox-map.c Log Message: ----------- mdbox: Fix assert-crash caused by race condition with multiple doveadm purges. This fixes a problem where an email that was just written to a new m.* file gets expunged and purged by another process. Fixes: Panic: file mdbox-map.c: line 1359: unreached