[dovecot/core] 05475b: lib: Make sure stdin/stdout/stderr have fd at star...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 05475b8318550618dd76d6ab4694e2110d0b5710
      https://github.com/dovecot/core/commit/05475b8318550618dd76d6ab4694e2110d0b5710
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-16 (Wed, 16 Nov 2016)

  Changed paths:
    M src/lib/lib.c
    M src/lib/lib.h

  Log Message:
  -----------
  lib: Make sure stdin/stdout/stderr have fd at startup and keep /dev/null always open

This guarantees we will always have a fd that can be used as /dev/null.
It works even inside chroots.


  Commit: 253000d6d4805247116ee49922c9fd64add698e5
      https://github.com/dovecot/core/commit/253000d6d4805247116ee49922c9fd64add698e5
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-16 (Wed, 16 Nov 2016)

  Changed paths:
    M src/lib-master/master-service.c

  Log Message:
  -----------
  lib-master: Revert redundant stdin/stdout/stderr fd checks

This is now done by lib_init() in a bit nicer way.

Reverts 08923d2c956ece3dc604d5842ba152c2bdb11fb9


  Commit: be7c7c4e99a9bb8570cdd923d5d369125a6ca727
      https://github.com/dovecot/core/commit/be7c7c4e99a9bb8570cdd923d5d369125a6ca727
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-16 (Wed, 16 Nov 2016)

  Changed paths:
    M src/master/common.h
    M src/master/main.c
    M src/master/master-settings.c

  Log Message:
  -----------
  master: Don't unlink login sockets at startup if someone is listening to them.

The original check there never worked, because null_fd was always set.

Normally the master.pid file would prevent this happening, but if it didn't
exist, the sockets would be unlinked and usually also created back.


  Commit: 41ee23907b084da5baed459e35bccd5a33430419
      https://github.com/dovecot/core/commit/41ee23907b084da5baed459e35bccd5a33430419
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-16 (Wed, 16 Nov 2016)

  Changed paths:
    M src/lib-program-client/program-client-local.c
    M src/lib/module-dir.c
    M src/master/common.h
    M src/master/main.c
    M src/master/service-process.c

  Log Message:
  -----------
  global: use dev_null_fd instead of opening /dev/null


  Commit: 1e766413c73d963cdd55c17afe8ec86b46dd8463
      https://github.com/dovecot/core/commit/1e766413c73d963cdd55c17afe8ec86b46dd8463
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-16 (Wed, 16 Nov 2016)

  Changed paths:
    M src/lib/lib.c
    M src/lib/lib.h

  Log Message:
  -----------
  lib: Add fd_close_maybe_stdio()

The idea is that this should be used whenever closing fds that may be 0 or
1. If they are closed normally, the following code may end up using 0/1 fd
for other purposes, which could cause problems.


  Commit: 33a80622828063f5be6f743855d5273fabe8ae58
      https://github.com/dovecot/core/commit/33a80622828063f5be6f743855d5273fabe8ae58
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-11-16 (Wed, 16 Nov 2016)

  Changed paths:
    M src/imap-urlauth/imap-urlauth-client.c
    M src/imap-urlauth/imap-urlauth-worker.c
    M src/imap/imap-client.c
    M src/lib/connection.c
    M src/lmtp/client.c
    M src/pop3/pop3-client.c

  Log Message:
  -----------
  global: Use fd_close_maybe_stdio()


  Commit: 6028ef7bd1a453212b815b608e1c7b1b21ebca49
      https://github.com/dovecot/core/commit/6028ef7bd1a453212b815b608e1c7b1b21ebca49
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-11-16 (Wed, 16 Nov 2016)

  Changed paths:
    M src/imap/imap-state.c

  Log Message:
  -----------
  imap: Add details why unhibernation failed

This can help understanding why client
failed to unhibernate.


Compare: https://github.com/dovecot/core/compare/34742a4b92c1...6028ef7bd1a4