[dovecot/core] 8acb8d: dbox: iostream error logging improvements.

Wed May 18 12:30:11 UTC 2016

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 8acb8deef145fc0225095ed3974b2685fdaf959e
      https://github.com/dovecot/core/commit/8acb8deef145fc0225095ed3974b2685fdaf959e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lib-storage/index/dbox-common/dbox-file-fix.c
    M src/lib-storage/index/dbox-common/dbox-save.c

  Log Message:
  -----------
  dbox: iostream error logging improvements.

  Commit: 43cc944340b6879ce2c6aeba048ceaf040bf0932
      https://github.com/dovecot/core/commit/43cc944340b6879ce2c6aeba048ceaf040bf0932
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/doveadm/dsync/dsync-mailbox-import.c
    M src/imap/cmd-append.c
    M src/imap/cmd-urlfetch.c
    M src/lib-http/http-client-request.c
    M src/lib-imap-storage/imap-msgpart.c
    M src/lib-storage/index/index-mail-binary.c

  Log Message:
  -----------
  global: Code cleanup - remove unnecessary errno changes.

These were left behind from changing %m to [io]_stream_get_error()

  Commit: 0f3d4fbcf88e2ffd674893aed8cc1288fe17d290
      https://github.com/dovecot/core/commit/0f3d4fbcf88e2ffd674893aed8cc1288fe17d290
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/auth/mech-winbind.c
    M src/auth/userdb-passwd-file.c
    M src/director/director-connection.c
    M src/doveadm/doveadm-director.c
    M src/doveadm/doveadm-penalty.c
    M src/doveadm/doveadm-replicator.c
    M src/doveadm/doveadm-stats.c
    M src/doveadm/doveadm-who.c
    M src/doveadm/doveadm-zlib.c
    M src/lib-auth/auth-master.c
    M src/lib-auth/auth-server-connection.c
    M src/lib-http/http-server-response.c
    M src/lib-index/mail-index-strmap.c
    M src/lib-lda/duplicate.c
    M src/lib-lda/lmtp-client.c
    M src/lib-lda/smtp-client.c
    M src/lib-master/anvil-client.c
    M src/lib-master/master-instance.c
    M src/lib-master/master-service-settings.c
    M src/lib-storage/index/cydir/cydir-save.c
    M src/lib-storage/index/dbox-multi/mdbox-purge.c
    M src/lib-storage/index/dbox-single/sdbox-file.c
    M src/lib-storage/index/imapc/imapc-save.c
    M src/lib-storage/index/index-attachment.c
    M src/lib-storage/index/maildir/maildir-save.c
    M src/lib-storage/index/maildir/maildir-uidlist.c
    M src/lib/json-parser.c
    M src/plugins/acl/acl-backend-vfile-acllist.c
    M src/plugins/acl/acl-backend-vfile-update.c
    M src/plugins/acl/acl-backend-vfile.c
    M src/plugins/fts-squat/squat-trie.c
    M src/plugins/fts-squat/squat-uidlist.c
    M src/plugins/fts/fts-expunge-log.c

  Log Message:
  -----------
  global: Use [io]_stream_get_error() insted of %m

  Commit: f339a8e73beea7684ea634941ea82593dea522ee
      https://github.com/dovecot/core/commit/f339a8e73beea7684ea634941ea82593dea522ee
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/imap/cmd-getmetadata.c
    M src/imap/imap-fetch-body.c
    M src/imap/imap-fetch.c
    M src/imap/imap-fetch.h
    M src/lib-fs/fs-api.c
    M src/lib-http/test-http-payload.c
    M src/lib-storage/index/dbox-common/dbox-file-fix.c
    M src/lib-storage/index/dbox-multi/mdbox-purge.c
    M src/lib-storage/index/mbox/mbox-sync-rewrite.c
    M src/lib/file-copy.c

  Log Message:
  -----------
  global: Don't assume o_stream_send_istream() return bytes sent.

This won't be true soon after its API changes.

  Commit: 2fb246462dc1846a299ecc5530c2b90c53edcdb4
      https://github.com/dovecot/core/commit/2fb246462dc1846a299ecc5530c2b90c53edcdb4
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lib/ostream-file.c

  Log Message:
  -----------
  lib: istream-file: Code cleanup

No functional changes

  Commit: 08ab0b21d9da8881280071016a4475ee95f16c17
      https://github.com/dovecot/core/commit/08ab0b21d9da8881280071016a4475ee95f16c17
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lib-compression/ostream-bzlib.c
    M src/lib-compression/ostream-lzma.c
    M src/lib-compression/ostream-zlib.c

  Log Message:
  -----------
  lib-compression: Changed impossible errors to asserts.

o_stream_flush() no longer calls the stream's flush() if stream has failed.

  Commit: f988b93c2ef773987bcdcbfb4cca39b955e3a392
      https://github.com/dovecot/core/commit/f988b93c2ef773987bcdcbfb4cca39b955e3a392
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lib-index/mail-index-strmap.c
    M src/lib-storage/index/index-attachment.c
    M src/lib-storage/index/maildir/maildir-save.c
    M src/lib/ostream.c
    M src/lib/ostream.h

  Log Message:
  -----------
  lib: Removed ostream.last_failed_errno

It's been identical to ostream.stream_errno for a while now.

  Commit: 61d89b0ca0300e230c7882b71e8360edf62d9cd0
      https://github.com/dovecot/core/commit/61d89b0ca0300e230c7882b71e8360edf62d9cd0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lmtp/commands.c

  Log Message:
  -----------
  lmtp: Fixed error logging when writing to temp file

  Commit: 9de176ef7f3d28ff486c2a8805110b84389e4f19
      https://github.com/dovecot/core/commit/9de176ef7f3d28ff486c2a8805110b84389e4f19
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lib/ostream-private.h
    M src/lib/ostream.c
    M src/lib/ostream.h

  Log Message:
  -----------
  lib: Don't silently ignore partial writes for o_stream_nsend()

Normally o_stream_nsend() should be used only for blocking streams or
streams with infinite (or "enough") buffer space.

  Commit: 8b2cf1c1bd8ddcea0525b62fd35ba76e136828a1
      https://github.com/dovecot/core/commit/8b2cf1c1bd8ddcea0525b62fd35ba76e136828a1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lib/ostream-buffer.c
    M src/lib/ostream-file.c
    M src/lib/ostream-null.c
    M src/lib/ostream.c
    M src/lib/ostream.h

  Log Message:
  -----------
  lib: Added ostream.blocking boolean

Similar to istream.blocking.

  Commit: 6adf683655750bcb809275cd65dc75fd12214198
      https://github.com/dovecot/core/commit/6adf683655750bcb809275cd65dc75fd12214198
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lib-fs/ostream-metawrap.c
    M src/lib/iostream-temp.c
    M src/lib/ostream-file.c
    M src/lib/ostream-private.h
    M src/lib/ostream.c
    M src/lib/ostream.h

  Log Message:
  -----------
  lib: Simplified and clarified o_stream_send_istream() API

  Commit: b90fb7f78aca271243c26074ddd6587cce112a1e
      https://github.com/dovecot/core/commit/b90fb7f78aca271243c26074ddd6587cce112a1e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lib/ostream.c
    M src/lib/ostream.h

  Log Message:
  -----------
  lib: Added o_stream_nsend_istream()

  Commit: 6f187ae85911f63cb87271246c68f3c13a0adb7b
      https://github.com/dovecot/core/commit/6f187ae85911f63cb87271246c68f3c13a0adb7b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/doveadm/client-connection-http.c
    M src/doveadm/doveadm-fs.c
    M src/lib-fs/fs-metawrap.c
    M src/lib-lda/mail-send.c
    M src/lib-storage/index/dbox-multi/mdbox-purge.c
    M src/lib-storage/index/dbox-single/sdbox-file.c
    M src/plugins/fs-compress/fs-compress.c

  Log Message:
  -----------
  global: Use o_stream_nsend_istream() where useful

We can skip all of the io error handling and just leave it to
o_stream_nfinish().

  Commit: 0e0fe9bed9a2be8760acf93abc6e16758195ef38
      https://github.com/dovecot/core/commit/0e0fe9bed9a2be8760acf93abc6e16758195ef38
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/imap/cmd-getmetadata.c

  Log Message:
  -----------
  imap: Code cleanup - use istream-sized for GETMETADATA reply

This avoids doing the same work explicitly.

  Commit: 1fb4c7c4cdf470c8aec47d0de76ccff03094d374
      https://github.com/dovecot/core/commit/1fb4c7c4cdf470c8aec47d0de76ccff03094d374
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lib/istream-sized.c

  Log Message:
  -----------
  lib: istream-sized should log errors with its own name, not parent's name

  Commit: d04f3e064ceb2ba1d734182937a7115739ebadbe
      https://github.com/dovecot/core/commit/d04f3e064ceb2ba1d734182937a7115739ebadbe
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/doveadm/server-connection.c
    M src/imap/cmd-urlfetch.c
    M src/imap/imap-fetch-body.c
    M src/lib-fs/fs-api.c
    M src/lib-fs/ostream-metawrap.c
    M src/lib-http/http-client-request.c
    M src/lib-http/http-server-response.c
    M src/lib-http/test-http-payload.c
    M src/lib-imap-client/imapc-connection.c
    M src/lib/file-copy.c
    M src/lib/ostream.c
    M src/plugins/mail-filter/istream-ext-filter.c

  Log Message:
  -----------
  global: Simplify code with the new o_stream_send_istream() API

  Commit: 94a6b3df81d2edb93460b7beca6d37e618a48262
      https://github.com/dovecot/core/commit/94a6b3df81d2edb93460b7beca6d37e618a48262
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lib/buffer.h
    M src/lib/test-buffer.c

  Log Message:
  -----------
  lib: Updated buffer_set_used_size() comment and added unit test.

  Commit: f6d5c9fbdac9af5c4d3f467f828dc6f056309d5e
      https://github.com/dovecot/core/commit/f6d5c9fbdac9af5c4d3f467f828dc6f056309d5e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-18 (Wed, 18 May 2016)

  Changed paths:
    M src/lib-index/mail-cache-lookup.c
    M src/lib-index/mail-index-map-read.c
    M src/lib-index/mail-index-sync-update.c
    M src/lib-mail/istream-header-filter.c
    M src/lib/buffer.c
    M src/lib/buffer.h
    M src/lib/test-pkcs5.c

  Log Message:
  -----------
  Removed buffer_reset().

It was just a wrapper to buffer_set_used_size() and its comment was a bit
confusing (or obsolete), since it wasn't actually immediately zeroing out
the buffer.

Compare: https://github.com/dovecot/core/compare/651f981ca065...f6d5c9fbdac9