[dovecot/core] eb2394: lib-ldap: Do not retry with bad credentials

Tue May 10 21:30:15 UTC 2016

  Branch: refs/heads/master-2.2
  Home:   https://github.com/dovecot/core
  Commit: eb239417679f4d5bdf0299db64e4ac31d63addda
      https://github.com/dovecot/core/commit/eb239417679f4d5bdf0299db64e4ac31d63addda
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-ldap/ldap-connection.c

  Log Message:
  -----------
  lib-ldap: Do not retry with bad credentials

  Commit: 47f2320ca5ff396644e43e864d7b4ceb923f364a
      https://github.com/dovecot/core/commit/47f2320ca5ff396644e43e864d7b4ceb923f364a
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-ldap/ldap-connection.c

  Log Message:
  -----------
  lib-ldap: Handle various LDAP failures correctly

  Commit: 4497d28e19891c861e81e5bcb106f1f8e8b0facc
      https://github.com/dovecot/core/commit/4497d28e19891c861e81e5bcb106f1f8e8b0facc
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-storage/index/index-sync.c

  Log Message:
  -----------
  lib-storage: Fixed potential crash in mailbox_sync_deinit() error handling

If mailbox_sync*() was called before mailbox was opened, the automatic
mailbox opening could fail. mailbox_sync_deinit() would still try to access
box->view, which would be NULL.

  Commit: 81905b9300535941e918eb81760c26fc51edb704
      https://github.com/dovecot/core/commit/81905b9300535941e918eb81760c26fc51edb704
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-mail/istream-header-filter.c

  Log Message:
  -----------
  lib-mail: istream-header-filter - Check errors reading header

This probably doesn't affect the results much, since the stream_errno is set
anyway. But it's better to abort early, just in case the broken state might
end up asserting later.

  Commit: 03947494029d35847007ba8743076a9ad4fc07b0
      https://github.com/dovecot/core/commit/03947494029d35847007ba8743076a9ad4fc07b0
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-mail/istream-header-filter.c
    M src/lib-mail/test-istream-header-filter.c

  Log Message:
  -----------
  lib-mail: istream-header-filter: Fixed stat() with HEADER_FILTER_END_BODY_WITH_LF

  Commit: 7fd1292b9d55668d68ed5d046a1fec4cdd57b3e1
      https://github.com/dovecot/core/commit/7fd1292b9d55668d68ed5d046a1fec4cdd57b3e1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-mail/istream-header-filter.c
    M src/lib-mail/test-istream-header-filter.c

  Log Message:
  -----------
  lib-mail: istream-header-filter HEADER_FILTER_ADD_MISSING_EOH fixes

When using HEADER_FILTER_CRLF_PRESERVE, add CR to the EOH if the previous
header line ended with CRLF.

When header ends to a header without newline, add two newlines so we can get
the actual EOH added.

  Commit: 71c09f6b25467dfb6ae79dcee371781d2532d2d2
      https://github.com/dovecot/core/commit/71c09f6b25467dfb6ae79dcee371781d2532d2d2
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-mail/istream-header-filter.c
    M src/lib-mail/test-istream-header-filter.c

  Log Message:
  -----------
  lib-mail: istream-header-filter: Fixed stat() with HEADER_FILTER_HIDE_BODY

  Commit: 90c3923258819fcc222955fb71f0e5d77387c754
      https://github.com/dovecot/core/commit/90c3923258819fcc222955fb71f0e5d77387c754
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-mail/istream-header-filter.c
    M src/lib-mail/test-istream-header-filter.c

  Log Message:
  -----------
  lib-mail: istream-header-filter - fixed adding headers at eoh

  Commit: 1c3f119d72701fea1f5bf65cca17ace1d8026ef9
      https://github.com/dovecot/core/commit/1c3f119d72701fea1f5bf65cca17ace1d8026ef9
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-storage/index/index-mail.c

  Log Message:
  -----------
  lib-storage: Make it easier to debug mail's unclosed istream

  Commit: 9233125a5524ca2dfe324de19d95576f8a360562
      https://github.com/dovecot/core/commit/9233125a5524ca2dfe324de19d95576f8a360562
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/doveadm/doveadm-who.c

  Log Message:
  -----------
  doveadm who: Fixed listing LMTP sessions

  Commit: b0626c087fd1a15d47790873cae746324211e305
      https://github.com/dovecot/core/commit/b0626c087fd1a15d47790873cae746324211e305
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-mail/test-istream-header-filter.c

  Log Message:
  -----------
  lib-mail: Fixed istream-header-filter unit test names

  Commit: e36e97499078ff53671e00de863379b89823368c
      https://github.com/dovecot/core/commit/e36e97499078ff53671e00de863379b89823368c
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-fs/fs-metawrap.c

  Log Message:
  -----------
  lib-fs: fs-metawrap stat() error handling improvement.

We can't just treat i_stream_get_size() returning 0 as the reason being
istream is async and not fully read. It might be, but it might also be
because of other reasons. And since we're closing the istream we couldn't
even properly finish up the async handling. So for now just return an
error if we see this happening.

  Commit: bb3679aad440b7a971fe4c9f53fbb6f5fd29bb50
      https://github.com/dovecot/core/commit/bb3679aad440b7a971fe4c9f53fbb6f5fd29bb50
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/stats/mail-user.c

  Log Message:
  -----------
  stats: Fixed ADD-USER stats tracking (auth stats)

  Commit: 2615930e573084cac91dde95ab2052a267ae90e7
      https://github.com/dovecot/core/commit/2615930e573084cac91dde95ab2052a267ae90e7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-fs/fs-api.c

  Log Message:
  -----------
  lib-fs: Fixes to stats count tracking

fs_exists(), fs_copy(), fs_rename() and fs_delete() could have increased the
count multiple times on async operations.

  Commit: 501231e8455297016fdca992518a31b0904fc8b7
      https://github.com/dovecot/core/commit/501231e8455297016fdca992518a31b0904fc8b7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/plugins/lazy-expunge/lazy-expunge-plugin.c

  Log Message:
  -----------
  lazy-expunge: Handle mailbox create race conditions.

Don't log an error if another process just created the lazy-expunge mailbox.

  Commit: 4a92e7afb9683c8c4de60a822223c2ad6e0e55bd
      https://github.com/dovecot/core/commit/4a92e7afb9683c8c4de60a822223c2ad6e0e55bd
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib/connection.c

  Log Message:
  -----------
  lib: Improved connection_disconnect_reason()

  Commit: 0e65dc9c8a938fde37dea36d5e17dc7ea522d24f
      https://github.com/dovecot/core/commit/0e65dc9c8a938fde37dea36d5e17dc7ea522d24f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib/istream.c
    M src/lib/istream.h

  Log Message:
  -----------
  lib: Added i_stream_get_disconnect_reason()

  Commit: fc0f22ebd30428111592e0a7e404794c6d71f20f
      https://github.com/dovecot/core/commit/fc0f22ebd30428111592e0a7e404794c6d71f20f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/auth/Makefile.am

  Log Message:
  -----------
  auth: Makefile dependency fix

Hopefully fixes:
mv: cannot stat '.deps/auth-stats.Tpo': No such file or directory

  Commit: 37f0b04489ab73227ae28678d6f15067adea1a94
      https://github.com/dovecot/core/commit/37f0b04489ab73227ae28678d6f15067adea1a94
  Author: Aki Tuomi <aki.tuomi at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-dict-extra/dict-ldap.c

  Log Message:
  -----------
  dict-ldap: Properly duplicate result

  Commit: c8d8cb57937a065090d6e0bfe96425de79f69244
      https://github.com/dovecot/core/commit/c8d8cb57937a065090d6e0bfe96425de79f69244
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/plugins/stats/mail-stats-fill.c

  Log Message:
  -----------
  stats: Work around shrinking system CPU usage

Happening at least in Debian's Linux kernel 4.3.0-1-amd64.

getrusage() may returns ru_stime = 4000 or 8000, but later it drops to 0.
We'll just work around this by switching to the previous working ru_stime.

This fixes errors like:
Error: stats: session stats shrank: sys_cpu 0.0 < 0.4000

  Commit: 99e68380dfbc17b78c1cda139093dc108fa4f097
      https://github.com/dovecot/core/commit/99e68380dfbc17b78c1cda139093dc108fa4f097
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/plugins/stats/mail-stats-fill.c

  Log Message:
  -----------
  stats: Handle getrusage() errors better

I'm not aware of these errors actually happening anywhere, but its
error handling wouldn't have been correct if previous getrusage() calls
had succeeded. Now if it fails, log an error once and just keep on using
the last working rusage.

  Commit: 9f47b8c69789e8e61b1581e3fb1864a125bf276f
      https://github.com/dovecot/core/commit/9f47b8c69789e8e61b1581e3fb1864a125bf276f
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/imap/imap-sync.c

  Log Message:
  -----------
  imap: Avoid assert-crash after a failed mailbox sync.

We didn't close the mailbox and we didn't update message counts, so we could
have crashed with:

Panic: Message count decreased

  Commit: 8dfa9cf75a5f0811053a8d5e8170c2ce1421c291
      https://github.com/dovecot/core/commit/8dfa9cf75a5f0811053a8d5e8170c2ce1421c291
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-dict/dict-client.c

  Log Message:
  -----------
  dict-client: Added idle_msecs=<n> parameter

This can be useful when connected to dict-async server where extra idling
connections don't matter so much as with blocking dict servers.

  Commit: c2a17c802d691f5fc7eeec493613ce6c6965fc6e
      https://github.com/dovecot/core/commit/c2a17c802d691f5fc7eeec493613ce6c6965fc6e
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-http/http-client-private.h
    M src/lib-http/http-client-queue.c

  Log Message:
  -----------
  lib-http: If connect fails, include attempt count and total time in error.

This will produce errors such as:
9002 connect(1.2.3.4:801) failed: Connection timed out in 1.001 secs (4 attempts in 4.706 secs)

  Commit: 5f59c92c2a9047419bdd29856d6a91e3bdcead83
      https://github.com/dovecot/core/commit/5f59c92c2a9047419bdd29856d6a91e3bdcead83
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M README

  Log Message:
  -----------
  README: Added missing supported RFCs

  Commit: 99ce322e586996354583230b277ff87e6073cad5
      https://github.com/dovecot/core/commit/99ce322e586996354583230b277ff87e6073cad5
  Author: Stephan Bosch <stephan at rename-it.nl>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M run-test-valgrind.supp

  Log Message:
  -----------
  Added liblzma bug to Valgrind suppressions file.

It caused `make test` to fail with valgrind.
Occurred at least for Debian Jessie with liblzma package version 5.1.1alpha+20120614-2+b3.

  Commit: 7c2d7b9e7a1611658e61d91de4341dc712c2d1ec
      https://github.com/dovecot/core/commit/7c2d7b9e7a1611658e61d91de4341dc712c2d1ec
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-index/mail-index-transaction-finish.c

  Log Message:
  -----------
  lib-index: "first saved UID of the day" wasn't updated right always.

It was using the UID of the first append. But it may not have been the
lowest UID. Do this after the appends are first sorted by their UID.

  Commit: bd0bf1233c56f448690df5ba495f18d7a0b15f1a
      https://github.com/dovecot/core/commit/bd0bf1233c56f448690df5ba495f18d7a0b15f1a
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib/istream-concat.c

  Log Message:
  -----------
  lib: Fixed crash when closing a failed istream-concat

i_stream_concat_seek() could have set cur_input==NULL and we still
attempted to seek the cur_input at close time.

  Commit: 1b228876c020f2be8323253f862cbdabd482f756
      https://github.com/dovecot/core/commit/1b228876c020f2be8323253f862cbdabd482f756
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-05-10 (Tue, 10 May 2016)

  Changed paths:
    M src/lib-ldap/Makefile.am

  Log Message:
  -----------
  lib-ldap: Add libdovecot dependency to libdovecot-ldap

Required for linking to work on OSX.

Compare: https://github.com/dovecot/core/compare/139007fda81b...1b228876c020