dovecot-2.2: doveadm-server: Fixed potential crash if doveadm cl...

dovecot at dovecot.org dovecot at dovecot.org
Sat May 9 16:43:39 UTC 2015


details:   http://hg.dovecot.org/dovecot-2.2/rev/e702b7a745e0
changeset: 18616:e702b7a745e0
user:      Timo Sirainen <tss at iki.fi>
date:      Sat May 09 19:41:45 2015 +0300
description:
doveadm-server: Fixed potential crash if doveadm client disconnected
Found by Coverity

diffstat:

 src/doveadm/server-connection.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (14 lines):

diff -r cff670d68f69 -r e702b7a745e0 src/doveadm/server-connection.c
--- a/src/doveadm/server-connection.c	Sat May 09 19:39:39 2015 +0300
+++ b/src/doveadm/server-connection.c	Sat May 09 19:41:45 2015 +0300
@@ -127,9 +127,9 @@
 	ret = o_stream_flush(conn->output);
 	if (ret > 0 && conn->cmd_input != NULL && conn->delayed_cmd == NULL)
 		ret = server_connection_send_cmd_input_more(conn);
+	o_stream_uncork(conn->output);
 	if (ret < 0)
 		server_connection_destroy(&conn);
-	o_stream_uncork(conn->output);
 	return ret;
 }
 


More information about the dovecot-cvs mailing list