dovecot-2.2: lib-otp: OTP_MAX_WORD_LEN wasn't actually enforced,...

dovecot at dovecot.org dovecot at dovecot.org
Thu Jun 12 23:20:42 UTC 2014


details:   http://hg.dovecot.org/dovecot-2.2/rev/ecbe9abc14e3
changeset: 17470:ecbe9abc14e3
user:      Timo Sirainen <tss at iki.fi>
date:      Fri Jun 13 01:20:25 2014 +0300
description:
lib-otp: OTP_MAX_WORD_LEN wasn't actually enforced, any word lengths could have been used.
Doesn't look like this could have caused any real problems.
Found by Coverity

diffstat:

 src/lib-otp/otp-parse.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff -r 54f1beb8d071 -r ecbe9abc14e3 src/lib-otp/otp-parse.c
--- a/src/lib-otp/otp-parse.c	Fri Jun 13 01:11:24 2014 +0300
+++ b/src/lib-otp/otp-parse.c	Fri Jun 13 01:20:25 2014 +0300
@@ -106,7 +106,7 @@
 			}
 		} else {
 			if (i_isalpha(c)) {
-				if (len > OTP_MAX_WORD_LEN) {
+				if (++len > OTP_MAX_WORD_LEN) {
 					count = 0;
 					break;
 				}


More information about the dovecot-cvs mailing list