dovecot-2.2: liblib: connection_disconnect() didn't close fd_out...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.2/rev/50117c22151e
changeset: 16615:50117c22151e
user:      Timo Sirainen <tss at iki.fi>
date:      Wed Jul 17 10:23:21 2013 +0300
description:
liblib: connection_disconnect() didn't close fd_out if it was different from fd_in.

diffstat:

 src/lib/connection.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff -r ebbe00999da8 -r 50117c22151e src/lib/connection.c
--- a/src/lib/connection.c	Fri Jul 12 03:06:26 2013 +0300
+++ b/src/lib/connection.c	Wed Jul 17 10:23:21 2013 +0300
@@ -254,7 +254,7 @@
 	if (conn->fd_in != -1) {
 		if (close(conn->fd_in) < 0)
 			i_error("close(%s) failed: %m", conn->name);
-		if (conn->fd_in != conn->fd_out)
+		if (conn->fd_in != conn->fd_out && close(conn->fd_out) < 0)
 			i_error("close(%s/out) failed: %m", conn->name);
 		conn->fd_in = conn->fd_out = -1;
 	}