dovecot-2.2: lib-storage: Don't unnecessarily clear mailbox_stat...

dovecot at dovecot.org dovecot at dovecot.org
Mon Feb 11 00:25:02 EET 2013


details:   http://hg.dovecot.org/dovecot-2.2/rev/2492fa1232a0
changeset: 15747:2492fa1232a0
user:      Timo Sirainen <tss at iki.fi>
date:      Mon Feb 11 00:24:56 2013 +0200
description:
lib-storage: Don't unnecessarily clear mailbox_status multiple times.

diffstat:

 src/lib-storage/fail-mailbox.c                   |  1 -
 src/lib-storage/index/index-status.c             |  2 --
 src/lib-storage/list/mailbox-list-index-status.c |  2 --
 3 files changed, 0 insertions(+), 5 deletions(-)

diffs (35 lines):

diff -r 2aa20ea42d6d -r 2492fa1232a0 src/lib-storage/fail-mailbox.c
--- a/src/lib-storage/fail-mailbox.c	Mon Feb 11 00:23:07 2013 +0200
+++ b/src/lib-storage/fail-mailbox.c	Mon Feb 11 00:24:56 2013 +0200
@@ -81,7 +81,6 @@
 				   enum mailbox_status_items items ATTR_UNUSED,
 				   struct mailbox_status *status_r)
 {
-	memset(status_r, 0, sizeof(*status_r));
 	status_r->uidvalidity = TEST_UID_VALIDITY;
 	status_r->uidnext = 1;
 	mail_storage_set_error(box->storage, MAIL_ERROR_NOTFOUND,
diff -r 2aa20ea42d6d -r 2492fa1232a0 src/lib-storage/index/index-status.c
--- a/src/lib-storage/index/index-status.c	Mon Feb 11 00:23:07 2013 +0200
+++ b/src/lib-storage/index/index-status.c	Mon Feb 11 00:24:56 2013 +0200
@@ -109,8 +109,6 @@
 {
 	const struct mail_index_header *hdr;
 
-	memset(status_r, 0, sizeof(struct mailbox_status));
-
 	/* we can get most of the status items without any trouble */
 	hdr = mail_index_get_header(box->view);
 	status_r->messages = hdr->messages_count;
diff -r 2aa20ea42d6d -r 2492fa1232a0 src/lib-storage/list/mailbox-list-index-status.c
--- a/src/lib-storage/list/mailbox-list-index-status.c	Mon Feb 11 00:23:07 2013 +0200
+++ b/src/lib-storage/list/mailbox-list-index-status.c	Mon Feb 11 00:24:56 2013 +0200
@@ -122,8 +122,6 @@
 	uint32_t seq;
 	int ret;
 
-	memset(status_r, 0, sizeof(*status_r));
-
 	if ((items & STATUS_UNSEEN) != 0 &&
 	    (mailbox_get_private_flags_mask(box) & MAIL_SEEN) != 0) {
 		/* can't get UNSEEN from list index, since each user has


More information about the dovecot-cvs mailing list