dovecot-2.0-pigeonhole: ManageSieve: removed TODO status of addi...

[pigeonhole at rename-it.nl]

details:   http://hg.rename-it.nl/dovecot-2.0-pigeonhole/rev/5b57b1142864
changeset: 1458:5b57b1142864
user:      Stephan Bosch <stephan at rename-it.nl>
date:      Thu Jan 06 15:50:31 2011 +0100
description:
ManageSieve: removed TODO status of adding ANONYMOUS SASL support, since the RFC specification no longer describes it.

diffstat:

 README                                      |  3 ---
 TODO                                        |  1 -
 src/managesieve-login/client-authenticate.c |  8 +++-----
 3 files changed, 3 insertions(+), 9 deletions(-)

diffs (51 lines):

diff -r a8da6eef445d -r 5b57b1142864 README
--- a/README	Tue Jan 04 12:51:58 2011 +0100
+++ b/README	Thu Jan 06 15:50:31 2011 +0100
@@ -279,9 +279,6 @@
 	  These clients are specifically written for Cyrus timsieved and fail on
 	  multiple stages of the protocol when connected to Pigeonhole ManageSieve.
 
-* The ANONYMOUS authentication mechanism is currently not supported and
-  explicitly denied.
-
 Authors
 =======
 
diff -r a8da6eef445d -r 5b57b1142864 TODO
--- a/TODO	Tue Jan 04 12:51:58 2011 +0100
+++ b/TODO	Thu Jan 06 15:50:31 2011 +0100
@@ -51,7 +51,6 @@
 	  are tested at least once.
 * Fix ManageSieve proxy to recognize response codes from the backend and forward
   them to the user if appropriate/safe.
-* Implement proper support for ManageSieve SASL ANONYMOUS login.
 * Test ManageSieve behavior thoroughly:
 	- Test pipelined behavior
 	- Test proxy authentication
diff -r a8da6eef445d -r 5b57b1142864 src/managesieve-login/client-authenticate.c
--- a/src/managesieve-login/client-authenticate.c	Tue Jan 04 12:51:58 2011 +0100
+++ b/src/managesieve-login/client-authenticate.c	Thu Jan 06 15:50:31 2011 +0100
@@ -33,6 +33,7 @@
 	mech = sasl_server_get_advertised_mechs(client, &count);
 
 	for (i = 0; i < count; i++) {
+		/* Filter ANONYMOUS mechanism, ManageSieve has no use-case for it */
 		if ( (mech[i].flags & MECH_SEC_ANONYMOUS) == 0 ) {
 			if ( !first )
 				str_append_c(str, ' ');
@@ -215,13 +216,10 @@
 	if (*mech_name == '\0') 
 		return -1;
 
-	/* FIXME: This refuses the ANONYMOUS mechanism. 
-	 *   This can be removed once anonymous login is implemented according to the 
-	 *   draft RFC. - Stephan
-	 */
+	/* Refuse the ANONYMOUS mechanism. */
 	if ( strncasecmp(mech_name, "ANONYMOUS", 9) == 0 ) {
 		client_send_no
-			(&msieve_client->common, "ANONYMOUS mechanism is not implemented.");		
+			(&msieve_client->common, "ANONYMOUS login is not allowed.");
 		return 0;
 	}