dovecot-2.0: auth: Recent change caused userdb lookups to crash.

dovecot at dovecot.org dovecot at dovecot.org
Wed Jun 2 03:23:55 EEST 2010


details:   http://hg.dovecot.org/dovecot-2.0/rev/dc94f9240ec1
changeset: 11452:dc94f9240ec1
user:      Timo Sirainen <tss at iki.fi>
date:      Wed Jun 02 01:23:51 2010 +0100
description:
auth: Recent change caused userdb lookups to crash.
The deinit bug that it tried to fix isn't fixed yet.

diffstat:

 src/auth/auth-request.c |  8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diffs (18 lines):

diff -r 1b45f9641924 -r dc94f9240ec1 src/auth/auth-request.c
--- a/src/auth/auth-request.c	Tue Jun 01 20:00:07 2010 +0100
+++ b/src/auth/auth-request.c	Wed Jun 02 01:23:51 2010 +0100
@@ -742,14 +742,6 @@
 {
 	struct userdb_module *userdb = request->userdb->userdb;
 
-	if (auth_request_handler_is_destroyed(request->handler)) {
-		/* the userdb may have been freed already. this request won't
-		   be sent anywhere anyway, so just fail it immediately. */
-		request->private_callback.
-			userdb(USERDB_RESULT_INTERNAL_FAILURE, request);
-		return;
-	}
-
 	if (result != USERDB_RESULT_OK && request->userdb->next != NULL) {
 		/* try next userdb. */
 		if (result == USERDB_RESULT_INTERNAL_FAILURE)


More information about the dovecot-cvs mailing list