dovecot-2.0: lib-storage: Mailbox directory creation didn't prop...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.0/rev/4b084f357db1
changeset: 12515:4b084f357db1
user:      Timo Sirainen <tss at iki.fi>
date:      Mon Dec 06 00:43:28 2010 +0000
description:
lib-storage: Mailbox directory creation didn't properly enforce that the name was valid.
The name was checked against "valid existing name" rather than "valid create
name", which mainly meant that the name could have contained control characters
and other things that weren't really intended. This couldn't be used to
cause any security holes though.

diffstat:

 src/lib-storage/mailbox-list.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff -r 6a0f3010d592 -r 4b084f357db1 src/lib-storage/mailbox-list.c
--- a/src/lib-storage/mailbox-list.c	Fri Dec 03 23:16:26 2010 +0000
+++ b/src/lib-storage/mailbox-list.c	Mon Dec 06 00:43:28 2010 +0000
@@ -1163,7 +1163,7 @@
 
 int mailbox_list_create_dir(struct mailbox_list *list, const char *name)
 {
-	if (!mailbox_list_is_valid_existing_name(list, name) || *name == '\0') {
+	if (!mailbox_list_is_valid_create_name(list, name) || *name == '\0') {
 		mailbox_list_set_error(list, MAIL_ERROR_PARAMS,
 				       "Invalid mailbox name");
 		return -1;