dovecot-1.1: Don't use clean_pool with login processes.

dovecot at dovecot.org dovecot at dovecot.org
Fri Jan 23 20:13:28 EET 2009


details:   http://hg.dovecot.org/dovecot-1.1/rev/597616672d3b
changeset: 8123:597616672d3b
user:      Timo Sirainen <tss at iki.fi>
date:      Fri Jan 23 13:13:26 2009 -0500
description:
Don't use clean_pool with login processes.
The previous fix for clean_pool perhaps might have fixed all the bugs
related to it, but since it only produces extra work with no real benefit,
just don't use it. The original idea behind using it was flawed.

diffstat:

1 file changed, 7 deletions(-)
src/login-common/main.c |    7 -------

diffs (17 lines):

diff -r 6854699ba2e4 -r 597616672d3b src/login-common/main.c
--- a/src/login-common/main.c	Thu Jan 22 02:51:08 2009 +0200
+++ b/src/login-common/main.c	Fri Jan 23 13:13:26 2009 -0500
@@ -409,13 +409,6 @@ int main(int argc ATTR_UNUSED, char *arg
 		fd_debug_verify_leaks(i, 1024);
 	}
 #endif
-	/* clear all allocated memory before freeing it. this makes the login
-	   processes pretty safe to reuse for new connections since the
-	   attacker won't be able to find anything interesting from the
-	   memory. */
-	default_pool = system_clean_pool;
-	data_stack_set_clean_after_pop(TRUE);
-
 	/* NOTE: we start rooted, so keep the code minimal until
 	   restrict_access_by_env() is called */
 	lib_init();


More information about the dovecot-cvs mailing list