dovecot-1.1: Don't use krb5_get_error_message(), it doesn't work...

dovecot at dovecot.org dovecot at dovecot.org
Sun May 4 17:05:16 EEST 2008


details:   http://hg.dovecot.org/dovecot-1.1/rev/ad0f32abda6d
changeset: 7480:ad0f32abda6d
user:      Timo Sirainen <tss at iki.fi>
date:      Sun May 04 17:05:12 2008 +0300
description:
Don't use krb5_get_error_message(), it doesn't work with Heimdal Kerberos.

diffstat:

1 file changed, 6 insertions(+), 3 deletions(-)
src/auth/mech-gssapi.c |    9 ++++++---

diffs (19 lines):

diff -r 7871b6219480 -r ad0f32abda6d src/auth/mech-gssapi.c
--- a/src/auth/mech-gssapi.c	Sun May 04 16:57:58 2008 +0300
+++ b/src/auth/mech-gssapi.c	Sun May 04 17:05:12 2008 +0300
@@ -322,9 +322,12 @@ static bool gssapi_krb5_userok(struct gs
 	}
 	krb5_err = krb5_parse_name(ctx, princ_display_name, &princ);
 	if (krb5_err != 0) {
-		auth_request_log_error(&request->auth_request, "gssapi",
-				       "krb5_parse_name() failed: %s",
-				       krb5_get_error_message(ctx, krb5_err));
+		/* writing the error string would be better, but we probably
+		   rarely get here and there doesn't seem to be a standard
+		   way of getting it */
+		auth_request_log_error(&request->auth_request, "gssapi",
+				       "krb5_parse_name() failed: %d",
+				       (int)krb5_err);
 	} else {
 		/* See if the principal is authorized to act as the
 		   specified user */


More information about the dovecot-cvs mailing list