dovecot-1.1: Don't try to flush NFS file handle cache for mbox f...
dovecot at dovecot.org
dovecot at dovecot.org
Sun Mar 2 06:35:17 EET 2008
details: http://hg.dovecot.org/dovecot-1.1/rev/258477a3f1e7
changeset: 7316:258477a3f1e7
user: Timo Sirainen <tss at iki.fi>
date: Sun Mar 02 06:34:34 2008 +0200
description:
Don't try to flush NFS file handle cache for mbox files.
diffstat:
1 file changed, 4 insertions(+), 3 deletions(-)
src/lib-storage/index/mbox/mbox-lock.c | 7 ++++---
diffs (17 lines):
diff -r 3f53f528d338 -r 258477a3f1e7 src/lib-storage/index/mbox/mbox-lock.c
--- a/src/lib-storage/index/mbox/mbox-lock.c Sun Mar 02 06:23:59 2008 +0200
+++ b/src/lib-storage/index/mbox/mbox-lock.c Sun Mar 02 06:34:34 2008 +0200
@@ -171,9 +171,10 @@ static int mbox_file_open_latest(struct
return 0;
if (mbox->mbox_fd != -1) {
- if ((mbox->storage->storage.flags &
- MAIL_STORAGE_FLAG_NFS_FLUSH_STORAGE) != 0)
- nfs_flush_file_handle_cache(mbox->path);
+ /* we could flush NFS file handle cache here if we wanted to
+ be sure that the file is latest, but mbox files get rarely
+ deleted and the flushing might cause errors (e.g. EBUSY for
+ trying to flush a /var/mail mountpoint) */
if (nfs_safe_stat(mbox->path, &st) < 0) {
mbox_set_syscall_error(mbox, "stat()");
return -1;
More information about the dovecot-cvs
mailing list