dovecot: maildir_uidlist_sync_init() was called wrong, although ...

dovecot at dovecot.org dovecot at dovecot.org
Sat Dec 1 09:09:53 EET 2007


details:   http://hg.dovecot.org/dovecot/rev/0c3ab0aef33c
changeset: 6878:0c3ab0aef33c
user:      Timo Sirainen <tss at iki.fi>
date:      Sat Dec 01 09:09:21 2007 +0200
description:
maildir_uidlist_sync_init() was called wrong, although it just happened to
work.

diffstat:

2 files changed, 5 insertions(+), 2 deletions(-)
src/lib-storage/index/maildir/maildir-save.c |    3 ++-
src/lib-storage/index/maildir/maildir-sync.c |    4 +++-

diffs (34 lines):

diff -r a5a7d38b6df7 -r 0c3ab0aef33c src/lib-storage/index/maildir/maildir-save.c
--- a/src/lib-storage/index/maildir/maildir-save.c	Thu Nov 29 19:38:06 2007 +0200
+++ b/src/lib-storage/index/maildir/maildir-save.c	Sat Dec 01 09:09:21 2007 +0200
@@ -598,7 +598,8 @@ int maildir_transaction_save_commit_pre(
 	}
 
 	if (ctx->locked) {
-		ret = maildir_uidlist_sync_init(ctx->mbox->uidlist, TRUE,
+		ret = maildir_uidlist_sync_init(ctx->mbox->uidlist,
+						MAILDIR_UIDLIST_SYNC_PARTIAL,
 						&ctx->uidlist_sync_ctx);
 		i_assert(ret > 0); /* already locked, shouldn't fail */
 
diff -r a5a7d38b6df7 -r 0c3ab0aef33c src/lib-storage/index/maildir/maildir-sync.c
--- a/src/lib-storage/index/maildir/maildir-sync.c	Thu Nov 29 19:38:06 2007 +0200
+++ b/src/lib-storage/index/maildir/maildir-sync.c	Sat Dec 01 09:09:21 2007 +0200
@@ -695,6 +695,7 @@ static int maildir_sync_context(struct m
 static int maildir_sync_context(struct maildir_sync_context *ctx, bool forced,
 				bool *lost_files_r)
 {
+	enum maildir_uidlist_sync_flags sync_flags;
 	bool new_changed, cur_changed;
 	int ret;
 
@@ -754,7 +755,8 @@ static int maildir_sync_context(struct m
 	*/
 
 	ctx->partial = !cur_changed;
-	ret = maildir_uidlist_sync_init(ctx->mbox->uidlist, ctx->partial,
+	sync_flags = ctx->partial ? MAILDIR_UIDLIST_SYNC_PARTIAL : 0;
+	ret = maildir_uidlist_sync_init(ctx->mbox->uidlist, sync_flags,
 					&ctx->uidlist_sync_ctx);
 	if (ret <= 0) {
 		/* failure / timeout. if forced is TRUE, we could still go


More information about the dovecot-cvs mailing list